All comparisons of for non-commutative symbols used to return False. Now
an Inequality or StrictInequality is returned instead.
Added a test.
---
sympy/core/basic.py| 12 +---
sympy/core/tests/test_basic.py |8
2 files changed, 13 insertions(+), 7 deletions(-)
Řyvind Jensen wrote:
All comparisons of for non-commutative symbols used to return False. Now
an Inequality or StrictInequality is returned instead.
Added a test.
All tests pass for me. The coding is clean. I'm not very familiar with
sympy core, but it is good as far as I can tell.
cheers,
2010/3/28 Øyvind Jensen
> All comparisons of for non-commutative symbols used to return False. Now
> an Inequality or StrictInequality is returned instead.
>
> Added a test.
> ---
> sympy/core/basic.py| 12 +---
> sympy/core/tests/test_basic.py |8
> 2 files c
On Mar 28, 2010, at 2:50 PM, Vinzent Steinberg wrote:
> 2010/3/28 Øyvind Jensen
> All comparisons of for non-commutative symbols used to return False. Now
> an Inequality or StrictInequality is returned instead.
>
> Added a test.
> ---
> sympy/core/basic.py| 12 +---
> sy
> I think he meant to put commutative=False, not noncommutative=True.
Exactly, I put up another branch fix__lt__2, where this is fixed.
> It's weird that Symbol will let you create nonexistent assumptions
> on it:
But that can be quite useful:
In [4]: r = Symbol('r',something=True)
In [5]: r
2010/3/29 Øyvind Jensen :
>> I think he meant to put commutative=False, not noncommutative=True.
>
> Exactly, I put up another branch fix__lt__2, where this is fixed.
Thanks! I'm +1 for this one. I have only a few minor stylistic remarks:
+assert (ab) == Gt(a,b)
+assert (a>=b) == Ge(a,b)
Fixed the spacing and pushed to tha branch fix__lt__3.
The parentheses around (a < b) are necessary, else it is interpreted as
assert (a < b == Lt(a, b)).
Øyvind
ma., 29.03.2010 kl. 13.21 +0200, skrev Vinzent Steinberg:
> 2010/3/29 Øyvind Jensen :
> >> I think he meant to put commutative=False,
2010/3/29 Øyvind Jensen :
> Fixed the spacing and pushed to tha branch fix__lt__3.
>
> The parentheses around (a < b) are necessary, else it is interpreted as
> assert (a < b == Lt(a, b)).
Thanks, this is in!
Vinzent
--
You received this message because you are subscribed to the Google Groups
great, thanks!
ma., 29.03.2010 kl. 18.53 +0200, skrev Vinzent Steinberg:
> 2010/3/29 Øyvind Jensen :
> > Fixed the spacing and pushed to tha branch fix__lt__3.
> >
> > The parentheses around (a < b) are necessary, else it is interpreted as
> > assert (a < b == Lt(a, b)).
>
> Thanks, this is in!
>
