>From d11d7e2c1a52af277ab14b95b49c1e320aa87206 Mon Sep 17 00:00:00 2001
From: Thomas Sidoti
Date: Sun, 24 May 2009 16:46:27 -0400
Subject: [PATCH 2/2] added tests, EulerGamma, removed pretty
---
sympy/printing/mathml.py| 24 ++--
sympy/printing/tests/test_mathml
I wasn't sure how to add attachments and stay on the same thread.
I changed the comments to comments and removed the prettyxml from the
mathml() function but kept it in the print_mathml function.
I added two tests which will fail if we don't have the unescape. One
way around unescaping is to ke
Thanks for the patches, thanks for making the appropriate changes. I am
quite busy right now with other things, so I'll reply in a couple of days.
Looks good overall, but I'd like to investigate a bit because I've got
the feeling we can somehow avoid using saxutils.unescape
Thomas Sidoti wrote
Let's wait for Fabian's review.
http://code.google.com/p/sympy/issues/detail?id=1442
Thanks for the patches!
Ondrej
On Mon, May 25, 2009 at 4:37 PM, Fabian Pedregosa wrote:
>
> Thanks for the patches, thanks for making the appropriate changes. I am
> quite busy right now with other things, so
TSidoti wrote:
> I wasn't sure how to add attachments and stay on the same thread.
>
> I changed the comments to comments and removed the prettyxml from the
> mathml() function but kept it in the print_mathml function.
>
> I added two tests which will fail if we don't have the unescape. One
> wa
The changes look good. Thanks!
-Thomas Sidoti
On May 27, 10:33 am, Fabian Pedregosa wrote:
> TSidoti wrote:
> > I wasn't sure how to add attachments and stay on the same thread.
>
> > I changed the comments to comments and removed the prettyxml from the
> > mathml() function but kept it in the
+1 from me too.
Ondrej
On Wed, May 27, 2009 at 10:47 AM, TSidoti wrote:
>
> The changes look good. Thanks!
>
> -Thomas Sidoti
>
> On May 27, 10:33 am, Fabian Pedregosa wrote:
>> TSidoti wrote:
>> > I wasn't sure how to add attachments and stay on the same thread.
>>
>> > I changed the comment
Ondrej Certik wrote:
> +1 from me too.
Thanks for the review. It's in
>
> Ondrej
>
> On Wed, May 27, 2009 at 10:47 AM, TSidoti wrote:
>> The changes look good. Thanks!
>>
>> -Thomas Sidoti
>>
>> On May 27, 10:33 am, Fabian Pedregosa wrote:
>>> TSidoti wrote:
I wasn't sure how to add at
Fabian Pedregosa wrote:
> Ondrej Certik wrote:
>> +1 from me too.
>
> Thanks for the review. It's in
>
>> Ondrej
>>
>> On Wed, May 27, 2009 at 10:47 AM, TSidoti wrote:
>>> The changes look good. Thanks!
>>>
>>> -Thomas Sidoti
>>>
>>> On May 27, 10:33 am, Fabian Pedregosa wrote:
TSidoti w
Where are those patches? I can't find them in the main repository. Am
I missing something?
Ondrej
On Thu, May 28, 2009 at 6:53 AM, Fabian Pedregosa wrote:
>
> Fabian Pedregosa wrote:
>> Ondrej Certik wrote:
>>> +1 from me too.
>>
>> Thanks for the review. It's in
>>
>>> Ondrej
>>>
>>> On Wed, M
10 matches
Mail list logo
