Re: Fix issue 1920: SymTuple doesn't rebuild itself

2010-06-10 Thread Øyvind Jensen
I think I could make good use of SymTuples for code generation with array arguments, and I believe we did reach a conclusion above, so I rebased the patch to current master and created another patch moving SymTuple into the core. They are both in the branch

Re: Fix issue 1920: SymTuple doesn't rebuild itself

2010-05-01 Thread jegerjensen
On 1 Mai, 05:24, Ronan Lamy ronan.l...@gmail.com wrote: Le vendredi 30 avril 2010 à 19:59 -0600, Aaron S. Meurer a écrit : On Apr 30, 2010, at 5:26 PM, Ronan Lamy wrote: Le vendredi 30 avril 2010 à 16:06 -0700, Ondrej Certik a écrit : On Fri, Apr 30, 2010 at 3:04 PM, Ronan Lamy

Re: Fix issue 1920: SymTuple doesn't rebuild itself

2010-05-01 Thread jegerjensen
On 1 Mai, 15:22, Øyvind Jensen jensen.oyv...@gmail.com wrote: SymTuple did not fulfill foo.func(*foo.args) == foo.  This patch fixes that by treating the constructor *args as items of the tuple, rather than expecting exactly one tuple argument. Added docstring, doctest and test  +  fixed some

[PATCH] Fix issue 1920: SymTuple doesn't rebuild itself

2010-04-30 Thread Øyvind Jensen
SymTuple did not fulfill foo.func(*foo.args) == foo. This patch fixes that by storing the wrapped tuple as .args[0] instead of directly as .args Updated all SymTuple methods, added a test and fixed some whitespace. --- sympy/physics/secondquant.py| 35

Re: Fix issue 1920: SymTuple doesn't rebuild itself

2010-04-30 Thread jegerjensen
The above patch was my response to Ondrejs comment: Well, I am not sure that the change from: -assert st == SymTuple((1,2,3,4)) to: +assert st == SymTuple(1, 2, 3, 4) is a good idea. In fact I think it's a bad idea, as we migrated from Matrix(1,2, 3, 4) syntax to Matrix([1, 2, 3, 4]).

Re: Fix issue 1920: SymTuple doesn't rebuild itself

2010-04-30 Thread Ronan Lamy
Le vendredi 30 avril 2010 à 14:23 -0700, Ondrej Certik a écrit : On Fri, Apr 30, 2010 at 6:26 AM, jegerjensen jensen.oyv...@gmail.com wrote: Also, shouldn't this go into sympy.core? Ondrej That is probably a good idea. Where should we put the decorator _tuple_wrapper? Or should

Re: Fix issue 1920: SymTuple doesn't rebuild itself

2010-04-30 Thread Ondrej Certik
On Fri, Apr 30, 2010 at 3:04 PM, Ronan Lamy ronan.l...@gmail.com wrote: Le vendredi 30 avril 2010 à 14:23 -0700, Ondrej Certik a écrit : On Fri, Apr 30, 2010 at 6:26 AM, jegerjensen jensen.oyv...@gmail.com wrote: Also, shouldn't this go into sympy.core? Ondrej That is probably a

Re: Fix issue 1920: SymTuple doesn't rebuild itself

2010-04-30 Thread Ronan Lamy
Le vendredi 30 avril 2010 à 16:06 -0700, Ondrej Certik a écrit : On Fri, Apr 30, 2010 at 3:04 PM, Ronan Lamy ronan.l...@gmail.com wrote: Le vendredi 30 avril 2010 à 14:23 -0700, Ondrej Certik a écrit : On Fri, Apr 30, 2010 at 6:26 AM, jegerjensen jensen.oyv...@gmail.com wrote: Also,