Comment #70 on issue 2084 by smi...@gmail.com: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
I'm sorry, I misunderstood. I don't think there was anything wrong with
it. "2084" has come to be a catch-all for the series work in my head.
Say, with the
Comment #69 on issue 2084 by nicolas@gmail.com: limit(1+1/x, x, 0,
dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
Sorry, I don't understand what you mean.
I labelled it fixed, since limit(1+1/x, x, 0, dir='-') - and similar limits
- were fixed in your branch 2084_2
Comment #68 on issue 2084 by smi...@gmail.com: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
Nicolas, I just noticed that the fixed status was used here but that was
for a separate issue. It's best to start a new issue rather than piggyback
off of
Updates:
Status: Fixed
Comment #67 on issue 2084 by nicolas@gmail.com: limit(1+1/x, x, 0,
dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
Thanks Aaron. That's in now.
--
You received this message because you are subscribed to the Google Groups
"sympy-patches"
Comment #66 on issue 2084 by asmeurer: limit(1+1/x, x, 0, dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
Nice. I made a few small corrections. I like how you can edit the wiki in
your own text editor from the git repository, and then manage everything
from git.
--
Yo
Comment #65 on issue 2084 by Vinzent.Steinberg: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
Done:
https://github.com/sympy/sympy/wiki/Pushing-patches
(I added some small things.)
--
You received this message because you are subscribed to the Googl
Comment #64 on issue 2084 by asmeurer: limit(1+1/x, x, 0, dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
Please do.
--
You received this message because you are subscribed to the Google Groups
"sympy-patches" group.
To post to this group, send email to sympy-patches@google
Comment #63 on issue 2084 by Vinzent.Steinberg: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
Nice summary, do you mind if I add this to the wiki?
--
You received this message because you are subscribed to the Google Groups
"sympy-patches" group.
To
Comment #62 on issue 2084 by asmeurer: limit(1+1/x, x, 0, dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
OK, I have added you. Here is how to push stuff:
You need to add a remote repository for the main sympy repo if you don't
already have one ("git remote" will show you
Comment #61 on issue 2084 by nicolas@gmail.com: limit(1+1/x, x, 0,
dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
Thanks, that's wxgeo : https://github.com/wxgeo.
I'm far from a git/github expert however, so I hope I won't break
anything ;)
--
You received this m
Comment #60 on issue 2084 by asmeurer: limit(1+1/x, x, 0, dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
Nicolas, what is your GitHub username? I can give you push access to the
main repo. I think you have been helping around here with patches and
reviewing long enough
Comment #59 on issue 2084 by nicolas@gmail.com: limit(1+1/x, x, 0,
dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
Well, since I have not the rights to push this in master, I personally
don't mind.
What I want is this commit in as soon as possible. :)
I'd prefer th
Comment #58 on issue 2084 by smi...@gmail.com: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
You can cherry pick a commit. I've created a separate branch with just this
commit which is only lightly dependent on previous commits:
2084_2084
Do you
Comment #57 on issue 2084 by nicolas@gmail.com: limit(1+1/x, x, 0,
dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
So, you mean one may push this commit alone
(https://github.com/smichr/sympy/commit/dc2b35bcd8fab07db208f5931a011fc3990a4962)
in master, without openi
Comment #56 on issue 2084 by smi...@gmail.com: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
They are interdependent...at least some are...and it becomes a headache to
keep them all synchronized when they are in different places. There are 8
commit
Updates:
Labels: -NeedsReview PassedReview
Comment #55 on issue 2084 by nicolas@gmail.com: limit(1+1/x, x, 0,
dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
Thanks Chris, results seem to be correct now.
Btw, why did you append all those additional commits to
Updates:
Labels: -NeedsBetterPatch NeedsReview
Comment #54 on issue 2084 by smi...@gmail.com: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
Changes have been made. See commit 2084 in [
https://github.com/sympy/sympy/pull/61 ].
--
You receiv
Updates:
Labels: -PassedReview NeedsBetterPatch
Comment #53 on issue 2084 by nicolas@gmail.com: limit(1+1/x, x, 0,
dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
(No comment was entered for this change.)
--
You received this message because you are subscribed
Comment #52 on issue 2084 by nicolas@gmail.com: limit(1+1/x, x, 0,
dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
Some issues mentioned by Ronan still remain:
In [1]: limit((-x)**(-1/S(2)),x,0,dir="-")
Out[1]:
-ⅈ
──
0
In [2]: gruntz((-x)**(-1/S(2)),x,0,dir="-")
Out[
Comment #51 on issue 2084 by smi...@gmail.com: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
If you could have a look that would be great. Nobody said anything after
the last change.
--
You received this message because you are subscribed to the Go
Comment #50 on issue 2084 by nicolas@gmail.com: limit(1+1/x, x, 0,
dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
Yes, I meant this one.
Did last changes pass review ? Do you want me to have a look, or is this
ok ?
--
You received this message because you are sub
Comment #49 on issue 2084 by smi...@gmail.com: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
I don't think there is any pending discussion. What url are you seeing the
discussion on? I'm looking at
https://github.com/sympy/sympy/pull/61
where 5 da
Comment #48 on issue 2084 by nicolas@gmail.com: limit(1+1/x, x, 0,
dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
Sorry, I didn't see there's a new discussion bellow pull request 61...
--
You received this message because you are subscribed to the Google Groups
"sym
Updates:
Cc: asmeurer Ronan.Lamy ondrej.certik Vinzent.Steinberg smichr
Comment #47 on issue 2084 by nicolas@gmail.com: limit(1+1/x, x, 0,
dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
Could someone push this in, since it passed review for a while now, and
Comment #46 on issue 2084 by candleband: limit(1+1/x, x, 0, dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
I closed all 3, and opened a new request (61) that shows the correct single
commit over the current master.
--
You received this message because you are subscribed
Comment #45 on issue 2084 by nicolas.pourcelot: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
Commit bae66169 is the correct one, so pull requests 22 and 29 are both
right.
Pull request 43 should be removed however (corresponding commits b7264f6
Comment #44 on issue 2084 by ronan.l...@gmail.com: limit(1+1/x, x, 0,
dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
I'd push this in if I understood which of the 3 pull requests named "2084"
is/are the right one(s). Chris, can you sort out the confusion between
https
Comment #43 on issue 2084 by smichr: limit(1+1/x, x, 0, dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
Maybe a new pull request is generated when the code is rebased?
--
You received this message because you are subscribed to the Google Groups
"sympy-patches" group.
To pos
Comment #42 on issue 2084 by nicolas.pourcelot: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
The point is, commits content itself as displayed in Github has not change
since November, despite smichr/2084 having change at least twice since...
Btw,
Comment #41 on issue 2084 by asmeurer: limit(1+1/x, x, 0, dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
Well, since you also worked on a patch, I would consider your review to be
valid. You definitely can say more about the changes than someone like me,
who isn't at al
Comment #40 on issue 2084 by nicolas.pourcelot: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
'Chris is actually a "senior member" if you ask me'
Yes, but I meant, someone else than the author. :)
There's something I don't understand concerning Githu
Comment #39 on issue 2084 by Vinzent.Steinberg: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
Chris is actually a "senior member" if you ask me, so it's fine. :)
Actually, our policy is that a patch is fine if it got reviewed by anyone
but the autho
Updates:
Labels: -NeedsReview PassedReview
Comment #38 on issue 2084 by nicolas.pourcelot: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
Thanks Chris, your smichr/2084 branch is now fine for me.
(Your pull request content seems outdated howeve
Comment #37 on issue 2084 by smichr: limit(1+1/x, x, 0, dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
Thanks for the feedback. I made those changes and added the tests. Please
check recent update.
--
You received this message because you are subscribed to the Google Gro
Comment #36 on issue 2084 by nicolas.pourcelot: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
Chris, I finished reviewing it.
It's almost ok for me.
The most important tests are in, imo.
The only remaining issue is this 1/0 == oo problem I mentioned
Comment #35 on issue 2084 by nicolas.pourcelot: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
"Nicolas, I fixed the issue of comment 20 in response to someone commenting
on the commit and put in a pull request."
Actually, it was me. ;)
I opened a gi
Comment #34 on issue 2084 by smichr: limit(1+1/x, x, 0, dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
2084 now has 100% coverage, too. In comparing the two commits I saw that
2084 imported but did not use zoo while the other did not import it. I
added a test to 2084 to
Comment #33 on issue 2084 by smichr: limit(1+1/x, x, 0, dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
I like how mine is factored better. I'm not sure that all the tests are
necessary (as raised in comment 18) and I fix a typo in another test, too.
--
You received this
Updates:
Labels: nicolas.pourcelot
Comment #32 on issue 2084 by asmeurer: limit(1+1/x, x, 0, dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
Since you both have worked on a patch, can you both review each other's
work and make sure that the one patch is just as good
Comment #31 on issue 2084 by smichr: limit(1+1/x, x, 0, dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
Nicolas, I fixed the issue of comment 20 in response to someone commenting
on the commit and put in a pull request. I don't care which version goes in
(this or the one
Comment #30 on issue 2084 by nicolas.pourcelot: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
I read http://help.github.com/pull-requests/, and this seems quite easy.
Thanks for your advice.
--
You received this message because you are subscribed to
Comment #29 on issue 2084 by asmeurer: limit(1+1/x, x, 0, dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
If you can send a patch as a pull request in GitHub, it will greatly
increase its chances of being reviewed.
--
You received this message because you are subscribed t
Updates:
Labels: Milestone-Release0.7.0
Comment #28 on issue 2084 by nicolas.pourcelot: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
The patch (attached with comment 17) is not very long to review... so I
think this could reasonably be done
Comment #27 on issue 2084 by smichr: limit(1+1/x, x, 0, dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
issue2084#c17
--
You received this message because you are subscribed to the Google Groups
"sympy-patches" group.
To post to this group, send email to sympy-patc...@googl
Comment #26 on issue 2084 by Vinzent.Steinberg: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
It can be shorter:
http://code.google.com/p/sympy/issues/detail?id=2084#c17
but not as short as "issue 2084".
--
You received this message because you are
Comment #25 on issue 2084 by asmeurer: limit(1+1/x, x, 0, dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
I don't think Google Code autolinks those like it does issues (see the
bottom of http://code.google.com/p/support/wiki/WhatsNew). Usually, people
just say "Comment w
Comment #24 on issue 2084 by nicolas.pourcelot: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
(By the way, is there a clean and easy way to make an hyperlink which
refers to a comment, the same way we does for an issue ??)
--
You received this mess
Comment #23 on issue 2084 by nicolas.pourcelot: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
As of today, the code in the pull request is incorrect, because of the
wrong special case of 'z being a real'.
Chris, do you agree with my patch ? (comment
Comment #22 on issue 2084 by smichr: limit(1+1/x, x, 0, dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
I must be forgetting to put in the minus sign when I do the test. I'll make
the change and repush.
--
You received this message because you are subscribed to the Google
Comment #21 on issue 2084 by asmeurer: limit(1+1/x, x, 0, dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
This is the pull request: https://github.com/sympy/sympy/pull/29
--
You received this message because you are subscribed to the Google Groups
"sympy-patches" group.
To
Comment #20 on issue 2084 by nicolas.pourcelot: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
(Sorry, previous comment deleted... this was not the right example.)
"limit(r**(-Rational(1,2)), r, 0, '-') would then be oo not I*oo, right?"
No, once agai
Comment #19 on issue 2084 by nicolas.pourcelot: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
"limit(r**(-Rational(1,2)), r, 0, '-') would then be oo not I*oo, right?"
No, once again, this doesn't change anything:
(-.0001)**(S(1)/2) # -.0001
Comment #18 on issue 2084 by smichr: limit(1+1/x, x, 0, dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
I'm not sure about adding all the tests. Tests should test coverage and
assert behavior that shouldn't change. They aren't all needed for coverage.
They do assert what
Updates:
Labels: -NeedsBetterPatch NeedsReview
Comment #17 on issue 2084 by nicolas.pourcelot: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
Chris, I rebased your 2 commits and my patch.
I also added your quite exhaustive test suggestion.
The
Comment #16 on issue 2084 by nicolas.pourcelot: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
On my 2084 branch (with the patch I attached previously):
x**(-2) dir= - = oo
x**(-2) dir= + = oo
x**(-3) dir= - = -oo
x**(-3) dir= + = oo
x**(-1/2) dir= - =
Updates:
Labels: -NeedsReview NeedsBetterPatch
Comment #15 on issue 2084 by nicolas.pourcelot: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
"What about positive rationals from the left? Does this now look right?
x**(1/2) dir= - = zoo
...
x**(
Comment #14 on issue 2084 by smichr: limit(1+1/x, x, 0, dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
I'll add the tests tonight or tomorrow.
var('x')
from sympy.utilities.iterables import cartes
for args in cartes([-1,1],[2,3,Rational(1,2),Rational(2,3)],['-', '+']):
Updates:
Labels: -NeedsBetterPatch NeedsReview
Comment #13 on issue 2084 by smichr: limit(1+1/x, x, 0, dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
What about positive rationals from the left? Does this now look right?
x**(1/2) dir= - = zoo
x**(1/2) dir= + = 0
x**
Comment #12 on issue 2084 by nicolas.pourcelot: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
I think x**0 is already automatically converted to 1 by sympy, isn't it ?
x**0
1
So, computing limit(x**0, x, 0) results in limit(1, x, 0), not matter
w
Comment #11 on issue 2084 by smichr: limit(1+1/x, x, 0, dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
but x**0 should be 1 no matter what, shouldn't it?
--
You received this message because you are subscribed to the Google Groups
"sympy-patches" group.
To post to this gro
Comment #10 on issue 2084 by nicolas.pourcelot: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
A cleaner version to illustrate what I meant (I didn't adapt tests).
Attachments:
0001-second-Pow-issue-try.patch 1.3 KB
--
You received this messa
Updates:
Labels: -NeedsReview NeedsBetterPatch
Comment #9 on issue 2084 by nicolas.pourcelot: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
Two comments:
1) About 1/x**(p/q) with x<0:
gruntz(1/x**Rational(3,2),x,0,dir='-')
oo*I
limit(1/x*
Updates:
Labels: -NeedsBetterPatch NeedsReview
Comment #8 on issue 2084 by smichr: limit(1+1/x, x, 0, dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
This was a separate but related issue: a Pow instead of an Add.
Added a new commit to 2084.
--
You received this mes
Comment #7 on issue 2084 by nicolas.pourcelot: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
This is caused by the following bug (in master too) :
limit(1/x**2,x,0,dir='-')
-oo
--
You received this message because you are subscribed to the Google Gr
Updates:
Labels: -NeedsReview NeedsBetterPatch
Comment #6 on issue 2084 by nicolas.pourcelot: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
Hmm, I spoke to quickly:
limit(x+1/x,x,0,dir='-')
-oo # ok
limit(1/x**2+1/x,x,0,dir='-')
-oo # wro
Comment #5 on issue 2084 by nicolas.pourcelot: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
I think it's ok.
--
You received this message because you are subscribed to the Google Groups
"sympy-patches" group.
To post to this group, send email to sym
Updates:
Labels: NeedsReview smichr
Blockedon: -2096
Comment #4 on issue 2084 by smichr: limit(1+1/x, x, 0, dir='-') fails
http://code.google.com/p/sympy/issues/detail?id=2084
Please consider the following branch which has a minor modification of
limit that gives the correct re
67 matches
Mail list logo
