Re: [Synfig-devl] Review Request: Partially fix 2175043: Exception not caught when render target file is not accessible (writable or path exists)

2009-04-11 Thread Paul Wise
> On 2008-10-18 00:31:14.554976, Paul Wise wrote: > > I think that it should catch the exception instead of testing if the file > > can be created. > > Carlos López González wrote: > using try { stuff } catch() {} doesn't seem to correct the problem. Maybe > it has to be caught in other pl

Re: [Synfig-devl] Review Request: ValueNode Type: Power

2009-04-11 Thread Paul Wise
--- This is an automatically generated e-mail. To reply, visit: http://patches.synfig.org/r/18/#review39 --- Some fixes needed. /synfig-core/trunk/src/synfig/valuenode.cpp

Re: [Synfig-devl] Review Request: Fix the double intializing of field state_ in InputDevice

2009-04-11 Thread Paul Wise
--- This is an automatically generated e-mail. To reply, visit: http://patches.synfig.org/r/20/#review38 --- Ship it! Great, please commit it. - Paul On 2009-04-11 02:45:55.550583,

Re: [Synfig-devl] Review Request: patch for saving and restoring the input devices configuration

2009-04-11 Thread Paul Wise
> On 2009-04-10 18:43:48.042762, Paul Wise wrote: > > Patch looks good, except for a few remaining comments from the previous > > version and adding copyright info and adding your name to AUTHORS. > > > > You might also want to add doxygen comments for the new public functions. > > > > I assum

Re: [Synfig-devl] Review Request: patch for saving and restoring the input devices configuration

2009-04-11 Thread Gerco Ballintijn
--- This is an automatically generated e-mail. To reply, visit: http://patches.synfig.org/r/19/ --- (Updated 2009-04-11 03:01:13.096969) Review request for Synfig. Changes ---

Re: [Synfig-devl] Review Request: patch for saving and restoring the input devices configuration

2009-04-11 Thread Gerco Ballintijn
> On 2009-04-10 18:43:48.042762, Paul Wise wrote: > > Patch looks good, except for a few remaining comments from the previous > > version and adding copyright info and adding your name to AUTHORS. > > > > You might also want to add doxygen comments for the new public functions. > > > > I assum

[Synfig-devl] Review Request: Fix the double intializing of field state_ in InputDevice

2009-04-11 Thread Gerco Ballintijn
--- This is an automatically generated e-mail. To reply, visit: http://patches.synfig.org/r/20/ --- Review request for Synfig. Summary --- This patch fixes removes the second int