Branch: refs/heads/master
  Home:   https://github.com/synfig/synfig
  Commit: 495ce1f6d7695032e6ed8735d63075b6a3147786
      
https://github.com/synfig/synfig/commit/495ce1f6d7695032e6ed8735d63075b6a3147786
  Author: Firas Hanife <firashan...@gmail.com>
  Date:   2020-11-18 (Wed, 18 Nov 2020)

  Changed paths:
    M synfig-studio/src/gui/dialogs/dialog_setup.cpp
    M synfig-studio/src/gui/instance.cpp

  Log Message:
  -----------
  Add confirm dialog for Restore Defaults in Preferences


  Commit: d831641f1e0a2a224a7317f73c56fd8db321f7e6
      
https://github.com/synfig/synfig/commit/d831641f1e0a2a224a7317f73c56fd8db321f7e6
  Author: Firas Hanife <firashan...@gmail.com>
  Date:   2020-11-18 (Wed, 18 Nov 2020)

  Changed paths:
    M synfig-studio/src/gui/dialogs/dialog_setup.cpp

  Log Message:
  -----------
  Restore Defaults is  applied on Ok pressed


  Commit: cc638dfd639587121616100d539cccc05c1d01d9
      
https://github.com/synfig/synfig/commit/cc638dfd639587121616100d539cccc05c1d01d9
  Author: Firas Hanife <firashan...@gmail.com>
  Date:   2020-11-18 (Wed, 18 Nov 2020)

  Changed paths:
    M synfig-studio/src/gui/dialogs/dialog_setup.cpp

  Log Message:
  -----------
  Add confirm dialog and code for not applied settings


  Commit: 4a60dab49514d309afd1f2e79922133c82fb98d7
      
https://github.com/synfig/synfig/commit/4a60dab49514d309afd1f2e79922133c82fb98d7
  Author: Firas Hanife <firashan...@gmail.com>
  Date:   2020-11-18 (Wed, 18 Nov 2020)

  Changed paths:
    M synfig-studio/src/gui/dialogs/dialog_setup.cpp
    M synfig-studio/src/gui/dialogs/dialog_setup.h

  Log Message:
  -----------
  Avoid unintended overwriting of current settings


  Commit: 73172fbc67618e284bc80fd2e2d0b8dafe7b55ca
      
https://github.com/synfig/synfig/commit/73172fbc67618e284bc80fd2e2d0b8dafe7b55ca
  Author: Firas Hanife <firashan...@gmail.com>
  Date:   2020-11-18 (Wed, 18 Nov 2020)

  Changed paths:
    M synfig-studio/src/gui/dialogs/dialog_setup.cpp

  Log Message:
  -----------
  Add code for reading current settings


  Commit: 743c6057e0a68dd3bdb8785b95d96a9960916dea
      
https://github.com/synfig/synfig/commit/743c6057e0a68dd3bdb8785b95d96a9960916dea
  Author: Firas Hanife <firashan...@gmail.com>
  Date:   2020-11-18 (Wed, 18 Nov 2020)

  Changed paths:
    M synfig-studio/src/gui/app.cpp
    M synfig-studio/src/gui/app.h

  Log Message:
  -----------
  Remove unused code


  Commit: e8c46344026d8f51c237f4894520dc6906c430d9
      
https://github.com/synfig/synfig/commit/e8c46344026d8f51c237f4894520dc6906c430d9
  Author: Firas Hanife <firashan...@gmail.com>
  Date:   2020-11-18 (Wed, 18 Nov 2020)

  Changed paths:
    M synfig-studio/src/gui/dialogs/dialog_setup.cpp

  Log Message:
  -----------
  Restore new parameter for animation thumbnail preview


  Commit: d51978a35fe6b3116a8e54c8e0a00a790ebbdeb5
      
https://github.com/synfig/synfig/commit/d51978a35fe6b3116a8e54c8e0a00a790ebbdeb5
  Author: Firas Hanife <firashan...@gmail.com>
  Date:   2020-11-18 (Wed, 18 Nov 2020)

  Changed paths:
    M synfig-studio/src/gui/dialogs/dialog_setup.cpp

  Log Message:
  -----------
  Fix build error


  Commit: 3d329775ff210eea3b5ce390485654e472bf1bc1
      
https://github.com/synfig/synfig/commit/3d329775ff210eea3b5ce390485654e472bf1bc1
  Author: ice0 <konop...@gmail.com>
  Date:   2020-11-19 (Thu, 19 Nov 2020)

  Changed paths:
    M synfig-studio/src/gui/app.cpp
    M synfig-studio/src/gui/app.h
    M synfig-studio/src/gui/dialogs/dialog_setup.cpp
    M synfig-studio/src/gui/dialogs/dialog_setup.h
    M synfig-studio/src/gui/instance.cpp

  Log Message:
  -----------
  Merge PR #1445: Restore Defaults is applied only on OK pressed

There is a functional issue with the current implementation.

Some values have their signal connected to a function which does change the 
settings of Synfig.
This means that if for example autosave is disabled, when Cancel is pressed it 
won't be reverted to current settings.
Probably the best way to deal with it is to remove those parts that in practice 
don't give any advantage to the user.


Compare: https://github.com/synfig/synfig/compare/05c760f4506b...3d329775ff21


_______________________________________________
Synfig-devl mailing list
Synfig-devl@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/synfig-devl

Reply via email to