Branch: refs/heads/master
Home: https://github.com/synfig/synfig
Commit: a329cc4c61832f639f3e61949652b19fdc29b153
https://github.com/synfig/synfig/commit/a329cc4c61832f639f3e61949652b19fdc29b153
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2023-09-27 (Wed, 27 Sep 2023)
Changed paths:
M synfig-core/src/synfig/canvas.cpp
M synfig-core/src/synfig/canvasfilenaming.cpp
M synfig-core/src/synfig/filesystem_path.cpp
M synfig-core/src/synfig/filesystem_path.h
M synfig-core/test/filesystem_path.cpp
Log Message:
-----------
fix: issues with importing with absolute paths from different root path
and implements missing lexically_proximate(), that actually do what
old ETL relative() did.
relative() returns empty path if path isn't relative to base path.
fix #3212
Commit: 7088556bcd23f21602752947ad818d776584267f
https://github.com/synfig/synfig/commit/7088556bcd23f21602752947ad818d776584267f
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2023-09-27 (Wed, 27 Sep 2023)
Changed paths:
M synfig-studio/src/gui/widgets/widget_filename.cpp
Log Message:
-----------
fix: Widget_Filename didn't resolve correct filepath with absolute files
Problem rises only when user clicks the Widget_Filename Open button.
This widget supposes both current Synfig document (canvas) filepath
and the filepath the widget stores are in the same root path (e.g. C:\
or \\shared-fs).
It tries to solve the absolute path by simply concatenating the canvas
parent directory with stored file path, and that solution doesn't work
on such cases.
Example:
"Regular" case:
C:\Users\anonymous\synfig\my-canvas.sif
C:\assets\sound\bg.ogg (proximate path -> ../../../assets/sound/bg.ogg)
C:\Users\anonymous\synfig + / + ../../../assets/sound/bg.ogg
becomes
C:\assets\sound\bg.ogg (it works!)
"Problematic" case:
C:\Users\anonymous\synfig\my-canvas.sif
D:\assets\sound\bg.ogg (proximate path -> D:\assets\sound\bg.ogg)
C:\Users\anonymous\synfig + / + D:\assets\sound\bg.ogg
becomes
C:\Users\anonymous\synfig/D:\assets\sound\bg.ogg (Ugh!)
Commit: 2cf7e0eefae64dedc92103265d3c45bf14d58b0d
https://github.com/synfig/synfig/commit/2cf7e0eefae64dedc92103265d3c45bf14d58b0d
Author: ice0 <konop...@gmail.com>
Date: 2023-09-27 (Wed, 27 Sep 2023)
Changed paths:
M synfig-core/src/synfig/canvas.cpp
M synfig-core/src/synfig/canvasfilenaming.cpp
M synfig-core/src/synfig/filesystem_path.cpp
M synfig-core/src/synfig/filesystem_path.h
M synfig-core/test/filesystem_path.cpp
M synfig-studio/src/gui/widgets/widget_filename.cpp
Log Message:
-----------
fix: issues when importing with absolute paths from different root path
(#3214)
Compare: https://github.com/synfig/synfig/compare/3f490e5c18db...2cf7e0eefae6
_______________________________________________
Synfig-devl mailing list
Synfig-devl@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/synfig-devl
