>From b165f17de89c1d61d640234e6516d9f517aa25b2 Mon Sep 17 00:00:00 2001
From: William Douglas
Date: Tue, 7 Feb 2012 12:31:20 -0800
Subject: [PATCH] systemd: Add systemd.setenv for /proc/cmdline parsing.
Check for systemd.setenv when parsing /proc/cmdline.
ex: systemd.setenv=PATH=/opt/bin
Signed-
Fixes segfault in systemd-logind, triggered by:
systemd-loginctl show-session $XDG_SESSION_ID.
Bug introduced by d200735e13c52dcfe36c0e066f9f6c2fbfb85a9c,
so only systemd v39 is affected.
---
src/login/logind-session-dbus.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/
Hi Phil,
On Tue, Feb 7, 2012 at 8:15 PM, Phil Miller wrote:
> Since it get's more and more complex to keep up our patch to add our distro to
> systemd it would be nice to have it added upstream. Attached your current
> patch for systemd 40
I think the patch is duplicating the parsing of rc.conf
Since it get's more and more complex to keep up our patch to add our distro to
systemd it would be nice to have it added upstream. Attached your current
patch for systemd 40diff -Npur systemd-40.orig/config.h.in systemd-40/config.h.in
--- systemd-40.orig/config.h.in 2011-06-16 13:19:00.0
On Tue, 07.02.12 15:57, Michael Olbrich (m.olbr...@pengutronix.de) wrote:
> > our_env needs to be allocated larger for this. You need to increase the
> > new0() line to 5 instead of the current 4 char* objects.
>
> Not in this case I think. An earlier commit removed on env variable without
> decr
On Tue, Feb 07, 2012 at 03:25:32PM +0100, Lennart Poettering wrote:
> On Fri, 03.02.12 21:14, Michael Olbrich (m.olbr...@pengutronix.de) wrote:
>
> > ---
> > src/service.c |6 ++
> > 1 files changed, 6 insertions(+), 0 deletions(-)
> >
> > diff --git a/src/service.c b/src/service.c
> > i
On Fri, 03.02.12 21:14, Michael Olbrich (m.olbr...@pengutronix.de) wrote:
> +s->start_limit_interval = 10*USEC_PER_SEC;
> +s->start_limit_burst = 5;
> +
Just use RATELIMIT_INIT() here, as previously.
> s->timer_watch.type = WATCH_INVALID;
> #ifdef HAVE_SYSV_COMPAT
>
On Fri, 03.02.12 21:14, Michael Olbrich (m.olbr...@pengutronix.de) wrote:
> switch (s->state) {
> diff --git a/src/service.h b/src/service.h
> index b1e8b90..32341f0 100644
> --- a/src/service.h
> +++ b/src/service.h
> @@ -95,6 +95,7 @@ typedef enum ServiceResult {
> SERVICE_FAIL
On Fri, 03.02.12 21:14, Michael Olbrich (m.olbr...@pengutronix.de) wrote:
> The third patch. This is work in progress. Just the variables so far. I
> tried to follow other examples. Not sure if I did everything correctly.
> And I could not find any place to initialize the rate limiter with the
> c
On Fri, 03.02.12 21:14, Michael Olbrich (m.olbr...@pengutronix.de) wrote:
> ---
> src/service.c |6 ++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/src/service.c b/src/service.c
> index f030ccf..9bd3332 100644
> --- a/src/service.c
> +++ b/src/service.c
> @@ -1726,
On Tue, 07.02.12 13:18, Michael Olbrich (m.olbr...@pengutronix.de) wrote:
>
> Hi,
>
> I've been thinking a bit more about this. There are some problems with
> this. Consider a service that works like this:
> 2. might be a bit too restrictive for more relaxed scenarios, especially
> when combined
On Mon, 06.02.12 16:21, Douglas, William (william.doug...@intel.com) wrote:
Heya,
your mailer applied line breaks to you patch. Please resend with
unbroken lines.
> +} else if (startswith(word, "systemd.setenv=")) {
> +char *eq;
> +int r;
> +
> +
Hi,
I've been thinking a bit more about this. There are some problems with
this. Consider a service that works like this:
do_setup()
sd_notify("READY=1")
while (true) {
do_work()
sd_notify("WATCHDOG=1")
}
Now the error is, that do_work() never finishes, even after restart.
First
13 matches
Mail list logo
