[systemd-devel] [PATCH V3] man: Add even more to the bootchart man page

2013-02-13 Thread William Giokas
Essentially transfer the 'README' file in src/bootchart to the man page for easier reading by users. --- > I don't think that this is a good idea. It mixes semantic and visual > markup and it'll confuse make-directive-index.py badly. > Maybe Original bash? I see your point. Fixed in this version.

Re: [systemd-devel] [PATCH V2] man: Add even more to the bootchart man page

2013-02-13 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Feb 13, 2013 at 05:54:49PM -0600, William Giokas wrote: > Essentially transfer the 'README' file in src/bootchart to the man page > for easier reading by users. > --- > man/systemd-bootchart.xml | 120 > -- > 1 file changed, 106 insertions(+), 1

Re: [systemd-devel] [PATCH] ignore comments in multiline variable definitions

2013-02-13 Thread Kok, Auke-jan H
On Wed, Feb 13, 2013 at 4:26 PM, Kay Sievers wrote: > On Wed, Feb 13, 2013 at 9:52 PM, Zbigniew Jędrzejewski-Szmek > wrote: >> On Wed, Feb 13, 2013 at 08:07:07PM +0100, Lennart Poettering wrote: >>> On Wed, 13.02.13 20:05, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) >>> wrote: >>> >>> > Actu

Re: [systemd-devel] [PATCH] bootchart: use conf-parser & CamelCase names in .conf

2013-02-13 Thread Kok, Auke-jan H
On Wed, Feb 13, 2013 at 4:00 PM, Kay Sievers wrote: > On Thu, Feb 14, 2013 at 12:42 AM, Kok, Auke-jan H > wrote: >> On Wed, Feb 13, 2013 at 3:32 PM, Lennart Poettering >> wrote: >>> On Wed, 13.02.13 14:27, Kok, Auke-jan H (auke-jan.h@intel.com) wrote: >>> > Hmm, what does this stand for

Re: [systemd-devel] [PATCH] ignore comments in multiline variable definitions

2013-02-13 Thread Kay Sievers
On Wed, Feb 13, 2013 at 9:52 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Wed, Feb 13, 2013 at 08:07:07PM +0100, Lennart Poettering wrote: >> On Wed, 13.02.13 20:05, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) >> wrote: >> >> > Actually, the syntax already is _not_ a subset of the shell, and h

Re: [systemd-devel] [PATCH] bootchart: use conf-parser & CamelCase names in .conf

2013-02-13 Thread Kay Sievers
On Thu, Feb 14, 2013 at 12:42 AM, Kok, Auke-jan H wrote: > On Wed, Feb 13, 2013 at 3:32 PM, Lennart Poettering > wrote: >> On Wed, 13.02.13 14:27, Kok, Auke-jan H (auke-jan.h@intel.com) wrote: >> >>> > Hmm, what does this stand for? Wikipedia doesn't have it, can't be that >>> > well known...

[systemd-devel] [PATCH V2] man: Add even more to the bootchart man page

2013-02-13 Thread William Giokas
Essentially transfer the 'README' file in src/bootchart to the man page for easier reading by users. --- man/systemd-bootchart.xml | 120 -- 1 file changed, 106 insertions(+), 14 deletions(-) diff --git a/man/systemd-bootchart.xml b/man/systemd-bootchar

Re: [systemd-devel] troubleshooting different behaviour of systemd between f16 and f18

2013-02-13 Thread Thierry Parmentelat
On Feb 13, 2013, at 10:29 PM, Lennart Poettering wrote: > Hmm? Why does syslog/journalctl require the network? Yeah, sorry, I haven't made myself very clear: I can't get into the node as I have no physical access; and the node can't talk on the network; so I can't see the output of either of th

Re: [systemd-devel] [PATCH] bootchart: use conf-parser & CamelCase names in .conf

2013-02-13 Thread Kok, Auke-jan H
On Wed, Feb 13, 2013 at 3:32 PM, Lennart Poettering wrote: > On Wed, 13.02.13 14:27, Kok, Auke-jan H (auke-jan.h@intel.com) wrote: > >> > Hmm, what does this stand for? Wikipedia doesn't have it, can't be that >> > well known... >> >> PSS is the alternative to RSS... You probably won't find an

Re: [systemd-devel] [PATCH] man: Add even more to the bootchart man page

2013-02-13 Thread Kok, Auke-jan H
On Wed, Feb 13, 2013 at 3:21 PM, William Giokas <1007...@gmail.com> wrote: > Essentially transfer the 'README' file in src/bootchart to the man page > for easier reading by users. > --- thanks, one comment: > + > + > +Contributors misnomer, the only person in this list

Re: [systemd-devel] [PATCH] bootchart: use conf-parser & CamelCase names in .conf

2013-02-13 Thread Lennart Poettering
On Wed, 13.02.13 14:27, Kok, Auke-jan H (auke-jan.h@intel.com) wrote: > > Hmm, what does this stand for? Wikipedia doesn't have it, can't be that > > well known... > > PSS is the alternative to RSS... You probably won't find an > explanation anywhere else but the kernel source code: > > Docu

[systemd-devel] encrypted swap

2013-02-13 Thread Stefan G. Weichinger
I see an issue with systemd-197 on one of my gentoo systems. Encrypted swap doesn't get enabled correctly as mentioned below. In the git-repo of systemd I read in the TODO-file: > swap units that are activated by one name but shown in the kernel > under another are semi-broken Might that be re

Re: [systemd-devel] [PATCH][V3] systemd-analyze: rewrite in C.

2013-02-13 Thread Kok, Auke-jan H
On Mon, Feb 4, 2013 at 12:32 PM, Simon Peeters wrote: > Written by Peeters Simon . Makefile stuff > and cleaned up a bit by Auke Kok . > --- > > Fixed some stuff and dit some more cleanup. > > This should just cover the same usage as the old systemd-analyze, but we can > add more functionality aft

Re: [systemd-devel] [PATCH] man: bootchart: change /var/log to /run/log

2013-02-13 Thread Kok, Auke-jan H
On Wed, Feb 13, 2013 at 12:49 PM, William Giokas <1007...@gmail.com> wrote: > As of [1], bootchart stores files in /run/log, not /var/log, by default. > > [1] f2f85884caac671da84256acb44148df9a4dca70 applied, thanks! Auke ___ systemd-devel mailing list

[systemd-devel] [PATCH] [RFC] Set StopWhenUnneeded=no when unit unneeded, but forced

2013-02-13 Thread Oleksii Shevchuk
--- src/core/dbus-unit.c | 18 +++- src/core/job.c| 27 +++- src/core/job.h| 1 + src/core/load-fragment-gperf.gperf.m4 | 2 +- src/core/load-fragment.c | 3 ++ src/core/manager.c| 2 +

Re: [systemd-devel] [PATCH] bootchart: use conf-parser & CamelCase names in .conf

2013-02-13 Thread Kok, Auke-jan H
On Wed, Feb 13, 2013 at 2:54 PM, Thomas H.P. Andersen wrote: > On Wed, Feb 13, 2013 at 10:31 PM, Lennart Poettering > wrote: >> On Wed, 13.02.13 12:20, Kok, Auke-jan H (auke-jan.h@intel.com) wrote: >> >>> >>> On Wed, Feb 13, 2013 at 11:31 AM, Lennart Poettering >>> wrote: >>> > On Wed, 13.02

[systemd-devel] [PATCH] man: Add even more to the bootchart man page

2013-02-13 Thread William Giokas
Essentially transfer the 'README' file in src/bootchart to the man page for easier reading by users. --- man/systemd-bootchart.xml | 144 +- 1 file changed, 130 insertions(+), 14 deletions(-) diff --git a/man/systemd-bootchart.xml b/man/systemd-bootchar

Re: [systemd-devel] [PATCH] bootchart: use conf-parser & CamelCase names in .conf

2013-02-13 Thread Thomas H.P. Andersen
On Wed, Feb 13, 2013 at 10:31 PM, Lennart Poettering wrote: > On Wed, 13.02.13 12:20, Kok, Auke-jan H (auke-jan.h@intel.com) wrote: > >> >> On Wed, Feb 13, 2013 at 11:31 AM, Lennart Poettering >> wrote: >> > On Wed, 13.02.13 20:24, Thomas Hindoe Paaboel Andersen (pho...@gmail.com) >> > wrote

Re: [systemd-devel] network/openvswitch dependency loop/deadlock

2013-02-13 Thread Thomas Graf
On 02/13/2013 08:03 PM, Lennart Poettering wrote: Well, so first of all, no service needs syslog.service anymore. The socket of syslog is established during early boot, and you should not add deps for it anymore. OK, I'll remove that dependency. We inherited that from the upstream unit file.

Re: [systemd-devel] [PATCH] bootchart: use conf-parser & CamelCase names in .conf

2013-02-13 Thread Kok, Auke-jan H
On Wed, Feb 13, 2013 at 1:31 PM, Lennart Poettering wrote: > On Wed, 13.02.13 12:20, Kok, Auke-jan H (auke-jan.h@intel.com) wrote: > >> >> On Wed, Feb 13, 2013 at 11:31 AM, Lennart Poettering >> wrote: >> > On Wed, 13.02.13 20:24, Thomas Hindoe Paaboel Andersen (pho...@gmail.com) >> > wrote:

[systemd-devel] [PATCH] bootchart: use conf-parser & CamelCase names in .conf

2013-02-13 Thread Thomas Hindoe Paaboel Andersen
v2: Rel -> Relative Freq -> Frequency passes NULL instead of FILE to config_parse --- src/bootchart/bootchart.c| 82 +--- src/bootchart/bootchart.conf | 22 ++-- src/shared/conf-parser.c | 27 +++ src/shared/conf-parser.h |

[systemd-devel] [PATCH] Fix the race in deserialization.

2013-02-13 Thread Oleksii Shevchuk
unit_notify is fired in deserelization code (particulary in service_set_state). Units passed in random order, and there is possibility, that unit with StopWhenUnneeded=yes passed before it actual dependecies. In that case unit will be stopped as unneeded, because deps in UNIT_INACTIVE state yet. S

[systemd-devel] rfe: buildbot entry without --Wl, --as-needed, --gc-sections

2013-02-13 Thread Zbigniew Jędrzejewski-Szmek
Hi David, would it be possible to queue a second jenkins job without those flags? They are added in configure.ac, and I think the easiest way to avoid them is to compile with 'make OUR_LDFLAGS='. This would help some of the stupid linkage bugs. Zbyszek _

Re: [systemd-devel] [PATCH] bootchart: use conf-parser & CamelCase names in .conf

2013-02-13 Thread Lennart Poettering
On Wed, 13.02.13 12:20, Kok, Auke-jan H (auke-jan.h@intel.com) wrote: > > On Wed, Feb 13, 2013 at 11:31 AM, Lennart Poettering > wrote: > > On Wed, 13.02.13 20:24, Thomas Hindoe Paaboel Andersen (pho...@gmail.com) > > wrote: > > > >> +[Bootchart] > >> +#Samples=500 > >> +#Freq=25 > >> +#Rel

Re: [systemd-devel] troubleshooting different behaviour of systemd between f16 and f18

2013-02-13 Thread Lennart Poettering
On Wed, 13.02.13 21:26, Thierry Parmentelat (thierry.parmente...@inria.fr) wrote: > > On Feb 13, 2013, at 4:41 PM, Lennart Poettering wrote: > > > Log output of services ends up in the journal these days, from both > > early boot and late boot. And used to end up in syslog, except for > > early

Re: [systemd-devel] [PATCH] man: bootchart: change /var/log to /run/log

2013-02-13 Thread William Giokas
On Wed, Feb 13, 2013 at 09:57:56PM +0100, Zbigniew Jędrzejewski-Szmek wrote: > On Wed, Feb 13, 2013 at 02:49:24PM -0600, William Giokas wrote: > > As of [1], bootchart stores files in /run/log, not /var/log, by default. > > > > [1] f2f85884caac671da84256acb44148df9a4dca70 > > --- > > man/bootchar

Re: [systemd-devel] [PATCH] man: bootchart: change /var/log to /run/log

2013-02-13 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Feb 13, 2013 at 02:49:24PM -0600, William Giokas wrote: > As of [1], bootchart stores files in /run/log, not /var/log, by default. > > [1] f2f85884caac671da84256acb44148df9a4dca70 > --- > man/bootchart.conf.xml | 2 +- > man/systemd-bootchart.xml| 2 +- > src/bootchart/README

Re: [systemd-devel] [PATCH] ignore comments in multiline variable definitions

2013-02-13 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Feb 13, 2013 at 08:07:07PM +0100, Lennart Poettering wrote: > On Wed, 13.02.13 20:05, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > Actually, the syntax already is _not_ a subset of the shell, and has its > > own pecularities. Anyone trying to blindly follow shell rules is g

[systemd-devel] [PATCH] man: bootchart: change /var/log to /run/log

2013-02-13 Thread William Giokas
As of [1], bootchart stores files in /run/log, not /var/log, by default. [1] f2f85884caac671da84256acb44148df9a4dca70 --- man/bootchart.conf.xml | 2 +- man/systemd-bootchart.xml| 2 +- src/bootchart/README | 2 +- src/bootchart/bootchart.conf | 2 +- src/bootchart/svg.c

Re: [systemd-devel] troubleshooting different behaviour of systemd between f16 and f18

2013-02-13 Thread Thierry Parmentelat
On Feb 13, 2013, at 9:26 PM, Thierry Parmentelat wrote: > Right now I'm using > systemd.log_level=debug systemd.log_target=kmsg OK, of course, I should use log_target=console Which I just did, and that shows a brief mention to pl_sysinit: About to execute /etc/init.d/pl_sysinit^M Forked /etc/

Re: [systemd-devel] troubleshooting different behaviour of systemd between f16 and f18

2013-02-13 Thread Thierry Parmentelat
On Feb 13, 2013, at 4:41 PM, Lennart Poettering wrote: > Log output of services ends up in the journal these days, from both > early boot and late boot. And used to end up in syslog, except for > early-boot where it ended up in kmsg -- which is probably what you saw. > > hence, check syslog or j

Re: [systemd-devel] [PATCH] bootchart: use conf-parser & CamelCase names in .conf

2013-02-13 Thread Kok, Auke-jan H
On Wed, Feb 13, 2013 at 11:31 AM, Lennart Poettering wrote: > On Wed, 13.02.13 20:24, Thomas Hindoe Paaboel Andersen (pho...@gmail.com) > wrote: > >> +[Bootchart] >> +#Samples=500 >> +#Freq=25 >> +#Rel=0 >> +#Filter=1 >> +#Output= This has changed to /run/log being the default with Harald's patc

Re: [systemd-devel] How do you set the machine's domain name with systemd?

2013-02-13 Thread Reindl Harald
Am 13.02.2013 20:26, schrieb Lennart Poettering: > On Wed, 13.02.13 20:23, Reindl Harald (h.rei...@thelounge.net) wrote: > this is a very bad style which became visible with this bug >>> >>> Well, it's not as simple as it might appear. "hostnamectl set-hostname" >>> actually sets the pretty

Re: [systemd-devel] [PATCH] bootchart: use conf-parser & CamelCase names in .conf

2013-02-13 Thread Lennart Poettering
On Wed, 13.02.13 20:24, Thomas Hindoe Paaboel Andersen (pho...@gmail.com) wrote: Heya, looks good in principle. > +fn = "/etc/systemd/bootchart.conf"; > +f = fopen(fn, "re"); No need to open this if you don't have a reason to. config_parse() actually takes a NULL argument for the

Re: [systemd-devel] How do you set the machine's domain name with systemd?

2013-02-13 Thread Lennart Poettering
On Wed, 13.02.13 20:23, Reindl Harald (h.rei...@thelounge.net) wrote: > >> this is a very bad style which became visible with this bug > > > > Well, it's not as simple as it might appear. "hostnamectl set-hostname" > > actually sets the pretty hostname (and should do that unaltered), then > > str

[systemd-devel] [PATCH] bootchart: use conf-parser & CamelCase names in .conf

2013-02-13 Thread Thomas Hindoe Paaboel Andersen
--- src/bootchart/bootchart.c| 82 ++-- src/bootchart/bootchart.conf | 22 ++-- src/shared/conf-parser.c | 27 +++ src/shared/conf-parser.h | 1 + src/shared/util.c| 17 + src/shared/util.h| 2

Re: [systemd-devel] How do you set the machine's domain name with systemd?

2013-02-13 Thread Reindl Harald
Am 13.02.2013 20:12, schrieb Lennart Poettering: > On Wed, 13.02.13 10:23, Reindl Harald (h.rei...@thelounge.net) wrote: > >> >> >> Am 13.02.2013 03:50, schrieb Lennart Poettering: >>> On Wed, 13.02.13 05:42, Adam Nielsen (a.niel...@shikadi.net) wrote: >>> > Use hostnamectl, assuming yo

Re: [systemd-devel] [PATCH 1/4] test-strv.c: added strv_merge test

2013-02-13 Thread Lennart Poettering
On Wed, 13.02.13 16:13, Daniel Buch (boogiewasth...@gmail.com) wrote: Thanks! Commited all four! > --- > src/test/test-strv.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/src/test/test-strv.c b/src/test/test-strv.c > index 07aac3a..3ed5a09 100644 > --- a/src/tes

Re: [systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-02-13 Thread Lennart Poettering
On Wed, 13.02.13 14:45, Michal Sekletar (msekl...@redhat.com) wrote: Heya! Looks good in principle. > +if (context->private_tmp) { > +if (!context->tmp_dir) { > +d = mktemp(tmp_dir); mktemp() is never OK. Also see "BUGS" section in the man page ab

Re: [systemd-devel] How do you set the machine's domain name with systemd?

2013-02-13 Thread Lennart Poettering
On Wed, 13.02.13 10:23, Reindl Harald (h.rei...@thelounge.net) wrote: > > > Am 13.02.2013 03:50, schrieb Lennart Poettering: > > On Wed, 13.02.13 05:42, Adam Nielsen (a.niel...@shikadi.net) wrote: > > > >> > >>> Use hostnamectl, assuming your systemd version is new enough: > >>> > >>> http://ww

Re: [systemd-devel] dependencies between instances

2013-02-13 Thread Lennart Poettering
On Wed, 13.02.13 11:22, Oleksii Shevchuk (alx...@gmail.com) wrote: > > > Can you suggest other usecases? > > I can. Situation like local client-server, where server requires root > creds, cannot into socket/d-bus activation and requires device or > something about it; client should be running fr

Re: [systemd-devel] Can bootchart take advantage of startup completed signal?

2013-02-13 Thread Lennart Poettering
On Wed, 13.02.13 09:27, Umut Tezduyar (u...@tezduyar.com) wrote: > Hi Auke, > > I was wondering if you have tried to take advantage of StartupFinished > signal sent by systemd ( > http://www.freedesktop.org/wiki/Software/systemd/dbus). > > Would it make sense to register on "StartupFinished" sig

Re: [systemd-devel] [PATCH] ignore comments in multiline variable definitions

2013-02-13 Thread Lennart Poettering
On Wed, 13.02.13 20:05, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > Actually, the syntax already is _not_ a subset of the shell, and has its > own pecularities. Anyone trying to blindly follow shell rules is going > to be severly bitten anyway. So, why not go a bit further and change

Re: [systemd-devel] [PATCH] ignore comments in multiline variable definitions

2013-02-13 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Feb 13, 2013 at 07:41:54PM +0100, Lennart Poettering wrote: > On Wed, 13.02.13 05:26, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > > > On Wed, Feb 13, 2013 at 04:27:49AM +0100, Lennart Poettering wrote: > > > On Thu, 07.02.13 11:45, Michal Vyskocil (mvysko...@suse.cz) wrot

Re: [systemd-devel] network/openvswitch dependency loop/deadlock

2013-02-13 Thread Lennart Poettering
On Wed, 13.02.13 08:49, Thomas Graf (tg...@redhat.com) wrote: > > On 02/13/2013 04:06 AM, Lennart Poettering wrote: > >Well, there still is a dep loop, that is unfixed, right? > > > >I mean, you want your service to run as part of bringing up some > >networks, but also after the network is up. So

Re: [systemd-devel] [PATCH 1/6] Set StopWhenUnneeded=no, if unit started manually

2013-02-13 Thread Lennart Poettering
On Wed, 13.02.13 11:46, Oleksii Shevchuk (alx...@gmail.com) wrote: > > Lennart, thanks for reviewing. > > > so the current patch can't really work, or am I missing something? > > Patch works, as I use it every day. Anyway idea with override is better, > as it leaves space for additional usecas

Re: [systemd-devel] RFC: Predictable Network Interface Names

2013-02-13 Thread Kay Sievers
On Wed, Feb 13, 2013 at 7:35 PM, Tomasz Torcz wrote: > On Wed, Feb 13, 2013 at 07:29:10PM +0100, Kay Sievers wrote: >> On Wed, Feb 13, 2013 at 7:19 PM, Tomasz Torcz wrote: >> > On Tue, Feb 12, 2013 at 09:07:00AM +0100, Jan Engelhardt wrote: >> >> >> >> On Monday 2013-01-07 23:29, Lennart Poetteri

Re: [systemd-devel] [PATCH] ignore comments in multiline variable definitions

2013-02-13 Thread Lennart Poettering
On Wed, 13.02.13 05:26, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > On Wed, Feb 13, 2013 at 04:27:49AM +0100, Lennart Poettering wrote: > > On Thu, 07.02.13 11:45, Michal Vyskocil (mvysko...@suse.cz) wrote: > > > > > Commented lines are ignored by default and are considered as end

Re: [systemd-devel] [PATCH] selinux-access:log_callback() increase buffer for audit logging

2013-02-13 Thread Lennart Poettering
On Wed, 13.02.13 17:08, har...@redhat.com (har...@redhat.com) wrote: > From: Harald Hoyer > > As per https://bugzilla.redhat.com/show_bug.cgi?id=883043#c5 > we can increase the buffer used with audit_log_user_avc_message() safely > to 4096 bytes. I have now changed this to use a dynamically siz

Re: [systemd-devel] RFC: Predictable Network Interface Names

2013-02-13 Thread Tomasz Torcz
On Wed, Feb 13, 2013 at 07:29:10PM +0100, Kay Sievers wrote: > On Wed, Feb 13, 2013 at 7:19 PM, Tomasz Torcz wrote: > > On Tue, Feb 12, 2013 at 09:07:00AM +0100, Jan Engelhardt wrote: > >> > >> On Monday 2013-01-07 23:29, Lennart Poettering wrote: > >> > > >> >For your example the new code would p

Re: [systemd-devel] RFC: Predictable Network Interface Names

2013-02-13 Thread Kay Sievers
On Wed, Feb 13, 2013 at 7:19 PM, Tomasz Torcz wrote: > On Tue, Feb 12, 2013 at 09:07:00AM +0100, Jan Engelhardt wrote: >> >> On Monday 2013-01-07 23:29, Lennart Poettering wrote: >> > >> >For your example the new code would pick a name of "enp0s0d0", i.e. for >> >pci bus 0, slot 0, and dev_id 0. >

Re: [systemd-devel] strv tests

2013-02-13 Thread Lennart Poettering
On Wed, 13.02.13 18:29, Thomas H.P. Andersen (pho...@gmail.com) wrote: > > On Wed, Feb 13, 2013 at 1:25 AM, Lennart Poettering > wrote: > > On Mon, 11.02.13 22:39, Daniel Buch (boogiewasth...@gmail.com) wrote: > > > >> And now with patch files. > > > > Looks pretty OK. > > > > But two points: >

Re: [systemd-devel] [PATCH] bootchart: Use os-release, not system-release

2013-02-13 Thread Lennart Poettering
On Wed, 13.02.13 11:37, William Giokas (1007...@gmail.com) wrote: > os-release is required for systemd now, so use that file and stop > printing 'Unknown' on the bootchart. Actually, this code should probably use load_env_file() instead anyway... > --- > src/bootchart/svg.c | 12 >

Re: [systemd-devel] RFC: Predictable Network Interface Names

2013-02-13 Thread Tomasz Torcz
On Tue, Feb 12, 2013 at 09:07:00AM +0100, Jan Engelhardt wrote: > > On Monday 2013-01-07 23:29, Lennart Poettering wrote: > > > >For your example the new code would pick a name of "enp0s0d0", i.e. for > >pci bus 0, slot 0, and dev_id 0. > > Is it Solaris time yet? enp0s0d0, that's just like c0t0d

[systemd-devel] [PATCH] bootchart: Use os-release, not system-release

2013-02-13 Thread William Giokas
os-release is required for systemd now, so use that file and stop printing 'Unknown' on the bootchart. --- src/bootchart/svg.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/bootchart/svg.c b/src/bootchart/svg.c index d7c4168..ec81da9 100644 --- a/src/bootchar

Re: [systemd-devel] strv tests

2013-02-13 Thread Thomas H.P. Andersen
On Wed, Feb 13, 2013 at 1:25 AM, Lennart Poettering wrote: > On Mon, 11.02.13 22:39, Daniel Buch (boogiewasth...@gmail.com) wrote: > >> And now with patch files. > > Looks pretty OK. > > But two points: > > Could you please use assert_se() rather than assert() for these tests? > They both have pre

Re: [systemd-devel] Can bootchart take advantage of startup completed signal?

2013-02-13 Thread Kok, Auke-jan H
On Wed, Feb 13, 2013 at 12:27 AM, Umut Tezduyar wrote: > Hi Auke, > > I was wondering if you have tried to take advantage of StartupFinished > signal sent by systemd > (http://www.freedesktop.org/wiki/Software/systemd/dbus). > > Would it make sense to register on "StartupFinished" signal and stop

Re: [systemd-devel] [PATCH] [RFC] Remove installation of symlinks in /etc

2013-02-13 Thread Kok, Auke-jan H
On Wed, Feb 13, 2013 at 7:16 AM, Richard Maw wrote: > On Wed, Feb 13, 2013 at 03:00:46PM +, Colin Guthrie wrote: >> 'Twas brillig, and Lennart Poettering at 13/02/13 00:21 did gyre and gimble: >> > On Mon, 11.02.13 16:34, Auke Kok (auke-jan.h@intel.com) wrote: >> > >> >> Contrary to it's o

[systemd-devel] [PATCH] selinux-access:log_callback() increase buffer for audit logging

2013-02-13 Thread harald
From: Harald Hoyer As per https://bugzilla.redhat.com/show_bug.cgi?id=883043#c5 we can increase the buffer used with audit_log_user_avc_message() safely to 4096 bytes. --- src/core/selinux-access.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/selinux-access.c b/sr

Re: [systemd-devel] [PATCH] log_error(), if inotify_add_watch() fails

2013-02-13 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Feb 13, 2013 at 04:27:59PM +0100, Lennart Poettering wrote: > On Wed, 13.02.13 16:16, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > > > On Wed, Feb 13, 2013 at 03:09:36PM +0100, har...@redhat.com wrote: > > > k = inotify_add_watch(fd, "/run/systemd/seats/",

Re: [systemd-devel] troubleshooting different behaviour of systemd between f16 and f18

2013-02-13 Thread Lennart Poettering
On Wed, 13.02.13 10:56, Thierry Parmentelat (thierry.parmente...@inria.fr) wrote: > > Hi Lennart > > Thanks for the feedback; I didn't know that, so it might come in handy in > understanding the problem > > However, I'm puzzled because it looks like there's no attempt at all to > launch pl_s

Re: [systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-02-13 Thread Tom Gundersen
On Wed, Feb 13, 2013 at 2:45 PM, Michal Sekletar wrote: > All Execs within the service, will get mounted the same /tmp and /var/tmp > directories, if service is configured with PrivateTmp=yes. Temporary > directories are cleaned up by service itself, rather than relying on > systemd-tmpfiles. Same

Re: [systemd-devel] [PATCH] log_error(), if inotify_add_watch() fails

2013-02-13 Thread Lennart Poettering
On Wed, 13.02.13 16:16, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > On Wed, Feb 13, 2013 at 03:09:36PM +0100, har...@redhat.com wrote: > > k = inotify_add_watch(fd, "/run/systemd/seats/", > > IN_MOVED_TO|IN_DELETE); > > if (k < 0) { > > +

Re: [systemd-devel] [PATCH] [RFC] Remove installation of symlinks in /etc

2013-02-13 Thread Richard Maw
On Wed, Feb 13, 2013 at 03:00:46PM +, Colin Guthrie wrote: > 'Twas brillig, and Lennart Poettering at 13/02/13 00:21 did gyre and gimble: > > On Mon, 11.02.13 16:34, Auke Kok (auke-jan.h@intel.com) wrote: > > > >> Contrary to it's own packaging guidelines, these symlinks are created > >> i

Re: [systemd-devel] [PATCH] log_error(), if inotify_add_watch() fails

2013-02-13 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Feb 13, 2013 at 03:09:36PM +0100, har...@redhat.com wrote: > k = inotify_add_watch(fd, "/run/systemd/seats/", > IN_MOVED_TO|IN_DELETE); > if (k < 0) { > +log_error("Failed to watch /run/systemd/seats/: %m"); >

[systemd-devel] [PATCH 4/4] test-strv.c: Changed assert() to assert_se()

2013-02-13 Thread Daniel Buch
test-strv.c: Indent fix --- src/test/test-strv.c | 96 ++-- 1 file changed, 48 insertions(+), 48 deletions(-) diff --git a/src/test/test-strv.c b/src/test/test-strv.c index 535685f..a8801b5 100644 --- a/src/test/test-strv.c +++ b/src/test/test-strv.

[systemd-devel] [PATCH 3/4] test-strv.c: added strv_append test

2013-02-13 Thread Daniel Buch
--- src/test/test-strv.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/test/test-strv.c b/src/test/test-strv.c index fabc26e..535685f 100644 --- a/src/test/test-strv.c +++ b/src/test/test-strv.c @@ -190,6 +190,19 @@ static void test_strv_merge(void) { assert(str

[systemd-devel] [PATCH 2/4] test-strv.c: added strv_merge_concat test

2013-02-13 Thread Daniel Buch
--- src/test/test-strv.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/test/test-strv.c b/src/test/test-strv.c index 3ed5a09..fabc26e 100644 --- a/src/test/test-strv.c +++ b/src/test/test-strv.c @@ -158,6 +158,20 @@ static void test_strv_sort(void) { assert(stre

[systemd-devel] [PATCH 1/4] test-strv.c: added strv_merge test

2013-02-13 Thread Daniel Buch
--- src/test/test-strv.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/test/test-strv.c b/src/test/test-strv.c index 07aac3a..3ed5a09 100644 --- a/src/test/test-strv.c +++ b/src/test/test-strv.c @@ -158,6 +158,24 @@ static void test_strv_sort(void) { assert(

Re: [systemd-devel] [PATCH] [RFC] Remove installation of symlinks in /etc

2013-02-13 Thread Colin Guthrie
'Twas brillig, and Lennart Poettering at 13/02/13 00:21 did gyre and gimble: > On Mon, 11.02.13 16:34, Auke Kok (auke-jan.h@intel.com) wrote: > >> Contrary to it's own packaging guidelines, these symlinks are created >> in /etc/. While technically not a problem, this makes it harder >> for fol

Re: [systemd-devel] troubleshooting different behaviour of systemd between f16 and f18

2013-02-13 Thread Colin Guthrie
'Twas brillig, and Thierry Parmentelat at 13/02/13 14:03 did gyre and gimble: > Hi Kay; thanks for taking the time to write this down > > I understand what you guys are saying; and at first sight I am on the > safe side here though (as the name suggests, pl_sysinit will only > mount filesystems an

[systemd-devel] [PATCH] log_error(), if inotify_add_watch() fails

2013-02-13 Thread harald
From: Harald Hoyer --- src/login/sd-login.c| 3 +++ src/shared/ask-password-api.c | 1 + src/shared/util.c | 1 + src/tty-ask-password-agent/tty-ask-password-agent.c | 2 ++ 4 files changed, 7 insertions(+)

Re: [systemd-devel] troubleshooting different behaviour of systemd between f16 and f18

2013-02-13 Thread Thierry Parmentelat
Hi Kay; thanks for taking the time to write this down I understand what you guys are saying; and at first sight I am on the safe side here though (as the name suggests, pl_sysinit will only mount filesystems and init network interfaces and the like) However your answers do not shed any light on

Re: [systemd-devel] [PATCH] man: Make options consistent

2013-02-13 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Feb 13, 2013 at 03:39:22AM -0600, William Giokas wrote: > Option listings seemed to be pretty much random, some were short opt, > long opt, others were long opt, short opt. This just makes every option > with a short and long opt that I could find in the order short opt, long > opt, for for

Re: [systemd-devel] [PATCH] man: Write man page for systemd-bootchart(1)

2013-02-13 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Feb 13, 2013 at 03:38:49AM -0600, William Giokas wrote: > Mostly coppied from bootchart.conf(5) Applied. > Signed-off-by: William Giokas <1007...@gmail.com> No need for that. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop

Re: [systemd-devel] [PATCH] test-udev: include missing.h

2013-02-13 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Feb 13, 2013 at 08:50:15AM +0100, Aleksander Morgado wrote: > We need MS_REC and MS_SHARED defined for a proper compilation, so get them > from > 'missing.h' if not defined already. Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@l

Re: [systemd-devel] [PATCH] ratelimit: fix off-by-one

2013-02-13 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Feb 13, 2013 at 08:00:46AM +0100, Michael Olbrich wrote: > The current code might make sense during startup for service restart > limiting: > With burst=1 after starting num is 1, so the next ('first') restart is > still accepted ( 1 <= 1). However, once interval has expired, num is 1 > aft

[systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-02-13 Thread Michal Sekletar
All Execs within the service, will get mounted the same /tmp and /var/tmp directories, if service is configured with PrivateTmp=yes. Temporary directories are cleaned up by service itself, rather than relying on systemd-tmpfiles. Same logic applies also to inaccessible directories. --- man/systemd

Re: [systemd-devel] network/openvswitch dependency loop/deadlock

2013-02-13 Thread Kay Sievers
On Wed, Feb 13, 2013 at 12:10 PM, Colin Guthrie wrote: > Either way, is a generator the way to go here longer term, or is there > some other plan afoot to modernise the static network configs? The static network config files, file format and parsing will some day be part of the core systemd. Lo

Re: [systemd-devel] troubleshooting different behaviour of systemd between f16 and f18

2013-02-13 Thread Kay Sievers
On Wed, Feb 13, 2013 at 10:56 AM, Thierry Parmentelat wrote: > Thanks for the feedback; I didn't know that, so it might come in handy in > understanding the problem > > However, I'm puzzled because it looks like there's no attempt at all to > launch pl_sysinit The background here is: ExecStartP

Re: [systemd-devel] network/openvswitch dependency loop/deadlock

2013-02-13 Thread Colin Guthrie
'Twas brillig, and Lennart Poettering at 13/02/13 03:06 did gyre and gimble: > On Tue, 12.02.13 14:07, Thomas Graf (tg...@redhat.com) wrote: > >> >> On 02/07/2013 04:55 PM, Ian Pilcher wrote: >>> On 02/07/2013 06:13 AM, Colin Guthrie wrote: Also re the initscripts tweaks and the if statement

Re: [systemd-devel] How do you set the machine's domain name with systemd?

2013-02-13 Thread Jóhann B. Guðmundsson
On 02/13/2013 02:50 AM, Lennart Poettering wrote: I am figure "hostnamectl set-hostname" is currently a bit too drastic, but I am not fond at all of the idea of adovcate this fqdn-as-kernel-hostname nonsense any further, it sounds like the wrong idea, from a very narrow IP+DNS mindset... I woul

Re: [systemd-devel] [PATCH] units: Make getty@.service install rule generic.

2013-02-13 Thread Colin Guthrie
'Twas brillig, and Thomas Bächler at 13/02/13 10:01 did gyre and gimble: > Am 13.02.2013 10:29, schrieb Colin Guthrie: >>> Hmm, but what happens then if people do run >>> >>> systemctl enable getty@.service? > > In my eyes, doing this always seemed wrong, I wouldn't mind if it > returned an error.

Re: [systemd-devel] [PATCH] units: Make getty@.service install rule generic.

2013-02-13 Thread Thomas Bächler
Am 13.02.2013 10:29, schrieb Colin Guthrie: >> Hmm, but what happens then if people do run >> >> systemctl enable getty@.service? In my eyes, doing this always seemed wrong, I wouldn't mind if it returned an error. >> We really need to get the story right on this, I guess, so that >> something us

Re: [systemd-devel] troubleshooting different behaviour of systemd between f16 and f18

2013-02-13 Thread Thierry Parmentelat
Hi Lennart Thanks for the feedback; I didn't know that, so it might come in handy in understanding the problem However, I'm puzzled because it looks like there's no attempt at all to launch pl_sysinit The reason I came to believe that is with what I can see specifically on f18 where the init

Re: [systemd-devel] [PATCH 1/6] Set StopWhenUnneeded=no, if unit started manually

2013-02-13 Thread Oleksii Shevchuk
Lennart, thanks for reviewing. > so the current patch can't really work, or am I missing something? Patch works, as I use it every day. Anyway idea with override is better, as it leaves space for additional usecases. But I don't get, how root of transactions should be detected? Should I mark t

[systemd-devel] [PATCH] man: Make options consistent

2013-02-13 Thread William Giokas
Option listings seemed to be pretty much random, some were short opt, long opt, others were long opt, short opt. This just makes every option with a short and long opt that I could find in the order short opt, long opt, for formatting's sake. Signed-off-by: William Giokas <1007...@gmail.com> ---

[systemd-devel] [PATCH] man: Write man page for systemd-bootchart(1)

2013-02-13 Thread William Giokas
Mostly coppied from bootchart.conf(5) Signed-off-by: William Giokas <1007...@gmail.com> --- man/systemd-bootchart.xml | 92 +-- 1 file changed, 89 insertions(+), 3 deletions(-) diff --git a/man/systemd-bootchart.xml b/man/systemd-bootchart.xml index f3

Re: [systemd-devel] [PATCH] units: Make getty@.service install rule generic.

2013-02-13 Thread Colin Guthrie
'Twas brillig, and Lennart Poettering at 13/02/13 03:13 did gyre and gimble: > On Wed, 06.02.13 09:47, Colin Guthrie (co...@mageia.org) wrote: > >> The getty@.service used to specifically enable a getty@tty1.service >> under getty.target when enabled. >> >> Modern versions of systemd allow command

Re: [systemd-devel] How do you set the machine's domain name with systemd?

2013-02-13 Thread Reindl Harald
Am 13.02.2013 03:50, schrieb Lennart Poettering: > On Wed, 13.02.13 05:42, Adam Nielsen (a.niel...@shikadi.net) wrote: > >> >>> Use hostnamectl, assuming your systemd version is new enough: >>> >>> http://www.freedesktop.org/software/systemd/man/hostnamectl.html >> >> Thanks for the suggestion,

Re: [systemd-devel] dependencies between instances

2013-02-13 Thread Oleksii Shevchuk
> Can you suggest other usecases? I can. Situation like local client-server, where server requires root creds, cannot into socket/d-bus activation and requires device or something about it; client should be running from user and server requires. Example: pcscd + nfc-eventd So, how it supposed to

Re: [systemd-devel] Timer units fail when conditions fail

2013-02-13 Thread Thomas Bächler
Am 13.02.2013 03:38, schrieb Lennart Poettering: > Hmm, indeed. There's a missing connection between unit_start() failing > and timer_unit_notify()... > > I added this to the todo list now, to get fixed... From my short look into the code, the same holds for path_unit_notify(). signature.asc

[systemd-devel] Can bootchart take advantage of startup completed signal?

2013-02-13 Thread Umut Tezduyar
Hi Auke, I was wondering if you have tried to take advantage of StartupFinished signal sent by systemd ( http://www.freedesktop.org/wiki/Software/systemd/dbus). Would it make sense to register on "StartupFinished" signal and stop taking measurements when systemd boots up completely? This would be

Re: [systemd-devel] How to debug crash of systemd

2013-02-13 Thread cee1
在 2013年2月13日星期三,Lennart Poettering 写道: > On Tue, 12.02.13 13:43, cee1 (fykc...@gmail.com ) wrote: > > > Hi all, > > > > systemd will call crash() if received fatal signals. It will produce a > > core dump for analysis. > > However, it seems signal handler has a separated stack, so can't back > > t

Re: [systemd-devel] systemd-fsck change fsck arguments to "-a" -> "-y"

2013-02-13 Thread Karel Zak
On Wed, Feb 13, 2013 at 03:32:46AM +0100, Lennart Poettering wrote: > On Mon, 11.02.13 09:46, Karel Zak (k...@redhat.com) wrote: > > > > > On Fri, Feb 08, 2013 at 12:38:55AM +0100, Lennart Poettering wrote: > > > > diff --git a/src/fsck/fsck.c b/src/fsck/fsck.c > > > > index 058f34d..b1938c7 1006