Re: [systemd-devel] [PATCH] build-sys: "link" libsystemd-id128.so with libsystemd-label

2013-06-28 Thread Michael Biebl
Am 29.06.2013 05:34, schrieb Zbigniew Jędrzejewski-Szmek: > Fixes build on debian wheezy: > ./.libs/libudev.so: undefined reference to `cg_create' > > Appears to have no influence on the resulting binaries and > libraries. Cf. b5fafdf63f. > --- > Hi Michael, hi Holger, > > could you check if this

[systemd-devel] [PATCH] build-sys: "link" libsystemd-id128.so with libsystemd-label

2013-06-28 Thread Zbigniew Jędrzejewski-Szmek
Fixes build on debian wheezy: ./.libs/libudev.so: undefined reference to `cg_create' Appears to have no influence on the resulting binaries and libraries. Cf. b5fafdf63f. --- Hi Michael, hi Holger, could you check if this fixes the build for you? Best, Zbyszek Makefile.am | 2 ++ 1 file change

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Holger Hans Peter Freyther
On Fri, Jun 28, 2013 at 07:05:35PM +0200, Michael Biebl wrote: > That said, I don't understand, why this commit breaks the build with > that (older) toolchain. > Neither bootctl nor libsystemd-id128.so is using cg_create(). at the same time it has an undefined reference... $ nm -D .libs/libsyste

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Michael Biebl
2013/6/28 Michael Biebl : > 2013/6/28 Holger Hans Peter Freyther : >> On Fri, Jun 28, 2013 at 04:01:08PM +0200, Lennart Poettering wrote: >>> >>> Maybe this is simply broken automake dependency info somewhere left in >>> your tree? >> >> I did the git clean but I still wondered, this is why I creat

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Michael Biebl
2013/6/28 Holger Hans Peter Freyther : > On Fri, Jun 28, 2013 at 04:01:08PM +0200, Lennart Poettering wrote: >> >> Maybe this is simply broken automake dependency info somewhere left in >> your tree? > > I did the git clean but I still wondered, this is why I created the > .travis.yml. Before I was

[systemd-devel] [PATCH v2] tmpfiles, man: Add xattr support to tmpfiles

2013-06-28 Thread Maciej Wereski
This patch makes it possible to set extended attributes on files created by tmpfiles. This can be especially used to set SMACK security labels on volatile files and directories. It is done by adding new line of type "t". Such line should contain attributes in Argument field, using following format

[systemd-devel] [PATCH v5] journalctl: Add support for showing messages from a previous boot

2013-06-28 Thread Jan Janssen
Unfortunately, order of sd_journal_enumerate_unique() is undefined, so we have to sort the boot IDs. For that we seach for any log entry with a specific boot ID and then use the realtime stamp to order everything. --- Hi, I redid the boot ID look up to use enumerate_unique. This is quite fast if

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Martin Pitt
Michael Biebl [2013-06-28 15:41 +0200]: > 2013/6/28 Lennart Poettering : > > On Fri, 28.06.13 10:06, Holger Hans Peter Freyther (hol...@freyther.de) > > wrote: > > > >> Well, that is one part. "make test" really just checks if the test/ > >> directory exists, it doesn't really contribute to the qu

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Holger Hans Peter Freyther
On Fri, Jun 28, 2013 at 04:01:08PM +0200, Lennart Poettering wrote: > > Maybe this is simply broken automake dependency info somewhere left in > your tree? I did the git clean but I still wondered, this is why I created the .travis.yml. Before I was building a branch that contained some of my RFC

Re: [systemd-devel] [PATCH] man: fix a typo in systemd.socket.xml

2013-06-28 Thread Jason St. John
On Fri, Jun 28, 2013 at 12:40 PM, Łukasz Stelmach wrote: > Signed-off-by: Łukasz Stelmach > --- > man/systemd.socket.xml |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/man/systemd.socket.xml b/man/systemd.socket.xml > index 0d5652b..515412d 100644 > --- a/man/systemd

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Lennart Poettering
On Fri, 28.06.13 15:49, Holger Hans Peter Freyther (hol...@freyther.de) wrote: > > On Fri, Jun 28, 2013 at 03:44:35PM +0200, Michael Biebl wrote: > > > v44, v204 and git master all build and link fine on my pretty standard > > Debian sid system, so I can't reproduce the problem, at least not on

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Michael Biebl
2013/6/28 Holger Hans Peter Freyther : > On Fri, Jun 28, 2013 at 03:44:35PM +0200, Michael Biebl wrote: > >> v44, v204 and git master all build and link fine on my pretty standard >> Debian sid system, so I can't reproduce the problem, at least not on >> Debian. > > Which linker and which system do

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Holger Hans Peter Freyther
On Fri, Jun 28, 2013 at 03:44:35PM +0200, Michael Biebl wrote: > v44, v204 and git master all build and link fine on my pretty standard > Debian sid system, so I can't reproduce the problem, at least not on > Debian. Which linker and which system do you run it on? A clean build on my Debian Testi

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Michael Biebl
2013/6/28 Holger Hans Peter Freyther : > systemd currently does not link on default Debian/Ubuntu systems. v44, v204 and git master all build and link fine on my pretty standard Debian sid system, so I can't reproduce the problem, at least not on Debian. Cheers, Michael __

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Michael Biebl
2013/6/28 Lennart Poettering : > On Fri, 28.06.13 10:06, Holger Hans Peter Freyther (hol...@freyther.de) wrote: > >> Well, that is one part. "make test" really just checks if the test/ >> directory exists, it doesn't really contribute to the quality control. >> >> The other thing with "make check"

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Lennart Poettering
On Fri, 28.06.13 10:06, Holger Hans Peter Freyther (hol...@freyther.de) wrote: > Well, that is one part. "make test" really just checks if the test/ > directory exists, it doesn't really contribute to the quality control. > > The other thing with "make check" is that it is failing if the build >

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Lennart Poettering
On Fri, 28.06.13 08:50, Holger Hans Peter Freyther (hol...@freyther.de) wrote: Heya, > Dear Lennart, > > the systemd build is currently broken[1] and judging from the commit So, it builds fine ("make check") on Fedora 18/19, which is what I check against. It also builds fine on Pantheon's Jenki

[systemd-devel] [PATCH] man: fix a typo in systemd.socket.xml

2013-06-28 Thread Łukasz Stelmach
Signed-off-by: Łukasz Stelmach --- man/systemd.socket.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/systemd.socket.xml b/man/systemd.socket.xml index 0d5652b..515412d 100644 --- a/man/systemd.socket.xml +++ b/man/systemd.socket.xml @@ -388,7 +388,7 @@

Re: [systemd-devel] [PATCH] makefile:put macros file to the correct place

2013-06-28 Thread Frederic Crozat
Le vendredi 28 juin 2013 à 10:50 +0200, Václav Pavlín a écrit : > Zbigniew Jędrzejewski-Szmek píše v Čt 27. 06. 2013 v 17:00 +0200: > > On Thu, Jun 27, 2013 at 04:30:12PM +0200, Vaclav Pavlin wrote: > > > From: Fedora systemd team > > > > > > --- > > > Makefile.am | 2 +- > > > 1 file changed, 1

Re: [systemd-devel] [PATCH] makefile:put macros file to the correct place

2013-06-28 Thread Kay Sievers
- Original Message - > Zbigniew Jędrzejewski-Szmek píše v Čt 27. 06. 2013 v 17:00 +0200: > > On Thu, Jun 27, 2013 at 04:30:12PM +0200, Vaclav Pavlin wrote: > > > From: Fedora systemd team > > > > > > --- > > > Makefile.am | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [systemd-devel] Please review the patch about support the samsung series 2 Fn+keys.

2013-06-28 Thread Martin Pitt
Hello Dongjun, 장동준 [2013-06-28 8:44 +]: > As your opinion, I discussed about this issue with our firmware engineer. > He said he can not guarantee about this. > Because Product ID 300*, 270* will be expanded, And firmware have possibility > to change. > I think it have some risk... > Honestl

Re: [systemd-devel] [PATCH] makefile:put macros file to the correct place

2013-06-28 Thread Václav Pavlín
Zbigniew Jędrzejewski-Szmek píše v Čt 27. 06. 2013 v 17:00 +0200: > On Thu, Jun 27, 2013 at 04:30:12PM +0200, Vaclav Pavlin wrote: > > From: Fedora systemd team > > > > --- > > Makefile.am | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Makefile.am b/Makefile.am >

Re: [systemd-devel] Please review the patch about support the samsung series 2 Fn+keys.

2013-06-28 Thread 장동준
Hello Martin Pitt. At first, I sorry about first patch, it is just test patch for my test PC. It's my mistake. As your opinion, I discussed about this issue with our firmware engineer. He said he can not guarantee about this. Because Product ID 300*, 270* will be expanded, And firmware have poss

Re: [systemd-devel] Please review the patch about support the samsung series 2 Fn+keys.

2013-06-28 Thread Martin Pitt
Hello again, 장동준 [2013-06-28 8:15 +]: > Please review the attached patch for the samsung series 3 Fn+F* keys(keymap > and forced release events). > This patch is for samsung series3 models. Ah, I sent my reply to your first patch at the same time when you sent this second patch. +ENV{DMI

Re: [systemd-devel] Please review the patch about support the samsung series 2 Fn+keys.

2013-06-28 Thread Martin Pitt
Hello Dongjun Jang, 장동준 [2013-06-28 7:09 +]: > Please review the attached patch for the samsung series 3 Fn+F* keys(keymap > and forced release events). > This patch is for 300E5EV/300E4EV/270E5EV/270E4EV which is samsung series3 > models. This looks good by and large, but I wonder about

[systemd-devel] Please review the patch about support the samsung series 2 Fn+keys.

2013-06-28 Thread 장동준
Hello. This is dongjun jang. Please review the attached patch for the samsung series 3 Fn+F* keys(keymap and forced release events). This patch is for samsung series3 models. If you have any feedback, please let me know. Thank-you. samsung-series-3-keyboard.patch Description: Binary data

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Holger Hans Peter Freyther
On Fri, Jun 28, 2013 at 09:43:08AM +0200, Peter Sztanojev wrote: > So this issue is about tweaking how jenkins does its job? > I have added David Strauss to the CC, hopefully he won't mind. Well, that is one part. "make test" really just checks if the test/ directory exists, it doesn't really con

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Peter Sztanojev
On Fri, Jun 28, 2013 at 9:18 AM, Holger Hans Peter Freyther wrote: > On Fri, Jun 28, 2013 at 09:05:40AM +0200, Peter Sztanojev wrote: >> On Fri, Jun 28, 2013 at 8:50 AM, Holger Hans Peter Freyther > >> there already is a jenkins ci for systemd kindly provided by Pantheon: >> http://systemd.getpant

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Holger Hans Peter Freyther
On Fri, Jun 28, 2013 at 09:05:40AM +0200, Peter Sztanojev wrote: > On Fri, Jun 28, 2013 at 8:50 AM, Holger Hans Peter Freyther > there already is a jenkins ci for systemd kindly provided by Pantheon: > http://systemd.getpantheon.com:8080/jenkins/ The jenkins script is still using "make test" (whi

[systemd-devel] Please review the patch about support the samsung series 2 Fn+keys.

2013-06-28 Thread 장동준
Hello. This is dongjun jang. Please review the attached patch for the samsung series 3 Fn+F* keys(keymap and forced release events). This patch is for 300E5EV/300E4EV/270E5EV/270E4EV which is samsung series3 models. If you have any feedback, please let me know. Thank-you samsung-series-3-

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Peter Sztanojev
On Fri, Jun 28, 2013 at 8:50 AM, Holger Hans Peter Freyther wrote: > Dear Lennart, > > the systemd build is currently broken[1] and judging from the commit > history it appears that this happened more than once. Besides fixing > the build you might want to consider adopting another strategy. > > I

[systemd-devel] Broken build and CI strategy

2013-06-28 Thread Holger Hans Peter Freyther
Dear Lennart, the systemd build is currently broken[1] and judging from the commit history it appears that this happened more than once. Besides fixing the build you might want to consider adopting another strategy. In mature software projects the following is quite common: a.) Create a .travis.