[systemd-devel] [PATCH 18/18] shell-comp: Fix up unit completing for _journalctl

2013-08-01 Thread William Giokas
-u and --user-unit can be specified multiple times, so put a * in front of it, and --user-unit can have an =, and should be looking for the USER_UNIT not _SYSTEMD_USER_UNIT. --- shell-completion/zsh/_journalctl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/shell-completio

[systemd-devel] [PATCH 17/18] shell-comp: Speed up noncached perf of _journalctl

2013-08-01 Thread William Giokas
Splitting things unnecessarily at newlines causes tab completion to take an extremely long time. Also add a note saying that caching is not good for journalctl's completion. --- shell-completion/zsh/_journalctl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/shell-completion/

[systemd-devel] [PATCH] fixed hashmap leaks in mmap-cache

2013-08-01 Thread George McCollister
hashmap_free() wasn't being called on m->contexts and m->fds resulting in a leak. To reproduce do: while(1) { sd_journal_open(&j, SD_JOURNAL_LOCAL_ONLY); sd_journal_close(j); } Memory usage will increase until OOM. Signed-off-by: George McCollister

Re: [systemd-devel] [Feature request] A way to native import /proc/cmdline within unit

2013-08-01 Thread Jan Engelhardt
On Tuesday 2013-07-30 02:12, Gerardo Exequiel Pozzi wrote: > >In inside systemd unit, I want to avoid shell script if possible, using >units only, doing things in a "systemd way". Anyway for complex tasks >where systemd does not fit, scripting seems to be necessary. The "systemd way" is not {avoi

Re: [systemd-devel] macros in systemd unit files question

2013-08-01 Thread Daniel Wallace
On Thu, Aug 1, 2013 at 9:41 AM, Colin Guthrie wrote: > 'Twas brillig, and lux-integ at 01/08/13 15:25 did gyre and gimble: > > On Thursday 01 August 2013 12:58:46 Tom Gundersen wrote: > >> 'm not following. Do you mean that systemd is already doing what you > >> need, > > > > > > not sure as I a

Re: [systemd-devel] macros in systemd unit files question

2013-08-01 Thread Tom Gundersen
On Thu, Aug 1, 2013 at 4:25 PM, lux-integ wrote: > On Thursday 01 August 2013 12:58:46 Tom Gundersen wrote: >> 'm not following. Do you mean that systemd is already doing what you >> need, > > > not sure as I am just learning > > > ...but suppose > I have already mounted proc, run and sys > and

Re: [systemd-devel] macros in systemd unit files question

2013-08-01 Thread Colin Guthrie
'Twas brillig, and lux-integ at 01/08/13 15:25 did gyre and gimble: > On Thursday 01 August 2013 12:58:46 Tom Gundersen wrote: >> 'm not following. Do you mean that systemd is already doing what you >> need, > > > not sure as I am just learning > > > ...but suppose > I have already mounted

Re: [systemd-devel] macros in systemd unit files question

2013-08-01 Thread lux-integ
On Thursday 01 August 2013 12:58:46 Tom Gundersen wrote: > 'm not following. Do you mean that systemd is already doing what you > need, not sure as I am just learning ...but suppose I have already mounted proc, run and sys and I want just a read only root filesystem --a) how do I get

Re: [systemd-devel] macros in systemd unit files question

2013-08-01 Thread Tom Gundersen
On Thu, Aug 1, 2013 at 1:45 PM, lux-integ wrote: > On Thursday 01 August 2013 12:15:21 Colin Guthrie wrote: >> The rootfs mount is called -.mount (i.e. a leading -) > many thanks for this >> To be honest with you tho', unless you are tailoring your system for a >> very specific case > > yes this i

Re: [systemd-devel] macros in systemd unit files question

2013-08-01 Thread lux-integ
On Thursday 01 August 2013 12:15:21 Colin Guthrie wrote: > The rootfs mount is called -.mount (i.e. a leading -) many thanks for this > To be honest with you tho', unless you are tailoring your system for a > very specific case yes this is so, it is remounting / (RW) earlier in the boot proces

Re: [systemd-devel] macros in systemd unit files question

2013-08-01 Thread Colin Guthrie
'Twas brillig, and lux-integ at 01/08/13 11:53 did gyre and gimble: > On Wednesday 31 July 2013 14:36:25 Colin Guthrie wrote: >> Mount units have to be named specially after their mount points, so be >> careful there e.g. if the mount point is /mnt/mymountpoint then the unit >> should be called mnt

Re: [systemd-devel] macros in systemd unit files question

2013-08-01 Thread Harald Hoyer
On 08/01/2013 12:53 PM, lux-integ wrote: > On Wednesday 31 July 2013 14:36:25 Colin Guthrie wrote: >> Mount units have to be named specially after their mount points, so be >> careful there e.g. if the mount point is /mnt/mymountpoint then the unit >> should be called mnt-mymountpoint.mount > > th

Re: [systemd-devel] [Install] question

2013-08-01 Thread lux-integ
On Thursday 01 August 2013 08:00:49 Tomasz Torcz wrote: > You can stuff mkdir into ExecStartPre and cp into ExecStart; > you have to make your unit Require the mount unit (or go with the > automounter); activation of your work unit should trigger mount. many thanks for this __

Re: [systemd-devel] macros in systemd unit files question

2013-08-01 Thread lux-integ
On Wednesday 31 July 2013 14:36:25 Colin Guthrie wrote: > Mount units have to be named specially after their mount points, so be > careful there e.g. if the mount point is /mnt/mymountpoint then the unit > should be called mnt-mymountpoint.mount thanks for your reply Now I have an init script to

[systemd-devel] [PATCH] journal: handle multiline syslog messages

2013-08-01 Thread harald
From: Harald Hoyer Since the journal can handle multiple lines just well natively, and rsyslog can be configured to handle them as well, there is no need to truncate messages from syslog() after the first newline. Reproducer: 1. Add following four lines to /etc/rsyslog.conf -- $E

Re: [systemd-devel] [Install] question

2013-08-01 Thread lux-integ
On Thursday 01 August 2013 08:00:49 Tomasz Torcz wrote: > They cannot be in mount. There are few way to accomplish what you want, > but without details I can provide only vague directions. You need to > create unit for your work. You can stuff mkdir into ExecStartPre and cp > into ExecStart; y

Re: [systemd-devel] [PATCH] fstab-generator: introduce rd.weak_sysroot to bypass failures in sysroot.mount

2013-08-01 Thread WANG Chao
On 08/01/13 at 08:49am, Colin Guthrie wrote: > [Resend because I fail at reply-all] > > 'Twas brillig, and WANG Chao at 01/08/13 06:36 did gyre and gimble: > > On 07/30/13 at 04:40pm, Tom Gundersen wrote: > >> On Tue, Jul 30, 2013 at 4:13 PM, Harald Hoyer wrote: > >>> On 07/30/2013 03:46 PM, Zbig

Re: [systemd-devel] macros in systemd unit files question

2013-08-01 Thread Michal Vyskocil
On Wed, Jul 31, 2013 at 06:59:18PM +0100, lux-integ wrote: > On Wednesday 31 July 2013 14:22:35 Michal Vyskocil wrote: > > You can split the logic into two mount units with opposite Condition > > > > #mountpoint.mount > > [Unit] > > Description=mount mountpoint > > ConditionPathIsMountPoint=/mount

Re: [systemd-devel] [PATCH] fstab-generator: introduce rd.weak_sysroot to bypass failures in sysroot.mount

2013-08-01 Thread Colin Guthrie
[Resend because I fail at reply-all] 'Twas brillig, and WANG Chao at 01/08/13 06:36 did gyre and gimble: > On 07/30/13 at 04:40pm, Tom Gundersen wrote: >> On Tue, Jul 30, 2013 at 4:13 PM, Harald Hoyer wrote: >>> On 07/30/2013 03:46 PM, Zbigniew Jędrzejewski-Szmek wrote: Maybe rootfsflags=nof

Re: [systemd-devel] [PATCH] fstab-generator: introduce rd.weak_sysroot to bypass failures in sysroot.mount

2013-08-01 Thread Colin Guthrie
'Twas brillig, and WANG Chao at 01/08/13 06:36 did gyre and gimble: > On 07/30/13 at 04:40pm, Tom Gundersen wrote: >> On Tue, Jul 30, 2013 at 4:13 PM, Harald Hoyer wrote: >>> On 07/30/2013 03:46 PM, Zbigniew Jędrzejewski-Szmek wrote: Maybe rootfsflags=nofail could do be used as this flag? >>>

Re: [systemd-devel] [Install] question

2013-08-01 Thread Tomasz Torcz
On Thu, Aug 01, 2013 at 07:48:19AM +0100, lux-integ wrote: > Greetings, > > I am trying to learn to use systemd. > > I scanned through some of the online manpages and looked at some example > unit > files. I keep seeing > > [Install] > WantedBy=multi-user.target > > or > > [Install] > Want