Re: [systemd-devel] [PATCH 1/3] cgroup: setup BlockIODeviceWeight in bus_cgroup_set_property

2013-09-04 Thread Gao feng
On 08/27/2013 01:36 PM, Gao feng wrote: > This patch adds the support for setting up BlockIODeviceWeight > in bus_cgroup_set_property. most of the codes are copied from > the case that sets up DeviceAllow. any comments? > --- > src/core/dbus-cgroup.c | 85 > +

[systemd-devel] Systemd and Qemu

2013-09-04 Thread Bartek Rekke
Hello! I'am running Archlinux (recent version) including Systemd and Qemu. Since killing qemu directly is highly destructive for guest os I want to shut it gracefully. I think it is obvious nessesity To do so I decided to use 'net rpc' or qemu monitor command. Both requires networking to be up an

[systemd-devel] [PATCH] libudev: fix memleak when enumerating childs

2013-09-04 Thread David Herrmann
We need to free udev-devices again if they don't match. Funny that no-one noticed it yet since valgrind is quite verbose about it. Fix it and free non-matching devices. --- src/libudev/libudev-enumerate.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/libude

[systemd-devel] [PATCH 2/2] journald: fix fd leak in journal_file_empty

2013-09-04 Thread George McCollister
Before my previous patch, journal_file_empty wasn't be called with the correct filename. Now that it's being called with the correct filename it leaks file descriptors. This patch closes the file descriptors before returning. Signed-off-by: George McCollister --- src/journal/journal-vacuum.c | 1

[systemd-devel] [PATCH 1/2] journald: fix vacuuming of archived journals

2013-09-04 Thread George McCollister
d_name is modified on line 227 so if the entire journal name is needed again p must be used. Before this change when journal_file_empty was called on archived journals it would always return with -2. Signed-off-by: George McCollister --- src/journal/journal-vacuum.c | 10 +- 1 file chang

Re: [systemd-devel] [PATCH] libudev: fix memleak when enumerating childs

2013-09-04 Thread Kay Sievers
On Wed, Sep 4, 2013 at 12:36 PM, David Herrmann wrote: > We need to free udev-devices again if they don't match. Funny that no-one > noticed it yet since valgrind is quite verbose about it. > Fix it and free non-matching devices. Applied. Thanks, Kay _

Re: [systemd-devel] [PATCH] cgtop: fixup the online help

2013-09-04 Thread Kay Sievers
On Wed, Sep 4, 2013 at 6:41 AM, Brandon Philips wrote: > The online help shows the keys as uppercase but the code and manpage say > lower case. Make the online help follow reality. Applied. Thanks, Kay ___ systemd-devel mailing list systemd-devel@lists

[systemd-devel] [PATCH 1/2] systemd-coredump: Ignore coredumps larger than COREDUMP_MAX

2013-09-04 Thread Andrew Cook
Currently this check happens when the coredump has been collected in it's entirety and being received by journald. this is not ideal behaviour when the crashing process is consuming significant percentage of physical memory such as a large instance of firefox or a java application. --- src/journa

[systemd-devel] [PATCH 2/2] systemd-coredump: Log crashes without coredumps on failure

2013-09-04 Thread Andrew Cook
Make a best-effort attempt to store information about crashes during failure, currently if these are encountered the crash is completely silenced. ideally coredumpctl would show if a coredump is available. --- src/journal/coredump.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

Re: [systemd-devel] [PATCH] libudev: enumerate: fix NULL-deref for subsystem-matches

2013-09-04 Thread Kay Sievers
On Fri, Aug 30, 2013 at 3:50 PM, David Herrmann wrote: > udev_device_get_subsystem() may return NULL if no subsystem could be > figured out by libudev. This might be due to OOM or if the device > disconnected between the udev_device_new() call and > udev_device_get_subsystem(). Therefore, we need