[systemd-devel] Regression: systemd-logind failure after migration to internal dbus impl

2013-11-07 Thread Oleksii Shevchuk
FYI, systemd-logind is still broken as for 86198b2788e56fd05959c2dce670d1646bf99bcd. Current symptoms: After leaving S3 logind doesn't sent notifications about leaving sleep mode. Instead, it goes to failure state: systemd[1]: systemd-logind.service: main process exited, code=exited,

Re: [systemd-devel] Regression: systemd-logind failure after migration to internal dbus impl

2013-11-07 Thread Kay Sievers
On Thu, Nov 7, 2013 at 9:34 AM, Oleksii Shevchuk alx...@gmail.com wrote: FYI, systemd-logind is still broken as for 86198b2788e56fd05959c2dce670d1646bf99bcd. Current symptoms: After leaving S3 logind doesn't sent notifications about leaving sleep mode. Instead, it goes to failure state:

Re: [systemd-devel] [PATCH 1/2] bus: make bus_print_all_properties work for non machinectl cases

2013-11-07 Thread Kay Sievers
On Thu, Nov 7, 2013 at 8:58 AM, Simon Peeters peeters.si...@gmail.com wrote: add a destination parameter and skip properties we can't read --- src/libsystemd-bus/bus-util.c | 16 +++- src/libsystemd-bus/bus-util.h | 2 +- src/machine/machinectl.c | 2 +- 3 files changed,

Re: [systemd-devel] [RFC][PATCH] networkd: add a basic network daemon

2013-11-07 Thread Lennart Poettering
On Thu, 07.11.13 01:45, Tom Gundersen (t...@jklm.no) wrote: On Wed, Nov 6, 2013 at 7:56 AM, Holger Winkelmann [TP] h...@travelping.com wrote: We really like to see this direct, how ever would it not better to join efforts for network management. I.e. arch Linux claims with netctl [1] to

Re: [systemd-devel] [RFC][PATCH] networkd: add a basic network daemon

2013-11-07 Thread Holger Winkelmann [TP]
Hi, To clarify this: systemd-networkd is supposed to cover the initrd, container, server and (some) embedded usecases. However, use NM or connman for the interactive stuff (like wlans and suchlike) you need on laptops/desktops and mobile. Will this cover the UseCase of having a DHCP enabled

Re: [systemd-devel] [RFC][PATCH] networkd: add a basic network daemon

2013-11-07 Thread Kay Sievers
On Thu, Nov 7, 2013 at 4:03 PM, Holger Winkelmann [TP] h...@travelping.com wrote: To clarify this: systemd-networkd is supposed to cover the initrd, container, server and (some) embedded usecases. However, use NM or connman for the interactive stuff (like wlans and suchlike) you need on

Re: [systemd-devel] [RFC][PATCH] networkd: add a basic network daemon

2013-11-07 Thread Holger Winkelmann [TP]
A native and fast DHCP client will be part of it, yes, it is needed in the initrd. Not sure though when we will get there though. nice to hear. and right, having it in initrd is nice too. currently we integrate http://0pointer.de/lennart/projects/ifplugd/ Urks, the 90s calling. :)

[systemd-devel] [PATCH] zsh-completion: Move machine listing to autoload

2013-11-07 Thread William Giokas
Instead of having two different listings of machines, use an autoloaded function that can be used by other shell completions in the future. It will also allow editing a single file to change the way machinectl and systemd-run completion for machines. --- An extension of the previous zsh

Re: [systemd-devel] [PATCH] zsh-completion: Move machine listing to autoload

2013-11-07 Thread Ronny Chevalier
You can do the same with _outputmodes which is used in _systemctl and _journalctl 2013/11/7 William Giokas 1007...@gmail.com: Instead of having two different listings of machines, use an autoloaded function that can be used by other shell completions in the future. It will also allow editing a

Re: [systemd-devel] [PATCH 1/7] bus: allow reading empty arrays

2013-11-07 Thread Lennart Poettering
On Thu, 07.11.13 13:48, Marc-Antoine Perennou (marc-anto...@perennou.com) wrote: Applied a similar patch that just makes use of *array_size to detect if we are looking at an empty array. Also added a test case for this! Thanks! --- src/libsystemd-bus/bus-message.c | 21 +

Re: [systemd-devel] [PATCH 2/7] bus: fix bus_message_read_strv

2013-11-07 Thread Lennart Poettering
On Thu, 07.11.13 18:50, Lennart Poettering (lenn...@poettering.net) wrote: On Thu, 07.11.13 13:48, Marc-Antoine Perennou (marc-anto...@perennou.com) wrote: message_read_strv_extend returns 0 on success Ah, hmm. sd_bus_message_read_strv() was actually right,

Re: [systemd-devel] [PATCH 3/7] bus: fix bus_print_property with strv

2013-11-07 Thread Lennart Poettering
On Thu, 07.11.13 13:49, Marc-Antoine Perennou (marc-anto...@perennou.com) wrote: Applied! Thanks! --- src/libsystemd-bus/bus-util.c | 29 - 1 file changed, 12 insertions(+), 17 deletions(-) diff --git a/src/libsystemd-bus/bus-util.c

Re: [systemd-devel] [PATCH 5/7] bus: mark sd_bus_message_at_end public

2013-11-07 Thread Lennart Poettering
On Thu, 07.11.13 13:49, Marc-Antoine Perennou (marc-anto...@perennou.com) wrote: Applied! Thanks! --- src/libsystemd-bus/bus-message.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libsystemd-bus/bus-message.c b/src/libsystemd-bus/bus-message.c index

Re: [systemd-devel] [PATCH 4/7] bus: rename sd_bus_get_property_{trivial, basic}

2013-11-07 Thread Lennart Poettering
On Thu, 07.11.13 13:49, Marc-Antoine Perennou (marc-anto...@perennou.com) wrote: This one is unfortunately not that easy. The reason this checks for trivial and not basic types is that strings (which are basic, but not trivial) are pointers in C. Usually we just return pointers into the actual

Re: [systemd-devel] [PATCH 4/7] bus: rename sd_bus_get_property_{trivial, basic}

2013-11-07 Thread Lennart Poettering
On Thu, 07.11.13 19:15, Lennart Poettering (lenn...@poettering.net) wrote: On Thu, 07.11.13 13:49, Marc-Antoine Perennou (marc-anto...@perennou.com) wrote: This one is unfortunately not that easy. The reason this checks for trivial and not basic types is that strings (which are basic, but

Re: [systemd-devel] [PATCH 2/2] loginctl: convert to sd-bus

2013-11-07 Thread Lennart Poettering
On Thu, 07.11.13 08:58, Simon Peeters (peeters.si...@gmail.com) wrote: Thanks! Applied! I made some changes though. I didn't like log_bus_error() since it took away format strings. So I reworked that. However I did like log_parse_error() and generalized it and added it to bus-error.h since this

Re: [systemd-devel] [PATCH 2/3] net-util: call ioctl() only if necessary

2013-11-07 Thread Lennart Poettering
On Wed, 06.11.13 11:18, Michal Sekletar (msekl...@redhat.com) wrote: In case when update of current values is not necessary we still might end up calling ioctl(), because need_update variable is not explicitly initialized. Thanks! Applied! --- src/udev/net/ethtool-util.c | 4 ++-- 1 file

Re: [systemd-devel] [PATCH 1/3] tmpfiles: skip the path entirely if configured as type x

2013-11-07 Thread Lennart Poettering
On Wed, 06.11.13 11:18, Michal Sekletar (msekl...@redhat.com) wrote: Type x in tmpfiles configuration accepts shell style globs instead of normal paths. If user uses normal path he might expect that the path will be left untouched. However this is not the case for directories and content of

[systemd-devel] [PATCH 2/2] zsh-completion: Move output modes to autoload

2013-11-07 Thread William Giokas
--- Added on to the previous patch. shell-completion/zsh/_journalctl | 8 +--- shell-completion/zsh/_sd_outputmodes | 5 + shell-completion/zsh/_systemctl | 8 +--- 3 files changed, 7 insertions(+), 14 deletions(-) create mode 100644 shell-completion/zsh/_sd_outputmodes

Re: [systemd-devel] [PATCH 3/3] systemctl: return r instead of always returning 0

2013-11-07 Thread Lennart Poettering
On Wed, 06.11.13 11:18, Michal Sekletar (msekl...@redhat.com) wrote: Thanks! Applied! --- src/systemctl/systemctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 9f5e273..0c1588c 100644 ---

Re: [systemd-devel] [PATCH] systemctl: provide better error message when start limit is exceeded.

2013-11-07 Thread Lennart Poettering
On Thu, 31.10.13 15:12, Vaclav Pavlin (vpav...@redhat.com) wrote: From: Václav Pavlín vpav...@redhat.com I like the idea, but I'd prefer if we wouldn't let the service failure field spill into the job result. I don't like redundant fields I must say... Also, the reason why a job failed is not

[systemd-devel] [PATCH v2 1/2] analyze: split out bus util functions

2013-11-07 Thread Marc-Antoine Perennou
They will soon be used in systemctl --- src/analyze/analyze.c | 68 +++ src/libsystemd-bus/bus-util.c | 49 +++ src/libsystemd-bus/bus-util.h | 17 +++ 3 files changed, 70 insertions(+), 64 deletions(-) diff

Re: [systemd-devel] [PATCH] Cache aggregated cgroup mask data at the slice level.

2013-11-07 Thread David Strauss
I'm specifically wondering if it's safe to use cgroup_mask in slices to aggregate the masks of their children. If not, it's trivial to add another item to the struct (like cgroup_mask_children) to use for aggregation. ___ systemd-devel mailing list