Re: [systemd-devel] [PATCH] core/socket: we only want one event on standard sockets

2013-11-22 Thread Shawn
oh wait, this doesn't build, here is a version that builds On Fri, Nov 22, 2013 at 6:56 PM, Shawn Landden wrote: > With EPOLLONESHOT we are guaranteed to only recieve one event > until we reload with socket_enter_listening(s), otherwise > multiple events can be generated upon receipt of multiple

[systemd-devel] [PATCH] core/socket: we only want one event on standard sockets

2013-11-22 Thread Shawn Landden
With EPOLLONESHOT we are guaranteed to only recieve one event until we reload with socket_enter_listening(s), otherwise multiple events can be generated upon receipt of multiple chunks of data. We also only want wake-ups when external events happen, i.e. edge-triggered wakeups. --- src/core/socke

Re: [systemd-devel] [HEADS-UP] PID 1 now ported to libsystemd-bus

2013-11-22 Thread Tom Gundersen
On Fri, Nov 22, 2013 at 2:33 PM, Lennart Poettering wrote: > On Thu, 21.11.13 10:03, Oleksii Shevchuk (alx...@gmail.com) wrote: > >> >> Segfaults fixed, but: >> >> systemd-logind[2167]: Failed to start session scope session-3.scope: Invalid >> arguments 'ssa(sv)' to call >> org.freedesktop.syste

[systemd-devel] send -isolateDevice and -config option to Xserver

2013-11-22 Thread Floris
Dear systemd Maintainers, I am still struggling to get multiseat working with systemd 204, gdm3.10 and gnome3.10. Last week Debian Testing has released Gnome 3.8 but unfortunately gdm3 is was build without systemd support, so I tried the experimental 3.10 version with systemd. Unfortunate

Re: [systemd-devel] [PATCH] cgroups: Cache controller masks and optimize queues.

2013-11-22 Thread David Timothy Strauss
On Sat, Nov 23, 2013 at 7:53 AM, David Timothy Strauss wrote: > My attempts to discuss options and > approaches with you at LinuxCon, on the mailing list, and IRC have > only been marginally productive. Before my commit, we only had a TODO > logged. Actually, I'm being a bit unfair here. Most of

Re: [systemd-devel] [PATCH] cgroups: Cache controller masks and optimize queues.

2013-11-22 Thread David Timothy Strauss
I'm disappointed in your response here. It's not up to your normally high standards of technical discourse and tact on this mailing list. I realize I've stepped on some feet, but there's quite a bit more to this than me getting trigger-happy with a core commit. On Fri, Nov 22, 2013 at 11:43 PM, Le

Re: [systemd-devel] pam: Don't use loginuid [was: Re: Fix PAM module to not clobber XDG_RUNTIME_DIR with su]

2013-11-22 Thread Colin Guthrie
'Twas brillig, and Colin Walters at 22/11/13 17:05 did gyre and gimble: > On Wed, 2013-11-20 at 19:19 -0500, Colin Walters wrote: >> I care about pkexec. > > Note we're now carrying a workaround for this: > > https://bugs.freedesktop.org/show_bug.cgi?id=71894 Thanks for that Colin, I'll pick up

[systemd-devel] [PATCH 1/2] systemctl: refactor show()

2013-11-22 Thread Shawn Landden
--- src/systemctl/systemctl.c | 66 ++- 1 file changed, 43 insertions(+), 23 deletions(-) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 84826a3..576396f 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c @@

[systemd-devel] [PATCH 2/2] systemctl: add "systemctl cat"

2013-11-22 Thread Shawn Landden
--- TODO | 2 -- src/shared/fileio.c | 73 - src/shared/fileio.h | 1 + src/systemctl/systemctl.c | 91 +++ 4 files changed, 149 insertions(+), 18 deletions(-) diff --git a/TODO b/TO

Re: [systemd-devel] pam: Don't use loginuid [was: Re: Fix PAM module to not clobber XDG_RUNTIME_DIR with su]

2013-11-22 Thread Colin Walters
On Wed, 2013-11-20 at 19:19 -0500, Colin Walters wrote: > I care about pkexec. Note we're now carrying a workaround for this: https://bugs.freedesktop.org/show_bug.cgi?id=71894 ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http:

Re: [systemd-devel] [PATCH] include: fix problem with __LINE__ macro expansion

2013-11-22 Thread Lukasz Skalski
On 11/22/2013 02:46 PM, David Herrmann wrote: Hi Hi, On Fri, Nov 22, 2013 at 2:09 PM, Lennart Poettering wrote: On Thu, 21.11.13 17:26, Lukasz Skalski (l.skal...@partner.samsung.com) wrote: Hi all, Macro __LINE__ in #define assert_cc() (src/shared/macro.h) is not properly expanded. Ple

Re: [systemd-devel] Newbie question - Requires doesn't work properly

2013-11-22 Thread David Timothy Strauss
On Fri, Nov 22, 2013 at 10:24 PM, Reindl Harald wrote: > your internal checks are mostly theory because in case of > a bug you have undefined behavior and what you want to achieve > with the watchdog is catch this undefined behavior and restart > the service - in doubt this will not work in the ra

Re: [systemd-devel] [PATCH] include: fix problem with __LINE__ macro expansion

2013-11-22 Thread David Herrmann
Hi On Fri, Nov 22, 2013 at 2:09 PM, Lennart Poettering wrote: > On Thu, 21.11.13 17:26, Lukasz Skalski (l.skal...@partner.samsung.com) wrote: > >> Hi all, >> >> Macro __LINE__ in #define assert_cc() (src/shared/macro.h) is not >> properly expanded. >> >> Please find patch in attachment for review

Re: [systemd-devel] [PATCH] cgroups: Cache controller masks and optimize queues.

2013-11-22 Thread Lennart Poettering
On Tue, 19.11.13 17:12, David Timothy Strauss (da...@davidstrauss.net) wrote: > > I'm pretty confident in the accuracy of the controller mask > aggregation, especially given the new unit test. Here are the main > review questions. Ahum. Please do not just commit stuff like this that is not obvio

Re: [systemd-devel] [HEADS-UP] PID 1 now ported to libsystemd-bus

2013-11-22 Thread Lennart Poettering
On Thu, 21.11.13 10:03, Oleksii Shevchuk (alx...@gmail.com) wrote: > > Segfaults fixed, but: > > systemd-logind[2167]: Failed to start session scope session-3.scope: Invalid > arguments 'ssa(sv)' to call > org.freedesktop.systemd1.Manager:StartTransientUnit, expecting > 'ssa(sv)a(sa(sv))'. or

Re: [systemd-devel] [PATCH] include: fix problem with __LINE__ macro expansion

2013-11-22 Thread Lennart Poettering
On Thu, 21.11.13 17:26, Lukasz Skalski (l.skal...@partner.samsung.com) wrote: > Hi all, > > Macro __LINE__ in #define assert_cc() (src/shared/macro.h) is not > properly expanded. > > Please find patch in attachment for review. Thanks! Seems David Herrmann has now fixed this thing slightly diffe

Re: [systemd-devel] [PATCH 0/4] [RFC v1] gdbus: Preliminary kdbus-support patches

2013-11-22 Thread Karol Lewandowski
On 11/22/2013 01:32 PM, Matthias Clasen wrote: > On Fri, Nov 22, 2013 at 7:03 AM, Karol Lewandowski > mailto:k.lewando...@samsung.com>> wrote: > > On 11/21/2013 08:28 PM, Colin Walters wrote: > > On Thu, 2013-11-21 at 16:35 +0100, Karol Lewandowski wrote: > > > >> Truth is that gio

Re: [systemd-devel] [PATCH 0/4] [RFC v1] gdbus: Preliminary kdbus-support patches

2013-11-22 Thread Matthias Clasen
On Fri, Nov 22, 2013 at 7:03 AM, Karol Lewandowski wrote: > On 11/21/2013 08:28 PM, Colin Walters wrote: > > On Thu, 2013-11-21 at 16:35 +0100, Karol Lewandowski wrote: > > > >> Truth is that gio guys already merged tizen's glib-kdbus modifications > >> into their own devel branch without us even

Re: [systemd-devel] Newbie question - Requires doesn't work properly

2013-11-22 Thread Reindl Harald
Am 22.11.2013 12:49, schrieb David Timothy Strauss: > It is the responsibility of whatever sends the watchdog to ensure > everything's healthy, however necessary. It would > be silly to spawn a thread and have it blindly report health to watchdog. The > point is for that thread to do proper > c

Re: [systemd-devel] [PATCH 0/4] [RFC v1] gdbus: Preliminary kdbus-support patches

2013-11-22 Thread Karol Lewandowski
On 11/21/2013 08:28 PM, Colin Walters wrote: > On Thu, 2013-11-21 at 16:35 +0100, Karol Lewandowski wrote: > >> Truth is that gio guys already merged tizen's glib-kdbus modifications >> into their own devel branch without us even knowing, not to mention >> proposing it. > > If you're referring

Re: [systemd-devel] Newbie question - Requires doesn't work properly

2013-11-22 Thread David Timothy Strauss
It is the responsibility of whatever sends the watchdog to ensure everything's healthy, however necessary. It would be silly to spawn a thread and have it blindly report health to watchdog. The point is for that thread to do proper checks but ensure reports go in at the right intervals. On Nov 22,

Re: [systemd-devel] Newbie question - Requires doesn't work properly

2013-11-22 Thread Reindl Harald
Am 22.11.2013 03:04, schrieb salil GK: > Thanks a lot David > > On 22 November 2013 06:44, David Timothy Strauss > wrote: > > On Thu, Nov 21, 2013 at 4:57 PM, salil GK > wrote: > > What happens is - my process may be busy with som