[systemd-devel] fstab, rootfs on btrfs

2013-11-26 Thread Chris Murphy
In Fedora 20, by default anaconda sets fs_passno in fstab to 1 for / on btrfs. During offline updates, this is causing systemd-fstab-generator to freak out not finding fsck.btrfs. https://bugzilla.redhat.com/show_bug.cgi?id=1034563 For some time I've been suggesting that fstab should use fs_pa

Re: [systemd-devel] [systemd-commits] man/systemd-socket-proxyd.xml src/socket-proxy TODO

2013-11-26 Thread David Timothy Strauss
On Wed, Nov 27, 2013 at 12:03 PM, Lennart Poettering wrote: > Could you please explain what the usecase here is? Why is this better > than having two socket units with two proxy services? Right now, it's because separate services cannot exist in the same network namespace with another service. Th

Re: [systemd-devel] [PATCH] core/socket: we only want one event on standard sockets

2013-11-26 Thread David Timothy Strauss
On Wed, Nov 27, 2013 at 7:57 AM, Shawn Landden wrote: > Are you sure applications can handle the extra file descriptor of > passing both the sockfd > and the acceptfd in this case? I don't see why they wouldn't just do > the accept() themselves? > > Can you explain what you mean here, and how it d

Re: [systemd-devel] [systemd-commits] man/systemd-socket-proxyd.xml src/socket-proxy TODO

2013-11-26 Thread Lennart Poettering
On Sun, 24.11.13 16:47, David Strauss (strau...@kemper.freedesktop.org) wrote: > TODO |1 > man/systemd-socket-proxyd.xml| 80 > ++- > src/socket-proxy/socket-proxyd.c | 63 -- > 3 files chan

Re: [systemd-devel] [PATCH] core/socket: we only want one event on standard sockets

2013-11-26 Thread Lennart Poettering
On Wed, 27.11.13 07:48, David Timothy Strauss (da...@davidstrauss.net) wrote: > > On Wed, Nov 27, 2013 at 6:23 AM, Shawn Landden wrote: > > I was worried that the fact that we never accept() the socket when using > > distribute (now I am convinced we shouldn't use it otherwise) > > I'm not sure

Re: [systemd-devel] [PATCH] core/socket: we only want one event on standard sockets

2013-11-26 Thread Shawn Landden
On Tue, Nov 26, 2013 at 1:48 PM, David Timothy Strauss wrote: > On Wed, Nov 27, 2013 at 6:23 AM, Shawn Landden wrote: >> I was worried that the fact that we never accept() the socket when using >> distribute (now I am convinced we shouldn't use it otherwise) > > I'm not sure what you mean here. D

Re: [systemd-devel] [PATCH] core/socket: we only want one event on standard sockets

2013-11-26 Thread David Timothy Strauss
On Wed, Nov 27, 2013 at 6:23 AM, Shawn Landden wrote: > I was worried that the fact that we never accept() the socket when using > distribute (now I am convinced we shouldn't use it otherwise) I'm not sure what you mean here. Distribute-style functionality is absolutely useful with Accept=true (t

Re: [systemd-devel] [PATCH] core/socket: we only want one event on standard sockets

2013-11-26 Thread Shawn Landden
As we only reciece one event at a time, and dequeue it in the same go, yeah ONESHOT won't change anything. On Tue, Nov 26, 2013 at 9:33 AM, David Timothy Strauss wrote: > On Wed, Nov 27, 2013 at 2:32 AM, Lennart Poettering > wrote: >> Well, but EPOLLET only works correctly if each time an event

Re: [systemd-devel] [PATCH] core/socket: we only want one event on standard sockets

2013-11-26 Thread David Timothy Strauss
On Wed, Nov 27, 2013 at 2:32 AM, Lennart Poettering wrote: > Well, but EPOLLET only works correctly if each time an event is > triggered we dispatch *all* possibly queued events on the fd, until > EAGAIN is read again. But we don't do that, heck, if Listen=no is used > we don''t even read a single

Re: [systemd-devel] [RFC][PATCH] conf-parser: distinguish between multiple sections with the same name

2013-11-26 Thread Lennart Poettering
On Thu, 21.11.13 02:27, Tom Gundersen (t...@jklm.no) wrote: > > Maybe then back to labelled sections: > > > > [Address:foobar] > > Label=waldo > > Address=1.1.1.1 > > > > or so, so that the suffix "foobar" is purely an id that is by default > > disconnected from any setting? And then maybe optiona

Re: [systemd-devel] pam: Don't use loginuid [was: Re: Fix PAM module to not clobber XDG_RUNTIME_DIR with su]

2013-11-26 Thread Lennart Poettering
On Tue, 26.11.13 09:53, Colin Guthrie (gm...@colin.guthr.ie) wrote: > >> I'm proposing a simple goal: XDG_RUNTIME_DIR should always be that > >> matching the current uid. I can't think of any case where you'd > >> want it otherwise. > > > > That can't work. As the directory only exists when a re

Re: [systemd-devel] pam: Don't use loginuid [was: Re: Fix PAM module to not clobber XDG_RUNTIME_DIR with su]

2013-11-26 Thread Lennart Poettering
On Tue, 26.11.13 07:19, Martin Pitt (martin.p...@ubuntu.com) wrote: Heya, > Lennart Poettering [2013-11-26 5:17 +0100]: > > That can't work. As the directory only exists when a real login session > > is around. su/sudo don't get their own login sessins, hence the dir > > doesn't necessarily exis

Re: [systemd-devel] [PATCH] core/socket: we only want one event on standard sockets

2013-11-26 Thread Lennart Poettering
On Tue, 26.11.13 14:44, David Timothy Strauss (da...@davidstrauss.net) wrote: > > On Tue, Nov 26, 2013 at 2:35 PM, Lennart Poettering > wrote: > > Not following here. What precisely does this fix, can you elaborate? > > > > We currently turn off the poll for the socket fds as soon as we queued >

Re: [systemd-devel] pam: Don't use loginuid [was: Re: Fix PAM module to not clobber XDG_RUNTIME_DIR with su]

2013-11-26 Thread Colin Walters
On Tue, 2013-11-26 at 09:53 +, Colin Guthrie wrote: > Colin W's later patch did implement these semantics for the root user's > XDG_RUNTIME_DIR. It kept it around and didn't tidy it up. Doesn't this > solve the problem for the root user nicely (which is the primary problem)? Yes, I run "pkexe

Re: [systemd-devel] pam: Don't use loginuid [was: Re: Fix PAM module to not clobber XDG_RUNTIME_DIR with su]

2013-11-26 Thread Dr. Werner Fink
On Tue, Nov 26, 2013 at 02:39:49PM +, Colin Guthrie wrote: > 'Twas brillig, and Dr. Werner Fink at 26/11/13 14:21 did gyre and gimble: > > On Tue, Nov 26, 2013 at 10:41:36AM +, Colin Guthrie wrote: > >> 'Twas brillig, and Martin Pitt at 26/11/13 06:19 did gyre and gimble: > >>> Hey Lennart,

Re: [systemd-devel] Question regarding the NotifyAccess parameter

2013-11-26 Thread Hoyer, Marko (ADITG/SW2)
> >One more issue I observed is - if I specify Restart=on-failure, if > > watchdog timer expire, it restart the service. But I can see that it > > create two processes rather than restarting the process. But if I do > > systemctl restart Myservice , it kills the previous instance of > > service

Re: [systemd-devel] pam: Don't use loginuid [was: Re: Fix PAM module to not clobber XDG_RUNTIME_DIR with su]

2013-11-26 Thread Colin Guthrie
'Twas brillig, and Dr. Werner Fink at 26/11/13 14:21 did gyre and gimble: > On Tue, Nov 26, 2013 at 10:41:36AM +, Colin Guthrie wrote: >> 'Twas brillig, and Martin Pitt at 26/11/13 06:19 did gyre and gimble: >>> Hey Lennart, >>> >>> Lennart Poettering [2013-11-26 5:12 +0100]: I implemente

Re: [systemd-devel] Question regarding the NotifyAccess parameter

2013-11-26 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Nov 21, 2013 at 08:56:25PM +0530, salil GK wrote: > Hello > >I have a service in shell script in which I am sending notification to > systemd using `systemd-notify WATCHDOG=1` command. What happens is - > systemd-notify will be a child process and in the systemd notification will > not

Re: [systemd-devel] pam: Don't use loginuid [was: Re: Fix PAM module to not clobber XDG_RUNTIME_DIR with su]

2013-11-26 Thread Dr. Werner Fink
On Tue, Nov 26, 2013 at 10:41:36AM +, Colin Guthrie wrote: > 'Twas brillig, and Martin Pitt at 26/11/13 06:19 did gyre and gimble: > > Hey Lennart, > > > > Lennart Poettering [2013-11-26 5:12 +0100]: > >> I implemented this now, using a different approach than Martin's > >> original patch (i.

Re: [systemd-devel] systemd 208:trouble with inactive user sessions at non-seat0 seats

2013-11-26 Thread Laércio de Sousa
David, Looking at GDM debug and gdm-simple-slave.c source file, as well as "loginctl show-seat" output. I guess that GDM only requests user session activation for seats with CanMultiSession=yes, but currently systemd-logind still sets CanMultiSession=no for my non-seat0 seats. Does seat_can_multi

Re: [systemd-devel] [PATCH] tree-wide usage of %m specifier instead of strerror(errno)

2013-11-26 Thread David Timothy Strauss
Thanks. Applied. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] pam: Don't use loginuid [was: Re: Fix PAM module to not clobber XDG_RUNTIME_DIR with su]

2013-11-26 Thread Colin Guthrie
'Twas brillig, and Martin Pitt at 26/11/13 06:19 did gyre and gimble: > Hey Lennart, > > Lennart Poettering [2013-11-26 5:12 +0100]: >> I implemented this now, using a different approach than Martin's >> original patch (i.e. I don't think it is a good idea to involve stat() >> here, instead let's

Re: [systemd-devel] pam: Don't use loginuid [was: Re: Fix PAM module to not clobber XDG_RUNTIME_DIR with su]

2013-11-26 Thread Colin Guthrie
'Twas brillig, and Lennart Poettering at 26/11/13 04:17 did gyre and gimble: > On Wed, 20.11.13 19:19, Colin Walters (walt...@verbum.org) wrote: > >>> So yeah, there your mix >>> and match is broken: >> >> I'm proposing a simple goal: XDG_RUNTIME_DIR should always be that >> matching the current

[systemd-devel] [PATCH] tree-wide usage of %m specifier instead of strerror(errno)

2013-11-26 Thread Daniel Buch
Also for log_error() except where a specific error is specified e.g. errno ? strerror(errno) : "Some user specified message" --- TODO | 2 -- src/core/automount.c | 2 +- src/core/main.c| 2 +- src/core/manager.c | 2 +- src/core