Re: [systemd-devel] udevadm settle takes too long to finish

2013-12-09 Thread Robert Milasan
On Mon, 09 Dec 2013 11:33:03 +0100 Thomas Bächler tho...@archlinux.org wrote: Am 07.12.2013 22:29, schrieb Robert Milasan: From systemd-analyze dump: Wants: systemd-udevd.service WantedBy: lvm2-activation-early.service WantedBy: lvm2-activation.service

[systemd-devel] [PATCH] libsystemd-bus: Clean up code

2013-12-09 Thread Lukasz Skalski
--- src/libsystemd-bus/bus-dump.c | 2 +- src/libsystemd-bus/bus-error.c | 3 +-- src/libsystemd-bus/bus-kernel.c| 12 +++- src/libsystemd-bus/bus-message.c | 12 +++- src/libsystemd-bus/bus-signature.c | 13 - 5 files changed, 12 insertions(+), 30

[systemd-devel] [PATCH] update README to not suggest that systemd works without procfs

2013-12-09 Thread Shawn Landden
--- README | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/README b/README index cc43953..f2a86c5 100644 --- a/README +++ b/README @@ -45,6 +45,7 @@ REQUIREMENTS: CONFIG_EPOLL CONFIG_NET CONFIG_SYSFS + CONFIG_PROC_FS

Re: [systemd-devel] systemd-nspawn and kernel command line

2013-12-09 Thread Colin Guthrie
'Twas brillig, and Lennart Poettering at 08/12/13 23:48 did gyre and gimble: On Sat, 07.12.13 18:33, Colin Guthrie (gm...@colin.guthr.ie) wrote: Hi, When playing with systemd-nspawn, is there a way to override the kernel command line seen inside the container. I mean it's probably not

Re: [systemd-devel] [PATCH 4/4] core: lazy distribute for Distribute pools

2013-12-09 Thread David Timothy Strauss
On Sun, Dec 8, 2013 at 8:25 PM, Shawn Landden shawnland...@gmail.com wrote: This one doesn't work. I have have a somewhat-working next patch, but the way epoll_wait works it actually isn't lazy at all, and would require EPOLLET to even do one-spawn-per-connection (global connection), but we

[systemd-devel] Setting low-level cgroups attributes in systemd

2013-12-09 Thread Joe Miller
It appears that the .slice changed described here[1] removed all ability to set low-level cgroups settings, is that correct? For cgroup attributes that systemd does not natively support (example: cpu.cfs_period_us and cpu.cfs_quota_us) it was previously possible to set these 1. via unit files:

Re: [systemd-devel] udevadm settle takes too long to finish

2013-12-09 Thread Chris Murphy
On Dec 9, 2013, at 3:33 AM, Thomas Bächler tho...@archlinux.org wrote: Am 07.12.2013 22:29, schrieb Robert Milasan: From systemd-analyze dump: Wants: systemd-udevd.service WantedBy: lvm2-activation-early.service WantedBy: lvm2-activation.service Before:

[systemd-devel] user@.service doesn't stop on logout

2013-12-09 Thread Thomas Bächler
In systemd 208 and latest systemd git, every user gets a new user@.service instance when they login. However, when their last session exits, that service is not terminated. After a few weeks of uptime on one of my servers, dozens of user@.service units are running, belonging to users that logged

[systemd-devel] [PATCH] fix scan-build issues

2013-12-09 Thread Thomas H.P. Andersen
From: Thomas Hindoe Paaboel Andersen pho...@gmail.com The static analyzer scan-build had a few issues with analysing parts of systemd. gpt-auto-generator.c: scan-build could not find blkid.h. Whether it should be blkid.h or blkid/blkid.h seems to depend on the version used. We already use

Re: [systemd-devel] [PATCH] libsystemd-bus: Clean up code

2013-12-09 Thread Thomas H.P. Andersen
If I understood correctly then the assert_return was meant to be used only on the public library functions. I can't seem to find the reference to it so maybe I am wrong though. On Mon, Dec 9, 2013 at 2:09 PM, Lukasz Skalski l.skal...@partner.samsung.com wrote: --- src/libsystemd-bus/bus-dump.c

Re: [systemd-devel] [PATCH] test: rework run_qemu

2013-12-09 Thread Ronny Chevalier
Do we really want to add a compat for several distributions ? Because why not Archlinux, Ubuntu,... too ? I used Fedora's path by default because it was in the previous script. 2013/12/8 Shawn Landden sh...@churchofgit.com: On Sat, Dec 7, 2013 at 3:01 PM, Ronny Chevalier

Re: [systemd-devel] [PATCH v2 00/26] Initial DHCP v4 library implementation

2013-12-09 Thread Patrik Flykt
On Mon, 2013-11-25 at 23:52 +0100, Lennart Poettering wrote: Of course, timer callbacks should only be called once, ence ONESHOT mode is the default -- unless you change that explicitly. If this doesn't solve the issue, I wouldn't be surprised if there was still a bug lurking with the

[systemd-devel] [PATCH v3 10/26] dhcp: Add test function for computing checksum

2013-12-09 Thread Patrik Flykt
--- src/dhcp/test-dhcp-client.c | 40 1 file changed, 40 insertions(+) diff --git a/src/dhcp/test-dhcp-client.c b/src/dhcp/test-dhcp-client.c index cb2f652..b226d3f 100644 --- a/src/dhcp/test-dhcp-client.c +++ b/src/dhcp/test-dhcp-client.c @@ -22,6

[systemd-devel] [PATCH v3 04/26] build: Add initial build support

2013-12-09 Thread Patrik Flykt
The client test program is the only one to be built so far. --- Makefile.am | 13 + src/dhcp/Makefile |1 + 2 files changed, 14 insertions(+) create mode 12 src/dhcp/Makefile diff --git a/Makefile.am b/Makefile.am index 7bedd76..4e13370 100644 --- a/Makefile.am +++

[systemd-devel] [PATCH v3 15/26] dhcp: Add test for discover DHCP packet creation

2013-12-09 Thread Patrik Flykt
Set a fake MAC address and emulate raw packet sending. When the buffer containing the Discover message is received, check selected IP and UDP headers and compute IP header and UDP message checksums. Also send the DHCP message for option parsing and expect a successful outcome. --- Makefile.am

[systemd-devel] [PATCH v3 24/26] dhcp: Compute expire, T1 and T2 timers

2013-12-09 Thread Patrik Flykt
Compute the default T1 and T2 timer values if they were not set by the DHCP server. Verify that the values are reasonable. --- src/dhcp/client.c | 116 ++- src/dhcp/protocol.h |2 + 2 files changed, 117 insertions(+), 1 deletion(-) diff

[systemd-devel] [PATCH v3 11/26] shared: Add struct sockaddr_ll to sockaddr_union

2013-12-09 Thread Patrik Flykt
--- src/shared/socket-util.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/shared/socket-util.h b/src/shared/socket-util.h index d42a2fe..84ebc30 100644 --- a/src/shared/socket-util.h +++ b/src/shared/socket-util.h @@ -27,6 +27,7 @@ #include net/if.h #include asm/types.h

[systemd-devel] [PATCH v3 25/26] dhcp: Add notification callback

2013-12-09 Thread Patrik Flykt
Define a notification callback and events for stopping and client lease expiry. Add functions to fetch IP parameters from a lease. --- src/dhcp/client.c| 112 +- src/systemd/sd-dhcp-client.h | 13 + 2 files changed, 124 insertions(+), 1

[systemd-devel] [PATCH v3 16/26] dhcp: Support seconds elapsed since start of DHCP negotiation

2013-12-09 Thread Patrik Flykt
It was noticed by Grant Erickson in ConnMan commit 95e15c09350acf58d4707056ae2614570883ef66 that: Certain DHCP servers, such as that implemented in Mac OS X ( 10.7) for its Internet Sharing feature, refuse to issue a DHCP lease to clients that have not set a non-zero value in their

[systemd-devel] [PATCH v3 23/26] dhcp: Process DHCP Ack/Nak message

2013-12-09 Thread Patrik Flykt
Process a DHCP Ack/Nak in much the same way as an DHCP Offer. Factor out header verification and process options sent. Add notification functionality with discrete values for the outcome of the DHCP Ack/ Nak processing. --- v3: use size_t for length, -ENOMEM for OOM src/dhcp/client.c

[systemd-devel] [PATCH v3 21/26] dhcp: Send DHCP Request to acquire an IP address

2013-12-09 Thread Patrik Flykt
Create and send a DHCP Request message reusing already existing parts of the code. This causes factoring out IP and UDP header creation and moving next timeout calculation to be done every time in the timer callback function independent of DHCP state. Also add an exponential part to the timer

[systemd-devel] [PATCH v3 02/26] dhcp: Add DHCP client initialization

2013-12-09 Thread Patrik Flykt
Provide functionality for initializing a DHCP client struct, setting interface index, last used address and additional options to request. On initialization the most useful options are added by default. --- v3: fix OOM check, #ifdef in public header, fix struct prefix src/dhcp/client.c

[systemd-devel] [PATCH v3 09/26] dhcp: Add option append tests

2013-12-09 Thread Patrik Flykt
Add checks for invalid lengths and parameters when using the option appending function. Add also checks for adding options, see to it that the resulting array is identical to the array of options added. --- src/dhcp/test-dhcp-option.c | 72 +++ 1 file

[systemd-devel] [PATCH v3 07/26] build: Add DHCP option test

2013-12-09 Thread Patrik Flykt
--- Makefile.am | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Makefile.am b/Makefile.am index 4e13370..5794380 100644 --- a/Makefile.am +++ b/Makefile.am @@ -3837,6 +3837,15 @@ lib_LTLIBRARIES += \ endif #

[systemd-devel] [PATCH v3 17/26] dhcp: Add function to stop the DHCP client

2013-12-09 Thread Patrik Flykt
The client is stopped and brought back to its initial state. --- src/dhcp/client.c| 32 src/systemd/sd-dhcp-client.h |1 + 2 files changed, 33 insertions(+) diff --git a/src/dhcp/client.c b/src/dhcp/client.c index 665f986..60a1b4c 100644 ---

[systemd-devel] [PATCH v3 03/26] dhcp: Add test for DHCP client initialization and parameter setting

2013-12-09 Thread Patrik Flykt
--- src/dhcp/test-dhcp-client.c | 81 +++ 1 file changed, 81 insertions(+) create mode 100644 src/dhcp/test-dhcp-client.c diff --git a/src/dhcp/test-dhcp-client.c b/src/dhcp/test-dhcp-client.c new file mode 100644 index 000..cb2f652 --- /dev/null

[systemd-devel] [PATCH v3 18/26] build: Add dependency on libsystemd-bus needed for main loop

2013-12-09 Thread Patrik Flykt
--- Makefile.am |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 1b9edf2..cfa9b4b 100644 --- a/Makefile.am +++ b/Makefile.am @@ -3855,7 +3855,8 @@ libsystemd_dhcp_la_LDFLAGS = \ $(AM_LDFLAGS) libsystemd_dhcp_la_LIBADD = \ -

[systemd-devel] [PATCH v3 26/26] dhcp: Add function to free DHCP client data

2013-12-09 Thread Patrik Flykt
--- src/dhcp/client.c| 13 + src/systemd/sd-dhcp-client.h |1 + 2 files changed, 14 insertions(+) diff --git a/src/dhcp/client.c b/src/dhcp/client.c index d93cceb..2a479e4 100644 --- a/src/dhcp/client.c +++ b/src/dhcp/client.c @@ -961,6 +961,19 @@ int

[systemd-devel] [PATCH v3 20/26] dhcp: Handle received DHCP Offer message

2013-12-09 Thread Patrik Flykt
Create a function for handling the full IP, UDP and DHCP packet and tie it to the main loop. Verify IP and UDP headers and checksum. Creat a new lease structure with using the values supplied in the DHCP message. Free the lease structure when client is stopped. Split out socket handling into a

[systemd-devel] [PATCH v3 22/26] dhcp: Add maximum message size option

2013-12-09 Thread Patrik Flykt
Add maximum message size option to keep some DHCP server implementations from sending too big messages. See ConnMan commit 0c5c862749c05193cf4c513628328c6db02b5222. --- src/dhcp/client.c | 12 src/dhcp/protocol.h |1 + 2 files changed, 13 insertions(+) diff --git

[systemd-devel] [PATCH v3 06/26] dhcp: Add buffer length and invalid cookie tests for DHCP options

2013-12-09 Thread Patrik Flykt
Create an initial simple test program for these two cases. --- src/dhcp/test-dhcp-option.c | 51 +++ 1 file changed, 51 insertions(+) create mode 100644 src/dhcp/test-dhcp-option.c diff --git a/src/dhcp/test-dhcp-option.c b/src/dhcp/test-dhcp-option.c

[systemd-devel] [PATCH 2/2] epoll and signalfd has been moved into sd event loop

2013-12-09 Thread Shawn Landden
--- src/core/manager.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/core/manager.c b/src/core/manager.c index f06df54..56c10cf 100644 --- a/src/core/manager.c +++ b/src/core/manager.c @@ -22,9 +22,7 @@ #include assert.h #include errno.h #include string.h -#include sys/epoll.h

[systemd-devel] [PATCH 1/2] core: support Distribute=n to distribute to n workers

2013-12-09 Thread Shawn Landden
Until there are some use cases for Distribute= w/o SO_REUSEPORT make it imply that. Otherwise we need a new config_parse_distribute in load-fragment.c and gain the same issues of config_parse_syscall, where NoNewPrivs can be still set to false, but only if set _after_ SystemCallFilter (only

Re: [systemd-devel] File system gets remounted read-only after using nspawn

2013-12-09 Thread Canek Peláez Valdés
(Sorry for taking so long to answer, I was away from my test system). On Sat, Dec 7, 2013 at 5:56 PM, Colin Guthrie gm...@colin.guthr.ie wrote: 'Twas brillig, and Canek Peláez Valdés at 05/12/13 23:26 did gyre and gimble: Hi; I've been playing with systemd-nspawn with Gentoo. I'm running

Re: [systemd-devel] [PATCH] Fix usage of kernel-install

2013-12-09 Thread Sébastien Luttringer
On 05/12/2013 02:55, Sébastien Luttringer wrote: Kernel install doesn't need the second argument on his command line when removing. This is correctly documented in the man page. Signed-off-by: Sébastien Luttringer se...@seblu.net --- src/kernel-install/kernel-install | 2 +- 1 file

Re: [systemd-devel] [PATCH v2 00/26] Initial DHCP v4 library implementation

2013-12-09 Thread Lennart Poettering
On Mon, 09.12.13 23:41, Patrik Flykt (patrik.fl...@linux.intel.com) wrote: On Mon, 2013-11-25 at 23:52 +0100, Lennart Poettering wrote: Of course, timer callbacks should only be called once, ence ONESHOT mode is the default -- unless you change that explicitly. If this doesn't solve

Re: [systemd-devel] [PATCH v3 01/26] dhcp: Add DHCP protocol structures and initial defines

2013-12-09 Thread Lennart Poettering
On Mon, 09.12.13 23:43, Patrik Flykt (patrik.fl...@linux.intel.com) wrote: +struct DHCPMessage { +uint8_t op; +uint8_t htype; +uint8_t hlen; +uint8_t hops; +be32_t xid; +be16_t secs; +be16_t flags; +uint32_t ciaddr; +

Re: [systemd-devel] [PATCH] test: rework run_qemu

2013-12-09 Thread Tom Gundersen
On 10 Dec 2013 02:44, Ronny Chevalier chevalier.ro...@gmail.com wrote: Do we really want to add a compat for several distributions ? Because why not Archlinux, Ubuntu,... too ? I used Fedora's path by default because it was in the previous script. Maybe just use the path created by our

Re: [systemd-devel] [PATCH v3 00/26] Initial DHCP v4 library implementation

2013-12-09 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Dec 09, 2013 at 11:43:06PM +0200, Patrik Flykt wrote: Hi, Here is version 3 fixed according to comments plus a few identical ones found in the code. Essential changes are unconditionally compiling the DHCP code and re-adding the sd_dhcp_client_get_netmask() function due to

Re: [systemd-devel] [PATCH] Fix usage of kernel-install

2013-12-09 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 10, 2013 at 02:06:07AM +0100, Sébastien Luttringer wrote: On 05/12/2013 02:55, Sébastien Luttringer wrote: Kernel install doesn't need the second argument on his command line when removing. This is correctly documented in the man page. Signed-off-by: Sébastien Luttringer

Re: [systemd-devel] [PATCH] libsystemd-bus: Clean up code

2013-12-09 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Dec 09, 2013 at 09:22:43PM +0100, Thomas H.P. Andersen wrote: If I understood correctly then the assert_return was meant to be used only on the public library functions. I can't seem to find the reference to it so maybe I am wrong though. There's no strong reason to limit usage to

Re: [systemd-devel] [PATCH] fix scan-build issues

2013-12-09 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Dec 09, 2013 at 09:01:08PM +0100, Thomas H.P. Andersen wrote: From: Thomas Hindoe Paaboel Andersen pho...@gmail.com The static analyzer scan-build had a few issues with analysing parts of systemd. gpt-auto-generator.c: scan-build could not find blkid.h. Whether it should be

Re: [systemd-devel] udevadm settle takes too long to finish

2013-12-09 Thread Andrey Borzenkov
В Mon, 9 Dec 2013 12:42:21 -0700 Chris Murphy li...@colorremedies.com пишет: On Dec 9, 2013, at 3:33 AM, Thomas Bächler tho...@archlinux.org wrote: Am 07.12.2013 22:29, schrieb Robert Milasan: From systemd-analyze dump: Wants: systemd-udevd.service WantedBy:

Re: [systemd-devel] udevadm settle takes too long to finish

2013-12-09 Thread Cristian Rodríguez
El 10/12/13 03:47, Andrey Borzenkov escribió: There is no such service on openSUSE, which OP has :) Yes there is :-) but in factory only. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

[systemd-devel] [PATCH 6/8] add GOP mode setting and splash drawing support

2013-12-09 Thread Joonas Lahtinen
Add support for two new configuration directives gfxmode and splash which respectively allow setting the screen graphics mode and drawing splash image during gummiboot execution. See README.gop for more details. Signed-off-by: Joonas Lahtinen joonas.lahti...@linux.intel.com Reviewed-by: Mikko

[systemd-devel] [PATCH 5/8] make console_text_mode into more generic function

2013-12-09 Thread Joonas Lahtinen
Convert console_text_mode function into console_mode function which is able to switch back and forth between graphics and text mode. Signed-off-by: Joonas Lahtinen joonas.lahti...@linux.intel.com Reviewed-by: Darren Hart dvh...@linux.intel.com Reviewed-by: Mikko Ylinen mikko.yli...@intel.com ---

[systemd-devel] [PATCH 0/8] GOP display initialization and splash screen drawing

2013-12-09 Thread Joonas Lahtinen
Hi, The following patch series implement UEFI GOP graphics mode initialization and screen clearing functionality to Gummiboot. They're all based on top of the current master. The functionality was written against the UEFI specification, so it should work everywhere where that functionality is

[systemd-devel] [PATCH 7/8] add ppm2bgrx utility

2013-12-09 Thread Joonas Lahtinen
Add utility to convert 8-bit PPM files into UEFI GOP supported BGRX files to be used as splash screens. Signed-off-by: Joonas Lahtinen joonas.lahti...@linux.intel.com Reviewed-by: Mikko Ylinen mikko.yli...@intel.com Acked-by: Darren Hart dvh...@linux.intel.com --- .gitignore | 1 +

[systemd-devel] [PATCH 3/8] add atoi function

2013-12-09 Thread Joonas Lahtinen
Add generic purpose number parsing function to be used by modeline parsing. Signed-off-by: Joonas Lahtinen joonas.lahti...@linux.intel.com Reviewed-by: Darren Hart dvh...@linux.intel.com Reviewed-by: Mikko Ylinen mikko.yli...@intel.com --- src/efi/gummiboot.c | 26 ++ 1

[systemd-devel] [PATCH 1/8] add source format modeline

2013-12-09 Thread Joonas Lahtinen
For easier editing, add source format modeline similar to other files. Signed-off-by: Joonas Lahtinen joonas.lahti...@linux.intel.com Reviewed-by: Mikko Ylinen mikko.yli...@intel.com Acked-by: Darren Hart dvh...@linux.intel.com --- src/efi/gummiboot.c | 2 ++ 1 file changed, 2 insertions(+)

[systemd-devel] [PATCH 4/8] make file_read callable outside compilation unit

2013-12-09 Thread Joonas Lahtinen
Make file_read usable from other compilation units allowing reuse of code when splitting functionality to multiple files. Signed-off-by: Joonas Lahtinen joonas.lahti...@linux.intel.com Reviewed-by: Darren Hart dvh...@linux.intel.com Reviewed-by: Mikko Ylinen mikko.yli...@intel.com ---