Re: [systemd-devel] [PATCH] DEFAULT_PATH_SPLIT_USR macro

2013-12-20 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Dec 20, 2013 at 03:35:38PM -0800, Shawn Landden wrote: > --- > src/nspawn/nspawn.c| 2 +- > src/shared/path-util.h | 4 +++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/nspawn/nspawn.c b/src/nspawn/nspawn.c > index a85579b..241b4b5 100644 > --- a/src/nspawn

Re: [systemd-devel] systemd + logind possible deadlock

2013-12-20 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Dec 16, 2013 at 06:32:56PM +0200, Oleksii Shevchuk wrote: > > Are you suggesting O_SNDTIMEO doesn't work for you? Normally it should > > simply cause the send() to fail if the receiver doesn't take the packet > > within some time. > > I don't take much investigation into this, but looks li

[systemd-devel] [PATCH] Split out /run/nologin creation into a separate service

2013-12-20 Thread Zbigniew Jędrzejewski-Szmek
This has come up before, and will come up again: running systemd-tmpfiles --create kills user logins. In principle this is documented, but in practice people don't always read the documentation. Split out /run/nologin creation so it's harder to do execute it by mistake. https://bugzilla.redhat.com

[systemd-devel] [PATCH] DEFAULT_PATH_SPLIT_USR macro

2013-12-20 Thread Shawn Landden
--- src/nspawn/nspawn.c| 2 +- src/shared/path-util.h | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/nspawn/nspawn.c b/src/nspawn/nspawn.c index a85579b..241b4b5 100644 --- a/src/nspawn/nspawn.c +++ b/src/nspawn/nspawn.c @@ -1243,7 +1243,7 @@ int main(int argc, ch

Re: [systemd-devel] systemd-nspawn and kernel command line

2013-12-20 Thread Shawn Landden
On Fri, Dec 20, 2013 at 2:09 PM, Shawn Landden wrote: > On Mon, Dec 9, 2013 at 9:23 AM, Colin Guthrie wrote: >> 'Twas brillig, and Lennart Poettering at 08/12/13 23:48 did gyre and gimble: >>> On Sat, 07.12.13 18:33, Colin Guthrie (gm...@colin.guthr.ie) wrote: >>> Hi, When playing

Re: [systemd-devel] systemd-nspawn and kernel command line

2013-12-20 Thread Shawn Landden
On Mon, Dec 9, 2013 at 9:23 AM, Colin Guthrie wrote: > 'Twas brillig, and Lennart Poettering at 08/12/13 23:48 did gyre and gimble: >> On Sat, 07.12.13 18:33, Colin Guthrie (gm...@colin.guthr.ie) wrote: >> >>> Hi, >>> >>> When playing with systemd-nspawn, is there a way to override the kernel >>>

Re: [systemd-devel] [PATCH 02/11] libsystemd-dhcp: Return proper error if bind fails

2013-12-20 Thread Lennart Poettering
On Fri, 20.12.13 16:35, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > On Fri, Dec 20, 2013 at 05:16:11PM +0200, Patrik Flykt wrote: > > This also fixes a minor indentation damage. > > --- > > src/libsystemd-dhcp/dhcp-network.c |7 --- > > 1 file changed, 4 insertions(+), 3 dele

Re: [systemd-devel] [PATCH 00/11] *** SUBJECT HERE ***

2013-12-20 Thread Lennart Poettering
On Fri, 20.12.13 11:59, Shawn Landden (sh...@churchofgit.com) wrote: > > On Fri, Dec 20, 2013 at 11:50 AM, Colin Walters wrote: > > On Thu, 2013-12-19 at 14:20 +0100, Florian Weimer wrote: > > > >> readdir_r is rather broken on Linux because there are some directories > >> it cannot read. > > >

Re: [systemd-devel] [PATCH 00/11] *** SUBJECT HERE ***

2013-12-20 Thread Florian Weimer
On 12/20/2013 08:50 PM, Colin Walters wrote: On Thu, 2013-12-19 at 14:20 +0100, Florian Weimer wrote: readdir_r is rather broken on Linux because there are some directories it cannot read. Citation? Are you talking about http://womble.decadent.org.uk/readdir_r-advisory.html ? Partly, yes.

Re: [systemd-devel] [PATCH 00/11] *** SUBJECT HERE ***

2013-12-20 Thread Shawn Landden
On Fri, Dec 20, 2013 at 11:50 AM, Colin Walters wrote: > On Thu, 2013-12-19 at 14:20 +0100, Florian Weimer wrote: > >> readdir_r is rather broken on Linux because there are some directories >> it cannot read. > > Citation? Are you talking about > http://womble.decadent.org.uk/readdir_r-advisory.h

Re: [systemd-devel] [PATCH 00/11] *** SUBJECT HERE ***

2013-12-20 Thread Colin Walters
On Thu, 2013-12-19 at 14:20 +0100, Florian Weimer wrote: > readdir_r is rather broken on Linux because there are some directories > it cannot read. Citation? Are you talking about http://womble.decadent.org.uk/readdir_r-advisory.html ? ___ systemd-d

Re: [systemd-devel] [PATCH 00/11] Finalize initial DHCP support

2013-12-20 Thread Marcel Holtmann
Hi Tom, >>> The first seven patches fix a few issues with the current code. >>> >>> Patch 09 adds DHCP lease renewing support when timer T1 triggers. Using >>> the UDP socket sending implementation in patch 08, the DHCP lease >>> renewal is unicasted to the DHCP server. This means that systemd-ne

Re: [systemd-devel] [PATCH 00/11] Finalize initial DHCP support

2013-12-20 Thread Tom Gundersen
On Fri, Dec 20, 2013 at 4:43 PM, Marcel Holtmann wrote: > Hi Patrik, > >> The first seven patches fix a few issues with the current code. >> >> Patch 09 adds DHCP lease renewing support when timer T1 triggers. Using >> the UDP socket sending implementation in patch 08, the DHCP lease >> renewal is

Re: [systemd-devel] [PATCH 00/11] Finalize initial DHCP support

2013-12-20 Thread Marcel Holtmann
Hi Patrik, > The first seven patches fix a few issues with the current code. > > Patch 09 adds DHCP lease renewing support when timer T1 triggers. Using > the UDP socket sending implementation in patch 08, the DHCP lease > renewal is unicasted to the DHCP server. This means that systemd-network >

Re: [systemd-devel] [PATCH 02/11] libsystemd-dhcp: Return proper error if bind fails

2013-12-20 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Dec 20, 2013 at 05:16:11PM +0200, Patrik Flykt wrote: > This also fixes a minor indentation damage. > --- > src/libsystemd-dhcp/dhcp-network.c |7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/src/libsystemd-dhcp/dhcp-network.c > b/src/libsystemd-dhcp/dhc

Re: [systemd-devel] [PATCH 08/11] libsystemd-dhcp: Add functions for sending unicast UDP messages

2013-12-20 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Dec 20, 2013 at 05:16:17PM +0200, Patrik Flykt wrote: > Create a helper functions setting up an unicast DHCP UDP socket and > sending data. Add function stubs for the test program. > --- > src/libsystemd-dhcp/dhcp-internal.h|3 +++ > src/libsystemd-dhcp/dhcp-network.c | 38 >

Re: [systemd-devel] [PATCH 4/4] gdbus: Add basic kdbus tests

2013-12-20 Thread Yin Kangkai
On 2013-11-21, 12:33 +0100, Karol Lewandowski wrote: > +TESTS > += > + > +* Build test binaries: > + > + cd gio/tests > + make > + > +* Set variable to use custom library and to use kdbus as session bus: > + > + export LD_LIBRARY_PATH=absolute_path_to_glib_libs_with_kdbus_patch > + export D

[systemd-devel] [PATCH 00/11] Finalize initial DHCP support

2013-12-20 Thread Patrik Flykt
Hi, The first seven patches fix a few issues with the current code. Patch 09 adds DHCP lease renewing support when timer T1 triggers. Using the UDP socket sending implementation in patch 08, the DHCP lease renewal is unicasted to the DHCP server. This means that systemd-network should hav

[systemd-devel] [PATCH 07/11] libsystemd-dhcp: Check test result without casting value

2013-12-20 Thread Patrik Flykt
--- src/libsystemd-dhcp/test-dhcp-client.c |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/libsystemd-dhcp/test-dhcp-client.c b/src/libsystemd-dhcp/test-dhcp-client.c index 7400cc6..1ff78c1 100644 --- a/src/libsystemd-dhcp/test-dhcp-client.c +++ b/src/libsystemd-

[systemd-devel] [PATCH 09/11] libsystemd-dhcp: Handle T1 Renewing timeout

2013-12-20 Thread Patrik Flykt
Expiration of T1 timeout takes the client to the Rebinding state, where it attempts to renew its lease. Start by opening a DCHP unicast socket as there now is a proper IP address set. Compute the resend timer as half of the remaining time down to a minimum of 60 seconds (RFC2131). Modify DHCP Requ

[systemd-devel] [PATCH 11/11] libsystemd-dhcp: Handle T2 Rebinding timeout

2013-12-20 Thread Patrik Flykt
Reuse existing functionality when adding T2 Rebinding support. --- src/libsystemd-dhcp/dhcp-client.c | 41 - 1 file changed, 36 insertions(+), 5 deletions(-) diff --git a/src/libsystemd-dhcp/dhcp-client.c b/src/libsystemd-dhcp/dhcp-client.c index 23669c7..a8

[systemd-devel] [PATCH 06/11] libsystemd-dhcp: Fix checksum computation for buffer with odd size

2013-12-20 Thread Patrik Flykt
Fix off-by-one error and notice that summing may need more than one round for the result to be in the lower 16 bits. --- src/libsystemd-dhcp/dhcp-client.c |7 +-- src/libsystemd-dhcp/test-dhcp-client.c |7 +-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src

[systemd-devel] [PATCH 10/11] libsystemd-dhcp: Factor out common code initializing events

2013-12-20 Thread Patrik Flykt
Factor out common code from timeout T1 handling and starting of the DHCP client. --- src/libsystemd-dhcp/dhcp-client.c | 76 + 1 file changed, 34 insertions(+), 42 deletions(-) diff --git a/src/libsystemd-dhcp/dhcp-client.c b/src/libsystemd-dhcp/dhcp-client.

[systemd-devel] [PATCH 03/11] libsystemd-dhcp: Return proper error on OOM

2013-12-20 Thread Patrik Flykt
--- src/libsystemd-dhcp/dhcp-client.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libsystemd-dhcp/dhcp-client.c b/src/libsystemd-dhcp/dhcp-client.c index fe41067..043d574 100644 --- a/src/libsystemd-dhcp/dhcp-client.c +++ b/src/libsystemd-dhcp/dhcp-client.c @@ -726,

[systemd-devel] [PATCH 04/11] libsystemd-dhcp: Unref event source before closing socket

2013-12-20 Thread Patrik Flykt
--- src/libsystemd-dhcp/dhcp-client.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libsystemd-dhcp/dhcp-client.c b/src/libsystemd-dhcp/dhcp-client.c index 043d574..18a6e3c 100644 --- a/src/libsystemd-dhcp/dhcp-client.c +++ b/src/libsystemd-dhcp/dhcp-client.c @@ -

[systemd-devel] [PATCH 08/11] libsystemd-dhcp: Add functions for sending unicast UDP messages

2013-12-20 Thread Patrik Flykt
Create a helper functions setting up an unicast DHCP UDP socket and sending data. Add function stubs for the test program. --- src/libsystemd-dhcp/dhcp-internal.h|3 +++ src/libsystemd-dhcp/dhcp-network.c | 38 src/libsystemd-dhcp/test-dhcp-client.c |

[systemd-devel] [PATCH 05/11] libsystemd-dhcp: Fix receiving of other message when expecting Ack

2013-12-20 Thread Patrik Flykt
When a DHCP Nak is received, return a DHCP_EVENT_NO_LEASE event. If some other DHCP message is received or an error happens when parsing options, return -ENOMSG in order to ignore the packet. There may be more than one server serving the same subnet, each server will send its Offer to the client. -

[systemd-devel] [PATCH 01/11] libsystemd-dhcp: Use be32_t for IP addresses in network order.

2013-12-20 Thread Patrik Flykt
--- src/libsystemd-dhcp/dhcp-client.c | 10 +- src/libsystemd-dhcp/dhcp-protocol.h |8 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/libsystemd-dhcp/dhcp-client.c b/src/libsystemd-dhcp/dhcp-client.c index c0c348c..fe41067 100644 --- a/src/libsystemd-d

[systemd-devel] [PATCH 02/11] libsystemd-dhcp: Return proper error if bind fails

2013-12-20 Thread Patrik Flykt
This also fixes a minor indentation damage. --- src/libsystemd-dhcp/dhcp-network.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/libsystemd-dhcp/dhcp-network.c b/src/libsystemd-dhcp/dhcp-network.c index 83a3084..3ff2d0b 100644 --- a/src/libsystemd-dhcp/dhcp-net

Re: [systemd-devel] journal: How to limit the file size of runtime system.journal

2013-12-20 Thread Sascha Kattelmann
On 12/16/2013 02:30 PM, Zbigniew Jędrzejewski-Szmek wrote: On Mon, Dec 16, 2013 at 08:31:46AM +0100, Holger Winkelmann [TP] wrote: Hi, Is there any particular reason? I think thresold for runtime journal size can lower much because in initramfs it's not supposed to have much logs. First, the