Re: [systemd-devel] [PATCH] man: cryptsetup now allows partition device file in system mode

2014-02-06 Thread Tom Gundersen
On Thu, Feb 6, 2014 at 8:33 PM, Jan Janssen wrote: > --- > man/crypttab.xml | 9 + > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/man/crypttab.xml b/man/crypttab.xml > index 5f386e5..c563851 100644 > --- a/man/crypttab.xml > +++ b/man/crypttab.xml > @@ -305,14 +305,7 @@

[systemd-devel] [PATCH 7/7] logind: do not call session_jobs_reply() on CLOSING

2014-02-06 Thread Djalal Harouni
match_job_removed() signal is triggered when queued jobs finish during session opening or closing. Calling session_jobs_reply() during opening is valid, but during session closing does not make sense. The session_send_create_reply() function which is called by session_jobs_reply() is able to dete

[systemd-devel] [PATCH 6/7] logind: add user_is_opening() and session_is_opening()

2014-02-06 Thread Djalal Harouni
Add the user_is_opening() and session_is_opening() functions. These functions will check their appropriate 'opening' flag to see if we are in the middel of the opening state. This patch is preparation for the next patch which will use it to guard match_job_remove() from calling session_jobs_reply(

[systemd-devel] [PATCH 5/7] logind: just call session_get_state() to get the session state

2014-02-06 Thread Djalal Harouni
In function user_get_state() remove the session_is_active() check, just count on the session_get_state() function to get the correct session state. session_is_active() may return true before starting the session scope and user service, this means it will return true even before the creation of the

[systemd-devel] [PATCH 4/7] logind: close races on user state at logout

2014-02-06 Thread Djalal Harouni
To get the state of the user, the user_get_state() is used. This function will check if the user->slice_job or the user->service_job are set then it will automatically return USER_OPENING. This is buggy in the context of user closing: At logout or D-Bus TerminateUser() calls user_stop() user_stop(

[systemd-devel] [PATCH 3/7] logind: close races on session state at logout

2014-02-06 Thread Djalal Harouni
To get the state of the session, the session_get_state() is used. This function will check if the session->scope_job is set then it will automatically return SESSION_OPENING. This is buggy in the context of session closing: At logout or D-Bus TerminateSession() fifo_fd is removed: => session_

[systemd-devel] [PATCH v2 0/7] logind: close races on user and session states

2014-02-06 Thread Djalal Harouni
Summary: Currently logind will not clear sessions on logout. The bug is confirmed for getty and ssh logins. This series is preparation for next patches to address that bug, it does not fix it. However, this series also fixe real races on user and session states. This ensures that user_save() and s

[systemd-devel] [PATCH 1/7] logind: add function session_jobs_reply() to unify the create reply

2014-02-06 Thread Djalal Harouni
The session_send_create_reply() function which notifies clients about session creation is used for both session and user units. Unify the shared code in a new function session_jobs_reply(). The session_save() will be called unconditionally on sessions since it does not make sense to only call it i

[systemd-devel] [PATCH 2/7] logind: close races on user and session states during login

2014-02-06 Thread Djalal Harouni
Currently the user and session states are not stable, they are affected by several races during login: 1) session state: To get the session state the function session_get_state() is used. Opening state: At login the D-Bus CreateSession() method will call session_start() which calls user_start(

Re: [systemd-devel] [PATCH] systemd crashes if locale.conf contains invalid utf8 string

2014-02-06 Thread David Timothy Strauss
+1 on no crashing with invalid user input ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH 1/3] Add SELinuxContext configuration item

2014-02-06 Thread David Timothy Strauss
In order to maximize consistency with newly committed options in systemd-nspawn, would it make sense to allow independent configuration of the process and file labels instead? ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists

[systemd-devel] [PATCH] man: cryptsetup now allows partition device file in system mode

2014-02-06 Thread Jan Janssen
--- man/crypttab.xml | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/man/crypttab.xml b/man/crypttab.xml index 5f386e5..c563851 100644 --- a/man/crypttab.xml +++ b/man/crypttab.xml @@ -305,14 +305,7 @@ Use TrueCrypt in system

[systemd-devel] [PATCH] systemd crashes if locale.conf contains invalid utf8 string

2014-02-06 Thread Goffredo Baroncelli
In the parse_env_file_push() and load_env_file_push() functions, there are two assert() call to check if the key or value parameters are utf8 valid. If the strings aren't utf8 valid, assert does abort. These function are used early by systemd to parse some files. For example '/etc/locale.conf'.

Re: [systemd-devel] [PATCH] udev: Adding zram to inappropriate block device

2014-02-06 Thread Reindl Harald
Am 06.02.2014 18:45, schrieb Greg KH: > On Thu, Feb 06, 2014 at 04:54:59PM +, "Jóhann B. Guðmundsson" wrote: >> >> On 02/06/2014 03:39 PM, Greg KH wrote: > Right now you have to decide before loading the module how many > devices you want. And also when trying to use a device (any devi

Re: [systemd-devel] [PATCH] udev: Adding zram to inappropriate block device

2014-02-06 Thread Greg KH
On Thu, Feb 06, 2014 at 04:54:59PM +, "Jóhann B. Guðmundsson" wrote: > > On 02/06/2014 03:39 PM, Greg KH wrote: > >>>Right now you have to decide before loading the module how many > >>>devices you want. And also when trying to use a device (any device), > >>>you have to look for one. The same

Re: [systemd-devel] [PATCH] udev: Adding zram to inappropriate block device

2014-02-06 Thread Jóhann B. Guðmundsson
On 02/06/2014 03:39 PM, Greg KH wrote: >Right now you have to decide before loading the module how many >devices you want. And also when trying to use a device (any device), >you have to look for one. The same issues as with loop. Given that the code doesn't have the ability to dynamically add/

Re: [systemd-devel] [PATCHv2] tty: Set correct tty name in 'active' sysfs attribute

2014-02-06 Thread Greg Kroah-Hartman
On Thu, Feb 06, 2014 at 04:44:20PM +0100, Hannes Reinecke wrote: > On 02/06/2014 04:29 PM, Greg Kroah-Hartman wrote: > > On Thu, Feb 06, 2014 at 03:27:43PM +0100, Hannes Reinecke wrote: > >> The 'active' sysfs attribute should refer to the currently > >> active tty devices the console is running on

Re: [systemd-devel] fstrim "cron" job

2014-02-06 Thread Tom Gundersen
On Thu, Feb 6, 2014 at 4:51 PM, Karel Zak wrote: > On Sun, Dec 22, 2013 at 11:06:19AM +0100, Tom Gundersen wrote: >> On Sat, Dec 21, 2013 at 7:11 PM, Chris Murphy >> wrote: >> > >> > On Dec 21, 2013, at 6:44 AM, Kay Sievers wrote: >> > >> >> Trimming should be the job of the filesystem, not for

Re: [systemd-devel] fstrim "cron" job

2014-02-06 Thread Karel Zak
On Sun, Dec 22, 2013 at 11:06:19AM +0100, Tom Gundersen wrote: > On Sat, Dec 21, 2013 at 7:11 PM, Chris Murphy wrote: > > > > On Dec 21, 2013, at 6:44 AM, Kay Sievers wrote: > > > >> Trimming should be the job of the filesystem, not for a nasty cron > >> job. We do not want to support legacy file

Re: [systemd-devel] [PATCHv2] tty: Set correct tty name in 'active' sysfs attribute

2014-02-06 Thread Hannes Reinecke
On 02/06/2014 04:29 PM, Greg Kroah-Hartman wrote: > On Thu, Feb 06, 2014 at 03:27:43PM +0100, Hannes Reinecke wrote: >> The 'active' sysfs attribute should refer to the currently >> active tty devices the console is running on, not the currently >> active console. > > That's not what Documentation

Re: [systemd-devel] [PATCH] udev: Adding zram to inappropriate block device

2014-02-06 Thread Greg KH
On Thu, Feb 06, 2014 at 03:58:59AM +0100, Zbigniew Jędrzejewski-Szmek wrote: > On Thu, Feb 06, 2014 at 03:27:07AM +0100, Greg KH wrote: > > On Thu, Feb 06, 2014 at 01:31:37AM +0100, Zbigniew Jędrzejewski-Szmek wrote: > > > Patch applied. > > > > > > On Mon, Feb 03, 2014 at 10:33:37AM +, "Jóhan

Re: [systemd-devel] [PATCH] tty: Set correct tty name in 'active' sysfs attribute

2014-02-06 Thread Hannes Reinecke
On 02/05/2014 01:53 PM, David Herrmann wrote: > Hi > > On Wed, Feb 5, 2014 at 11:11 AM, Hannes Reinecke wrote: >> The 'active' sysfs attribute should refer to the currently >> active tty devices the console is running on, not the currently >> active console. >> The console structure doesn't refer

Re: [systemd-devel] Howto run systemd within a linux container

2014-02-06 Thread Daniel P. Berrange
On Thu, Feb 06, 2014 at 04:33:22PM +0100, Greg KH wrote: > On Thu, Feb 06, 2014 at 10:55:01AM +, Daniel P. Berrange wrote: > > On Wed, Feb 05, 2014 at 11:44:33PM +0100, Richard Weinberger wrote: > > > Hi! > > > > > > We're heavily using Linux containers in our production environment. > > > As

Re: [systemd-devel] Howto run systemd within a linux container

2014-02-06 Thread Greg KH
On Thu, Feb 06, 2014 at 10:55:01AM +, Daniel P. Berrange wrote: > On Wed, Feb 05, 2014 at 11:44:33PM +0100, Richard Weinberger wrote: > > Hi! > > > > We're heavily using Linux containers in our production environment. > > As modern Linux distributions move forward to systemd have to make sure

Re: [systemd-devel] Howto run systemd within a linux container

2014-02-06 Thread Daniel P. Berrange
On Wed, Feb 05, 2014 at 11:44:33PM +0100, Richard Weinberger wrote: > Hi! > > We're heavily using Linux containers in our production environment. > As modern Linux distributions move forward to systemd have to make sure that > systemd works within our containers. > > Sadly we're facing issues wit

[systemd-devel] [PATCH 3/3] Add support for ignoring errors on SELinuxContext by prefixing it with -, like for others settings.

2014-02-06 Thread Michael Scherer
Also remove call to security_check_context, as this doesn't serve anything, since setexeccon will fail anyway. --- man/systemd.exec.xml | 4 +++- src/core/execute.c | 14 -- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/man/systemd.exec.xml b/man/systemd.exec.xml

[systemd-devel] [PATCH 2/3] Ignore the setting SELinuxContext if selinux is not enabled

2014-02-06 Thread Michael Scherer
--- src/core/execute.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/execute.c b/src/core/execute.c index c02c768..474a4af 100644 --- a/src/core/execute.c +++ b/src/core/execute.c @@ -1569,7 +1569,7 @@ int exec_spawn(ExecCommand *command,

[systemd-devel] [PATCH 1/3] Add SELinuxContext configuration item

2014-02-06 Thread Michael Scherer
This permit to let system administrators decide of the domain of a service. This can be used with templated units to have each service in a différent domain ( for example, a per customer database, using MLS or anything ), or can be used to force a non selinux enabled system (jvm, erlang, etc) to st

[systemd-devel] [PATCH 0/3] SELinuxContext configuration, v2

2014-02-06 Thread Michael Scherer
This series of patch implement a SELinuxContext configuration item, whose usage is explained in the first mail. This patch series take in account the feedback received on http://lists.freedesktop.org/archives/systemd-devel/2013-December/015875.html Michael Scherer (3): Add SELinuxContext confi