[systemd-devel] [PATCH] Use strlen even for constant strings

2014-03-08 Thread Josh Triplett
GCC optimizes strlen("string constant") to a constant, even with -O0. Thus, replace patterns like sizeof("string constant")-1 with strlen("string constant") where possible, for clarity. In particular, for expressions intended to add up the lengths of components going into a string, this often make

Re: [systemd-devel] [HEADSUP] Formalizing Backports

2014-03-08 Thread Greg KH
On Sun, Mar 09, 2014 at 05:41:24AM +0100, Zbigniew Jędrzejewski-Szmek wrote: > On Sat, Mar 08, 2014 at 06:52:59PM -0800, Greg KH wrote: > > On Fri, Feb 28, 2014 at 02:34:15PM +0100, Lennart Poettering wrote: > > > Heya! > > > > > > Since a while now we have been adding Backport tags to git commits

[systemd-devel] The Bridge on the River PID EINS

2014-03-08 Thread poma
% STATIC OK! $ ll /etc/systemd/network/ ... enp3s0.network $ cat /etc/systemd/network/enp3s0.network [Match] Name=enp3s0 [Network] Address=192.168.2.2/24 Gateway=192.168.2.1 DNS=192.168.2.1 # journalctl -b -u systemd-netw

Re: [systemd-devel] [HEADSUP] Formalizing Backports

2014-03-08 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Mar 08, 2014 at 06:52:59PM -0800, Greg KH wrote: > On Fri, Feb 28, 2014 at 02:34:15PM +0100, Lennart Poettering wrote: > > Heya! > > > > Since a while now we have been adding Backport tags to git commits with > > "git notes". Zbigniew and Colin have now set up a new git repo with a > > "st

[systemd-devel] [PATCH] Add avoid_cleanup macro to cancel _cleanup_ of a pointer

2014-03-08 Thread Josh Triplett
avoid_cleanup also returns a copy of the pointer, making it convenient to use at the point where initialization completes, to hand the constructed object off somewhere without freeing it. Change all NULL assignments tagged with /* avoid cleanup */ to use this instead. --- Seems like a common patt

Re: [systemd-devel] [HEADSUP] Formalizing Backports

2014-03-08 Thread Greg KH
On Fri, Feb 28, 2014 at 02:34:15PM +0100, Lennart Poettering wrote: > Heya! > > Since a while now we have been adding Backport tags to git commits with > "git notes". Zbigniew and Colin have now set up a new git repo with a > "stable" branch where these are backported to selected versions, to > sh

Re: [systemd-devel] [systemd-commits] 2 commits - src/libsystemd src/network

2014-03-08 Thread Tom Gundersen
On Sat, Mar 8, 2014 at 6:23 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Fri, Mar 07, 2014 at 04:13:06PM -0800, Tom Gundersen wrote: >> src/libsystemd/sd-rtnl/rtnl-internal.h |2 +- >> src/network/networkd-link.c|6 ++ >> 2 files changed, 3 insertions(+), 5 deletions(-) >>

[systemd-devel] Minor improvement to footnote in http://freedesktop.org/wiki/Software/systemd/MinimalBuilds/

2014-03-08 Thread Samuli Suominen
To footnote of http://freedesktop.org/wiki/Software/systemd/MinimalBuilds/ "Because libcap doesn't have a pkg-config file yet, you can `export ac_cv_search_cap_init=yes` and `export ac_cv_header_sys_capability_h=yes` to skip the matching AC_CHECK_HEADERS and AC_SEARCH_LIBS checks from configure.ac

Re: [systemd-devel] [systemd-commits] 2 commits - src/libsystemd src/network

2014-03-08 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Mar 07, 2014 at 04:13:06PM -0800, Tom Gundersen wrote: > src/libsystemd/sd-rtnl/rtnl-internal.h |2 +- > src/network/networkd-link.c|6 ++ > 2 files changed, 3 insertions(+), 5 deletions(-) > > New commits: > commit 76800848f281c3705c9364fd3e888153d94aaf34 > Author

Re: [systemd-devel] [patch] Fix AC_PATH_PROG usage in configure.ac for systems with (still) bin vs. sbin distiction

2014-03-08 Thread Samuli Suominen
This version of the patch is likely more agreeable. No reason to add /usr/bin:/bin again to $PATH as it should be safe to expect at least they are there, or otherwise the system is really *broken*. :-) On 08/03/14 09:52, Samuli Suominen wrote: > If eg. setcap is in /sbin and user is building as a