[systemd-devel] [PATCH rebased] Use strlen even for constant strings

2014-03-15 Thread Josh Triplett
GCC optimizes strlen("string constant") to a constant, even with -O0. Thus, replace patterns like sizeof("string constant")-1 with strlen("string constant") where possible, for clarity. In particular, for expressions intended to add up the lengths of components going into a string, this often make

[systemd-devel] [PATCH] test-resolve.c: cleanup alittle bit and make use of sockaddr_pretty()

2014-03-15 Thread Daniel Buch
--- src/libsystemd/sd-resolve/test-resolve.c | 48 +++- 1 file changed, 22 insertions(+), 26 deletions(-) diff --git a/src/libsystemd/sd-resolve/test-resolve.c b/src/libsystemd/sd-resolve/test-resolve.c index d3b2d55..c9bcbfc 100644 --- a/src/libsystemd/sd-resolve/tes

Re: [systemd-devel] Fix machinectls machine completion

2014-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Mar 10, 2014 at 03:17:30PM +0100, Wieland Hoffmann wrote: > Hi, > > the following two patches fix machinectls machine name completion by > actually installing the required _sd_machines file using machinectls > --no-legend switch to prevent bogus entries from appearing in the list > of mach

Re: [systemd-devel] [RFC][PATCH v3 0/2] journald: add support for wall forwarding

2014-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Mar 14, 2014 at 12:37:56AM +0100, Sebastian Thorarensen wrote: > These patches add two new options for journald.conf: > * ForwardToWall (default yes) > * MaxLevelWall (default emerg) Note for mailing-list archives' sake: whole series applied by Lennart as 40b71e89bae4. Zbyszek __

Re: [systemd-devel] [PATCH 4/4] libsystemd-network: Add Init-Reboot support

2014-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Mar 13, 2014 at 01:01:52PM +0200, Patrik Flykt wrote: > Init-Reboot is tried if a client IP address has been given when > the DHCP client is started. In Init-Reboot, start by sending a > broadcasted DHCP Request including the supplied client IP address > but without the server identifier. A

Re: [systemd-devel] [systemd-commits] .gitignore Makefile.am src/timedate

2014-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Mar 13, 2014 at 04:39:37PM -0700, Kay Sievers wrote: > .gitignore|1 > Makefile.am | 27 + > src/timedate/test-timedate-sntp.c | 107 ++ > src/timedate/timedate-sntp.c | 652 > ++ > src/tim

Re: [systemd-devel] [PATCH] Use strlen even for constant strings

2014-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Mar 08, 2014 at 10:54:36PM -0800, Josh Triplett wrote: > GCC optimizes strlen("string constant") to a constant, even with -O0. (clang does too, btw). > Thus, replace patterns like sizeof("string constant")-1 with > strlen("string constant") where possible, for clarity. In particular, > fo

Re: [systemd-devel] [PATCH 2/4] libsystemd-network: Add hangcheck timer for DHCP client test

2014-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Mar 14, 2014 at 08:05:10PM +0100, Tom Gundersen wrote: > On Thu, Mar 13, 2014 at 12:01 PM, Patrik Flykt > wrote: > > --- > > src/libsystemd-network/test-dhcp-client.c | 16 > > 1 file changed, 16 insertions(+) > > > > diff --git a/src/libsystemd-network/test-dhcp-client.c

Re: [systemd-devel] [PATCH] man: improve wording of systemctl's --after/--before

2014-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Mar 13, 2014 at 09:03:09AM +0400, Andrey Borzenkov wrote: > В Wed, 12 Mar 2014 23:07:32 -0400 > "Jason St. John" пишет: > > > Commit 4a77ca7 was an attempt at fixing the wording of --after and --before, > > but the new wording was unclear. > > > > Split the combined --after/--before sect

Re: [systemd-devel] [RFC][PATCH v3 0/2] journald: add support for wall forwarding

2014-03-15 Thread Lennart Poettering
On Fri, 14.03.14 00:37, Sebastian Thorarensen (se...@naju.se) wrote: > These patches add two new options for journald.conf: > * ForwardToWall (default yes) > * MaxLevelWall (default emerg) > > When ForwardToWall is yes, journald forwards all log messages equal or > below MaxLevelWall to utmp_wa

Re: [systemd-devel] [RFC][PATCH v3 0/2] journald: add support for wall forwarding

2014-03-15 Thread Sebastian Thorarensen
On Fri, 14 Mar 2014, Lennart Poettering wrote: > Applied, but made some changes regarding allocation and how to deal with > errors. Please check! Thanks! Will do. -- Sebastian Thorarensen ___ systemd-devel mailing list systemd-devel@lists.freedesktop.

[systemd-devel] [PATCH] core, libsystemd, systemd, timedate, udev: spelling fixes

2014-03-15 Thread Miklos Vajna
--- src/core/service.c | 2 +- src/core/unit.c | 2 +- src/libsystemd/sd-bus/bus-message.c | 2 +- src/libsystemd/sd-bus/sd-bus.c | 4 ++-- src/systemd/sd-resolve.h| 2 +- src/timedate/timedated.c| 2 +- src/udev/udevadm-settle.c

Re: [systemd-devel] Passing variables from udev to unit

2014-03-15 Thread Lennart Poettering
On Fri, 14.03.14 08:53, Peter Hutterer (peter.hutte...@who-t.net) wrote: > Hey, > > I have a service file wacom-inputattach@.service that is started from a udev > rule: > > SUBSYSTEM=="tty|pnp", KERNEL=="ttyS[0-9]*", ATTRS{id}=="WACf*", > TAG+="systemd", ENV{SYSTEMD_WANTS}+="wacom-inputattac