Re: [systemd-devel] [PATCH] Drop the udev firmware loader

2014-05-30 Thread Cristian Rodríguez
El vie 30 may 2014 01:41:37 CLT, Samuli Suominen escribió: On 30/05/14 04:55, Greg KH wrote: On Fri, May 30, 2014 at 03:40:52AM +0200, Zbigniew Jędrzejewski-Szmek wrote: On Thu, May 29, 2014 at 08:54:22PM -0400, Cristian Rodríguez wrote: As discussed ad-nauseum previously, it is the kernel's

Re: [systemd-devel] [PATCH] Drop the udev firmware loader

2014-05-30 Thread Tom Gundersen
On 30 May 2014 03:10, Michael Biebl mbi...@gmail.com wrote: 2014-05-30 3:55 GMT+02:00 Greg KH gre...@linuxfoundation.org: On Fri, May 30, 2014 at 03:40:52AM +0200, Zbigniew Jędrzejewski-Szmek wrote: On Thu, May 29, 2014 at 08:54:22PM -0400, Cristian Rodríguez wrote: As discussed

Re: [systemd-devel] [PATCH] sd-dhcp-client: Sets broadcast flag to 1

2014-05-30 Thread Tom Gundersen
On Fri, May 30, 2014 at 3:24 AM, Camilo Aguilar camilo.agui...@gmail.com wrote: Hi Tom, the patch did not work because there is no layer2 file. Would it be safe to assume that no file is the same as the file having 0? This is out of my reach unfortunately, but I will be happy to read whatever

Re: [systemd-devel] [PATCH] sd-dhcp-client: Sets broadcast flag to 1

2014-05-30 Thread Patrik Flykt
On Thu, 2014-05-29 at 00:03 +0100, Tom Gundersen wrote: On Wed, May 28, 2014 at 7:43 PM, Camilo Aguilar camilo.agui...@gmail.com wrote: In systems running on hypervisors this flag needs to be set ON, so offers can reach the virtual machines. For more information please refer to this

Re: [systemd-devel] [PATCH] sd-dhcp-client: Sets broadcast flag to 1

2014-05-30 Thread Patrik Flykt
On Thu, 2014-05-29 at 18:18 +0100, Tom Gundersen wrote: + if (link-udev_device) { + const char *l2; + + l2 = udev_device_get_sysattr_value(link-udev_device, layer2); + if (l2) { + unsigned layer2; + + r = safe_atou(l2, layer2); + if (r 0)

Re: [systemd-devel] [PATCH] Drop the udev firmware loader

2014-05-30 Thread Samuli Suominen
On 30/05/14 09:17, Cristian Rodríguez wrote: El vie 30 may 2014 01:41:37 CLT, Samuli Suominen escribió: On 30/05/14 04:55, Greg KH wrote: On Fri, May 30, 2014 at 03:40:52AM +0200, Zbigniew Jędrzejewski-Szmek wrote: On Thu, May 29, 2014 at 08:54:22PM -0400, Cristian Rodríguez wrote: As

Re: [systemd-devel] git requires now linux api userspace headers = 3.13 to build?

2014-05-30 Thread Wulf C. Krueger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 31.03.2014 17:18, Tom Gundersen wrote: I remember reading a while back here = 3.7 being required and that being reworked to not require so new, but looks like something backfired there... Ah, my bad. I did the rework, but forgot to put in the

Re: [systemd-devel] [PATCH] Drop the udev firmware loader

2014-05-30 Thread Jóhann B. Guðmundsson
On 05/30/2014 02:51 AM, Greg KH wrote: On Fri, May 30, 2014 at 04:41:01AM +0200, Michael Biebl wrote: 2014-05-30 4:32 GMT+02:00 Michael Bieblmbi...@gmail.com: 2014-05-30 4:26 GMT+02:00 Greg KHgre...@linuxfoundation.org: You update systemd but you don't update the kernel? How does that

[systemd-devel] [PATCH] journald: collect process data from socket data

2014-05-30 Thread Piotr Wilczek
This patch adds posibility for journal to get process data from socket data (if available) instead of from procfs. Additionally a new procinfo structure is added to store all process data in single place. This data include creditentials and status. To enable this functionality, SO_PASSPROC

Re: [systemd-devel] [PATCH 1/2] man: Document server sockets in use by journald

2014-05-30 Thread Michal Sekletar
On Wed, May 28, 2014 at 10:30:56PM +0200, Lubomir Rintel wrote: --- man/systemd-journald.service.xml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/man/systemd-journald.service.xml b/man/systemd-journald.service.xml index f0ce7aa..715 100644 ---

Re: [systemd-devel] [PATCH] journald: collect process data from socket data

2014-05-30 Thread Michal Sekletar
On Fri, May 30, 2014 at 12:45:21PM +0200, Piotr Wilczek wrote: This patch adds posibility for journal to get process data from socket data (if available) instead of from procfs. Additionally a new procinfo structure is added to store all process data in single place. This data include

[systemd-devel] [PATCH v3 0/2] Move initscript parsing to a generator

2014-05-30 Thread Thomas H.P. Andersen
From: Thomas Hindoe Paaboel Andersen pho...@gmail.com Move initscript parsing to a generator Compared to the previous version this one includes a fix for initscripts that have no start priority. I have also updated the commit messages. The patches have a few warts that I consider irrelevant but

[systemd-devel] [PATCH v3 2/2] Remove sysv parser from service.c

2014-05-30 Thread Thomas H.P. Andersen
From: Thomas Hindoe Paaboel Andersen pho...@gmail.com Parsing sysv files was moved to the sysv-generator in the previous commit. This patch removes the sysv parsing from serivce.c. To avoid introducing an extra compat option in .service fies for identifying sysv services we instead add a check

[systemd-devel] [PATCH v3 1/2] Move handling of sysv initscripts to a generator

2014-05-30 Thread Thomas H.P. Andersen
From: Thomas Hindoe Paaboel Andersen pho...@gmail.com Reuses logic from service.c and the rc-local generator. Note that this drops reading of chkconfig entirely. It also drops reading runlevels from the LSB headers. The runlevels were only used to check for runlevels outside of the normal 1-5

Re: [systemd-devel] [PATCH] units: use KillMode=mixed for systemd-nspawn@.service

2014-05-30 Thread Zbigniew Jędrzejewski-Szmek
On Thu, May 29, 2014 at 01:17:25AM +1000, Jonathan Liu wrote: This causes the container to shut down cleanly when the service is stopped. --- units/systemd-nsp...@.service.in | 1 + 1 file changed, 1 insertion(+) diff --git a/units/systemd-nsp...@.service.in

Re: [systemd-devel] [PATCH] sd-dhcp-client: Sets broadcast flag to 1

2014-05-30 Thread Camilo Aguilar
I'd really hope we could avoid setting broadcast everywhere, as that seems very wasteful... I agree with you, broadcasting everywhere it's clearly not convenient. It seems to me the ideal path to move forward looks like this: 1. Use platform specific raw sockets for the first attempt of

Re: [systemd-devel] [PATCH] Drop the udev firmware loader

2014-05-30 Thread Greg KH
On Fri, May 30, 2014 at 12:50:50PM +0300, Samuli Suominen wrote: On 30/05/14 09:17, Cristian Rodríguez wrote: El vie 30 may 2014 01:41:37 CLT, Samuli Suominen escribió: On 30/05/14 04:55, Greg KH wrote: On Fri, May 30, 2014 at 03:40:52AM +0200, Zbigniew Jędrzejewski-Szmek wrote: On

Re: [systemd-devel] [PATCH] Drop the udev firmware loader

2014-05-30 Thread Samuli Suominen
On 30/05/14 17:13, Greg KH wrote: On Fri, May 30, 2014 at 12:50:50PM +0300, Samuli Suominen wrote: On 30/05/14 09:17, Cristian Rodríguez wrote: El vie 30 may 2014 01:41:37 CLT, Samuli Suominen escribió: On 30/05/14 04:55, Greg KH wrote: On Fri, May 30, 2014 at 03:40:52AM +0200, Zbigniew

Re: [systemd-devel] [PATCH] Drop the udev firmware loader

2014-05-30 Thread Greg KH
On Fri, May 30, 2014 at 06:05:19PM +0300, Samuli Suominen wrote: On 30/05/14 17:13, Greg KH wrote: On Fri, May 30, 2014 at 12:50:50PM +0300, Samuli Suominen wrote: On 30/05/14 09:17, Cristian Rodríguez wrote: El vie 30 may 2014 01:41:37 CLT, Samuli Suominen escribió: On 30/05/14 04:55,

[systemd-devel] [PATCH] localed: consider an unset model as a wildcard

2014-05-30 Thread Michal Sekletar
--- src/locale/localed.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/locale/localed.c b/src/locale/localed.c index e3061c8..358f6c2 100644 --- a/src/locale/localed.c +++ b/src/locale/localed.c @@ -712,15 +712,16 @@ static int find_legacy_keymap(Context

Re: [systemd-devel] [PATCH] sd-dhcp-client: Sets broadcast flag to 1

2014-05-30 Thread Tom Gundersen
On 30 May 2014 10:25, Patrik Flykt patrik.fl...@linux.intel.com wrote: On Thu, 2014-05-29 at 18:18 +0100, Tom Gundersen wrote: + if (link-udev_device) { + const char *l2; + + l2 = udev_device_get_sysattr_value(link-udev_device, layer2); + if (l2) { + unsigned

Re: [systemd-devel] [PATCH] sd-dhcp-client: Sets broadcast flag to 1

2014-05-30 Thread Tom Gundersen
On 30 May 2014 10:12, Patrik Flykt patrik.fl...@linux.intel.com wrote: On Thu, 2014-05-29 at 00:03 +0100, Tom Gundersen wrote: On Wed, May 28, 2014 at 7:43 PM, Camilo Aguilar camilo.agui...@gmail.com wrote: In systems running on hypervisors this flag needs to be set ON, so offers can

Re: [systemd-devel] [PATCH] Drop the udev firmware loader

2014-05-30 Thread Greg KH
On Thu, May 29, 2014 at 08:54:22PM -0400, Cristian Rodríguez wrote: As discussed ad-nauseum previously, it is the kernel's task to load firmware, not udev's. Ok, it turns out there is still one kernel driver that requires this to work properly, so we can't delete it just yet :( Now, if the

[systemd-devel] [PATCH] udev-builtin-keyboard: do tell on which device EVIOCSKEYCODE failed.

2014-05-30 Thread Cristian Rodríguez
I am getting Error calling EVIOCSKEYCODE (scan code 0xc022d, key code 418): Invalid argument, the error message does not tell on which specific device the problem is, add that info. --- src/udev/udev-builtin-keyboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [systemd-devel] [PATCH] Drop the udev firmware loader

2014-05-30 Thread Cristian Rodríguez
El 30/05/14 13:08, Greg KH escribió: On Thu, May 29, 2014 at 08:54:22PM -0400, Cristian Rodríguez wrote: As discussed ad-nauseum previously, it is the kernel's task to load firmware, not udev's. Ok, it turns out there is still one kernel driver that requires this to work properly, so we

Re: [systemd-devel] [PATCH] Drop the udev firmware loader

2014-05-30 Thread Tom Gundersen
On 30 May 2014 18:25, Cristian Rodríguez crrodrig...@opensuse.org wrote: El 30/05/14 13:08, Greg KH escribió: On Thu, May 29, 2014 at 08:54:22PM -0400, Cristian Rodríguez wrote: As discussed ad-nauseum previously, it is the kernel's task to load firmware, not udev's. Ok, it turns out