Re: [systemd-devel] [PATCH] nspawn: When exiting with an error, make the error code meaningful.

2014-06-29 Thread Djalal Harouni
On Mon, Jun 30, 2014 at 01:54:57AM +0100, Djalal Harouni wrote: > On Sun, Jun 29, 2014 at 07:59:38PM -0400, Luke Shumaker wrote: > > At Sun, 29 Jun 2014 12:31:13 +0100, > > Djalal Harouni wrote: > > > On Sat, Jun 28, 2014 at 12:09:56PM -0400, Luke Shumaker wrote: > > > > This is accomplished by hav

Re: [systemd-devel] [PATCH] nspawn: When exiting with an error, make the error code meaningful.

2014-06-29 Thread Djalal Harouni
On Sun, Jun 29, 2014 at 07:59:38PM -0400, Luke Shumaker wrote: > At Sun, 29 Jun 2014 12:31:13 +0100, > Djalal Harouni wrote: > > On Sat, Jun 28, 2014 at 12:09:56PM -0400, Luke Shumaker wrote: > > > This is accomplished by having wait_for_container() return a positive > > > error > > > code when we

[systemd-devel] [PATCH v2 2/3] nspawn: Fix regression with exit status

2014-06-29 Thread Luke Shumaker
Commit 113cea8 introduced a bug that caused the exit code of systemd-nspawn to not reflect the exit code of the program executed in the container. --- src/nspawn/nspawn.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/src/nspawn/nspawn.c b/src/nsp

[systemd-devel] [PATCH v2 3/3] nspawn: log a warning on failure from wait_for_terminate()

2014-06-29 Thread Luke Shumaker
This is at the suggestion of Djalal Harouni on the mailing list, and reflects the behavior of shared/util.c:wait_for_terminate_and_warn(). --- src/nspawn/nspawn.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/nspawn/nspawn.c b/src/nspawn/nspawn.c index be0e6b5..8fb72d6

[systemd-devel] [PATCH v2 1/3] shared/util.c:wait_for_terminate_and_warn(): Add a comment on the return values

2014-06-29 Thread Luke Shumaker
--- src/shared/util.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/shared/util.c b/src/shared/util.c index e7ff0f8..32358e5 100644 --- a/src/shared/util.c +++ b/src/shared/util.c @@ -3474,6 +3474,17 @@ int wait_for_terminate(pid_t pid, siginfo_t *status) { } } +

Re: [systemd-devel] [PATCH] fstab-generator: do not check btrfs and xfs

2014-06-29 Thread Marcos Mello
Kai Krakow gmail.com> writes: > > To check this, I've just pulled the original source from git and built it. > This is original upstream behavior, no special Gentoo thing. The fsck.btrfs > utility is just a shell script. It seems to originate from xfs-progs: > > https://github.com/josefbacik/b

Re: [systemd-devel] [PATCH] nspawn: When exiting with an error, make the error code meaningful.

2014-06-29 Thread Luke Shumaker
At Sun, 29 Jun 2014 12:31:13 +0100, Djalal Harouni wrote: > On Sat, Jun 28, 2014 at 12:09:56PM -0400, Luke Shumaker wrote: > > This is accomplished by having wait_for_container() return a positive error > > code when we would like that error code to make its way to the user. This > > is at odds wi

Re: [systemd-devel] [PATCH] fstab-generator: do not check btrfs and xfs

2014-06-29 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jun 30, 2014 at 01:17:47AM +0200, Kai Krakow wrote: > Zbigniew Jędrzejewski-Szmek schrieb: > > >> IMHO both xfs and btrfs should just not ship a fsck helper at all, not > >> even as a symlink. This workaround made sense at some point, but now I > >> believe both systemd _and_ fsck itself

Re: [systemd-devel] [PATCH] fstab-generator: do not check btrfs and xfs

2014-06-29 Thread Kai Krakow
Zbigniew Jędrzejewski-Szmek schrieb: >> IMHO both xfs and btrfs should just not ship a fsck helper at all, not >> even as a symlink. This workaround made sense at some point, but now I >> believe both systemd _and_ fsck itself can deal gracefully with a >> missing fsck helper. > IMHO, this shows

Re: [systemd-devel] [PATCH] fstab-generator: do not check btrfs and xfs

2014-06-29 Thread Kai Krakow
Stefan G. Weichinger schrieb: > Am 29.06.2014 23:52, schrieb Tom Gundersen: >> On Sun, Jun 29, 2014 at 11:31 PM, Stefan G. Weichinger >> wrote: >> >>> This is how gentoo currently implements things. So the devs there >>> should link it to /bin/true ? We could open a bug for that at >>> bugs.gen

Re: [systemd-devel] [PATCH] fstab-generator: do not check btrfs and xfs

2014-06-29 Thread Kai Krakow
Lennart Poettering schrieb: > On Sun, 29.06.14 21:51, Kai Krakow (hurikha...@gmail.com) wrote: > >> > This sounds really unnecessary, no? We already have fsck_exists() in >> > place that since a very recent commit of mine even detects a per-fstype >> > fsck implementation being linked to /bin/t

Re: [systemd-devel] Warning/error systemd-networkd

2014-06-29 Thread Luis Mauricio Costa
Hey, Tom. I'm glad to you for fixing this issue. Really worked for me. Now, no errors/warning. Thank you for feedback. Regards. Att, Luis Mauricio Costa. Cientista da Computação. On Sun, Jun 29, 2014 at 3:48 PM, Tom Gundersen wrote: > On Fri, Jun 20, 2014 at 10:17 PM, Luis Mauricio Costa

Re: [systemd-devel] [PATCH] fstab-generator: do not check btrfs and xfs

2014-06-29 Thread Tom Gundersen
On Mon, Jun 30, 2014 at 12:10 AM, Zbigniew Jędrzejewski-Szmek wrote: > On Sun, Jun 29, 2014 at 08:46:32PM +0200, Lennart Poettering wrote: >> This sounds really unnecessary, no? We already have fsck_exists() in >> place that since a very recent commit of mine even detects a per-fstype >> fsck imp

Re: [systemd-devel] [PATCH] fstab-generator: do not check btrfs and xfs

2014-06-29 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Jun 29, 2014 at 08:46:32PM +0200, Lennart Poettering wrote: > This sounds really unnecessary, no? We already have fsck_exists() in > place that since a very recent commit of mine even detects a per-fstype > fsck implementation being linked to /bin/true... I also downgraded all > warnings f

Re: [systemd-devel] systemd-networkd-wait-online and network.target

2014-06-29 Thread Tom Gundersen
On Wed, Jun 25, 2014 at 12:12 PM, Michael Olbrich wrote: > Commit 58e027023b47b32e42cf93dd4a629b869ee1ef25 'units: order > network-online.target after network.target' added "Before=network.target" > dependency to systemd-networkd-wait-online.service. Is that correct? If I > understand the document

Re: [systemd-devel] [PATCH] fstab-generator: do not check btrfs and xfs

2014-06-29 Thread Stefan G. Weichinger
Am 29.06.2014 23:52, schrieb Tom Gundersen: > On Sun, Jun 29, 2014 at 11:31 PM, Stefan G. Weichinger > wrote: > >> This is how gentoo currently implements things. So the devs there >> should link it to /bin/true ? We could open a bug for that at >> bugs.gentoo.org ... > > IMHO both xfs and btrfs

Re: [systemd-devel] [PATCH] fstab-generator: do not check btrfs and xfs

2014-06-29 Thread Tom Gundersen
On Sun, Jun 29, 2014 at 11:31 PM, Stefan G. Weichinger wrote: > Am 29.06.2014 23:24, schrieb Lennart Poettering: >> On Sun, 29.06.14 21:51, Kai Krakow (hurikha...@gmail.com) wrote: >>> # /sbin/fsck.btrfs /dev/sdb3 >>> If you wish to check the consistency of a BTRFS filesystem or >>> repair a damag

[systemd-devel] Misleading udev error messages regarding virtual interfaces

2014-06-29 Thread Leonid Isaev
Hi, I am seeing the following messages in my syslog on each boot: -- $ grep "link config " /var/log/errors.log 2014-06-29T09:31:39.000-04:00 hermes systemd-udevd[246]: Could not apply link config to br0 2014-06-29T09:31:40.000-04:00 hermes systemd-udevd[246]: Could not apply link con

Re: [systemd-devel] [PATCH] Add support for DHCP static route options in networkd

2014-06-29 Thread Tom Gundersen
On Fri, Jun 27, 2014 at 8:09 PM, Marcel Holtmann wrote: > Hi Lennart, > I am tempted to say that we should try to apply as much information from DHCP as we can by default, but make sure it doesn't become a security problem. i.e. we should probably use metrics or so so that manual ro

Re: [systemd-devel] [PATCH] Add support for DHCP static route options in networkd

2014-06-29 Thread Tom Gundersen
On Fri, Jun 27, 2014 at 7:58 PM, Lennart Poettering wrote: > On Thu, 26.06.14 12:49, Eugene Yakubovich (eyakubov...@gmail.com) wrote: > >> >> On Thu, Jun 26, 2014 at 11:17 AM, Lennart Poettering >> wrote: >> >> > I am tempted to say that we should try to apply as much information from >> > DHCP a

Re: [systemd-devel] [PATCH] unit: make unit can start without instance

2014-06-29 Thread Lennart Poettering
On Wed, 28.05.14 00:39, WaLyong Cho (walyong@samsung.com) wrote: Sorry for the late response! > I'm not sure this could be patch for below TODO. > > * enabling an instance unit creates a pointless link, and > the unit will be started with getty@getty.service: > $ systemctl enable getty

Re: [systemd-devel] [PATCH] fstab-generator: do not check btrfs and xfs

2014-06-29 Thread Stefan G. Weichinger
Am 29.06.2014 23:24, schrieb Lennart Poettering: > On Sun, 29.06.14 21:51, Kai Krakow (hurikha...@gmail.com) wrote: >> # /sbin/fsck.btrfs /dev/sdb3 >> If you wish to check the consistency of a BTRFS filesystem or >> repair a damaged filesystem, see btrfs(8) subcommand 'check'. > > Is this an upstr

Re: [systemd-devel] [PATCH] fstab-generator: do not check btrfs and xfs

2014-06-29 Thread Lennart Poettering
On Sun, 29.06.14 21:51, Kai Krakow (hurikha...@gmail.com) wrote: > > This sounds really unnecessary, no? We already have fsck_exists() in > > place that since a very recent commit of mine even detects a per-fstype > > fsck implementation being linked to /bin/true... I also downgraded all > > warn

Re: [systemd-devel] [systemd-commits] 6 commits - man/systemd.network.xml network/80-container-host0.network src/libsystemd-network src/network src/systemd units/local-fs.target

2014-06-29 Thread Tom Gundersen
On Sun, Jun 29, 2014 at 9:21 PM, Lennart Poettering wrote: > On Sun, 29.06.14 07:25, Tom Gundersen (tome...@kemper.freedesktop.org) wrote: > >> + >> +FOREACH_WORD(word, len, string, state) { >> +/* WORD FORMAT: dst_ip/dst_prefixlen,gw_ip */ >> +_cleanup_free

Re: [systemd-devel] [PATCH] fstab-generator: do not check btrfs and xfs

2014-06-29 Thread Kai Krakow
Lennart Poettering schrieb: > On Sat, 28.06.14 19:49, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) > wrote: > >> fsck.btrfs and fsck.xfs are documented to return immediately, so there is >> little sense in running them. Avoids some user confusion and a few lines >> in the logs. >> >> +stati

Re: [systemd-devel] [systemd-commits] 6 commits - man/systemd.network.xml network/80-container-host0.network src/libsystemd-network src/network src/systemd units/local-fs.target

2014-06-29 Thread Lennart Poettering
On Sun, 29.06.14 07:25, Tom Gundersen (tome...@kemper.freedesktop.org) wrote: > + > +FOREACH_WORD(word, len, string, state) { > +/* WORD FORMAT: dst_ip/dst_prefixlen,gw_ip */ > +_cleanup_free_ char* entry; missing initialization to NULL. > +

Re: [systemd-devel] [PATCH v2] Add support for DHCP static route options

2014-06-29 Thread Tom Gundersen
On Sat, Jun 28, 2014 at 12:00 AM, Eugene Yakubovich wrote: > This adds support for DHCP options 33 and 121: Static Route and > Classless Static Route. To enable this feature, set UseRoutes=true > in .network file. Returned routes are added to the routing table. Applied. Thanks! Tom > --- > man

Re: [systemd-devel] systemd-networkd: no network connectivity with 214/master due to 63a070415db09f5b5bcc5c

2014-06-29 Thread Tom Gundersen
Hi Camilo, Sorry for taking some time to get back to you. On Sat, Jun 21, 2014 at 9:08 PM, Camilo Aguilar wrote: > This is another reason why I previously suggested to expose a directive to > allow administrators to enable/disable the broadcast flag. I have seen DHCP > servers ignoring the flag

Re: [systemd-devel] Warning/error systemd-networkd

2014-06-29 Thread Tom Gundersen
On Fri, Jun 20, 2014 at 10:17 PM, Luis Mauricio Costa wrote: > When i try to start systemd-networkd "systemctl start systemd-networkd" with > conf file (pasted), service/daemon works, but returns this warning/error in > status: Hi Luis, Sorry for the delay in getting back to you. This should ha

Re: [systemd-devel] [PATCH] fstab-generator: do not check btrfs and xfs

2014-06-29 Thread Lennart Poettering
On Sat, 28.06.14 19:49, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > fsck.btrfs and fsck.xfs are documented to return immediately, so there is > little sense in running them. Avoids some user confusion and a few lines > in the logs. > > +static bool mount_skip_fsck(const char *fstype

Re: [systemd-devel] [PATCH] fstab-generator: do not check btrfs and xfs

2014-06-29 Thread Tom Gundersen
On Sat, Jun 28, 2014 at 7:49 PM, Zbigniew Jędrzejewski-Szmek wrote: > fsck.btrfs and fsck.xfs are documented to return immediately, so there is > little sense in running them. Avoids some user confusion and a few lines > in the logs. Is this special-casing really worth it? In general we don't kno

Re: [systemd-devel] [PATCH] fstab-generator: do not check btrfs and xfs

2014-06-29 Thread Jan Alexander Steffens
On Sun, Jun 29, 2014 at 6:08 PM, Andrey Borzenkov wrote: > This sounds far too specific for a generic tool. If I read this bug > report correctly, the primary complain was that systemd tries to > install fsck service even though fstab says skip fsck. This appears to > be the actual bug; I do not s

Re: [systemd-devel] [PATCH] fstab-generator: do not check btrfs and xfs

2014-06-29 Thread Andrey Borzenkov
В Sat, 28 Jun 2014 19:49:07 +0200 Zbigniew Jędrzejewski-Szmek пишет: > fsck.btrfs and fsck.xfs are documented to return immediately, so there is > little sense in running them. Avoids some user confusion and a few lines > in the logs. > > https://bugzilla.redhat.com/show_bug.cgi?id=1098799 This

Re: [systemd-devel] networkd losing dhcp lease with dracut / nfs root

2014-06-29 Thread Tom Gundersen
On Sat, Jun 28, 2014 at 11:29 AM, Tom Gundersen wrote: > Your analysis is correct. networkd is not updating the lft. > > We should change two things: dracut (or whatever is being used on your > machine) should set an infinite lifetime when using NFS root (IMHO), > and networkd should update the lf

Re: [systemd-devel] regression in a4a878d0 (units: introduce network-pre.target...)

2014-06-29 Thread Tom Gundersen
On Sat, Jun 28, 2014 at 6:36 AM, Gerardo Exequiel Pozzi wrote: > Looks like this commit also changes a unrelated file > (units/local-fs.target) reverting the commit 40f862e3 (filesystem > targets: disable default dependencies) > > The side effect, at least in my case is that the "nofail" option in

Re: [systemd-devel] [PATCH 3/4] connection: use the already cached metadata if KDBUS_HELLO_CACHE_META is set

2014-06-29 Thread Djalal Harouni
On Fri, Jun 27, 2014 at 01:02:19PM +0200, Daniel Mack wrote: > On 06/27/2014 12:46 PM, Kay Sievers wrote: > > On Fri, Jun 27, 2014 at 12:32 PM, Djalal Harouni wrote: > >> For connections with the KDBUS_HELLO_CACHE_META flag dup the > >> metadata/credentials from handle or from the HELLO cmd, and u

Re: [systemd-devel] [PATCH v2 ] hostnamectl: correct IDs for remote hosts

2014-06-29 Thread Zbigniew Jędrzejewski-Szmek
Ping? On Tue, Jun 03, 2014 at 08:47:37PM +0200, Lennart Poettering wrote: > On Sun, 01.06.14 20:53, Rico Sagner (sag...@b1-systems.de) wrote: > > > > > +static int property_get_machineid( > > +sd_bus *bus, > > +const char *path, > > +const char *i

Re: [systemd-devel] [PATCH] nspawn: When exiting with an error, make the error code meaningful.

2014-06-29 Thread Djalal Harouni
Hi, You are right, commit 113cea8 introduced this regression, we guarantee that nspawn returns the exit code of the program executed in the container in case nspwan wont fail. My bad, I missed this point... sorry! Ok will comment on this patch, the other one is wrong, since we mix -errno with exi

Re: [systemd-devel] SIT tunnel does not work

2014-06-29 Thread Tomasz Torcz
On Thu, Jun 26, 2014 at 11:01:30AM +0530, Susant Sahani wrote: > >>Name=em1 <==interface name > > > > After putting in interface name tunnel is still not created: > > > could send do ip link output. Hi, just to recollect, current configuration: he.netdev: -- [NetDev] Name=h

Re: [systemd-devel] Locking current session programmatically

2014-06-29 Thread Kirill Elagin
Right, sorry, I was probably thinking about something different. Speaking about marking `.Lock` non-privileged, I'd like to point out that there is also `.Unlock` and so, by making one of them non-privileged and the other one privileged, we kind of introduce asymmetry. On the other hand, making `.

Re: [systemd-devel] Locking current session programmatically

2014-06-29 Thread Mantas Mikulėnas
A session manager is *not necessary* for this; the screensaver or screenlocker itself could easily listen to the relevant DBus signals (e.g. cinnamon-screensaver does this). See also: xss-lock, systemd-lock-handler. -- Mantas Mikulėnas // sent from phone On Jun 29, 2014 1:02 PM, "Kirill Elagin"

Re: [systemd-devel] Locking current session programmatically

2014-06-29 Thread Kirill Elagin
If you don't have a DE you don't have a session manager either, so systemd-logind can't help you anyway. Indeed, you should just run your screenlocker. -- Кирилл Елагин On Sun, Jun 29, 2014 at 9:57 AM, Ivan Shapovalov wrote: > >> 27 июня 2014 г., в 21:54, Lennart Poettering > написал(а): > >