Re: [systemd-devel] systemd-socket-proxyd & slapd

2014-07-16 Thread Suvendu Mitra
I have changed proxy-to-directory-400.service as # cat proxy-to-directory-400.service [Unit] Requires=vgp.master-ldap-400.service After=vgp.master-ldap-400.service JoinsNamespaceOf=vgp.master-ldap-400.service [Service] ExecStart=/usr/lib/systemd/systemd-socket-proxyd ${HOSTNA

Re: [systemd-devel] Socket activated SSHD service showing up as a failure when the client connection fReply-To:

2014-07-16 Thread Roger Qiu
I've googled around and saw that 255 error code comes up a lot. But most resources talked about "ssh" not necessarily the "sshd". If we ignore 255 code, is it possible we're also ignoring some other real errors, and not just the client failing the connection? Basically I would like sshd to repo

Re: [systemd-devel] Socket activated SSHD service showing up as a failure when the client connection fReply-To:

2014-07-16 Thread Roger Qiu
You mean something like this: ``` $ cat /nix/store/wr8r8jrj204q3i0v4vfav8m63ssnv8w1-unit/sshd@.service [Unit] Description=SSH Daemon [Service] Environment="LD_LIBRARY_PATH=/nix/store/sk3017fxx2vhj69saizk5634y3w6hqhn-systemd-212/lib" Environment="LOCALE_ARCHIVE=/nix/store/5jxnz56h6ya1wy0dvcll65v

Re: [systemd-devel] Socket activated SSHD service showing up as a failure when the client connection fReply-To:

2014-07-16 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jul 17, 2014 at 12:53:01PM +1000, Roger Qiu wrote: > Hello, > > This is the log of the status codes: > > ``` > ● sshd@3-10.0.2.15:22-10.0.2.2:51014.service - SSH Daemon (10.0.2.2:51014) >Loaded: loaded > (/nix/store/wr8r8jrj204q3i0v4vfav8m63ssnv8w1-unit/sshd@.service) >Active: fai

Re: [systemd-devel] Socket activated SSHD service showing up as a failure when the client connection fReply-To:

2014-07-16 Thread Roger Qiu
Hello, This is the log of the status codes: ``` ● sshd@3-10.0.2.15:22-10.0.2.2:51014.service - SSH Daemon (10.0.2.2:51014) Loaded: loaded (/nix/store/wr8r8jrj204q3i0v4vfav8m63ssnv8w1-unit/sshd@.service) Active: failed (Result: exit-code) since Thu 2014-07-17 02:24:01 UTC; 2min 21s ago

Re: [systemd-devel] Socket activated SSHD service showing up as a failure when the client connection fReply-To:

2014-07-16 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jul 17, 2014 at 12:40:59PM +1000, Roger Qiu wrote: > Hello everybody, > > I recently discovered that when using a socket activated SSHD > service on NixOS, it will show up as a failure on `sudo systemctl > status` when the client fails the connection. > > The details are in this issue: ht

Re: [systemd-devel] [PATCH] smack: check smack cache after /sys mount

2014-07-16 Thread WaLyong Cho
On 07/17/2014 04:40 AM, Zbigniew Jędrzejewski-Szmek wrote: > On Thu, Jul 17, 2014 at 01:29:38AM +0900, WaLyong Cho wrote: >> use_smack_cached is capability of smack. That is not changed on >> runtime. So that should be a cache for performance. But the cache is >> updated as wrong value(maybe 0) upo

Re: [systemd-devel] [PATCH 05/10] rules: skip 99-systemd.rules when not running systemd as init

2014-07-16 Thread microcai
在 2014年7月16日 星期三 20:45:56,Jon Severinsson 写道: > The file still contains one RUN+="@rootlibexecdir@/systemd-sysctl ...", > which I don't think is desirable when systemd is installed but not running > as PID 1 (which we also have to support). support for the sake of support is a bad syndrom. _

[systemd-devel] Socket activated SSHD service showing up as a failure when the client connection fails

2014-07-16 Thread Roger Qiu
Hello everybody, I recently discovered that when using a socket activated SSHD service on NixOS, it will show up as a failure on `sudo systemctl status` when the client fails the connection. The details are in this issue: https://github.com/NixOS/nixpkgs/issues/3279 Basically all I need to d

Re: [systemd-devel] Logind error - Failed to abandon session scope: Connection reset

2014-07-16 Thread Roger Qiu
Hello Lennart, Are you saying that logind should be terminated first then dbus should be terminated second? In what situations would their termination sequence get mixed? Thanks, Roger On 17/07/2014 1:14 AM, Lennart Poettering wrote: On Wed, 16.07.14 14:53, Roger Qiu (roger@polycademy.c

[systemd-devel] journal-upload benchmarks

2014-07-16 Thread Zbigniew Jędrzejewski-Szmek
Hi, as a rough guide: src/journal-remote/log-generator.py 1 > f NO compression: time nc --send-only -v localhost 2001 < f 177029931 bytes 2.25s 2.23s 2.216s time build/systemd-journal-upload -u http://localhost:2001 - < f 177029931 bytes 2.143s 2.100s 2.125s time build/systemd-journal-u

Re: [systemd-devel] [PATCH] Add tool to query resolved

2014-07-16 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jul 17, 2014 at 12:36:17AM +0300, Mantas Mikulėnas wrote: > For testing, if the nss module is installed but not configured, > `getent --service="resolve" ahosts google.com` might work... Yes, but there's no way to extract interface information with the standard interfaces. Zbyszek

Re: [systemd-devel] [PATCH 08/10] units: make it possible to disable tmp.mount using systemctl

2014-07-16 Thread Michael Biebl
2014-07-16 16:59 GMT+02:00 Lennart Poettering : > > THis wouldn't work the way you might expect. RequiresMountsFor= I don't think we actually have a unit which has RequiresMountsFor=tmp.mount and if there was, I would consider that broken. -- Why is it that all of the instruments seeking intell

Re: [systemd-devel] systemd-socket-proxyd & slapd

2014-07-16 Thread David Timothy Strauss
On Wed, Jul 16, 2014 at 7:29 AM, Zbigniew Jędrzejewski-Szmek wrote: > This won't work, since proxyd now cannot connect to port 400. There is now a way to make that work with JoinsNamespaceOf= ___ systemd-devel mailing list systemd-devel@lists.freedeskto

Re: [systemd-devel] [PATCH] Add tool to query resolved

2014-07-16 Thread Mantas Mikulėnas
For testing, if the nss module is installed but not configured, `getent --service="resolve" ahosts google.com` might work... -- Mantas Mikulėnas ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/lis

[systemd-devel] [PATCH] Add tool to query resolved

2014-07-16 Thread Zbigniew Jędrzejewski-Szmek
--- Useful? Maybe as a test binary? Zbyszek .gitignore | 1 + Makefile.am | 10 ++ src/resolve-host/Makefile | 1 + src/resolve-host/resolve-host.c | 277 4 files changed, 289 insertions(+) create mode

Re: [systemd-devel] [PATCH] smack: check smack cache after /sys mount

2014-07-16 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jul 17, 2014 at 01:29:38AM +0900, WaLyong Cho wrote: > use_smack_cached is capability of smack. That is not changed on > runtime. So that should be a cache for performance. But the cache is > updated as wrong value(maybe 0) upon calling first mount_one. At this > time, until v210 "/proc" wi

Re: [systemd-devel] [PATCH 08/10] units: make it possible to disable tmp.mount using systemctl

2014-07-16 Thread Uoti Urpala
On Wed, 2014-07-16 at 20:22 +0200, Tollef Fog Heen wrote: > ]] Lennart Poettering > > > (Also I see little point in /tmp not being a tmpfs anyway. If you want a > > lot of space there, then use swap -- of which you can have up to 2G even > > on 32bit systems. tmpfs on on swap has the great benefi

Re: [systemd-devel] [PATCH 05/10] rules: skip 99-systemd.rules when not running systemd as init

2014-07-16 Thread Jon Severinsson
onsdagen den 16 juli 2014 16:49:55 skrev Lennart Poettering: > On Wed, 16.07.14 12:09, Jon Severinsson (j...@severinsson.net) wrote: > > From: Tollef Fog Heen > > If you really want to support systems without systemd installed, then I'd > recommend placing this rules file in the systemd pacakge,

Re: [systemd-devel] [PATCH 08/10] units: make it possible to disable tmp.mount using systemctl

2014-07-16 Thread Tollef Fog Heen
]] Lennart Poettering > (Also I see little point in /tmp not being a tmpfs anyway. If you want a > lot of space there, then use swap -- of which you can have up to 2G even > on 32bit systems. tmpfs on on swap has the great benefit that it > relieves the kernel from always having to utimately flus

Re: [systemd-devel] [PATCH 05/10] rules: skip 99-systemd.rules when not running systemd as init

2014-07-16 Thread Tollef Fog Heen
]] Lennart Poettering > On Wed, 16.07.14 12:09, Jon Severinsson (j...@severinsson.net) wrote: > > > From: Tollef Fog Heen > > If you really want to support systems without systemd installed, then I'd > recommend placing this rules file in the systemd pacakge, so that it is > gone if you uninst

Re: [systemd-devel] [PATCH 09/10] kmod-static-nodes: condition execution on kmod binary

2014-07-16 Thread Jon Severinsson
onsdagen den 16 juli 2014 16:52:57 skrev Lennart Poettering: > This appears unnecessary. The unit is conditionalized anyway on > CAP_SYS_MODULE, which is something a container should never ever have. OK, then I would like to nominate "e0c7469 units: conditionalize static device node logic on CAP

Re: [systemd-devel] [PATCH 04/10] rules: set default polling interval on removable devices as well

2014-07-16 Thread Samuli Suominen
On 16/07/14 14:01, Kay Sievers wrote: > On Wed, Jul 16, 2014 at 12:09 PM, Jon Severinsson > wrote: >> From: Martin Pitt >> >> The events_dfl_poll_msecs rule will not trigger if "block" is not a module, >> but >> built in. This will avoid udisks etc. having to poll from userspace, and >> provid

[systemd-devel] [PATCH] smack: check smack cache after /sys mount

2014-07-16 Thread WaLyong Cho
use_smack_cached is capability of smack. That is not changed on runtime. So that should be a cache for performance. But the cache is updated as wrong value(maybe 0) upon calling first mount_one. At this time, until v210 "/proc" will be tried. After v211 "/sys" will be tried. But both of first trial

Re: [systemd-devel] [PATCH] sysv-generator: do not generate 'Wants' symlinks to generated service files that will be shadowed by a native unit.

2014-07-16 Thread Jon Severinsson
At Wednesday 16 July 2014 17:17:40 Lennart Poettering wrote: > I am a bit concerned about this, as we will never be able to find all > the units that PID 1 will find, for example because generated units are > not included in the client's search paths... Right, but those cases have never been a pro

Re: [systemd-devel] [PATCH] sysv-generator: do not generate 'Wants' symlinks to generated service files that will be shadowed by a native unit.

2014-07-16 Thread Lennart Poettering
On Wed, 16.07.14 11:57, Jon Severinsson (j...@severinsson.net) wrote: I am a bit concerned about this, as we will never be able to find all the units that PID 1 will find, for example because generated units are not included in the client's search paths... What's the precise issue that this fixes

Re: [systemd-devel] Logind error - Failed to abandon session scope: Connection reset

2014-07-16 Thread Lennart Poettering
On Wed, 16.07.14 14:53, Roger Qiu (roger@polycademy.com) wrote: > Hello everybody, > > I always receive this error: > > ``` > > |Jul 14 08:27:57 matrix-node systemd-logind[1339]: Failed to abandon session > scope: Connection reset by peer| > > ``` > > When I shutdown a NixOS instance. >

Re: [systemd-devel] [PATCH] conf parser: introduce milisecond parsing

2014-07-16 Thread Lennart Poettering
On Wed, 16.07.14 16:28, Susant Sahani (sus...@redhat.com) wrote: > > On 07/16/2014 01:07 PM, Susant Sahani wrote: > >Add millisecord parsing support to conf parser. > > > >Immediate usage of this function is to parse bond options > >such as MIIMonitor, UpDelayMSec, DownDelayMSec which is > >repre

Re: [systemd-devel] [PATCH 08/10] units: make it possible to disable tmp.mount using systemctl

2014-07-16 Thread Lennart Poettering
On Wed, 16.07.14 13:51, Jon Severinsson (j...@severinsson.net) wrote: > > > tmp.mount is part of our default expected setup and should behave like > > this by default without any presets or configuration. > > Which is why I made `make install` enable it, which wasn't in the original > patch for

Re: [systemd-devel] [PATCH 09/10] kmod-static-nodes: condition execution on kmod binary

2014-07-16 Thread Lennart Poettering
On Wed, 16.07.14 12:09, Jon Severinsson (j...@severinsson.net) wrote: > From: Michael Biebl > > Creating the list of dead device nodes requires kmod. Inside containers > this is not strictly required so we don't want a hard dependency on the > kmod package. If the binary does not exist kmod-stat

Re: [systemd-devel] [PATCH 08/10] units: make it possible to disable tmp.mount using systemctl

2014-07-16 Thread Lennart Poettering
On Wed, 16.07.14 12:09, Jon Severinsson (j...@severinsson.net) wrote: > From: Michael Stapelberg > > But enable it by default in make install and systemd preset. THis wouldn't work the way you might expect. RequiresMountsFor= and suchlike would still pull in the mount unit, regardless if it is

Re: [systemd-devel] [PATCH 05/10] rules: skip 99-systemd.rules when not running systemd as init

2014-07-16 Thread Lennart Poettering
On Wed, 16.07.14 12:09, Jon Severinsson (j...@severinsson.net) wrote: > From: Tollef Fog Heen If you really want to support systems without systemd installed, then I'd recommend placing this rules file in the systemd pacakge, so that it is gone if you uninstall systemd. That said, nothing of wh

Re: [systemd-devel] systemd-socket-proxyd & slapd

2014-07-16 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jul 16, 2014 at 03:45:53PM +0300, Suvendu Mitra wrote: > want to start slapd with socket activation via 'systemd-socket-proxyd' , > > I can see that slapd is listening to port 400 & sytemd create socket at > 401. But ldapsearch doesn't work with port 401. Any help !! > >

Re: [systemd-devel] [PATCH 07/10] units: order remote-fs.target after local-fs.target

2014-07-16 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jul 16, 2014 at 03:56:27PM +0200, Jon Severinsson wrote: > > So the only thing it does is that it'll delay remote-fs.target if it were to > > be reached before local-fs.target. > > Which in my oppinion is a good thing, as writers of service files, as well as > legacy init scripts, should

Re: [systemd-devel] Misc patches from the Debian systemd package

2014-07-16 Thread Jóhann B. Guðmundsson
On 07/16/2014 01:56 PM, Jon Severinsson wrote: Well, I did filter out 30 Debian-specific hacks, 40 downstream distribution specific hacks for just component in Debian ( and one init system ). It would be interesting to see how much added maintenance burdens takes place in the Debian commun

Re: [systemd-devel] Misc patches from the Debian systemd package

2014-07-16 Thread Jon Severinsson
At Wednesday 16 July 2014 15:14:59 Jóhann B. Guðmundsson wrote: > It should not come as a surprise to anyone given that Debian has such an > diverse user base that there exist mass hacks in the distribution to > please them all so filtering is needed/expected before things are being > submitted ups

Re: [systemd-devel] [PATCH 07/10] units: order remote-fs.target after local-fs.target

2014-07-16 Thread Jon Severinsson
On Wed, Jul 16, 2014 at 12:57:41PM +0200, Tom Gundersen wrote: > If this is merely for sysv compat, it feels wrong to add this in the > native unit files (but maybe the argument could be made regardless?). That was indeed the original reason for the patch, but I believe it to be the right thing t

Re: [systemd-devel] Misc patches from the Debian systemd package

2014-07-16 Thread Jóhann B. Guðmundsson
On 07/16/2014 01:05 PM, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Jul 16, 2014 at 01:03:15PM +, "Jóhann B. Guðmundsson" wrote: > >On 07/16/2014 10:09 AM, Jon Severinsson wrote: > >Hi > > > >I'm part of the team working on updating the Debian systemd package to v214. > >As part of that wor

Re: [systemd-devel] Misc patches from the Debian systemd package

2014-07-16 Thread Kay Sievers
On Wed, Jul 16, 2014 at 3:03 PM, "Jóhann B. Guðmundsson" wrote: > > On 07/16/2014 10:09 AM, Jon Severinsson wrote: >> >> I'm part of the team working on updating the Debian systemd package to >> v214. >> As part of that work I have been rebasing and updating the Debian specific >> patches, and fou

Re: [systemd-devel] [PATCH 08/10] units: make it possible to disable tmp.mount using systemctl

2014-07-16 Thread Kay Sievers
On Wed, Jul 16, 2014 at 2:57 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Wed, Jul 16, 2014 at 01:51:13PM +0200, Jon Severinsson wrote: >> > tmp.mount is part of our default expected setup and should behave like >> > this by default without any presets or configuration. >> >> Which is why I made `m

Re: [systemd-devel] Misc patches from the Debian systemd package

2014-07-16 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jul 16, 2014 at 01:03:15PM +, "Jóhann B. Guðmundsson" wrote: > > On 07/16/2014 10:09 AM, Jon Severinsson wrote: > >Hi > > > >I'm part of the team working on updating the Debian systemd package to v214. > >As part of that work I have been rebasing and updating the Debian specific > >pat

Re: [systemd-devel] Misc patches from the Debian systemd package

2014-07-16 Thread Jóhann B. Guðmundsson
On 07/16/2014 10:09 AM, Jon Severinsson wrote: Hi I'm part of the team working on updating the Debian systemd package to v214. As part of that work I have been rebasing and updating the Debian specific patches, and found several that might be appropriate for upstream. While I'm not the origina

Re: [systemd-devel] [PATCH 08/10] units: make it possible to disable tmp.mount using systemctl

2014-07-16 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jul 16, 2014 at 01:51:13PM +0200, Jon Severinsson wrote: > > tmp.mount is part of our default expected setup and should behave like > > this by default without any presets or configuration. > > Which is why I made `make install` enable it, which wasn't in the original > patch for Debian.

Re: [systemd-devel] [PATCH 07/10] units: order remote-fs.target after local-fs.target

2014-07-16 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jul 16, 2014 at 12:57:41PM +0200, Tom Gundersen wrote: > On Wed, Jul 16, 2014 at 12:09 PM, Jon Severinsson > wrote: > > From: Michael Biebl > > > > This change was part of the old debianisation branch created by Tollef > > and reflects the fact that on Debian the $remote_fs system facili

Re: [systemd-devel] [PATCH] tmpfiles: only execute chmod()/chown() when needed

2014-07-16 Thread Michael Olbrich
On Fri, Jul 11, 2014 at 03:52:21PM -0700, Colin Walters wrote: > On Fri, Jul 11, 2014, at 03:04 PM, Dave Reisner wrote: > > No way. This precludes tmpfiles from creating directories in /run. > > Yeah that suggestion would break other stuff too, ignore it. > > This does get into the ostree commit

[systemd-devel] systemd-socket-proxyd & slapd

2014-07-16 Thread Suvendu Mitra
want to start slapd with socket activation via 'systemd-socket-proxyd' , I can see that slapd is listening to port 400 & sytemd create socket at 401. But ldapsearch doesn't work with port 401. Any help !! --- 1. $ cat proxy-to-directory-400.socket [Socket] ListenStream=401 [Inst

Re: [systemd-devel] [PATCH] sysv-generator: do not generate 'Wants' symlinks to generated service files that will be shadowed by a native unit.

2014-07-16 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jul 16, 2014 at 01:00:18PM +0200, Jon Severinsson wrote: > onsdagen den 16 juli 2014 12:48:23 skrev du: > > On Wed, Jul 16, 2014 at 11:57 AM, Jon Severinsson > > wrote: > > > +/* Do not generate 'Wants' symlinks to the generated service > > > file if it > > > + * will be

Re: [systemd-devel] [PATCH 08/10] units: make it possible to disable tmp.mount using systemctl

2014-07-16 Thread Jon Severinsson
> tmp.mount is part of our default expected setup and should behave like > this by default without any presets or configuration. Which is why I made `make install` enable it, which wasn't in the original patch for Debian. > It can be overridden by an entry in fstab just fine. Why is that needed?

Re: [systemd-devel] [PATCH 05/10] rules: skip 99-systemd.rules when not running systemd as init

2014-07-16 Thread Martin Pitt
Jon Severinsson [2014-07-16 12:09 +0200]: > ACTION=="remove", GOTO="systemd_end" > +TEST!="/run/systemd/system", GOTO="systemd_end" I'm fairly sure that this is obsolete. Can you please test without this? Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.

Re: [systemd-devel] [PATCH 03/10] rules: load sg module from 80-drivers.rules

2014-07-16 Thread Martin Pitt
Kay Sievers [2014-07-16 12:53 +0200]: > On Wed, Jul 16, 2014 at 12:09 PM, Jon Severinsson > wrote: > > From: Martin Pitt > > > > Taken from the Debian specific rules, this is the remaining difference over > > the > > upstream 80-drivers.rules. > > > > Bug-Debian: http://bugs.debian.org/657948 >

Re: [systemd-devel] [PATCH 02/10] rules: updates to default device permissions in 50-udev-default.rules

2014-07-16 Thread Martin Pitt
Hello Jon, Jon Severinsson [2014-07-16 12:09 +0200]: > Taken from the previous Debian specific rules, this is the remaining > difference > over the upstream 50-udev-default.rules. I deliberately didn't forward that upstream, as most of these are ancient hacks which are mostly required for not br

Re: [systemd-devel] [PATCH 06/10] tmpfiles: fix permissions of /run/lock and /run/lock/lockdev

2014-07-16 Thread Jon Severinsson
onsdagen den 16 juli 2014 12:15:09 skrev du: > Why do you think this should be changed? Mostly because this is the way it has always been done in Debian, and changing it breaks some existing init scripts, but I'm ok with continuing to carry it as a Debian specific patch if it is not considered app

Re: [systemd-devel] [PATCH 06/10] tmpfiles: fix permissions of /run/lock and /run/lock/lockdev

2014-07-16 Thread Tollef Fog Heen
]] Jon Severinsson > From: Tollef Fog Heen This one shouldn't be forwarded upstream, /run/lock has historically had different permissions in Debian and I'd rather get that fixed than pushing this upstream. -- Tollef Fog Heen UNIX is user friendly, it's just picky about who its friends are ___

Re: [systemd-devel] [PATCH 06/10] tmpfiles: fix permissions of /run/lock and /run/lock/lockdev

2014-07-16 Thread Kay Sievers
On Wed, Jul 16, 2014 at 12:18 PM, Mantas Mikulėnas wrote: > On Wed, Jul 16, 2014 at 1:09 PM, Jon Severinsson wrote: >> -d /run/lock 0755 root root - >> +d /run/lock 1777 root root - > > Won't any user be able to break the system by filling /run, if it has > world-writable directories? IIRC, this

Re: [systemd-devel] [PATCH 03/10] rules: load sg module from 80-drivers.rules

2014-07-16 Thread Marco d'Itri
On Jul 16, Kay Sievers wrote: > > +SUBSYSTEM=="scsi", ENV{DEVTYPE}=="scsi_device", TEST!="[module/sg]", > > RUN{builtin}+="kmod load sg" > We do not want to force-load the sg driver. Why would that be needed? When we tried removing this some application stopped working, but I do not remember wh

Re: [systemd-devel] [PATCH 04/10] rules: set default polling interval on removable devices as well

2014-07-16 Thread Kay Sievers
On Wed, Jul 16, 2014 at 12:09 PM, Jon Severinsson wrote: > From: Martin Pitt > > The events_dfl_poll_msecs rule will not trigger if "block" is not a module, > but > built in. This will avoid udisks etc. having to poll from userspace, and > provide proper ejection when the hardware eject button i

Re: [systemd-devel] [PATCH] sysv-generator: do not generate 'Wants' symlinks to generated service files that will be shadowed by a native unit.

2014-07-16 Thread Jon Severinsson
onsdagen den 16 juli 2014 12:48:23 skrev du: > On Wed, Jul 16, 2014 at 11:57 AM, Jon Severinsson > wrote: > > +/* Do not generate 'Wants' symlinks to the generated service file > > if it > > + * will be shadowed by an existing native unit, as the symlinks > > would > > +

Re: [systemd-devel] [PATCH 10/10] shared: include stdbool.h in mkdir.h

2014-07-16 Thread Kay Sievers
On Wed, Jul 16, 2014 at 12:09 PM, Jon Severinsson wrote: > From: Sjoerd Simons > > --- > src/shared/mkdir.h | 1 + > 1 file changed, 1 insertion(+) Applied. Thanks, Kay ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.f

Re: [systemd-devel] [PATCH 08/10] units: make it possible to disable tmp.mount using systemctl

2014-07-16 Thread Kay Sievers
On Wed, Jul 16, 2014 at 12:09 PM, Jon Severinsson wrote: > From: Michael Stapelberg > > But enable it by default in make install and systemd preset. tmp.mount is part of our default expected setup and should behave like this by default without any presets or configuration. It can be overridden

Re: [systemd-devel] [PATCH 07/10] units: order remote-fs.target after local-fs.target

2014-07-16 Thread Tom Gundersen
On Wed, Jul 16, 2014 at 12:09 PM, Jon Severinsson wrote: > From: Michael Biebl > > This change was part of the old debianisation branch created by Tollef > and reflects the fact that on Debian the $remote_fs system facility > depends on $local_fs. If this is merely for sysv compat, it feels wron

Re: [systemd-devel] [PATCH] conf parser: introduce milisecond parsing

2014-07-16 Thread Susant Sahani
On 07/16/2014 01:07 PM, Susant Sahani wrote: Add millisecord parsing support to conf parser. Immediate usage of this function is to parse bond options such as MIIMonitor, UpDelayMSec, DownDelayMSec which is represented in milli seconds. Dropped the idea . Please ignore the patch. Susant _

Re: [systemd-devel] [PATCH 01/10] build-sys: don't move libgudev to /lib

2014-07-16 Thread Kay Sievers
On Wed, Jul 16, 2014 at 12:09 PM, Jon Severinsson wrote: > From: Michael Biebl > > It depends on libgobject and libgmodule which are installed in /usr/lib. Applied. Thanks, Kay ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://

Re: [systemd-devel] [PATCH 03/10] rules: load sg module from 80-drivers.rules

2014-07-16 Thread Kay Sievers
On Wed, Jul 16, 2014 at 12:09 PM, Jon Severinsson wrote: > From: Martin Pitt > > Taken from the Debian specific rules, this is the remaining difference over > the > upstream 80-drivers.rules. > > Bug-Debian: http://bugs.debian.org/657948 > --- > rules/80-drivers.rules | 1 + > 1 file changed, 1

Re: [systemd-devel] [PATCH 05/10] rules: skip 99-systemd.rules when not running systemd as init

2014-07-16 Thread Tom Gundersen
On Wed, Jul 16, 2014 at 12:47 PM, Kay Sievers wrote: > On Wed, Jul 16, 2014 at 12:09 PM, Jon Severinsson > wrote: >> From: Tollef Fog Heen >> >> --- >> rules/99-systemd.rules.in | 1 + >> 1 file changed, 1 insertion(+) > > The file should not do any harm. If it does, we should check if > somet

Re: [systemd-devel] [PATCH 02/10] rules: updates to default device permissions in 50-udev-default.rules

2014-07-16 Thread Kay Sievers
On Wed, Jul 16, 2014 at 12:09 PM, Jon Severinsson wrote: > From: Martin Pitt > > Taken from the previous Debian specific rules, this is the remaining > difference > over the upstream 50-udev-default.rules. > --- > rules/50-udev-default.rules | 14 +- > 1 file changed, 13 insertions(

Re: [systemd-devel] [PATCH] sysv-generator: do not generate 'Wants' symlinks to generated service files that will be shadowed by a native unit.

2014-07-16 Thread Thomas H.P. Andersen
On Wed, Jul 16, 2014 at 11:57 AM, Jon Severinsson wrote: > --- > src/sysv-generator/sysv-generator.c | 29 +++-- > 1 file changed, 27 insertions(+), 2 deletions(-) > > diff --git a/src/sysv-generator/sysv-generator.c > b/src/sysv-generator/sysv-generator.c > index 5206279

Re: [systemd-devel] [PATCH 05/10] rules: skip 99-systemd.rules when not running systemd as init

2014-07-16 Thread Kay Sievers
On Wed, Jul 16, 2014 at 12:09 PM, Jon Severinsson wrote: > From: Tollef Fog Heen > > --- > rules/99-systemd.rules.in | 1 + > 1 file changed, 1 insertion(+) The file should not do any harm. If it does, we should check if something needs to be fixed in a different way. This patch looks like dis

Re: [systemd-devel] [PATCH 06/10] tmpfiles: fix permissions of /run/lock and /run/lock/lockdev

2014-07-16 Thread Mantas Mikulėnas
On Wed, Jul 16, 2014 at 1:09 PM, Jon Severinsson wrote: > -d /run/lock 0755 root root - > +d /run/lock 1777 root root - Won't any user be able to break the system by filling /run, if it has world-writable directories? IIRC, this was one of the reasons /run/user/* are separate 'tmpfs'es. -- Mant

Re: [systemd-devel] [PATCH 06/10] tmpfiles: fix permissions of /run/lock and /run/lock/lockdev

2014-07-16 Thread Tom Gundersen
Why do you think this should be changed? On Wed, Jul 16, 2014 at 12:09 PM, Jon Severinsson wrote: > From: Tollef Fog Heen > > --- > tmpfiles.d/legacy.conf | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tmpfiles.d/legacy.conf b/tmpfiles.d/legacy.conf > index 3219672

[systemd-devel] [PATCH 04/10] rules: set default polling interval on removable devices as well

2014-07-16 Thread Jon Severinsson
From: Martin Pitt The events_dfl_poll_msecs rule will not trigger if "block" is not a module, but built in. This will avoid udisks etc. having to poll from userspace, and provide proper ejection when the hardware eject button is pressed. Bug-Debian: https://bugs.debian.org/713877 Bug-Ubuntu: htt

[systemd-devel] [PATCH 10/10] shared: include stdbool.h in mkdir.h

2014-07-16 Thread Jon Severinsson
From: Sjoerd Simons --- src/shared/mkdir.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/shared/mkdir.h b/src/shared/mkdir.h index d15ede6..dd5b41e 100644 --- a/src/shared/mkdir.h +++ b/src/shared/mkdir.h @@ -22,6 +22,7 @@ along with systemd; If not, see

[systemd-devel] [PATCH 08/10] units: make it possible to disable tmp.mount using systemctl

2014-07-16 Thread Jon Severinsson
From: Michael Stapelberg But enable it by default in make install and systemd preset. --- Makefile.am | 4 ++-- system-preset/90-systemd.preset | 1 + units/tmp.mount | 3 +++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefil

[systemd-devel] [PATCH 01/10] build-sys: don't move libgudev to /lib

2014-07-16 Thread Jon Severinsson
From: Michael Biebl It depends on libgobject and libgmodule which are installed in /usr/lib. --- Makefile.am | 10 -- 1 file changed, 10 deletions(-) diff --git a/Makefile.am b/Makefile.am index a492a1f..94cd402 100644 --- a/Makefile.am +++ b/Makefile.am @@ -3373,16 +3373,6 @@ typelibs_

[systemd-devel] [PATCH 03/10] rules: load sg module from 80-drivers.rules

2014-07-16 Thread Jon Severinsson
From: Martin Pitt Taken from the Debian specific rules, this is the remaining difference over the upstream 80-drivers.rules. Bug-Debian: http://bugs.debian.org/657948 --- rules/80-drivers.rules | 1 + 1 file changed, 1 insertion(+) diff --git a/rules/80-drivers.rules b/rules/80-drivers.rules i

[systemd-devel] [PATCH 09/10] kmod-static-nodes: condition execution on kmod binary

2014-07-16 Thread Jon Severinsson
From: Michael Biebl Creating the list of dead device nodes requires kmod. Inside containers this is not strictly required so we don't want a hard dependency on the kmod package. If the binary does not exist kmod-static-nodes.service will fail, so add a condition to check if the binary is availabl

[systemd-devel] [PATCH 05/10] rules: skip 99-systemd.rules when not running systemd as init

2014-07-16 Thread Jon Severinsson
From: Tollef Fog Heen --- rules/99-systemd.rules.in | 1 + 1 file changed, 1 insertion(+) diff --git a/rules/99-systemd.rules.in b/rules/99-systemd.rules.in index c3ef81b..df83a38 100644 --- a/rules/99-systemd.rules.in +++ b/rules/99-systemd.rules.in @@ -6,6 +6,7 @@ # (at your option) any lat

[systemd-devel] [PATCH 06/10] tmpfiles: fix permissions of /run/lock and /run/lock/lockdev

2014-07-16 Thread Jon Severinsson
From: Tollef Fog Heen --- tmpfiles.d/legacy.conf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tmpfiles.d/legacy.conf b/tmpfiles.d/legacy.conf index 3219672..a634c17 100644 --- a/tmpfiles.d/legacy.conf +++ b/tmpfiles.d/legacy.conf @@ -10,7 +10,7 @@ # These files are co

[systemd-devel] Misc patches from the Debian systemd package

2014-07-16 Thread Jon Severinsson
Hi I'm part of the team working on updating the Debian systemd package to v214. As part of that work I have been rebasing and updating the Debian specific patches, and found several that might be appropriate for upstream. While I'm not the original author of these I have been rebasing and updatin

[systemd-devel] [PATCH 07/10] units: order remote-fs.target after local-fs.target

2014-07-16 Thread Jon Severinsson
From: Michael Biebl This change was part of the old debianisation branch created by Tollef and reflects the fact that on Debian the $remote_fs system facility depends on $local_fs. --- units/remote-fs.target | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/units/remote-fs.targ

[systemd-devel] [PATCH 02/10] rules: updates to default device permissions in 50-udev-default.rules

2014-07-16 Thread Jon Severinsson
From: Martin Pitt Taken from the previous Debian specific rules, this is the remaining difference over the upstream 50-udev-default.rules. --- rules/50-udev-default.rules | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/rules/50-udev-default.rules b/rules/50-ude

[systemd-devel] [PATCH] sysv-generator: do not generate 'Wants' symlinks to generated service files that will be shadowed by a native unit.

2014-07-16 Thread Jon Severinsson
--- src/sysv-generator/sysv-generator.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/src/sysv-generator/sysv-generator.c b/src/sysv-generator/sysv-generator.c index 5206279..aff5fd6 100644 --- a/src/sysv-generator/sysv-generator.c +++ b/src/sy

[systemd-devel] [PATCH] conf parser: introduce milisecond parsing

2014-07-16 Thread Susant Sahani
Add millisecord parsing support to conf parser. Immediate usage of this function is to parse bond options such as MIIMonitor, UpDelayMSec, DownDelayMSec which is represented in milli seconds. --- src/shared/conf-parser.c | 1 + src/shared/conf-parser.h | 1 + src/shared/time-util.c | 108 ++