Re: [systemd-devel] [PATCH] shell-completion: prevent mangling unit names (bash)

2014-07-26 Thread Eric Cook
On 07/26/2014 07:52 PM, Zbigniew Jędrzejewski-Szmek wrote: > Unfortunately it works only partially. It seems that completions are generated > properly, but bash doesn't seem to be able to continue after a backslash, > so one has to copy in the remaining part by hand. > > Zbyszek Hm... (I think)Once

Re: [systemd-devel] [PATCH] shell-completion: prevent mangling unit names (bash)

2014-07-26 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Jul 26, 2014 at 05:24:11PM -0400, Eric Cook wrote: > This looks seems like it should work. I would appreciate it if you could > trail run it. > My use of bash is limited and knowledge of it's completion system even more > so. > --- Unfortunately it works only partially. It seems that com

Re: [systemd-devel] systemd-socket-proxyd & slapd

2014-07-26 Thread David Timothy Strauss
Would you be willing to post the entire unit files for everything here, just so future users can see them? Presumably, you're using JoinsNamespaceOf=proxy-to-directory-400.service in vgp.master-ldap-400.service? ___ systemd-devel mailing list systemd-deve

[systemd-devel] [PATCH] shell-completion: prevent mangling unit names (bash)

2014-07-26 Thread Eric Cook
This looks seems like it should work. I would appreciate it if you could trail run it. My use of bash is limited and knowledge of it's completion system even more so. --- shell-completion/bash/systemctl.in | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/shell-

Re: [systemd-devel] [PATCH] analyze: fix seg-fault with no cl-argument

2014-07-26 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jul 24, 2014 at 11:29:40PM +0200, Daniel Buch wrote: > We need to check if argv[1] is set before compare > --- > src/analyze/analyze.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/analyze/analyze.c b/src/analyze/analyze.c > index 66e2aab..83da7f5 100644 > -

Re: [systemd-devel] [PATCH] journald: fix syslog facility for messages coming from kmsg

2014-07-26 Thread Zbigniew Jędrzejewski-Szmek
Hm, what was wrong with the facility before? Zbyszek On Fri, Jul 25, 2014 at 03:04:44PM +0200, Michal Sekletar wrote: > --- > src/journal/journald-kmsg.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/journal/journald-kmsg.c b/src/journal/journald-kmsg.c > in

Re: [systemd-devel] [PATCH] always check asprintf return code

2014-07-26 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jul 25, 2014 at 07:03:20PM +0400, Andrey Borzenkov wrote: > В Fri, 25 Jul 2014 15:38:31 +0200 > Karel Zak пишет: > > > There is a small number of the places in sources where we don't check > > asprintf() return code and assume that after error the function > > returns NULL pointer via the

Re: [systemd-devel] [PATCH] shell-completion: prevent mangling unit names

2014-07-26 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Jul 26, 2014 at 11:15:52AM -0400, Eric Cook wrote: > Units with literal hex '\xFF' in their names has to be read > and printed properly. > dev-disk-byx2dlabel-root.device != dev-disk-by\x2dlabel-root.device Applied. Any chance you could do the equivalent for bash? Zbyszek > --- > shell-

[systemd-devel] [PATCH] shell-completion: prevent mangling unit names

2014-07-26 Thread Eric Cook
Units with literal hex '\xFF' in their names has to be read and printed properly. dev-disk-byx2dlabel-root.device != dev-disk-by\x2dlabel-root.device --- shell-completion/zsh/_systemctl.in | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/shell-completion/z

Re: [systemd-devel] race conditions after SIGTERM

2014-07-26 Thread Reindl Harald
and it happended again how can it be that if i have running mysqld-instances as Type=simple directly starting mysqld that it is not safe after "systemctl stop" returns to rsync the datadirs i had over a long time in any mysqld-unit ExecStopPost=/usr/bin/sleep 1 pretty sure because that happened i