[systemd-devel] [PATCH] dbus1-generator: Always close file in create_dbus_files

2014-08-21 Thread Simon Danner
In the !service case, the first file doesn't get closed automatically, since the second one uses the same FILE*. Close it explicitly. Found by cppcheck Signed-off-by: Simon Danner --- src/dbus1-generator/dbus1-generator.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/

Re: [systemd-devel] [systemd-commits] man/journalctl.xml src/journal

2014-08-21 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Aug 21, 2014 at 05:16:37AM -0700, Harald Hoyer wrote: > @@ -276,6 +278,7 @@ static int parse_argv(int argc, char *argv[]) { > { "file", required_argument, NULL, ARG_FILE >}, > { "root", required_argument, NULL, ARG_ROOT

Re: [systemd-devel] Implementing resume from hibernation as a systemd unit file

2014-08-21 Thread Ivan Shapovalov
On Thursday 21 August 2014 at 01:03:20, Lennart Poettering wrote: > On Tue, 19.08.14 15:46, Ivan Shapovalov (intelfx...@gmail.com) wrote: > > > On Monday 18 August 2014 at 22:04:29, Ivan Shapovalov wrote: > > > [..] > > > > > > > > > > Even if initramfs-only, ordering dependencies

Re: [systemd-devel] Implementing resume from hibernation as a systemd unit file

2014-08-21 Thread Ivan Shapovalov
On Thursday 21 August 2014 at 19:32:01, Simon McVittie wrote: > On 21/08/14 19:12, Ivan Shapovalov wrote: > > Actually, I don't pretty understand the reasoning behind skipping the > > default > > dependencies on /usr mount > > (Some of) the default dependencies require that /usr is mounted, so

Re: [systemd-devel] Implementing resume from hibernation as a systemd unit file

2014-08-21 Thread Simon McVittie
On 21/08/14 19:12, Ivan Shapovalov wrote: > Actually, I don't pretty understand the reasoning behind skipping the default > dependencies on /usr mount (Some of) the default dependencies require that /usr is mounted, so mounting /usr cannot depend on them, to avoid a cycle. (Or to put it the way r

[systemd-devel] timesyncd: Frequent polling when no server could be reached

2014-08-21 Thread Florian Lindner
Hello, I tried out timesyncd today. Basically worked out of the box (disabled ntpd, enabling systemd-timesyncd and systemd-networkd, both unconfigured, side by side with NetworkManager). At my universities network they are blocking outgoing UDP why I can't reach any NTP timesyncd gives these m

Re: [systemd-devel] Implementing resume from hibernation as a systemd unit file

2014-08-21 Thread Ivan Shapovalov
On Thursday 21 August 2014 at 22:06:49, Ivan Shapovalov wrote: > On Thursday 21 August 2014 at 01:03:20, Lennart Poettering wrote: > > [...] > > > > > > > > ...missing sysroot's fsck, as well as any other x-initrd mounts and > > > > their fsck instances. > > > > > > > > Seems that sysroot

Re: [systemd-devel] Implementing resume from hibernation as a systemd unit file

2014-08-21 Thread Ivan Shapovalov
On Thursday 21 August 2014 at 01:03:20, Lennart Poettering wrote: > [...] > > > > > > ...missing sysroot's fsck, as well as any other x-initrd mounts and their > > > fsck instances. > > > > > > Seems that sysroot.mount alone isn't sufficient. > > > > ...Anything on this? > > > > Should

Re: [systemd-devel] [PATCH 3/3] kdbus: get some creds during meta append for optimization

2014-08-21 Thread Djalal Harouni
On Wed, Aug 20, 2014 at 10:49:22PM +0200, Daniel Mack wrote: > On 08/20/2014 06:16 PM, Djalal Harouni wrote: > > On Tue, Aug 19, 2014 at 09:15:35AM +0200, Daniel Mack wrote: > > >> Hmm, I'm not convinced this buys us anything really. After all, that > >> struct has a single user only, and factorin

[systemd-devel] [PATCH V4] use the switch_root function in shutdown

2014-08-21 Thread harald
From: Harald Hoyer removes code duplication also move switch-root to shared --- V2: - Removed all references to "/mnt" in switch_root() and the bogus comment. V3: - moved switch-root.[ch] to shared - added switch to mount MS_MOVE or MS_BIND the old dirs V4: - mkdir_p_label() in switch_root()

[systemd-devel] [PATCH V3] use the switch_root function in shutdown

2014-08-21 Thread harald
From: Harald Hoyer removes code duplication also move switch-root to shared --- V2: - Removed all references to "/mnt" in switch_root() and the bogus comment. V3: - moved switch-root.[ch] to shared - added switch to mount MS_MOVE or MS_BIND the old dirs Makefile.am| 4

Re: [systemd-devel] start / stop daemon

2014-08-21 Thread Lennart Poettering
On Wed, 20.08.14 05:36, Bonno Bloksma (b.blok...@tio.nl) wrote: > Most daemons will not need this feature and systemd can rely on a > timeout killing the job if it does not stop within x seconds. But it > would be good if the start / stop protocol allows for it when a notify > part is developed. >

Re: [systemd-devel] systemd-resolved cannot survive router reinstall

2014-08-21 Thread Thomas Suckow
So the problem is not in networkd, sorry for the noise. The problem is in OpenWRT that uses dnsmasq and stores dhcp lease information on tmpfs. If I reboot the router it looses all the leases and machines should update the information somehow. This is a problem for machines in a separate networ

Re: [systemd-devel] [PATCH V2] use the switch_root function in shutdown

2014-08-21 Thread Harald Hoyer
On 21.08.2014 16:28, har...@redhat.com wrote: > From: Harald Hoyer > > removes code duplication > --- > > Removed all references to "/mnt" in switch_root() and the bogus comment. > > Makefile.am| 1 + > src/core/main.c| 2 +- > src/core/shutdown.c| 77 > +

[systemd-devel] [PATCH V2] use the switch_root function in shutdown

2014-08-21 Thread harald
From: Harald Hoyer removes code duplication --- Removed all references to "/mnt" in switch_root() and the bogus comment. Makefile.am| 1 + src/core/main.c| 2 +- src/core/shutdown.c| 77 +- src/core/switch-root.c | 14 ++

[systemd-devel] [PATCH] use the switch_root function in shutdown

2014-08-21 Thread harald
From: Harald Hoyer removes code duplication --- Makefile.am| 1 + src/core/main.c| 2 +- src/core/shutdown.c| 77 +- src/core/switch-root.c | 6 ++-- src/core/switch-root.h | 2 +- 5 files changed, 13 insertions(+), 75 d

Re: [systemd-devel] [PATCH] journalctl: add "-t --identifier=STRING" option

2014-08-21 Thread Harald Hoyer
On 19.08.2014 21:18, Ronny Chevalier wrote: > 2014-08-19 12:12 GMT+02:00 : >> From: Harald Hoyer >> >> This turns journalctl to the counterpart of systemd-cat. >> Messages sent with >> >> systemd-cat --identifier foo --prioritiy debug >> >> can now be shown with >> >> journalctl --identifier foo

[systemd-devel] How to get rid of this ordering cycle?

2014-08-21 Thread Vlad Orlov
Hi again, Thank you all, removing dbus from the prerequisites did the trick. No more ordering cycles and mintsystem still runs fine. It turned out that mintsystem didn't even require dbus to work. Must be a copy-paste mistake (from some other init script) by the author... As for the adjustments

Re: [systemd-devel] [PATCH] missing: add BPF_XOR

2014-08-21 Thread Michal Sekletar
On Thu, Aug 21, 2014 at 12:38:08PM +0200, Michael Olbrich wrote: > BPF_XOR was introduced in kernel 3.7 > --- > > This fixes compiling systemd for me. I'm not sure about the implications of > this. I'm not sure what happens if the code using it is executed on a linux > kernel < 3.7 I don't think

[systemd-devel] [PATCH] journal-upload: fix service ordering

2014-08-21 Thread Umut Tezduyar Lindskog
[/usr/lib/systemd/system/systemd-journal-upload.service:20] Unknown lvalue 'After' in section 'Install' --- units/systemd-journal-upload.service.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/units/systemd-journal-upload.service.in b/units/systemd-journal-upload.service

[systemd-devel] [PATCH] timedated: add configure option to set name of controlled NTP service

2014-08-21 Thread Miroslav Lichvar
This is useful for installations where some other service than systemd-timesyncd is used to synchronize the system clock. --- configure.ac | 9 + src/timedate/timedated.c | 10 +- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.

[systemd-devel] [PATCH] missing: add BPF_XOR

2014-08-21 Thread Michael Olbrich
BPF_XOR was introduced in kernel 3.7 --- This fixes compiling systemd for me. I'm not sure about the implications of this. I'm not sure what happens if the code using it is executed on a linux kernel < 3.7 Michael src/shared/missing.h | 4 1 file changed, 4 insertions(+) diff --git a/src/

Re: [systemd-devel] systemd-resolved cannot survive router reinstall

2014-08-21 Thread Tom Gundersen
On Thu, Aug 21, 2014 at 8:22 AM, Anatol Pomozov wrote: > Hi > > Sorry for the delay, just got back home. > > On Tue, Aug 12, 2014 at 12:19 PM, Tom Gundersen wrote: >> On Tue, Aug 12, 2014 at 2:48 AM, Anatol Pomozov >> wrote: >>> Thanks for the instructions, here is the log >>> https://gist.githu

Re: [systemd-devel] [ANNOUNCE] systemd 216

2014-08-21 Thread Colin Guthrie
Lennart Poettering wrote on 20/08/14 23:17: > On Wed, 20.08.14 20:43, Colin Guthrie (gm...@colin.guthr.ie) wrote: > >> >> Lennart Poettering wrote on 20/08/14 01:59: >>> Heya! >>> >>> This is a major new release. Among many other changes systemd-resolved >>> is now a pretty complete caching DNS an