[systemd-devel] [PATCH 2/2 v3] socket: introduce SELinuxContextFromNet option

This makes possible to spawn service instances triggered by socket with MLS/MCS SELinux labels which are created based on information provided by connected peer. Implementation of label_get_child_mls_label derived from xinetd. Reviewed-by: Paul Moore --- Changes in v3: * renamed option

[systemd-devel] [PATCH 1/2] everywhere: don't use uprefixed word "context" in struct and function names

We use libselinux which exports context_free function. To prevent name clashes rename our internal APIs and don't use context_* but rather appropriately prefixed names. --- src/hostname/hostnamed.c | 72 +-- src/journal/mmap-cache.c | 102 ++

[systemd-devel] systemd-216: using nss-resolve

Hello, I'm trying to use nss-resolve instead of nss_dns and have several issues: - I'm using "Domains" in the [Network] section and systemd-resolved creates the "search ..." entry in /run/systemd/resolve/resolv.conf properly. However resolving short host names doesn't work (I've tried systemd-r

[systemd-devel] PrivateNetwork for user sessions?

Hi, I recently discovered the PrivateNetwork option in systemd.exec(5), and I was wondering: Is it also possible to restrict user sessions with this option? I'd like to prevent a certain user's group from accessing the network configuration of my machine (they should even be forbidden to see the

Re: [systemd-devel] PrivateNetwork for user sessions?

On Mon, Aug 25, 2014 at 12:58 PM, Yarny wrote: > I recently discovered the PrivateNetwork > option in systemd.exec(5), and I was wondering: > > Is it also possible to restrict user sessions with this option? > > I'd like to prevent a certain user's group from > accessing the network configuration

Re: [systemd-devel] loginctl - multi-seats

> > Don't forget to post config here when you're done. ;) > > > poma > Until now, I have unfortunately not be able to write a working xorg.conf to dual seat with only one graphic card. I tried many settings with xorg.conf and lightdm.conf, but still no luck.

Re: [systemd-devel] PrivateNetwork for user sessions?

> Instead, you should check if someone has written a PAM 'session' > module which could do this. (There's one for mount namespaces.) If > not, one should be easy to write, and it'll protect *all* login > methods. I just found pam_netns and will follow that path.

Re: [systemd-devel] loginctl - multi-seats

BTW: I guess http://dvdhrm.wordpress.com/2013/09/01/splitting-drm-and-kms-device-nodes/ was the post for splitting the GPU into different devices so that it would be possible for logind 2014-08-25 16:25 GMT+02:00 arnaud gaboury : >> >> Don't forget to post config here when you're done. ;) >> >> >

Re: [systemd-devel] loginctl - multi-seats

and found also the bug report https://bugs.freedesktop.org/show_bug.cgi?id=66501 and that I asked the same question before :) https://lists.fedoraproject.org/pipermail/devel/2013-October/190840.html 2014-08-25 17:37 GMT+02:00 Damian Ivanov : > BTW: I guess > http://dvdhrm.wordpress.com/2013/09/01

[systemd-devel] loginctl - multi-seats

I've just started following this discussion (so I don't know if it my reply will be correctly chained), and I would like to make some comments: * Starting with version 1.16, Xorg server no longer handles VTs if it was started as a non-seat0 X server i.e., if -seat option with a non-seat0 value was

[systemd-devel] seat1 ACL

Hi, It could be related to that "lazy session-activation on non-seat0 seats" introduced in systemd 208, and reverted by David Herrmann in version 209. See https://bugzilla.redhat.com/show_bug.cgi?id=1032014 Release 208-8 of Debian systemd packages already include David's patch: http://cgit.freed

Re: [systemd-devel] loginctl - multi-seats

On Sat, 23.08.14 15:10, arnaud gaboury (arnaud.gabo...@gmail.com) wrote: > Archlinux 3.16.1 > systemd 215-4 > Xorg 1.16 > > > Until now, I have been enable to set a dual seat following the > archwiki[1]. In short, I had to modify the /etc/X11/xorg.conf > accordingly, then $ startx -- layout seat

Re: [systemd-devel] loginctl - multi-seats

On Sat, 23.08.14 16:26, arnaud gaboury (arnaud.gabo...@gmail.com) wrote: > > > I understand from loginctl(1) I have to first create 1 new seat with > > loginctl using 1 existing graphic device: > > $ attach seat1 /sys/bus/pci/device/:00:01.0@ (my graphic card as > > listed by $lspci). > > No

Re: [systemd-devel] loginctl - multi-seats

On Sat, 23.08.14 17:00, Damian Ivanov (damianator...@gmail.com) wrote: > > With right distro I mean which carry the patches so the multiseat > stuff works. Don't know if Arch has them. Last time I tried gdm was > _required_ for a graphical multi-seat session. I worked with Ray to get support for

Re: [systemd-devel] loginctl - multi-seats

On Sat, 23.08.14 20:48, Damian Ivanov (damianator...@gmail.com) wrote: > Yeah, so tl,dr what this is trying to say with one GPU and two > connectors, no multiseat possible using logind (yet, though this > was/is a planned feature). It was/is? I have no intention to support this kind of multi-sea

Re: [systemd-devel] [PATCH] TODO: add molly-guard functionality

On Sat, 23.08.14 19:26, Josh Triplett (j...@joshtriplett.org) wrote: > Rather than requiring a third-party tool for this, systemctl should > handle this natively. This has been proposed before, but I sounds awfully random to me to have in systemd. I am pretty sure this should be an add-on, but no

Re: [systemd-devel] About systemd in initrd support

On Sat, 23.08.14 13:46, Luca Bruno (lethalma...@gmail.com) wrote: > I'm going to do an experiment with NixOS: replace the whole current initrd > process made of scripts and hooks with systemd. > > Before doing any work however I'd like to hear whether systemd in initrd is > still wanted in the fu

Re: [systemd-devel] Match section of .link file not working

On Sun, 24.08.14 06:49, Simon Peeters (peeters.si...@gmail.com) wrote: > >> This should be the value of ID_PATH property, not sysfs path. Check with > >> > >> udevadm info --query > >> property > >> /sys/devices/ocp.3/4740.usb/musb-hdrc.1.auto/usb1/1-1/1-1:1.0/net/wlv3 > > > > oops, I confuse

Re: [systemd-devel] PrivateNetwork for user sessions?

On Mon, 25.08.14 11:58, Yarny (ya...@public-files.de) wrote: > Hi, > > I recently discovered the PrivateNetwork > option in systemd.exec(5), and I was wondering: > > Is it also possible to restrict user sessions with this option? Not with systemd tools. But there are packages such as "pam_netns

Re: [systemd-devel] systemd-216: using nss-resolve

On Mon, 25.08.14 10:59, Vladimir Elisseev (vo...@vovan.nl) wrote: > Hello, Heya, > I'm trying to use nss-resolve instead of nss_dns and have several issues: > - I'm using "Domains" in the [Network] section and systemd-resolved > creates the "search ..." entry in /run/systemd/resolve/resolv.con

Re: [systemd-devel] Make journalctl start at the end of the journal by default

On Mon, 18.08.14 15:50, Reindl Harald (h.rei...@thelounge.net) wrote: > > > Am 18.08.2014 um 15:27 schrieb Lennart Poettering: > >> And also I would like to see the full logs always by default. > >> Usually after lots of searching you find the offending log entry for > >> the error, only to find

Re: [systemd-devel] [RFC] [PATCHv3 0/3] resume: implement support for resuming from hibernation

On Mon, 25.08.14 02:16, Ivan Shapovalov (intelfx...@gmail.com) wrote: > This patchset allows systemd to parse resume= kernel command line parameter > and initiate resume from the specified device. > > It adds: > - a 'systemd-resume' tool which takes path to a device node and > writes its major:

Re: [systemd-devel] Match section of .link file not working

On Mon, Aug 25, 2014 at 7:25 PM, Lennart Poettering wrote: > On Sun, 24.08.14 06:49, Simon Peeters (peeters.si...@gmail.com) wrote: > >> >> This should be the value of ID_PATH property, not sysfs path. Check with >> >> >> >> udevadm info --query >> >> property >> >> /sys/devices/ocp.3/4740.us

Re: [systemd-devel] loginctl - multi-seats

2014-08-25 14:14 GMT-03:00 Lennart Poettering : > I worked with Ray to get support for this into gdm, I am not sure > whether any other DM was ever updated to support this too. Stefan Brüns at openSUSE is currently working to bring logind multiseat support to KDM (based on original patch from Ma

Re: [systemd-devel] [RFC] [PATCHv3 2/3] resume: add a tool to write a device node's major:minor to /sys/power/resume.

On Mon, 25.08.14 02:16, Ivan Shapovalov (intelfx...@gmail.com) wrote: > +int main(int argc, char *argv[]) { > +struct stat st; > +const char *device; > +_cleanup_free_ char *major_minor = NULL; > +int r; > + > +if (argc != 2) { > +log_error("

Re: [systemd-devel] [RFC] [PATCHv3 0/3] resume: implement support for resuming from hibernation

On Monday 25 August 2014 at 19:42:21, Lennart Poettering wrote: > On Mon, 25.08.14 02:16, Ivan Shapovalov (intelfx...@gmail.com) wrote: > > > This patchset allows systemd to parse resume= kernel command line parameter > > and initiate resume from the specified device. > > > > It adds: > > - a 's

Re: [systemd-devel] [RFC] [PATCHv3 3/3] resume-generator: add a generator for instantiating the resume unit.

On Mon, 25.08.14 02:16, Ivan Shapovalov (intelfx...@gmail.com) wrote: > + > +static const char *arg_dest = "/tmp"; > +static char *arg_resume_dev = NULL; > + > +static int parse_proc_cmdline_item(const char *key, const char *value) { > +if (streq(key, "resume") && value) { > +

Re: [systemd-devel] [RFC] [PATCHv3 0/3] resume: implement support for resuming from hibernation

On Mon, 25.08.14 21:52, Ivan Shapovalov (intelfx...@gmail.com) wrote: > > > - legacy usr.mount is not automatically ordered after local-fs-pre.target, > > > so systemd-resume@.service has to be manually ordered before it; > > > > Not following here. We do not really support /usr split out unles

Re: [systemd-devel] [PATCH 1/2] everywhere: don't use uprefixed word "context" in struct and function names

On Mon, 25.08.14 10:02, Michal Sekletar (msekl...@redhat.com) wrote: > We use libselinux which exports context_free function. To prevent name > clashes rename our internal APIs and don't use context_* but rather > appropriately prefixed names. I'd prefer if we'd leave the type name as it is now.

Re: [systemd-devel] loginctl - multi-seats

On Mon, 25.08.14 13:26, Laércio de Sousa (laercioso...@sme-mogidascruzes.sp.gov.br) wrote: > I've just started following this discussion (so I don't know if it my reply > will be correctly chained), and I would like to make some comments: > > * Starting with version 1.16, Xorg server no longer h

Re: [systemd-devel] Match section of .link file not working

В Sun, 24 Aug 2014 21:28:51 +0200 Simon Peeters пишет: > 2014-08-24 20:29 GMT+02:00 Andrei Borzenkov : > > В Sun, 24 Aug 2014 09:19:13 +0200 > > Simon Peeters пишет: > > > >> >> Ok, so there is only one problem now: > >> >> ID_PATH is the same for all my vif interfaces, and i need to select > >>

Re: [systemd-devel] [RFC] [PATCHv3 2/3] resume: add a tool to write a device node's major:minor to /sys/power/resume.

On Monday 25 August 2014 at 19:49:52, Lennart Poettering wrote: > On Mon, 25.08.14 02:16, Ivan Shapovalov (intelfx...@gmail.com) wrote: > > > +int main(int argc, char *argv[]) { > > +struct stat st; > > +const char *device; > > +_cleanup_free_ char *major_minor = NULL; > >

Re: [systemd-devel] [PATCH] TODO: add molly-guard functionality

On Mon, Aug 25, 2014 at 07:19:47PM +0200, Lennart Poettering wrote: > On Sat, 23.08.14 19:26, Josh Triplett (j...@joshtriplett.org) wrote: > > > Rather than requiring a third-party tool for this, systemctl should > > handle this natively. > > This has been proposed before, but I sounds awfully ra

Re: [systemd-devel] [RFC] [PATCHv3 0/3] resume: implement support for resuming from hibernation

On Monday 25 August 2014 at 20:07:28, Lennart Poettering wrote: > On Mon, 25.08.14 21:52, Ivan Shapovalov (intelfx...@gmail.com) wrote: > > > > > - legacy usr.mount is not automatically ordered after > > > > local-fs-pre.target, > > > > so systemd-resume@.service has to be manually ordered bef

Re: [systemd-devel] [RFC] [PATCHv3 3/3] resume-generator: add a generator for instantiating the resume unit.

On Monday 25 August 2014 at 19:58:52, Lennart Poettering wrote: > [...] > > One more question though, regarding the terminology. So far we used the > following terms: > > "suspend" → means suspend-to-ram > "hibernate" → means suspend-to-disk > "hybrid-sleep" → means both STR + STD co

Re: [systemd-devel] loginctl - multi-seats

2014-08-25 15:13 GMT-03:00 Lennart Poettering : > I think we can remove the entire wrapper now, right? Would be happy to > merge a patch that kills it of. I agree. Or at least make systemd build option --disable-multi-seat-x the default for a while, until all major Linux distros ship with xorg-s

Re: [systemd-devel] loginctl - multi-seats

> > The way to go is to start with looking at "loginctl seat-status > seat0". This will show you all hardware currently assigned to seat0. Use > the device paths showmn to then create additional seats out of them, in > different combinations. > > Not all devices can be assigned to seats, they have

Re: [systemd-devel] loginctl - multi-seats

> > provided you tag another suitable device (e.g. a USB hub) as > "master-of-seat" and attach it to "seat-1". I will switch to nouveau, as I do not want to go this way. > About configuring multiseat using a single multi-head graphics card, the > only current available way to do this is with nes

Re: [systemd-devel] Match section of .link file not working

2014-08-25 20:16 GMT+02:00 Andrei Borzenkov : > В Sun, 24 Aug 2014 21:28:51 +0200 > Simon Peeters пишет: >> No, and yes. The wireless adaptor actually only exprts phy0. The >> kernel then by default creates wlan0. >> Then i use : >> # iw phy phy0 interface add wlv1 type __ap >> # iw phy phy0 inte

Re: [systemd-devel] About systemd in initrd support

Thank you all for the replies. After the first answers I've ported the initrd to systemd (only the basic stuff, no luks, lvm, etc.) and works very fine. Except one thing, that I hoped to find in dracut but does not seem to do anything special about it. It just goes through switch-root it seems. As

Re: [systemd-devel] Match section of .link file not working

2014-08-25 19:46 GMT+02:00 Kay Sievers : > On Mon, Aug 25, 2014 at 7:25 PM, Lennart Poettering > wrote: >> On Sun, 24.08.14 06:49, Simon Peeters (peeters.si...@gmail.com) wrote: >> >>> >> This should be the value of ID_PATH property, not sysfs path. Check with >>> >> >>> >> udevadm info --query >>

Re: [systemd-devel] Match section of .link file not working

On Mon, Aug 25, 2014 at 9:27 PM, Simon Peeters wrote: > 2014-08-25 19:46 GMT+02:00 Kay Sievers : >> On Mon, Aug 25, 2014 at 7:25 PM, Lennart Poettering >> wrote: >>> On Sun, 24.08.14 06:49, Simon Peeters (peeters.si...@gmail.com) wrote: >>> >> This should be the value of ID_PATH property, no

Re: [systemd-devel] About systemd in initrd support

On Mon, Aug 25, 2014 at 9:04 PM, Luca Bruno wrote: > Thank you all for the replies. After the first answers I've ported the > initrd to systemd (only the basic stuff, no luks, lvm, etc.) and works very > fine. > Except one thing, that I hoped to find in dracut but does not seem to do > anything sp

Re: [systemd-devel] Match section of .link file not working

Hi Tom, >>> This should be the value of ID_PATH property, not sysfs path. Check with >>> >>> udevadm info --query >>> property >>> /sys/devices/ocp.3/4740.usb/musb-hdrc.1.auto/usb1/1-1/1-1:1.0/net/wlv3 >> >> oops, I confused ID_PATH with DEVPATH, now i feel like

Re: [systemd-devel] About systemd in initrd support

> > > As you already mentioned, you'd have to make sure you manage to pass > through the state correctly. > > Thanks. Is there any docs I can read about this or just read the code? It appears that systemd dumps the state into a file, and afterwards it's passed to the new systemd instance. _

Re: [systemd-devel] Match section of .link file not working

On Mon, Aug 25, 2014 at 9:49 PM, Marcel Holtmann wrote: > Hi Tom, > This should be the value of ID_PATH property, not sysfs path. Check with udevadm info --query property /sys/devices/ocp.3/4740.usb/musb-hdrc.1.auto/usb1/1-1/1-1:1.0/net/w

Re: [systemd-devel] [PATCH 2/2] [POC] networkd: port to glib main loop

On Wed, Aug 20, 2014 at 7:08 PM, Simon McVittie wrote: > On 20/08/14 16:28, Tom Gundersen wrote: >> +int attach_sd_event_to_g_main_loop(GMainLoop *loop, sd_event *event) { > > (I know this is only a proof of concept but) > > I think the construct you're looking for is a GMainContext, not a GMainLo

Re: [systemd-devel] loginctl - multi-seats

Hi On Mon, Aug 25, 2014 at 7:17 PM, Lennart Poettering wrote: > On Sat, 23.08.14 20:48, Damian Ivanov (damianator...@gmail.com) wrote: > >> Yeah, so tl,dr what this is trying to say with one GPU and two >> connectors, no multiseat possible using logind (yet, though this >> was/is a planned featur

[systemd-devel] Current status wrt. realtime services (aka jackd)

Hello all, is there some replacement of the "ControlGroupAttribute=cpu.rt_runtime_us " tunable described at http://www.freedesktop.org/wiki/Software/systemd/MyServiceCantGetRealtime/ for allowing services like `jackd -R` to run? -- Ivan Shapovalov / intelfx / signature.asc Description: This i

[systemd-devel] [PATCH] NEWS: Fix typos.

From: Ansgar Burchardt --- NEWS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index 7dad765..2fca2cd 100644 --- a/NEWS +++ b/NEWS @@ -42,8 +42,8 @@ CHANGES WITH 216: * systemd-resolved now includes a caching DNS stub resolver and a co

[systemd-devel] systemd's interfaces are a bit wonky

Hello, I am making my own little init system for my game in order to sandbox and monitor individual child programs in it. I plan on reusing systemd's unit file format and other conventions instead of inventing my own. I know that the systemd developers would like to have a good set of common and

Re: [systemd-devel] systemd's interfaces are a bit wonky

On Mon, 25.08.14 22:27, Steven Stewart-Gallus (sstewartgallu...@mylangara.bc.ca) wrote: > Hello, I am making my own little init system for my game in order to > sandbox and monitor individual child programs in it. I plan on > reusing systemd's unit file format and other conventions instead of >

Re: [systemd-devel] Current status wrt. realtime services (aka jackd)

On Tue, 26.08.14 02:02, Ivan Shapovalov (intelfx...@gmail.com) wrote: > Hello all, > > is there some replacement of the "ControlGroupAttribute=cpu.rt_runtime_us > " > tunable described at > http://www.freedesktop.org/wiki/Software/systemd/MyServiceCantGetRealtime/ > for allowing services like `

Re: [systemd-devel] About systemd in initrd support

On Mon, 25.08.14 21:04, Luca Bruno (lethalma...@gmail.com) wrote: > Thank you all for the replies. After the first answers I've ported the > initrd to systemd (only the basic stuff, no luks, lvm, etc.) and works very > fine. > Except one thing, that I hoped to find in dracut but does not seem to d

Re: [systemd-devel] About systemd in initrd support

On Mon, 25.08.14 22:13, Luca Bruno (lethalma...@gmail.com) wrote: > > As you already mentioned, you'd have to make sure you manage to pass > > through the state correctly. > > > > > Thanks. Is there any docs I can read about this or just read the code? It > appears that systemd dumps the state int

Re: [systemd-devel] [RFC] initrd: systemd-{networkd,resolved}

On Sat, 23.08.14 23:26, Timofey Titovets (nefelim...@gmail.com) wrote: > Good time of day list, i just want to hear your opinions - pro and con > > Pre story: > Before i install bunch of systemd-{networkd,resolved} and > wpa_supplicant (for connecting to HotSpots) > > After i spend some time to

Re: [systemd-devel] [RFC] [PATCHv3 2/3] resume: add a tool to write a device node's major:minor to /sys/power/resume.

On Mon, 25.08.14 22:20, Ivan Shapovalov (intelfx...@gmail.com) wrote: > > > +log_notice("Failed to resume from device '%s' (%s).", > > > + device, major_minor); > > > > same here.. > > Fixed as well. > > > > > Hmm, what's the logic here? Is this something where we sho

Re: [systemd-devel] [RFC] [PATCHv3 0/3] resume: implement support for resuming from hibernation

On Mon, 25.08.14 22:23, Ivan Shapovalov (intelfx...@gmail.com) wrote: > > So, I am pretty sure we don#t want an explicit After= order here between > > dbus and systemd-resume@.service... > > > > Hmm, but yuck, I don't see a nice way to fix this for good. Grrr. > > > > I'd probably just merge thi

Re: [systemd-devel] [RFC] [PATCHv3 3/3] resume-generator: add a generator for instantiating the resume unit.

On Mon, 25.08.14 22:27, Ivan Shapovalov (intelfx...@gmail.com) wrote: > On Monday 25 August 2014 at 19:58:52, Lennart Poettering wrote: > > [...] > > > > One more question though, regarding the terminology. So far we used the > > following terms: > > > > "suspend" → means suspend-to-r

Re: [systemd-devel] [PATCH 2/2] [POC] networkd: port to glib main loop

On Mon, Aug 25, 2014 at 11:24:48PM +0200, Tom Gundersen wrote: > On Wed, Aug 20, 2014 at 7:08 PM, Simon McVittie > wrote: > > On 20/08/14 16:28, Tom Gundersen wrote: > >> +int attach_sd_event_to_g_main_loop(GMainLoop *loop, sd_event *event) { > > > > (I know this is only a proof of concept but) >

Re: [systemd-devel] [PATCH] TODO: add molly-guard functionality

On Mon, 25.08.14 11:21, Josh Triplett (j...@joshtriplett.org) wrote: > > On Mon, Aug 25, 2014 at 07:19:47PM +0200, Lennart Poettering wrote: > > On Sat, 23.08.14 19:26, Josh Triplett (j...@joshtriplett.org) wrote: > > > > > Rather than requiring a third-party tool for this, systemctl should > >

Re: [systemd-devel] systemctl preset and chkconfig

On Fri, 22.08.14 15:51, Colin Guthrie (gm...@colin.guthr.ie) wrote: > Hi, > > I recently changed my %post scripts in Mageia to use systemctl preset > rather than systemctl enable to allow for policy-based overrides of > "enable on install" behaviour. > > Sadly, unlike enable, preset does not she

Re: [systemd-devel] [PATCH] timedated: add configure option to set name of controlled NTP service

On Thu, 21.08.14 12:49, Miroslav Lichvar (mlich...@redhat.com) wrote: > This is useful for installations where some other service than > systemd-timesyncd is used to synchronize the system clock. What's the rationale here? We recently removed support for configuring arbitrary NTP servers from ti

Re: [systemd-devel] timesyncd: Frequent polling when no server could be reached

On Fri, 22.08.14 10:13, Miroslav Lichvar (mlich...@redhat.com) wrote: > > Polluting my log this way. Is is possible to inhibit that behavior? Maybe > > trying a couple of times, then giving up until next network status change. > > Hm, a well behaved client reduces its polling rate exponentially

Re: [systemd-devel] [PATCH V4] use the switch_root function in shutdown

On Thu, 21.08.14 19:07, har...@redhat.com (har...@redhat.com) wrote: > broadcast_signal(SIGTERM, false, true); > > /* And switch root */ > -r = switch_root(switch_root_dir); > +r = switch_root(switc

Re: [systemd-devel] [systemd-commits] src/shared

On Mon, 25.08.14 07:06, Lukas Nykryn (lnyk...@kemper.freedesktop.org) wrote: > src/shared/install.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > New commits: > commit 41a451cc2901a5deb985aea4cc8de204a22e5612 > Author: Lukas Nykryn > Date: Mon Aug 25 15:29:50 2014 +0200 > >

Re: [systemd-devel] loginctl - multi-seats

On Mon, 25.08.14 15:27, Laércio de Sousa (laercioso...@sme-mogidascruzes.sp.gov.br) wrote: > 2014-08-25 15:13 GMT-03:00 Lennart Poettering : > > > I think we can remove the entire wrapper now, right? Would be happy to > > merge a patch that kills it of. > > > I agree. Or at least make systemd

[systemd-devel] [PATCH 1/3] test-compress: make sure asserts with side effects use assert_se()

Otherwise the test fails when built with CPPFLAGS='-DNDEBUG' which disables assertions. Tested: - make check TESTS='test-compress' CPPFLAGS='-DNDEBUG' --- src/journal/test-compress.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/journal/test-compress.c b/src/journal/

[systemd-devel] [PATCH 2/3] test-path-util: use assert_se in all assertions

Otherwise they get optimized out when CPPFLAGS='-DNDEBUG' is used, and that causes the tests to fail. Tested: - make check TESTS='test-path-util' CPPFLAGS='-DNDEBUG' --- src/test/test-path-util.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/

[systemd-devel] [PATCH 3/3] test-util: use assert_se() for call to safe_mkdir with side effect

Otherwise it gets optimized out when CPPFLAGS='-DNDEBUG' is used. Tested: - make check TESTS='test-util' CPPFLAGS='-DNDEBUG' --- src/test/test-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/test-util.c b/src/test/test-util.c index 34d5f2ed7d23..4d9b28f9c8e7 10

[systemd-devel] [PATCH] journal: grant systemd-journal group permission

There is no Bofore= or After= dependencies between systemd-journald.service and systemd-tmpfiles-setup.service. So if both "/run/log/journal" and "/var/log/journal" does not exist then those can be make as root:root and also its ids directory and journal files. To make sure, do chown systemd-journa