[systemd-devel] [PATCH v2 1/2] util: add function getting proc environ

2014-11-24 Thread Jakub Filak
On the contrary of env, the added function returns all characters cescaped, because it improves reproducibility. --- src/shared/util.c| 154 --- src/shared/util.h| 1 + src/test/test-util.c | 5 ++ 3 files changed, 103 insertions(+), 57 d

[systemd-devel] [PATCH v2 0/2] coredump: add journal fields useful for bug reporting

2014-11-24 Thread Jakub Filak
'util: add functions getting proc status, maps, limits, cgroup' I dropped this patch, because we just need to read full proc file and 'get_process_proc_file()' function is not implementable without adding a wrapper function to procfs_file_alloca() macro. 'util: add function getting proc env

[systemd-devel] [PATCH v2 2/2] coredump: collect all /proc data useful for bug reporting

2014-11-24 Thread Jakub Filak
/proc/[pid]: - status - maps - limits - cgroup - cwd - root - environ - fd/ & fdinfo/ joined in open_fds --- src/journal/coredump.c | 156 - 1 file changed, 154 insertions(+), 2 deletions(-) diff --git a/src/journal/coredump.c b/src/journal/coredump

Re: [systemd-devel] serialization bug, swap bug, etc.

2014-11-24 Thread Mantas Mikulėnas
On Mon, Nov 24, 2014 at 5:57 PM, Zbigniew Jędrzejewski-Szmek < zbys...@in.waw.pl> wrote: > And what does 'udevadm info /dev/sda7' and 'systemctl show dev-sda7.swap' > and > the same for dev-disk-by\x2dpartlabel-swap.swap? > Attached both. -- Mantas Mikulėnas a.sd-show Description: Binary dat

Re: [systemd-devel] Compatibility between D-Bus and kdbus

2014-11-24 Thread Thiago Macieira
Sorry for the delay in replying. I didn't have time until after KLF... On Wednesday 01 October 2014 14:33:01 Simon McVittie wrote: > System bus access-control policy > [snip] > If I remember correctly, the least bad solution anyone could think of > was to introduce

[systemd-devel] how to properly control the daemons or run advanced cmds

2014-11-24 Thread Flavio Leitner
Hello, The Open vSwitch is comprised by two daemons. One is a database and another is the switch itself. Currently we have the openvswitch.service which start/stop/reload the service (both daemons) just fine. However, we need to support hot-upgrade which means to stop the vswitch daemon first,

[systemd-devel] [PATCH] networkd: route - allow routes without a gateway

2014-11-24 Thread Gavin Li
From: Gavin Li For IPv6, the kernel returns EINVAL if a route is added with the RTA_GATEWAY attribute set to in6addr_any (::). A route without a gateway is useful in some situations, such as layer 3 tunneling (sit, gre, etc.). This patch prevents the RTA_GATEWAY attribute from being added when r

Re: [systemd-devel] Shutdown problems

2014-11-24 Thread Nikolaus Rath
Nikolaus Rath writes: > On 11/13/2014 12:54 PM, Nikolaus Rath wrote: >> Nikolaus Rath writes: >>> Lennart Poettering writes: On Sat, 08.11.14 11:16, Nikolaus Rath (nikol...@rath.org) wrote: >> Please boot with "systemd.log_level=debug", then make the machine hang >> and check w

Re: [systemd-devel] [PATCH] networkd: route - allow routes without a gateway

2014-11-24 Thread Lennart Poettering
On Mon, 24.11.14 12:01, Gavin Li (gavi...@thegavinli.com) wrote: > For IPv6, the kernel returns EINVAL if a route is added with the > RTA_GATEWAY attribute set to in6addr_any (::). A route without a > gateway is useful in some situations, such as layer 3 tunneling > (sit, gre, etc.). > > This pat

[systemd-devel] [PATCH] networkd: route - allow routes without a gateway

2014-11-24 Thread Gavin Li
For IPv6, the kernel returns EINVAL if a route is added with the RTA_GATEWAY attribute set to in6addr_any (::). A route without a gateway is useful in some situations, such as layer 3 tunneling (sit, gre, etc.). This patch prevents the RTA_GATEWAY attribute from being added when route.in_addr is i

[systemd-devel] networkd: Support setting mtu / mac address by interface name

2014-11-24 Thread William Kennington
I'd like to be able to set the MAC Address and MTU of interfaces, with just the interface name alone. The current method for matching links seems to be heavily tied to udev ATTRs and I understand given the nature of systemd.link that it might not make sense to Match based on name. However, I need t

[systemd-devel] systemd.netdev: Tunnel should support ANY addresses for Local option

2014-11-24 Thread William Kennington
Currently, networkd netdevs do not support tunnel devices which do not have a local address configured. This breaks the configuration of sit devices on my hosts which run dhcp for ipv4 configuration, which normally have local set to 0.0.0.0. Is there any chance we could remove the any check for the

Re: [systemd-devel] Service not restarting after Condition failed

2014-11-24 Thread Umut Tezduyar Lindskog
Hi On Monday, November 24, 2014, D.S. Ljungmark wrote: > On 10/11/14 23:09, Lennart Poettering wrote: > > On Thu, 30.10.14 18:47, D.S. Ljungmark (spi...@aanstoot.se > ) wrote: > > > >> Hi > >> we have a service set to: > >> ConditionFileNotEmpty= > >> > >> and > >> > >> Restart=Always > >> > >>

Re: [systemd-devel] [PATCH 2/2] networkd: integrate LLDP

2014-11-24 Thread Umut Tezduyar Lindskog
On Sunday, November 23, 2014, Susant Sahani wrote: > > On 11/23/2014 09:33 PM, Umut Tezduyar Lindskog wrote: > >> Hi, >> > Hi Umut, > >> >> On Sun, Nov 23, 2014 at 5:45 AM, Susant Sahani wrote: >> >>> This patch integrates LLDP with networkd. >>> >>> Example conf: >>> file : lldp.network >>> >>>

[systemd-devel] [PATCH] build-sys: remove --gc-sections to fix debugging

2014-11-24 Thread Peter Wu
The --gc-sections linker option triggers a bug in the gold linker[1] which results in a bogus .eh_frame section making debugging harder: gdb backtraces stop at a library built by systemd and libunwind simply segfaults. Workaround by that bug by removing the option. The additional disk space saved

Re: [systemd-devel] Service not restarting after Condition failed

2014-11-24 Thread D.S. Ljungmark
On 10/11/14 23:09, Lennart Poettering wrote: > On Thu, 30.10.14 18:47, D.S. Ljungmark (spi...@aanstoot.se) wrote: > >> Hi >> we have a service set to: >> ConditionFileNotEmpty= >> >> and >> >> Restart=Always >> >> >> This combination would (in my feebled mind) cause the service to restart >> once

Re: [systemd-devel] Watchdog timeout signals

2014-11-24 Thread D.S. Ljungmark
On 24/11/14 17:58, Peter Sztanojev wrote: > On Mon, Nov 24, 2014 at 5:39 PM, D.S. Ljungmark wrote: >> Hi, >> We're pondering to use the WatchdogSec=.. function, but wanted to know >> what signal (if any) are sent to the application before termination. >> >> Main reason is that we want to get a pr

Re: [systemd-devel] [PATCH 4/4] coredump: collect all /proc data useful for bug reporting

2014-11-24 Thread Lennart Poettering
On Mon, 24.11.14 11:01, Jakub Filak (jfi...@redhat.com) wrote: > > char fd_name[sizeof("/proc/")-1 + DECIMAL_STR_MAX(pid_t) + sizeof("/fd/")-1 > > + DECIMAL_STR_MAX(int) + 1]; > > > OK, I thought systemd prefers alloca(). I was inspired by > procfs_file_alloca(). Well, this is a pseudo-functio

Re: [systemd-devel] [systemd-commits] src/cryptsetup

2014-11-24 Thread Quentin Lefebvre
Le 24/11/2014 19:17, Zbigniew Jędrzejewski-Szmek a écrit : On Mon, Nov 24, 2014 at 07:03:27PM +0100, Quentin Lefebvre wrote: Le 24/11/2014 19:01, Zbigniew Jędrzejewski-Szmek a écrit : On Mon, Nov 24, 2014 at 06:44:25PM +0100, Quentin Lefebvre wrote: Hi, I tested your patch and actually it doe

Re: [systemd-devel] [systemd-commits] src/cryptsetup

2014-11-24 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Nov 24, 2014 at 07:03:27PM +0100, Quentin Lefebvre wrote: > Le 24/11/2014 19:01, Zbigniew Jędrzejewski-Szmek a écrit : > >On Mon, Nov 24, 2014 at 06:44:25PM +0100, Quentin Lefebvre wrote: > >>Hi, > >> > >>I tested your patch and actually it doesn't solve the bug. > >>For example, if "hash=s

Re: [systemd-devel] [systemd-commits] src/cryptsetup

2014-11-24 Thread Quentin Lefebvre
Le 24/11/2014 19:01, Zbigniew Jędrzejewski-Szmek a écrit : On Mon, Nov 24, 2014 at 06:44:25PM +0100, Quentin Lefebvre wrote: Hi, I tested your patch and actually it doesn't solve the bug. For example, if "hash=sha512" is provided in /etc/crypttab, the first > if (!stre

Re: [systemd-devel] [systemd-commits] src/cryptsetup

2014-11-24 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Nov 24, 2014 at 06:44:25PM +0100, Quentin Lefebvre wrote: > Hi, > > I tested your patch and actually it doesn't solve the bug. > For example, if "hash=sha512" is provided in /etc/crypttab, the > first > if (!streq(arg_hash, "plain")) > is true, and the > > +

Re: [systemd-devel] Type=simple and BusName=

2014-11-24 Thread David Herrmann
Hi On Wed, Nov 19, 2014 at 2:05 PM, Umut Tezduyar Lindskog wrote: > Hi, > > Quote from man service: > > BusName= Takes a D-Bus bus name that this service is reachable as. > This option is mandatory for services where Type= is set to dbus, but > its use is otherwise recommended if the process take

Re: [systemd-devel] [PATCH] This patch solves the bug 52630 described here: https://bugs.freedesktop.org/show_bug.cgi?id=52630 .

2014-11-24 Thread Quentin Lefebvre
Hi, I reopened the bug after testing the patch. See: https://bugs.freedesktop.org/show_bug.cgi?id=52630 http://lists.freedesktop.org/archives/systemd-devel/2014-November/025490.html (sorry for the poor formatting of the last email). Best, Quentin Le 24/11/2014 15:21, Zbigniew Jędrzejewski-Szmek

Re: [systemd-devel] [systemd-commits] src/cryptsetup

2014-11-24 Thread Quentin Lefebvre
Hi, I tested your patch and actually it doesn't solve the bug. For example, if "hash=sha512" is provided in /etc/crypttab, the first > if (!streq(arg_hash, "plain")) is true, and the > +} else if (!key_file) is not reached. So I suggest rewriting the p

Re: [systemd-devel] Watchdog timeout signals

2014-11-24 Thread Peter Sztanojev
On Mon, Nov 24, 2014 at 5:39 PM, D.S. Ljungmark wrote: > Hi, > We're pondering to use the WatchdogSec=.. function, but wanted to know > what signal (if any) are sent to the application before termination. > > Main reason is that we want to get a proper stacktrace of the daemon if > it is killed f

[systemd-devel] Watchdog timeout signals

2014-11-24 Thread D.S. Ljungmark
Hi, We're pondering to use the WatchdogSec=.. function, but wanted to know what signal (if any) are sent to the application before termination. Main reason is that we want to get a proper stacktrace of the daemon if it is killed for some reason. //D.S. -- 8362 CB14 98AD 11EF CEB6 FA81 FCC3 767

Re: [systemd-devel] serialization bug, swap bug, etc.

2014-11-24 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Nov 24, 2014 at 07:48:17AM +0200, Mantas Mikulėnas wrote: > On Mon, Nov 24, 2014 at 2:59 AM, Zbigniew Jędrzejewski-Szmek < > zbys...@in.waw.pl> wrote: > > On Thu, Nov 20, 2014 at 09:13:02AM +0200, Mantas Mikulėnas wrote: > > > ~ If there are two .swap units for the same partition (one made

Re: [systemd-devel] [PATCH v3] smack: introduce new SmackProcessLabel option

2014-11-24 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Nov 24, 2014 at 08:46:20PM +0900, WaLyong Cho wrote: > In service file, if the file has some of special SMACK label in > ExecStart= and systemd has no permission for the special SMACK label > then permission error will occurred. To resolve this, systemd should > be able to set its SMACK lab

Re: [systemd-devel] [PATCH] This patch solves the bug 52630 described here: https://bugs.freedesktop.org/show_bug.cgi?id=52630 .

2014-11-24 Thread Quentin Lefebvre
On 24/11/2014 15:21, Zbigniew Jędrzejewski-Szmek wrote : On Wed, Nov 19, 2014 at 02:22:02PM +0100, Quentin Lefebvre wrote: For plain dm-crypt devices, the behavior of cryptsetup package is to ignore the hash algorithm when a key file is provided. With this patch, systemd-cryptsetup now behaves

Re: [systemd-devel] [PATCH] This patch solves the bug 52630 described here: https://bugs.freedesktop.org/show_bug.cgi?id=52630 .

2014-11-24 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Nov 19, 2014 at 02:22:02PM +0100, Quentin Lefebvre wrote: > >For plain dm-crypt devices, the behavior of cryptsetup package is to ignore > >the hash algorithm when a key file is provided. > >With this patch, systemd-cryptsetup now behaves as cryptsetup, so that old > >plain dm-crypt devic

Re: [systemd-devel] [PATCH v2] localed: validate set-x11-keymap input

2014-11-24 Thread David Herrmann
Hi On Wed, Nov 19, 2014 at 9:41 AM, Jan Synacek wrote: > David Herrmann writes: >> Hi >> >> On Fri, Nov 14, 2014 at 12:42 PM, Jan Synacek wrote: >>> Try to validate the input similarly to how setxkbmap does it. Multiple >>> layouts and variants can be specified, separated by a comma. Variants >

Re: [systemd-devel] [PATCH v2] localed: validate set-x11-keymap input

2014-11-24 Thread Jan Synacek
Lennart Poettering writes: > On Fri, 14.11.14 12:42, Jan Synacek (jsyna...@redhat.com) wrote: >> +if (look_for == LAYOUTS) { >> +Set *s; >> +char *k; >> +Iterator i; >> +/* XXX: Is there a better way to sort Hashmap keys? */ >

[systemd-devel] [PATCH v3] smack: introduce new SmackProcessLabel option

2014-11-24 Thread WaLyong Cho
In service file, if the file has some of special SMACK label in ExecStart= and systemd has no permission for the special SMACK label then permission error will occurred. To resolve this, systemd should be able to set its SMACK label to something accessible of ExecStart=. So introduce new SmackProce

[systemd-devel] [PATCH 5/5] machine-id-commit: add man pages

2014-11-24 Thread Didier Roche
>From 9b8d7613894838ce67db5141b8012b5abf7c02e4 Mon Sep 17 00:00:00 2001 From: Didier Roche Date: Mon, 24 Nov 2014 11:14:22 +0100 Subject: [PATCH 5/5] machine-id-commit: add man pages Add man pages for systemd-machine-id-commit.service and systemd-machine-id-commit. --- Makefile-man.am

[systemd-devel] [PATCH 4/5] machine-id-commit: add unit file

2014-11-24 Thread Didier Roche
>From 6821788f561770ea7e49f170a5bea4a7033f6ad3 Mon Sep 17 00:00:00 2001 From: Didier Roche Date: Mon, 24 Nov 2014 10:12:06 +0100 Subject: [PATCH 4/5] machine-id-commit: add unit file The unit file only active the machine-id-commit helper if /etc is mounted writable and /etc/machine-id is an ind

[systemd-devel] [PATCH 3/5] Introduce machine-id-commit binary

2014-11-24 Thread Didier Roche
>From 6a9dfa52ea8a5564c86942ac55c9173ee06f53fe Mon Sep 17 00:00:00 2001 From: Didier Roche Date: Mon, 24 Nov 2014 09:54:18 +0100 Subject: [PATCH 3/5] Introduce machine-id-commit binary This binary enables to commit transient machine-id on disk if it becomes writable. --- .gitignore

[systemd-devel] [PATCH 2/5] Add a machine_id_commit call to commit on disk a, transient machine-id

2014-11-24 Thread Didier Roche
>From 7506756189164ad7512a896b5d74e4eb1b19a1a5 Mon Sep 17 00:00:00 2001 From: Didier Roche Date: Mon, 24 Nov 2014 09:43:29 +0100 Subject: [PATCH 2/5] Add a machine_id_commit call to commit on disk a transient machine-id If /etc was read only at boot time with an empty /etc/machine-id, the latt

[systemd-devel] [PATCH 1/5] Factorize some machine-id-setup functions to be reused

2014-11-24 Thread Didier Roche
>From b4619f01b6f25752220b2fe5c5ccd22e248f4015 Mon Sep 17 00:00:00 2001 From: Didier Roche Date: Mon, 24 Nov 2014 09:40:57 +0100 Subject: [PATCH 1/5] Factorize some machine-id-setup functions to be reused --- src/core/machine-id-setup.c | 41 +++-- 1 file ch

Re: [systemd-devel] Hosts without /etc/machine-id on boot

2014-11-24 Thread Didier Roche
Le 21/11/2014 00:41, Lennart Poettering a écrit : On Thu, 20.11.14 17:23, Didier Roche (didro...@ubuntu.com) wrote: a) make /etc writable before systemd is invoked. If you use an initrd this is without risk, given that the initrd should really invoke fsck on the root disk anyway, and th

Re: [systemd-devel] [PATCH 4/4] coredump: collect all /proc data useful for bug reporting

2014-11-24 Thread Jakub Filak
On Fri, 2014-11-21 at 21:14 +0100, Lennart Poettering wrote: > On Wed, 19.11.14 11:01, Jakub Filak (jfi...@redhat.com) wrote: > > > +/* Joins /proc/[pid]/fd/ and /proc/[pid]/fdinfo/ into the following lines: > > + * > > + * 0:/dev/pts/23 > > + * pos:0 > > + * flags: 012 > > + * 1:/dev/pts

Re: [systemd-devel] [PATCH] networkd: disable tmpfiles and sysusers bits associated with networkd

2014-11-24 Thread Łukasz Stelmach
It was <2014-11-21 pią 21:36>, when Lennart Poettering wrote: > On Fri, 21.11.14 17:07, Łukasz Stelmach (l.stelm...@samsung.com) wrote: > >> On a system configured without networkd and sysusers there still needs >> to be the unnecessary systemd-network user, otherwise systemd-tmpfiles >> fails to s

[systemd-devel] [PATCH v2] networkd: disable tmpfiles and sysusers bits associated with networkd

2014-11-24 Thread Łukasz Stelmach
On a system configured without networkd and sysusers there still needs to be the unnecessary systemd-network user, otherwise systemd-tmpfiles fails to start. Use m4 to include information associated with networkd in tmpfiles.d and sysusers.d conditionally. Do not install it if netwrorkd is not ena