[systemd-devel] bug: offline update fails due to separate /var volume mounting too late

2015-01-08 Thread Chris Murphy
The gist is that when fstab specifies a separate volume to mount at /var, this happens too late for /var/.updated to get picked up and so offline updates aren't applied. systemd-216-12.fc21.x86_64 https://bugzilla.redhat.com/show_bug.cgi?id=1178978 -- Chris Murphy

Re: [systemd-devel] Questions regarding dbus started via systemd --user

2015-01-08 Thread Cameron Norman
On Thu, Jan 8, 2015 at 9:42 AM, Dimitri John Ledkov wrote: > On 8 January 2015 at 17:24, Simon McVittie > wrote: >> On 08/01/15 16:03, Dimitri John Ledkov wrote: >> * I'm in an X11 session and my GUI locks up. I use Ctrl+Alt+F1 >> and log in at the getty. How do I communicate with X11 session t

Re: [systemd-devel] [PATCH 1/2] Add detect_userns to detect uid/gid shifts

2015-01-08 Thread Stéphane Graber
On Fri, Jan 09, 2015 at 01:16:15AM +0100, Tom Gundersen wrote: > On Fri, Jan 9, 2015 at 12:55 AM, Stéphane Graber wrote: > > I expect we'll run into some more problems when dealing with units that > > start with their own view of /dev since mknod in a userns isn't allowed > > but I haven't run int

Re: [systemd-devel] [PATCH 1/2] Add detect_userns to detect uid/gid shifts

2015-01-08 Thread Tom Gundersen
On Fri, Jan 9, 2015 at 12:55 AM, Stéphane Graber wrote: > I expect we'll run into some more problems when dealing with units that > start with their own view of /dev since mknod in a userns isn't allowed > but I haven't run into one of those yet so it's not very high on my list. > > Once that happ

Re: [systemd-devel] [PATCH 1/2] Add detect_userns to detect uid/gid shifts

2015-01-08 Thread Stéphane Graber
On Fri, Jan 09, 2015 at 12:39:23AM +0100, Lennart Poettering wrote: > On Thu, 08.01.15 15:33, Stéphane Graber (stgra...@ubuntu.com) wrote: > > > As far as I know there's no obvious way to detect this case (well, > > short of trying a bunch of restricted syscalls). The only way I'm > > aware of is

Re: [systemd-devel] [PATCH 1/2] Add detect_userns to detect uid/gid shifts

2015-01-08 Thread Lennart Poettering
On Thu, 08.01.15 15:33, Stéphane Graber (stgra...@ubuntu.com) wrote: > As far as I know there's no obvious way to detect this case (well, > short of trying a bunch of restricted syscalls). The only way I'm > aware of is by comparing the target of /proc/self/ns/user to that of > /proc//ns/user whic

Re: [systemd-devel] [PATCH 1/2] Add detect_userns to detect uid/gid shifts

2015-01-08 Thread Stéphane Graber
On Thu, Jan 08, 2015 at 11:17:44PM +0100, Lennart Poettering wrote: > On Thu, 08.01.15 14:27, Stéphane Graber (stgra...@ubuntu.com) wrote: > > > This adds a new detect_userns function in virt.c which will check > > whether systemd is running in the host user namespace (single map of all > > availa

[systemd-devel] [PATCH] Add detect_userns to detect uid/gid shifts (V2)

2015-01-08 Thread Stéphane Graber
This adds a new detect_userns function in virt.c which will check whether systemd is running in the host user namespace (single map of all available uids and gids) or is using a uid/gid map. The check makes sure that uid_map and gid_map are both exactly equal to the default host map (assuming 32bi

Re: [systemd-devel] [PATCH 1/2] Add detect_userns to detect uid/gid shifts

2015-01-08 Thread Djalal Harouni
On Thu, Jan 08, 2015 at 09:25:07PM +0100, Tom Gundersen wrote: > On Thu, Jan 8, 2015 at 8:59 PM, Stéphane Graber wrote: > > On Thu, Jan 08, 2015 at 08:43:12PM +0100, Tom Gundersen wrote: > >> On Thu, Jan 8, 2015 at 8:27 PM, Stéphane Graber > >> wrote: > >> > +/* If both uid_map and gid_m

Re: [systemd-devel] [PATCH 1/2] Add detect_userns to detect uid/gid shifts

2015-01-08 Thread Lennart Poettering
On Thu, 08.01.15 14:27, Stéphane Graber (stgra...@ubuntu.com) wrote: > This adds a new detect_userns function in virt.c which will check > whether systemd is running in the host user namespace (single map of all > available uids and gids) or is using a uid/gid map. > > The check makes sure that u

Re: [systemd-devel] Fw: [PATCH] systemd-nspawn bash autocompletion

2015-01-08 Thread Zbigniew Jędrzejewski-Szmek
Applied. On Thu, Jan 08, 2015 at 09:51:49PM +0100, Carlos Morata Castillo wrote: > -complete -F _systemd_nspawn systemd-nspawn > +complete -F _systemd_nspawn systemd_nspawn This looks like a typo. I skipped that part. Zbyszek ___ systemd-devel mailing

Re: [systemd-devel] [PATCH 1/2] test-verbs: add unit tests for verbs minilib

2015-01-08 Thread Dave Reisner
On Thu, Jan 08, 2015 at 09:40:07PM +0100, Zbigniew Jędrzejewski-Szmek wrote: > On Sat, Dec 20, 2014 at 03:31:21PM -0800, Filipe Brandenburger wrote: > > Hi, > > > > On Sat, Dec 20, 2014 at 8:19 AM, Dave Reisner > > wrote: > > > --- > > > Makefile.am | 9 +- > > > src/test/test-ve

[systemd-devel] Fw: [PATCH] systemd-nspawn bash autocompletion

2015-01-08 Thread Carlos Morata Castillo
Sent attached. El Thu, 8 Jan 2015 21:40:07 +0100 Carlos Morata Castillo escribió: >Hi, > >*Autocompletion for dirs, doesn't leave until you press space. >*Added tmpfs, volatile and network-macvlan options. > >I tried with the SELinux options with seinfo(setools-console), but too >messy to get

Re: [systemd-devel] [PATCH] man (5) machine-info: add hostnamed chassis type "embedded"

2015-01-08 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Dec 20, 2014 at 03:09:19PM +0100, Peter Mattern wrote: > man machine-info lacks hostnamed chassis type "embedded" as introduced in > 218. The following lines should fix this. > > --- > man/machine-info.xml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/man/ma

[systemd-devel] [PATCH] systemd-nspawn bash autocompletion

2015-01-08 Thread Carlos Morata Castillo
Hi, *Autocompletion for dirs, doesn't leave until you press space. *Added tmpfs, volatile and network-macvlan options. I tried with the SELinux options with seinfo(setools-console), but too messy to get it right. Even Daniel Walsh haven't done it yet. :) diff --git a/shell-completion/bash/syste

Re: [systemd-devel] [PATCH 1/2] test-verbs: add unit tests for verbs minilib

2015-01-08 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Dec 20, 2014 at 03:31:21PM -0800, Filipe Brandenburger wrote: > Hi, > > On Sat, Dec 20, 2014 at 8:19 AM, Dave Reisner wrote: > > --- > > Makefile.am | 9 +- > > src/test/test-verbs.c | 78 > > +++ > > 2 files changed, 86 ins

Re: [systemd-devel] [PATCH 1/2] Add detect_userns to detect uid/gid shifts

2015-01-08 Thread Stéphane Graber
On Thu, Jan 08, 2015 at 09:25:07PM +0100, Tom Gundersen wrote: > On Thu, Jan 8, 2015 at 8:59 PM, Stéphane Graber wrote: > > On Thu, Jan 08, 2015 at 08:43:12PM +0100, Tom Gundersen wrote: > >> On Thu, Jan 8, 2015 at 8:27 PM, Stéphane Graber > >> wrote: > >> > +/* If both uid_map and gid_m

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-08 Thread Harald Hoyer
On 08.01.2015 18:30, Andrei Borzenkov wrote: > В Thu, 08 Jan 2015 17:12:25 +0100 > Harald Hoyer пишет: > >> On 08.01.2015 16:55, Lennart Poettering wrote: >>> On Thu, 08.01.15 16:34, Harald Hoyer (harald.ho...@gmail.com) wrote: >>> IMHO systemd-fsck-root.service should be removed e

Re: [systemd-devel] [PATCH] Add usernames as arguments to tmpfiles ignore directives.

2015-01-08 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 08, 2015 at 01:37:57PM +0100, Thomas Blume wrote: > Currently, systemd can only ignore files specified by their path, during > tmpdir cleanup. This patch adds the feature to give usernames as argument. > > During cleanup the file ownership is checked and files that match the > specifi

Re: [systemd-devel] [PATCH 1/2] Add detect_userns to detect uid/gid shifts

2015-01-08 Thread Tom Gundersen
On Thu, Jan 8, 2015 at 8:59 PM, Stéphane Graber wrote: > On Thu, Jan 08, 2015 at 08:43:12PM +0100, Tom Gundersen wrote: >> On Thu, Jan 8, 2015 at 8:27 PM, Stéphane Graber wrote: >> > +/* If both uid_map and gid_map don't exist or if they both match >> > + * the full uid/gid range,

Re: [systemd-devel] [PATCH 1/2] Add detect_userns to detect uid/gid shifts

2015-01-08 Thread Djalal Harouni
On Thu, Jan 08, 2015 at 02:59:46PM -0500, Stéphane Graber wrote: > On Thu, Jan 08, 2015 at 08:43:12PM +0100, Tom Gundersen wrote: > > On Thu, Jan 8, 2015 at 8:27 PM, Stéphane Graber wrote: > > > This adds a new detect_userns function in virt.c which will check > > > whether systemd is running in t

Re: [systemd-devel] [PATCH 1/2] Add detect_userns to detect uid/gid shifts

2015-01-08 Thread Stéphane Graber
On Thu, Jan 08, 2015 at 08:43:12PM +0100, Tom Gundersen wrote: > On Thu, Jan 8, 2015 at 8:27 PM, Stéphane Graber wrote: > > This adds a new detect_userns function in virt.c which will check > > whether systemd is running in the host user namespace (single map of all > > available uids and gids) or

Re: [systemd-devel] [PATCH 1/2] Add detect_userns to detect uid/gid shifts

2015-01-08 Thread Tom Gundersen
On Thu, Jan 8, 2015 at 8:27 PM, Stéphane Graber wrote: > This adds a new detect_userns function in virt.c which will check > whether systemd is running in the host user namespace (single map of all > available uids and gids) or is using a uid/gid map. > > The check makes sure that uid_map and gid_

Re: [systemd-devel] Questions regarding dbus started via systemd --user

2015-01-08 Thread Simon McVittie
On 08/01/15 17:42, Dimitri John Ledkov wrote: > On 8 January 2015 at 17:24, Simon McVittie > wrote: >> I personally think having only the user bus (and having >> (G_|DBUS_)BUS_TYPE_SESSION connect to it) is the best long-term setup, >> because it's easy to understand and does not try to impose iso

[systemd-devel] [PATCH 1/2] Add detect_userns to detect uid/gid shifts

2015-01-08 Thread Stéphane Graber
This adds a new detect_userns function in virt.c which will check whether systemd is running in the host user namespace (single map of all available uids and gids) or is using a uid/gid map. The check makes sure that uid_map and gid_map are both exactly equal to the default host map (assuming 32bi

[systemd-devel] [PATCH 2/2] Make OOMScoreAdjust non-fatal in user namespaces

2015-01-08 Thread Stéphane Graber
In a user namespace, uid 0 is mapped to a non-root uid outside the namespace. As a result, uid 0 in the namespace can only use the oom_adj scores which a regular user can use, all others fail with EACCES. This change makes it so that EACCES in a uid/gid shifted environment only results in a log en

Re: [systemd-devel] Questions regarding dbus started via systemd --user

2015-01-08 Thread Simon McVittie
On 08/01/15 17:04, Colin Guthrie wrote: > Although when I discussed this on the ML > before, one case which a PAM solution wouldn't address is people running > "startx" after logging into a tty session I personally am very tempted to say that startx users get to keep both pieces, and that the *dm

Re: [systemd-devel] Questions regarding dbus started via systemd --user

2015-01-08 Thread Dimitri John Ledkov
On 8 January 2015 at 17:24, Simon McVittie wrote: > On 08/01/15 16:03, Dimitri John Ledkov wrote: >> There is upstart --user spawned per session, and everything is under >> it. The sessions' logind cgroups are parent of all processes within a >> session, and there are sub cgroups as needed for con

Re: [systemd-devel] Questions regarding dbus started via systemd --user

2015-01-08 Thread Simon McVittie
On 08/01/15 17:24, Simon McVittie wrote: > This is a conversation about the distinction between a per-(uid,machine) > bus (the "user bus") and a per-login-session bus (the "session bus"). > We've had this discussion several times in the past Some further reading; I knew this conversation was old,

Re: [systemd-devel] Questions regarding dbus started via systemd --user

2015-01-08 Thread Dimitri John Ledkov
On 8 January 2015 at 17:15, Andrei Borzenkov wrote: > В Thu, 8 Jan 2015 16:03:43 + > Dimitri John Ledkov пишет: > >> On 8 January 2015 at 15:37, Simon McVittie >> wrote: >> > On 08/01/15 14:36, Colin Guthrie wrote: >> >> Lennart Poettering wrote on 08/01/15 13:19: >> Thus my expectation woul

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-08 Thread Andrei Borzenkov
В Thu, 08 Jan 2015 17:12:25 +0100 Harald Hoyer пишет: > On 08.01.2015 16:55, Lennart Poettering wrote: > > On Thu, 08.01.15 16:34, Harald Hoyer (harald.ho...@gmail.com) wrote: > > > >> IMHO > >> > >> systemd-fsck-root.service should be removed entirely and generated by the > >> fstab-generator i

Re: [systemd-devel] Questions regarding dbus started via systemd --user

2015-01-08 Thread Simon McVittie
On 08/01/15 16:03, Dimitri John Ledkov wrote: > There is upstart --user spawned per session, and everything is under > it. The sessions' logind cgroups are parent of all processes within a > session, and there are sub cgroups as needed for contained > jobs/processes. Thus for three graphical sessio

Re: [systemd-devel] Questions regarding dbus started via systemd --user

2015-01-08 Thread Andrei Borzenkov
В Thu, 8 Jan 2015 16:03:43 + Dimitri John Ledkov пишет: > On 8 January 2015 at 15:37, Simon McVittie > wrote: > > On 08/01/15 14:36, Colin Guthrie wrote: > >> Lennart Poettering wrote on 08/01/15 13:19: > >>> Yes, the idea is that these services become singleton services of the > >>> user, a

Re: [systemd-devel] Questions regarding dbus started via systemd --user

2015-01-08 Thread Colin Guthrie
Hi Simon, Hope my reply gets through to both lists (can't remember if I sub'ed to dbus in the past - I always read via gmane but am allowed to post on most of the lists...) Simon McVittie wrote on 08/01/15 12:39: > Adding D-Bus mailing list to Cc; questions about the user bus are > significant fo

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-08 Thread Harald Hoyer
On 08.01.2015 16:55, Lennart Poettering wrote: > On Thu, 08.01.15 16:34, Harald Hoyer (harald.ho...@gmail.com) wrote: > >> IMHO >> >> systemd-fsck-root.service should be removed entirely and generated by the >> fstab-generator in the real root like all the other mount points. > > Well, this servi

Re: [systemd-devel] Questions regarding dbus started via systemd --user

2015-01-08 Thread Dimitri John Ledkov
On 8 January 2015 at 15:37, Simon McVittie wrote: > On 08/01/15 14:36, Colin Guthrie wrote: >> Lennart Poettering wrote on 08/01/15 13:19: >>> Yes, the idea is that these services become singleton services of the >>> user, and the sessions ultimately only retain a "stub" process >> >> But dbus-dae

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-08 Thread Lennart Poettering
On Thu, 08.01.15 16:34, Harald Hoyer (harald.ho...@gmail.com) wrote: > IMHO > > systemd-fsck-root.service should be removed entirely and generated by the > fstab-generator in the real root like all the other mount points. Well, this service *is* special, it needs to run before the other fsck, an

Re: [systemd-devel] Questions regarding dbus started via systemd --user

2015-01-08 Thread Simon McVittie
On 08/01/15 14:36, Colin Guthrie wrote: > Lennart Poettering wrote on 08/01/15 13:19: >> Yes, the idea is that these services become singleton services of the >> user, and the sessions ultimately only retain a "stub" process > > But dbus-daemon itself might be excluded from that no? I mean the mod

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-08 Thread Harald Hoyer
On 08.01.2015 07:18, Andrei Borzenkov wrote: > В Wed, 07 Jan 2015 23:23:27 -0300 > Cristian Rodríguez пишет: > >> El 07/01/15 a las 22:55, Nikolai Zhubr escribió: >>> 08.01.2015 4:12, Cristian Rodríguez: El 07/01/15 a las 21:43, Lennart Poettering escribió: > Maybe suse forgot to in

Re: [systemd-devel] [PATCH udev v4] udev: Add builtin/rule to export touchscreen/tablet size as udev properties

2015-01-08 Thread Carlos Garnacho
Hey all, Now that holidays are over or almost, friendly ping about this one. I've got some pending GNOME patches eager to depend on this :). Is there anything else that needs considering/addressing? Cheers, Carlos On Mon, Dec 22, 2014 at 5:04 PM, Carlos Garnacho wrote: > This rule is only run

Re: [systemd-devel] Typo fix in libabc (you missed my prev. letter?)

2015-01-08 Thread Askar Safin
> Fixed. And your autogen.sh lost its executable bit ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] Questions regarding dbus started via systemd --user

2015-01-08 Thread Colin Guthrie
Lennart Poettering wrote on 08/01/15 13:19: > On Thu, 08.01.15 11:55, Colin Guthrie (co...@mageia.org) wrote: > >> Hi, >> >> I'm just playing around with this and making some progress. >> >> I've got a modified dbus-launch that can be slotted in nicely to poke >> dbus activated via systemd and tea

Re: [systemd-devel] [PATCH] perl-Net-DBus + new interactive authorization

2015-01-08 Thread Daniel P. Berrange
Re-sending as I wasn't subscribed to systemd-devel the first time, so it was rejected. On Wed, Jan 07, 2015 at 03:18:32PM +, Colin Guthrie wrote: > Hi Daniel, > > I've got a patch for perl-Net-DBus that adds support for the interactive > authorization stuff currently in dbus-1.9.x branch. >

[systemd-devel] journal verify problem

2015-01-08 Thread Michał Zegan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, I am running archlinux with systemd 218. My journal is sealed. But, when I try to verify it giving a verification key, then when user journals are verified, I always get the error "bad message". This happens only for user journals, system jour

Re: [systemd-devel] Questions regarding dbus started via systemd --user

2015-01-08 Thread Lennart Poettering
On Thu, 08.01.15 11:55, Colin Guthrie (co...@mageia.org) wrote: > Hi, > > I'm just playing around with this and making some progress. > > I've got a modified dbus-launch that can be slotted in nicely to poke > dbus activated via systemd and teach it about the environment for > subsequent launchi

Re: [systemd-devel] System halt on service stop

2015-01-08 Thread Lennart Poettering
On Wed, 07.01.15 19:00, Albert Strasheim (full...@gmail.com) wrote: > Hello all > > I'd like to find a clean way to halt a systemd system (actually, a > Docker container) when a "main" service stops (not just on failure). > > I tried Conflicts=systemd-halt.service and calling shutdown from > Exe

Re: [systemd-devel] [PATCH] build: print conditions of ldconfig, hibernate configs

2015-01-08 Thread David Herrmann
Hi On Tue, Dec 16, 2014 at 8:45 AM, Umut Tezduyar Lindskog wrote: > --- > configure.ac | 2 ++ > 1 file changed, 2 insertions(+) Applied! Thanks David > diff --git a/configure.ac b/configure.ac > index 90aa3cc..76d2119 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1442,6 +1442,8 @@ A

[systemd-devel] [PATCH] Add usernames as arguments to tmpfiles ignore directives.

2015-01-08 Thread Thomas Blume
Currently, systemd can only ignore files specified by their path, during tmpdir cleanup. This patch adds the feature to give usernames as argument. During cleanup the file ownership is checked and files that match the specified usernames are ignored. For example, you could give: X /tmp/* - - -

Re: [systemd-devel] Questions regarding dbus started via systemd --user

2015-01-08 Thread Simon McVittie
Adding D-Bus mailing list to Cc; questions about the user bus are significant for D-Bus as well as for systemd --user, and modifications of dbus-launch doubly so. On 08/01/15 11:55, Colin Guthrie wrote: > I've got a modified dbus-launch that can be slotted in nicely I'm happy for dbus to get bett

[systemd-devel] Questions regarding dbus started via systemd --user

2015-01-08 Thread Colin Guthrie
Hi, I'm just playing around with this and making some progress. I've got a modified dbus-launch that can be slotted in nicely to poke dbus activated via systemd and teach it about the environment for subsequent launching. It also pokes systemd --user with the environment too. It's pretty simply a

Re: [systemd-devel] Typo fix in libabc (you missed my prev. letter?)

2015-01-08 Thread Kay Sievers
On Thu, Jan 8, 2015 at 9:27 AM, Kay Sievers wrote: > On Thu, Jan 8, 2015 at 9:24 AM, Ivan Shapovalov wrote: >> On Thursday 08 January 2015 at 08:11:05, Martin Pitt wrote: >>> Hello Askar, >>> >>> Askar Safin [2015-01-07 1:13 +0300]: >>> > Hi. It seems you missed my prev. letter. So, I am sending

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-08 Thread Nikolai Zhubr
08.01.2015 5:13, Cristian Rodríguez: Ok. So should I file a report to opensuse bugtracker? Yes, against BaseSystem component. Bug 912209 https://bugzilla.opensuse.org/show_bug.cgi?id=912209 Thank you, Nikolai ___ systemd-devel mailing list system

Re: [systemd-devel] [PATCH] sd-bus: fix copy-paste error

2015-01-08 Thread David Herrmann
Hi On Thu, Jan 8, 2015 at 11:10 AM, Lukasz Skalski wrote: > --- > src/libsystemd/sd-bus/bus-control.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied! Thanks David > diff --git a/src/libsystemd/sd-bus/bus-control.c > b/src/libsystemd/sd-bus/bus-control.c > index 2db1afb..b450

[systemd-devel] [PATCH] sd-bus: fix copy-paste error

2015-01-08 Thread Lukasz Skalski
--- src/libsystemd/sd-bus/bus-control.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libsystemd/sd-bus/bus-control.c b/src/libsystemd/sd-bus/bus-control.c index 2db1afb..b450140 100644 --- a/src/libsystemd/sd-bus/bus-control.c +++ b/src/libsystemd/sd-bus/bus-control.c @

Re: [systemd-devel] Typo fix in libabc (you missed my prev. letter?)

2015-01-08 Thread Kay Sievers
On Thu, Jan 8, 2015 at 9:24 AM, Ivan Shapovalov wrote: > On Thursday 08 January 2015 at 08:11:05, Martin Pitt wrote: >> Hello Askar, >> >> Askar Safin [2015-01-07 1:13 +0300]: >> > Hi. It seems you missed my prev. letter. So, I am sending you the patch >> > again. Typo fix in README in libabc: >

Re: [systemd-devel] Typo fix in libabc (you missed my prev. letter?)

2015-01-08 Thread Ivan Shapovalov
On Thursday 08 January 2015 at 08:11:05, Martin Pitt wrote: > Hello Askar, > > Askar Safin [2015-01-07 1:13 +0300]: > > Hi. It seems you missed my prev. letter. So, I am sending you the patch > > again. Typo fix in README in libabc: > > -Make your code safe for unexpected termination and an