Re: [systemd-devel] [PATCH] sysv-generator: only allow regular files in enumerate_sysv()

2015-01-21 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 14, 2015 at 02:51:41AM -0300, Cristian Rodríguez wrote: > Otherwise, if the directory contains other directories we fail > at fopen in load_sysv() with EISDIR. > --- > src/sysv-generator/sysv-generator.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/sr

Re: [systemd-devel] [PATCH] build: export symbols to integrate mainloops

2015-01-21 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 21, 2015 at 10:59:45PM -0200, Lucas De Marchi wrote: > --- > src/libsystemd/libsystemd.sym.m4 | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/libsystemd/libsystemd.sym.m4 > b/src/libsystemd/libsystemd.sym.m4 > index 19a49f4..41418b9 100644 > --- a/src/libsystemd/libsy

Re: [systemd-devel] systemd-vconsole-setup fails very slowly

2015-01-21 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 21, 2015 at 07:15:12PM -0800, Andy Lutomirski wrote: > Hi all- > > When running virtme (a simple vm gadget) on Fedora 21, the slowest > part of bootup by far appears to be systemd-vconsole-setup: > > # time /usr/lib/systemd/systemd-vconsole-setup > putfont: PIO_FONT trying ... > .

[systemd-devel] systemd-vconsole-setup fails very slowly

2015-01-21 Thread Andy Lutomirski
Hi all- When running virtme (a simple vm gadget) on Fedora 21, the slowest part of bootup by far appears to be systemd-vconsole-setup: # time /usr/lib/systemd/systemd-vconsole-setup putfont: PIO_FONT trying ... ... setfont: putfont: 512,8x16: failed: -1 putfont: PIO_FONT: Invalid

[systemd-devel] [PATCH] build: export symbols to integrate mainloops

2015-01-21 Thread Lucas De Marchi
--- src/libsystemd/libsystemd.sym.m4 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libsystemd/libsystemd.sym.m4 b/src/libsystemd/libsystemd.sym.m4 index 19a49f4..41418b9 100644 --- a/src/libsystemd/libsystemd.sym.m4 +++ b/src/libsystemd/libsystemd.sym.m4 @@ -382,6 +382,9 @@ global:

Re: [systemd-devel] networkd link file not setting MTU

2015-01-21 Thread Tom Gundersen
On Wed, Jan 21, 2015 at 8:50 PM, Ian Pilcher wrote: > I found my problem: > > [root@localhost ~]# cat /usr/lib/systemd/network/99-default.link > [Link] > NamePolicy=kernel database onboard slot path > MACAddressPolicy=persistent > > It looks like this matches any interface and prevents any other s

Re: [systemd-devel] [PATCH] sysv-generator: Replace Provides: symlinks with real units

2015-01-21 Thread Jóhann B. Guðmundsson
On 01/21/2015 08:00 PM, Michael Biebl wrote: 2015-01-21 20:56 GMT+01:00 "Jóhann B. Guðmundsson" : On 01/21/2015 03:43 PM, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Jan 21, 2015 at 11:08:44AM +0100, Martin Pitt wrote: So I expect if it gets dropped upstream, a lot of distros (and all the majo

Re: [systemd-devel] [PATCH] sysv-generator: Replace Provides: symlinks with real units

2015-01-21 Thread Michael Biebl
2015-01-21 20:56 GMT+01:00 "Jóhann B. Guðmundsson" : > > On 01/21/2015 03:43 PM, Zbigniew Jędrzejewski-Szmek wrote: >> >> On Wed, Jan 21, 2015 at 11:08:44AM +0100, Martin Pitt wrote: >>> >>> >So I expect if it gets dropped upstream, a lot of distros (and all the >>> >major ones) will have to bring

Re: [systemd-devel] [PATCH] sysv-generator: Replace Provides: symlinks with real units

2015-01-21 Thread Jóhann B. Guðmundsson
On 01/21/2015 03:43 PM, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Jan 21, 2015 at 11:08:44AM +0100, Martin Pitt wrote: >So I expect if it gets dropped upstream, a lot of distros (and all the >major ones) will have to bring that back; it's IMHO better to just >maintain it upstream by the distro

Re: [systemd-devel] networkd link file not setting MTU

2015-01-21 Thread Ian Pilcher
I found my problem: [root@localhost ~]# cat /usr/lib/systemd/network/99-default.link [Link] NamePolicy=kernel database onboard slot path MACAddressPolicy=persistent It looks like this matches any interface and prevents any other settings from being applied. Renaming my file to /etc/systemd/netwo

Re: [systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-21 Thread Martin Pitt
Hey Simon, Simon McVittie [2015-01-21 14:31 +]: > systemd currently has > > AM_INIT_AUTOMAKE([foreign 1.11 -Wall -Wno-portability silent-rules > tar-pax no-dist-gzip dist-xz subdir-objects]) > > but Automake 1.11 and 1.12 use the old serial test harness by default. > That doesn't understand

Re: [systemd-devel] [PATCH] sysv-generator: Replace Provides: symlinks with real units

2015-01-21 Thread Martin Pitt
Hey Zbigniew, Zbigniew Jędrzejewski-Szmek [2015-01-21 16:36 +0100]: > On Wed, Jan 21, 2015 at 10:46:03AM +0100, Martin Pitt wrote: > > Keeping track of which alias symlinks we actually want is error prone, and > > restricting the creation of services for enabled init.d scripts would reduce > > the

Re: [systemd-devel] [PATCH] sysv-generator: Replace Provides: symlinks with real units

2015-01-21 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 21, 2015 at 11:08:44AM +0100, Martin Pitt wrote: > So I expect if it gets dropped upstream, a lot of distros (and all the > major ones) will have to bring that back; it's IMHO better to just > maintain it upstream by the distro maintainers. Exactly. Dropping it would be just busy work f

Re: [systemd-devel] [PATCH] sysv-generator: Replace Provides: symlinks with real units

2015-01-21 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 21, 2015 at 10:46:03AM +0100, Martin Pitt wrote: > Keeping track of which alias symlinks we actually want is error prone, and > restricting the creation of services for enabled init.d scripts would reduce > the utility of the generator (for manual starting disabled init.d scripts) as >

Re: [systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-21 Thread Dimitri John Ledkov
On 21 January 2015 at 14:31, Simon McVittie wrote: > On 20/01/15 20:33, Martin Pitt wrote: >> Dimitri John Ledkov [2015-01-20 18:23 +]: >>> With parallel test harness in automake (everyone should have it by >>> now) >> >> Yay, thanks for pointing this out! That makes the whole thing indeed >>

Re: [systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-21 Thread Simon McVittie
On 20/01/15 20:33, Martin Pitt wrote: > Dimitri John Ledkov [2015-01-20 18:23 +]: >> With parallel test harness in automake (everyone should have it by >> now) > > Yay, thanks for pointing this out! That makes the whole thing indeed > much friendlier. systemd currently has AM_INIT_AUTOMAKE([

Re: [systemd-devel] [PATCH v3] sysv-generator: Handle .sh suffixes when translating Provides:

2015-01-21 Thread Martin Pitt
Martin Pitt [2015-01-21 9:49 +0100]: > One more adjustment to master, considering a recent change in the > sysv-generator tests. Thomas and Michael both reviewed this patch, it's quite straightforward, and it fixes quite a severe regression, so I pushed it now. I don't want to push the other one

Re: [systemd-devel] [PATCH] sysv-generator: Handle .sh suffixes when translating Provides:

2015-01-21 Thread Michael Biebl
2015-01-20 17:44 GMT+01:00 Martin Pitt : > Hey all, > > the recent fix for sysv-generator's Provides: handling [1] caused, or > rather uncovered, another bug which now creates symlinks to itself > "foo.service -> foo.service" for any /etc/init.d/foo.sh. > > The generator would output an error messa

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-21 Thread Harald Hoyer
On 11.01.2015 12:57, Andrei Borzenkov wrote: > Does it using systemd *inside* of initrd? From upstream dracut: > > if ! dracut_module_included "systemd"; then > inst_hook cmdline 95 "$moddir/parse-block.sh" > inst_hook pre-udev 30 "$moddir/block-genrules.sh" > inst_hook

[systemd-devel] [logind] retroactive lid close handle upon vt switch

2015-01-21 Thread b3nmore
Hello, consider two vt sessions vt1, vt2. On vt1 handle-lid-switch is inhibited. Now the lid is closed and than a vt switch takes place (e.g. "sleep 10 && loginctl activate vt2"). Now the system suspends. I guess this is because the new active session has no inhibitor lock on handle-lid-switch and

Re: [systemd-devel] [PATCH] sysv-generator: Replace Provides: symlinks with real units

2015-01-21 Thread Martin Pitt
Hey Jóhann, "Jóhann B. Guðmundsson" [2015-01-21 9:59 +]: > Seems like a corner case as administrator should fix himself by not backing > up files in the /etc/init.d directory so arguably this broken behaviour is > expect. With SysV init this isn't "broken" at all. As long as you don't actual

Re: [systemd-devel] [PATCH] _systemctl.in: Do not interpret escape sequences in _filter_units_by_property

2015-01-21 Thread Martin Pitt
Hey Wieland, Wieland Hoffmann [2015-01-17 2:10 +0100]: > This makes all functions that rely on _f_u_b_p (like > _systemctl_{stop,kill,try_restart}) work with unit names that contain > backslash escaped sequences (like automount units with spaces that are > escaped to "\x20"). Confirmed to work.

Re: [systemd-devel] [PATCH] sysv-generator: Replace Provides: symlinks with real units

2015-01-21 Thread Jóhann B. Guðmundsson
On 01/21/2015 09:46 AM, Martin Pitt wrote: while working on the sysv generator, some more cases came up where the recently introduced "Provides:" symlink handling [1] causes trouble [2]. As soon as you have backup files like /etc/init.d/foo.bak, you'll get a "foo.service -> foo.bak.service" link

Re: [systemd-devel] [PATCH v2] sysv-generator: Handle .sh suffixes when translating Provides:

2015-01-21 Thread Martin Pitt
Dimitri John Ledkov [2015-01-21 9:47 +]: > I've also been bitten by generators defaulting to "do not override > file with same name" when writing out actual unit with contents. > There should not be any masked units inside generator/ generator.late/ > directories and thus if a file already exi

Re: [systemd-devel] [PATCH v2] sysv-generator: Handle .sh suffixes when translating Provides:

2015-01-21 Thread Dimitri John Ledkov
On 21 January 2015 at 07:27, Martin Pitt wrote: > Martin Pitt [2015-01-20 17:44 +0100]: >> the recent fix for sysv-generator's Provides: handling [1] caused, or >> rather uncovered, another bug which now creates symlinks to itself >> "foo.service -> foo.service" for any /etc/init.d/foo.sh. >> >> T

[systemd-devel] [PATCH] sysv-generator: Replace Provides: symlinks with real units

2015-01-21 Thread Martin Pitt
Hello all, while working on the sysv generator, some more cases came up where the recently introduced "Provides:" symlink handling [1] causes trouble [2]. As soon as you have backup files like /etc/init.d/foo.bak, you'll get a "foo.service -> foo.bak.service" link which prevents the creation of a

[systemd-devel] [PATCH v3] sysv-generator: Handle .sh suffixes when translating Provides:

2015-01-21 Thread Martin Pitt
Martin Pitt [2015-01-21 8:27 +0100]: > Reworked the patch to apply to current master (where the > sysv-generator test suite now landed), drop the log_debug() leftover, > and clean up the tests. One more adjustment to master, considering a recent change in the sysv-generator tests. Martin -- Mar

Re: [systemd-devel] networkd link file not setting MTU

2015-01-21 Thread Tom Gundersen
On Wed, Jan 21, 2015 at 2:53 AM, Cameron Norman wrote: > On Tue, Jan 20, 2015 at 4:40 PM, Tom Gundersen wrote: >> Hi Ian, >> >> Did you try to reboot? Note that .link files are applied by udev (so >> usually during early boot). You can override their settings from >> .network files in some cases