Re: [systemd-devel] [PATCH] udev: settle should return immediately when timeout is 0

2015-04-11 Thread Andrei Borzenkov
В Sat, 11 Apr 2015 23:31:05 +0300 Nir Soffer пишет: > udevadm manual says: > > A value of 0 will check if the queue is empty and always return > immediately. > > However, currently we ignore the deadline if the value is 0, and wait > without any limit. > > Zero timeout behaved accordin

Re: [systemd-devel] [RFC 0/6] A network proxy management daemon, systemd-proxy-discoveryd

2015-04-11 Thread Andrei Borzenkov
В Sat, 11 Apr 2015 19:41:15 + Zbigniew Jędrzejewski-Szmek пишет: > On Fri, Apr 10, 2015 at 03:17:37PM +0300, Tomasz Bursztyka wrote: > > Hi, > > > > As it has been discussed in the systemd hackfest during the Linux Conference > > Europe, one daemon could centralize the management of all netw

[systemd-devel] [PATCH] sd-dhcp-client: shutup gcc aliasing warning

2015-04-11 Thread Shawn Landden
we only access this as void* so there is no violation --- src/libsystemd-network/sd-dhcp-client.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libsystemd-network/sd-dhcp-client.c b/src/libsystemd-network/sd-dhcp-client.c index c44392e..bf57d4b 100644 --- a/src/libsy

Re: [systemd-devel] sd_event_run

2015-04-11 Thread Shawn Landden
On Sat, Apr 11, 2015 at 6:01 PM, Shawn Landden wrote: > On Sat, Apr 11, 2015 at 4:52 PM, Zbigniew Jędrzejewski-Szmek > wrote: >> On Fri, Apr 10, 2015 at 06:14:40PM +0200, Lennart Poettering wrote: >>> On Sat, 14.03.15 12:19, Tom Gundersen (t...@jklm.no) wrote: >>> >>> > > 1. shouldn't SD_EVENT_PA

Re: [systemd-devel] [systemd-commits] 2 commits - src/libsystemd-network src/udev

2015-04-11 Thread Jan Alexander Steffens
On Sun, Apr 12, 2015 at 1:49 AM, Shawn Landden wrote: > Given that we don't do any operations on it (besides memcmp which doesn't > matter) > it doesn't actually violate, but it does generate an annoying warning. What about making expected_chaddr a void pointer? Would that remove the warning? __

Re: [systemd-devel] sd_event_run

2015-04-11 Thread Shawn Landden
On Sat, Apr 11, 2015 at 4:52 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Fri, Apr 10, 2015 at 06:14:40PM +0200, Lennart Poettering wrote: >> On Sat, 14.03.15 12:19, Tom Gundersen (t...@jklm.no) wrote: >> >> > > 1. shouldn't SD_EVENT_PASSIVE become SD_EVENT_INITIAL? "passive" seems >> > > strange

Re: [systemd-devel] [systemd-commits] 8 commits - src/shared src/test src/tmpfiles

2015-04-11 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Apr 10, 2015 at 07:24:27AM -0700, Lennart Poettering wrote: > +static void item_array_sort(ItemArray *a) { > + > +/* Sort an item array, to enforce stable ordering in which we > + * apply things. */ > + > +if (a->count <= 1) > +return; > + > +

Re: [systemd-devel] [systemd-commits] 2 commits - src/libsystemd-network src/udev

2015-04-11 Thread Shawn Landden
On Fri, Apr 10, 2015 at 07:54:33PM +0200, Ronny Chevalier wrote: > On Fri, Apr 10, 2015 at 7:05 PM, Lennart Poettering > wrote: > > On Sat, 14.03.15 06:54, Ronny Chevalier (rcheval...@kemper.freedesktop.org) > > wrote: > > > >> commit 6ec8e7c763b7dfa82e25e31f6938122748d1608f > >> Author: Shawn La

Re: [systemd-devel] sd_event_run

2015-04-11 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Apr 10, 2015 at 06:14:40PM +0200, Lennart Poettering wrote: > On Sat, 14.03.15 12:19, Tom Gundersen (t...@jklm.no) wrote: > > > > 1. shouldn't SD_EVENT_PASSIVE become SD_EVENT_INITIAL? "passive" seems > > > strange > > >in this context. > > I found it weird to name this INITIAL (or "

[systemd-devel] [PATCH] udev: settle should return immediately when timeout is 0

2015-04-11 Thread Nir Soffer
udevadm manual says: A value of 0 will check if the queue is empty and always return immediately. However, currently we ignore the deadline if the value is 0, and wait without any limit. Zero timeout behaved according to the documentation until commit ead7c62ab7 (udevadm: settle - kill a

Re: [systemd-devel] [RFC 0/6] A network proxy management daemon, systemd-proxy-discoveryd

2015-04-11 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Apr 10, 2015 at 03:17:37PM +0300, Tomasz Bursztyka wrote: > Hi, > > As it has been discussed in the systemd hackfest during the Linux Conference > Europe, one daemon could centralize the management of all network proxy > configurations. Idea is something user can do per-application (like i

Re: [systemd-devel] [PATCH] udev: Restore udevadm settle timeout

2015-04-11 Thread Nir Soffer
On Sat, Apr 11, 2015 at 1:36 PM, David Herrmann wrote: > > @@ -139,6 +142,9 @@ static int adm_settle(struct udev *udev, int argc, char > > *argv[]) { > > break; > > } > > > > +if (now(CLOCK_MONOTONIC) >= deadline) > > +

Re: [systemd-devel] [RFC 1/6] proxy-discoveryd: Basic core added

2015-04-11 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Apr 10, 2015 at 03:17:38PM +0300, Tomasz Bursztyka wrote: > +# This file is part of systemd. > +# > +# systemd is free software; you can redistribute it and/or modify it > +# under the terms of the GNU Lesser General Public License as published by > +# the Free Software Foundation; either v

Re: [systemd-devel] SystemD, Gnome permission problems

2015-04-11 Thread Mantas Mikulėnas
On Sat, Apr 11, 2015 at 7:21 PM, Zbigniew Jędrzejewski-Szmek < zbys...@in.waw.pl> wrote: > On Sat, Apr 11, 2015 at 02:26:57PM +0200, Kai Krakow wrote: > > dean schrieb: > > > > > Ok thanks for your prompt reply. It is my understanding the the > > > house-keeping-plugin "cleans" /tmp so does it ne

Re: [systemd-devel] [PATCH 4/4] Add a new tmpfiles.d snippets to set the NOCOW the journal.

2015-04-11 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Apr 08, 2015 at 11:48:21PM +0200, Lennart Poettering wrote: > On Sun, 22.03.15 20:53, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > On Fri, Mar 20, 2015 at 07:06:28PM +0100, Goffredo Baroncelli wrote: > > > Hi Zbyszek, > > > > > > On 2015-03-21 14:37, Zbigniew Jędrzejewski-

Re: [systemd-devel] SystemD, Gnome permission problems

2015-04-11 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 11, 2015 at 02:26:57PM +0200, Kai Krakow wrote: > dean schrieb: > > > Ok thanks for your prompt reply. It is my understanding the the > > house-keeping-plugin "cleans" /tmp so does it need access? That sounds wrong. First, systemd is already cleaning /tmp, so nothing good is going to

Re: [systemd-devel] [PATCH 2/2] udev: Allow detection of udevadm settle timeout

2015-04-11 Thread David Herrmann
(Please keep the ML in CC) On Sat, Apr 11, 2015 at 5:38 PM, Nir Soffer wrote: > On Sat, Apr 11, 2015 at 1:50 PM, David Herrmann > wrote: >> >> Hi >> >> On Wed, Apr 8, 2015 at 9:40 PM, Nir Soffer wrote: >> > When udevadm settle times out, it exits with exit code 1. This make it >> > impossible f

[systemd-devel] [PATCH] input_id: Identify scroll-wheel device on Trust TB7300 tablet as keyboard

2015-04-11 Thread Hans de Goede
The Trust TB7300 (relabelled Waltop?) tablet has a scrollwheel which shows up as a /dev/input/event# node all by itself. Currently input_id does not set any ID_INPUT_FOO attr on this causing it it to not be recognized by Xorg / libinput. This commit fixes this by marking it with ID_INPUT_KEY. Cc:

Re: [systemd-devel] [PATCH 1/2] Revert patch 11689d2a which force the NOCOW attribute

2015-04-11 Thread Goffredo Baroncelli
Hi Lennart, On 2015-04-08 23:12, Lennart Poettering wrote: >> --- a/src/journal/journalctl.c >> > +++ b/src/journal/journalctl.c >> > @@ -1290,7 +1290,7 @@ static int setup_keys(void) { >> > size_t mpk_size, seed_size, state_size, i; >> > uint8_t *mpk, *seed, *state; >> >

Re: [systemd-devel] SystemD, Gnome permission problems

2015-04-11 Thread Kai Krakow
dean schrieb: > Ok thanks for your prompt reply. It is my understanding the the > house-keeping-plugin "cleans" /tmp so does it need access? Does systemD > "clean" its own /tmp files/folders? Yes, it does. See "man tmpfiles.d", it ships with defaults for the tmp directory. The directories you

Re: [systemd-devel] [PATCH] udevd: fix synchronization with settle when handling inotify events

2015-04-11 Thread David Herrmann
Hi On Tue, Apr 7, 2015 at 12:03 AM, Daniel Drake wrote: > udev uses inotify to implement a scheme where when the user closes > a writable device node, a change uevent is forcefully generated. > In the case of block devices, it actually requests a partition rescan. > > This currently can't be sync

Re: [systemd-devel] [PATCH] hwdb: add Samsung ATIV Book 6 / 8

2015-04-11 Thread David Herrmann
Hi On Tue, Apr 7, 2015 at 12:30 PM, wrote: > From: Gavin Li > > This adds support for the keyboard illumination keys and fixes > Fn+F1. > --- > hwdb/60-keyboard.hwdb | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/hwdb/60-keyboard.hwdb b/hwdb/60-keyboard.hwdb > index 8f0565d..84

Re: [systemd-devel] [PATCH 2/2] udev: Allow detection of udevadm settle timeout

2015-04-11 Thread David Herrmann
Hi On Wed, Apr 8, 2015 at 9:40 PM, Nir Soffer wrote: > When udevadm settle times out, it exits with exit code 1. This make it > impossible for users to detect a timeout and handle real errors. Now we > use exit code 3 on timeouts. What's the use-case for this? Thanks David > --- > src/udev/u

Re: [systemd-devel] [gummiboot][PATCH 1/5] Makefile: support non-x86 builds

2015-04-11 Thread Koen Kooi
On 11 April 2015 at 11:41, David Herrmann wrote: > Hi > > On Sat, Apr 11, 2015 at 10:23 AM, Koen Kooi wrote: >> Move the no-mmx/no-sse CFLAGS to X86-64 and IA32 defines in preparation >> for ARM32 and Aarch64 support. >> >> Signed-off-by: Koen Kooi >> --- >> Makefile.am | 12 +--- >> 1

Re: [systemd-devel] [PATCH v2 2/2] build: allow setting OBJCOPY

2015-04-11 Thread David Herrmann
Hi On Wed, Apr 8, 2015 at 10:33 PM, Marc-Antoine Perennou wrote: > --- > Makefile.am | 4 ++-- > configure.ac | 1 + > 2 files changed, 3 insertions(+), 2 deletions(-) Applied! Thanks David > diff --git a/Makefile.am b/Makefile.am > index 9b769ee..397a71c 100644 > --- a/Makefile.am > +++ b/M

Re: [systemd-devel] [PATCH v2 1/2] configure: allow setting EFI_CC

2015-04-11 Thread David Herrmann
Hi On Wed, Apr 8, 2015 at 10:33 PM, Marc-Antoine Perennou wrote: > --- > configure.ac | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied! Thanks David > diff --git a/configure.ac b/configure.ac > index 1608c83..7e4a574 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1147

Re: [systemd-devel] [PATCH 3/5] efi: use EFI_CC

2015-04-11 Thread David Herrmann
Hi On Tue, Apr 7, 2015 at 8:54 PM, Marc-Antoine Perennou wrote: > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 29111f5..1608c83 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1172,7 +1172,7 @@ AS_IF([test

Re: [systemd-devel] [PATCH 1/5] factory: install to datadir

2015-04-11 Thread David Herrmann
Hi On Tue, Apr 7, 2015 at 8:54 PM, Marc-Antoine Perennou wrote: > --- > Makefile.am | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied! Thanks David > diff --git a/Makefile.am b/Makefile.am > index a575af6..9fa4223 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -109,8 +1

Re: [systemd-devel] [PATCH] udev: Restore udevadm settle timeout

2015-04-11 Thread David Herrmann
Hi On Wed, Apr 8, 2015 at 3:04 AM, Nir Soffer wrote: > Commit 9ea28c55a2 (udev: remove seqnum API and all assumptions about > seqnums) introduced a regresion, ignoring the timeout option when > waiting until the event queue is empty. > > Previously, if the udev event queue was not empty when the

Re: [systemd-devel] [PATCH] 42-usb-hid-pm.rules: Fix tests for removable state

2015-04-11 Thread David Herrmann
Hi On Thu, Apr 9, 2015 at 3:58 AM, Matthew Garrett wrote: > From: Matthew Garrett > > We only care about whether our direct parent is removable, not whether any > further points up the tree are - the kernel will take care of policy for > those itself. This enables autosuspend on devices where th

Re: [systemd-devel] [PATCH] README: glibc version 2.16 is required for IP_UNICAST_IF

2015-04-11 Thread David Herrmann
Hi On Fri, Apr 10, 2015 at 7:39 PM, Łukasz Stelmach wrote: > https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=be08eda5 > https://bugs.gentoo.org/show_bug.cgi?id=546194 > --- > README | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) 2.16 is 3 years old, so this should be fine. If no

Re: [systemd-devel] [gummiboot][PATCH 5/5] Makefile.am: Add support for AARCH64

2015-04-11 Thread David Herrmann
Hi On Sat, Apr 11, 2015 at 10:23 AM, Koen Kooi wrote: > Aarch64 and ARM32 lack an EFI capable objcopy, so use the ldflags + -O > binary trick gnu-efi and the Red Hat shimloader are using. > > Signed-off-by: Koen Kooi > --- > Makefile.am | 15 +-- > 1 file changed, 13 insertions(+),

Re: [systemd-devel] [gummiboot][PATCH 4/5] util: confine x86 asm to x86 architectures

2015-04-11 Thread David Herrmann
Hi On Sat, Apr 11, 2015 at 10:23 AM, Koen Kooi wrote: > Also add a stub function that just returns '1' to avoid missing symbols. > > Signed-off-by: Koen Kooi > --- > src/efi/util.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/src/efi/util.c b/src/efi/util.c

Re: [systemd-devel] [gummiboot][PATCH 3/5] configure: add AARCH64 support

2015-04-11 Thread David Herrmann
Hi On Sat, Apr 11, 2015 at 10:23 AM, Koen Kooi wrote: > This is just plumbing to add ARCH_AARCH64 for makefile tests and > defining the machine name. > > Signed-off-by: Koen Kooi > --- > configure.ac | 4 > 1 file changed, 4 insertions(+) > > diff --git a/configure.ac b/configure.ac > inde

Re: [systemd-devel] [gummiboot][PATCH 2/5] util: use x86 ASM only on x86(-64) platforms.

2015-04-11 Thread David Herrmann
Hi On Sat, Apr 11, 2015 at 10:23 AM, Koen Kooi wrote: > Signed-off-by: Koen Kooi > --- > src/efi/util.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/efi/util.c b/src/efi/util.c > index ba5ed7d..689bc7c 100644 > --- a/src/efi/util.c > +++ b/src/efi/util.c > @@

Re: [systemd-devel] [gummiboot][PATCH 1/5] Makefile: support non-x86 builds

2015-04-11 Thread David Herrmann
Hi On Sat, Apr 11, 2015 at 10:23 AM, Koen Kooi wrote: > Move the no-mmx/no-sse CFLAGS to X86-64 and IA32 defines in preparation > for ARM32 and Aarch64 support. > > Signed-off-by: Koen Kooi > --- > Makefile.am | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) Applied to syst

Re: [systemd-devel] heads-up: chasing journal(?) related regression in 219 causing boot hang/fail

2015-04-11 Thread Martin Pitt
Hello Tobias, Tobias Hunger [2015-04-11 2:17 +0200]: > did you make any progress with this bug? Apparently the same issue is > blocking systemd-219 from getting into arch linux ( > https://bugs.archlinux.org/task/44016 ), so this seems to be a > wide-spread issue. Is anyone taking a serious look

[systemd-devel] [gummiboot][PATCH 2/5] util: use x86 ASM only on x86(-64) platforms.

2015-04-11 Thread Koen Kooi
Signed-off-by: Koen Kooi --- src/efi/util.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/efi/util.c b/src/efi/util.c index ba5ed7d..689bc7c 100644 --- a/src/efi/util.c +++ b/src/efi/util.c @@ -33,7 +33,9 @@ UINT64 ticks_read(VOID) { __asm__ volatile ("rdtsc"

[systemd-devel] [gummiboot][PATCH 4/5] util: confine x86 asm to x86 architectures

2015-04-11 Thread Koen Kooi
Also add a stub function that just returns '1' to avoid missing symbols. Signed-off-by: Koen Kooi --- src/efi/util.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/efi/util.c b/src/efi/util.c index 689bc7c..6ce1f18 100644 --- a/src/efi/util.c +++ b/src/efi/util.

[systemd-devel] [gummiboot][PATCH 1/5] Makefile: support non-x86 builds

2015-04-11 Thread Koen Kooi
Move the no-mmx/no-sse CFLAGS to X86-64 and IA32 defines in preparation for ARM32 and Aarch64 support. Signed-off-by: Koen Kooi --- Makefile.am | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/Makefile.am b/Makefile.am index 6568a35..2cca313 100644 --- a/Makefile.

[systemd-devel] [gummiboot][PATCH 5/5] Makefile.am: Add support for AARCH64

2015-04-11 Thread Koen Kooi
Aarch64 and ARM32 lack an EFI capable objcopy, so use the ldflags + -O binary trick gnu-efi and the Red Hat shimloader are using. Signed-off-by: Koen Kooi --- Makefile.am | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 2cca313.

[systemd-devel] [gummiboot][PATCH 3/5] configure: add AARCH64 support

2015-04-11 Thread Koen Kooi
This is just plumbing to add ARCH_AARCH64 for makefile tests and defining the machine name. Signed-off-by: Koen Kooi --- configure.ac | 4 1 file changed, 4 insertions(+) diff --git a/configure.ac b/configure.ac index 27bbe1d..c2077b1 100644 --- a/configure.ac +++ b/configure.ac @@ -51,6 +