[systemd-devel] [PATCH] networkd: don't touch global forwarding setting

2015-05-10 Thread Benedikt Morbach
This reverts commit 43c6d5abacaebf813845934ec8d5e5ee3c431854 (and a small part of 4046d8361c55c80ab8577aea52523b9e6eab0d0c) It turns out we don't actually need to set the global ip_forward setting. The only relevant setting is the one on each interface. What the global toggle actually does is swi

[systemd-devel] [RESEND][PATCH] man: IPMasquerade only implies IPForward=ipv4

2015-05-10 Thread Benedikt Morbach
at least that's what the code does. --- I didn't get any feedback last time[1], maybe this fell through the cracks? [1] http://lists.freedesktop.org/archives/systemd-devel/2015-April/031353.html man/systemd.network.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/syst

[systemd-devel] [PATCH 1/2] networkd: don't touch global forwarding setting

2015-04-29 Thread Benedikt Morbach
This reverts commit 43c6d5abacaebf813845934ec8d5e5ee3c431854. It turns out we don't actually need to set the global ip_forward setting for it to work on a per interface basis. What this toggle actually does is switch forwarding on/off for all currently present interfaces and change the default fo

[systemd-devel] [PATCH 2/2] networkd: IPMasquerade only implies IPForward=ipv4

2015-04-29 Thread Benedikt Morbach
at least that's what the code does --- man/systemd.network.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/systemd.network.xml b/man/systemd.network.xml index 31484d8..5504b46 100644 --- a/man/systemd.network.xml +++ b/man/systemd.network.xml @@ -382,7 +382,7 @@

[systemd-devel] networkd: ip forwarding fixes

2015-04-29 Thread Benedikt Morbach
After some more testing/thinking yesterday, I've decided to split this up and only do the bugfix for now. At least on my machine the global ip_forward setting is not needed, as long as all relevant interfaces have forwarding enabled. I still dislike that the default for networkd managed interfaces

Re: [systemd-devel] [PATCH] networkd: don't touch global forwarding setting

2015-04-28 Thread Benedikt Morbach
On Tue, Apr 28, 2015 at 7:36 PM, Lennart Poettering wrote: > If eth1 shows up first, then it will be configured, and thus the local > ip forwaring turned off, the global is left untouched. Since the other > interface hasn't shown up yet/has not been configured the global > setting doesn't matter f

[systemd-devel] [PATCH] networkd: don't touch global forwarding setting

2015-04-28 Thread Benedikt Morbach
this inevitably leads to race conditions and also means that IPForward=yes on one interface is equivalent to setting it on _every_ interface. (except when it isn't, see below) Suppose you have two networks * /etc/systemd/network/eth0.network [Match] Name=eth0 [Network] Address=1