Re: [systemd-devel] [RFC PATCH v6 3/5] ACPI: button: Rework lid_init_state=ignore mode

2017-06-23 Thread Benjamin Tissoires
orks it by unconditionally prepending "open" > complement events. Ouch. I thought the purpose of "ignore" was to not query the state on boot/resume and only rely on acpi notification to switch the states. I like the patch, the commit message is IMO too far from what it actuall

Re: [systemd-devel] [RFC PATCH v6 1/5] ACPI: button: Add a workaround to fix an order issue for old userspace

2017-06-23 Thread Benjamin Tissoires
it several seconds >(HoldoffTimeoutSec) before suspending the platform. Thus on case 4 >platforms, if users close lid, and re-open it during the >HoldoffTimeoutSec period, there is still no "open" events seen by the >userspace. Thus systemd still considers

Re: [systemd-devel] [RFC PATCH v6 2/5] ACPI: button: Add an optional workaround to fix an event missing issue for old userspace

2017-06-23 Thread Benjamin Tissoires
userspace programs. > > Users can configure update interval via button.lid_update_interval. > This should be configured to a smaller value than HoldoffTimeoutSec in > /etc/systemd/logind.conf. > > Cc: > Cc: Benjamin Tissoires > Cc: Peter Hutterer > Signed-off-by: Lv Zh

Re: [systemd-devel] [WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI

2017-06-16 Thread Benjamin Tissoires
On Jun 16 2017 or thereabouts, Zheng, Lv wrote: > Hi, Benjamin > > Let me just say something one more time. > > > From: Benjamin Tissoires [mailto:benjamin.tissoi...@redhat.com] [snip] > > > > > > > > > > We can see: > > > > > "

Re: [systemd-devel] [WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI

2017-06-16 Thread Benjamin Tissoires
le LID > > > > switch exported by ACPI > > > > > > > > On Thu, Jun 15, 2017 at 02:52:57AM +, Zheng, Lv wrote: > > > > > Hi, Benjamin > > > > > > > > > > > From: Benjamin Tissoires [mailto:ben

Re: [systemd-devel] [WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI

2017-06-13 Thread Benjamin Tissoires
Hi, [Sorry for the delay, I have been sidetracked from this] On Jun 07 2017 or thereabouts, Lennart Poettering wrote: > On Thu, 01.06.17 20:46, Benjamin Tissoires (benjamin.tissoi...@redhat.com) > wrote: > > > Hi, > > > > Sending this as a WIP as it still need a

Re: [systemd-devel] [WIP PATCH 2/4] ACPI: button: remove the LID input node when the state is unknown

2017-06-06 Thread Benjamin Tissoires
Hi Lv, On Jun 05 2017 or thereabouts, Zheng, Lv wrote: > Hi, Benjamin > > > From: Benjamin Tissoires [mailto:benjamin.tissoi...@redhat.com] > > Subject: [WIP PATCH 2/4] ACPI: button: remove the LID input node when the > > state is unknown > > > >

Re: [systemd-devel] [WIP PATCH 3/4] ACPI: button: Let input filter out the LID events

2017-06-06 Thread Benjamin Tissoires
On Jun 05 2017 or thereabouts, Zheng, Lv wrote: > Hi, Benjamin > > > From: Benjamin Tissoires [mailto:benjamin.tissoi...@redhat.com] > > Subject: [WIP PATCH 3/4] ACPI: button: Let input filter out the LID events > > > > The input stack already filters out

Re: [systemd-devel] [WIP PATCH 4/4] ACPI: button: Fix lid notification locks

2017-06-06 Thread Benjamin Tissoires
On Jun 05 2017 or thereabouts, Zheng, Lv wrote: > Hi, > > > From: Benjamin Tissoires [mailto:benjamin.tissoi...@redhat.com] > > Subject: [WIP PATCH 4/4] ACPI: button: Fix lid notification locks > > > > From: Lv Zheng > > > > acpi/button.c now conta

Re: [systemd-devel] [WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI

2017-06-02 Thread Benjamin Tissoires
On Jun 01 2017 or thereabouts, Bastien Nocera wrote: > On Thu, 2017-06-01 at 20:46 +0200, Benjamin Tissoires wrote: > > Hi, > > > > Sending this as a WIP as it still need a few changes, but it mostly > > works as > > expected (still not fully compliant yet). >

[systemd-devel] [WIP PATCH 1/4] ACPI: button: extract input creation/destruction helpers

2017-06-01 Thread Benjamin Tissoires
of the input node. Signed-off-by: Benjamin Tissoires --- drivers/acpi/button.c | 90 --- 1 file changed, 57 insertions(+), 33 deletions(-) diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c index 9ad8cdb..48bcdca 100644 --- a/drivers/acpi

[systemd-devel] [WIP PATCH 3/4] ACPI: button: Let input filter out the LID events

2017-06-01 Thread Benjamin Tissoires
itch state by some heuristics, this new state is forwarded to the listeners in the kernel. Signed-off-by: Benjamin Tissoires --- drivers/acpi/button.c | 156 -- 1 file changed, 139 insertions(+), 17 deletions(-) diff --git a/drivers/acpi/button.c

[systemd-devel] [WIP PATCH 4/4] ACPI: button: Fix lid notification locks

2017-06-01 Thread Benjamin Tissoires
notification to raw notifier in order not to have any events lost. Signed-off-by: Lv Zheng Signed-off-by: Benjamin Tissoires --- drivers/acpi/button.c | 68 --- 1 file changed, 27 insertions(+), 41 deletions(-) diff --git a/drivers/acpi/button.c b

[systemd-devel] [WIP PATCH 2/4] ACPI: button: remove the LID input node when the state is unknown

2017-06-01 Thread Benjamin Tissoires
ce to handle with a hwdb file and a udev rule. Note that this patch removes the filtering of duplicate events when calling blocking_notifier_call_chain(), but this will be addressed in a following patch. Signed-off-by: Benjamin Tissoires --- drivers/acpi/button.c | 207

[systemd-devel] [WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI

2017-06-01 Thread Benjamin Tissoires
ate events. One other benefit of this boilerplate is that when libinput changes the LID state, i915 and nouveau will get notified. Cheers, Benjamin [1] https://github.com/systemd/systemd/issues/2807 Benjamin Tissoires (3): ACPI: button: extract input creation/destruction helpers ACPI: button: r

Re: [systemd-devel] [RFC PATCH v3 1/5] ACPI: button: Add indication of BIOS notification and faked events

2017-05-29 Thread Benjamin Tissoires
Hi Lv, On May 27 2017 or thereabouts, Lv Zheng wrote: > This patch adds a parameter to acpi_lid_notify_state() so that it can act > differently against BIOS notification and kernel faked events. > > Cc: > Cc: Benjamin Tissoires > Cc: Peter Hutterer > Signed-off-by: Lv Zh

[systemd-devel] [PATCH 1/2] hwdb: add evdev entry for the Lenovo X230 series touchpad

2015-04-20 Thread Benjamin Tissoires
The Lenovo X230 advertize a vertical resolution of 136, which gives a true size of 31 mm. The actual physical size of the touchpad is 40 mm, so override the resolution to 100. --- hwdb/60-evdev.hwdb | 5 + 1 file changed, 5 insertions(+) diff --git a/hwdb/60-evdev.hwdb b/hwdb/60-evdev.hwdb in

[systemd-devel] [PATCH 2/2] hwdb: add Chromebook pixel (2015) resolution fix

2015-04-20 Thread Benjamin Tissoires
The atmel driver sets a default resolution of 20 for each touchpads it creates. On this model, 10 is more appropriate. The resolution is not set for the touchscreen by the kernel, so match the name to both touchpad and touchscreen. --- hwdb/60-evdev.hwdb | 7 +++ 1 file changed, 7 insertions(

Re: [systemd-devel] [PATCH] udev: input_id: tag accelerometers as ID_INPUT_ACCELEROMETER

2015-04-03 Thread Benjamin Tissoires
On Apr 03 2015 or thereabouts, David Herrmann wrote: > Hi > > On Fri, Apr 3, 2015 at 5:30 PM, Benjamin Tissoires > wrote: > > On Apr 03 2015 or thereabouts, David Herrmann wrote: > >> Hi > >> > >> On Fri, Apr 3, 2015 at 4:38 PM, Benjamin Tis

Re: [systemd-devel] [PATCH] udev: input_id: tag accelerometers as ID_INPUT_ACCELEROMETER

2015-04-03 Thread Benjamin Tissoires
On Apr 03 2015 or thereabouts, David Herrmann wrote: > Hi > > On Fri, Apr 3, 2015 at 4:38 PM, Benjamin Tissoires > wrote: > > On Apr 03 2015 or thereabouts, Hans de Goede wrote: > >> Hi, > >> > >> On 03-04-15 15:51, David Herrmann wrote: > >

Re: [systemd-devel] [PATCH] udev: input_id: tag accelerometers as ID_INPUT_ACCELEROMETER

2015-04-03 Thread Benjamin Tissoires
On Apr 03 2015 or thereabouts, Hans de Goede wrote: > Hi, > > On 03-04-15 15:51, David Herrmann wrote: > >Hi > > > >On Fri, Apr 3, 2015 at 12:07 PM, Hans de Goede wrote: > >>input_id already (tries to) tag accelerometers as such, but this only works > >>for absolute accelerometers. Recent kernels

Re: [systemd-devel] Supporting U2F over HID on Linux?

2014-11-02 Thread Benjamin Tissoires
On Sun, Nov 2, 2014 at 6:34 PM, Andy Lutomirski wrote: > On Sun, Nov 2, 2014 at 3:01 PM, Benjamin Tissoires > wrote: >> On Sun, Nov 2, 2014 at 5:49 PM, Andy Lutomirski wrote: >>> On Sun, Nov 2, 2014 at 2:45 PM, Benjamin Tissoires >>> wrote: >>>> O

Re: [systemd-devel] Supporting U2F over HID on Linux?

2014-11-02 Thread Benjamin Tissoires
On Sun, Nov 2, 2014 at 5:49 PM, Andy Lutomirski wrote: > On Sun, Nov 2, 2014 at 2:45 PM, Benjamin Tissoires > wrote: >> On Sun, Nov 2, 2014 at 4:40 PM, Jiri Kosina wrote: >>> On Sun, 2 Nov 2014, Jiri Kosina wrote: >>> >>>> Alternatively, you can