Alright, i just updated kdbus branch, and these issues is solved..
ons. 1. jul. 2015 kl. 22.20 skrev Daniel Buch :
> Hi,
>
> I been testing kdbus (v4.1 branch) and bus-proxy on kernel v4.1 (arch
> linux) and i just came across an inconsistency with my plain laptop/desktop
> se
Hi,
I been testing kdbus (v4.1 branch) and bus-proxy on kernel v4.1 (arch
linux) and i just came across an inconsistency with my plain laptop/desktop
setup.
dleyna crashes as i start gnome-calendar.
Also calendar doesn't seem to run aswell, im not able to check my entries
(Not sure what's causin
Patch attached. (git send-email currently brokken)
declarations with _cleanup_free_ attribute needs to be NULL initialized.
From e242049410bb8373f8724ac24328e0f024b9929b Mon Sep 17 00:00:00 2001
From: Daniel Buch
Date: Wed, 6 May 2015 10:28:08 +0200
Subject: [PATCH] systemctl: null-initialize
From 785b1367fedb912e91074360c0961209ac5dc9f8 Mon Sep 17 00:00:00 2001
From: Daniel Buch
Date: Thu, 30 Apr 2015 21:20:57 +0200
Subject: [PATCH] journal: .gitignore add audit_type-from-name*
---
src/journal/.gitignore | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/journal/.gitignore
Hi, I can confirm it works. Also I haven't noticed any complaints in the
journal. Good luck with v4.
lør. 14. feb. 2015 18.10 skrev David Herrmann :
> Hi Daniel!
>
> On Fri, Feb 13, 2015 at 1:16 PM, David Herrmann
> wrote:
> > Hi
> >
> > On Thu, Feb 12, 201
2 dbuch-laptop avahi-daemon[1217]: avahi-daemon 0.6.31
exiting.
This happens when you try to log on empathy, more specifically "Peoples
Nearby".
Let me know if you want additional logs or anything.
Cheers,
Daniel
2015-02-12 23:46 GMT+01:00 Daniel Buch :
> No problem, i will try do so
No problem, i will try do some extensive testing the next couple of days.
kdbus is now added to kernel entry cmdline :)
2015-02-12 19:12 GMT+01:00 David Herrmann :
> Hi
>
> On Wed, Feb 11, 2015 at 11:17 AM, Daniel Buch
> wrote:
> > Nice, everything works flawlessly with cur
Nice, everything works flawlessly with current git now. Good job!
2015-02-10 10:34 GMT+01:00 Daniel Buch :
> Hi,
>
> This is just a heads up.
>
> Avahi-daemon doesn't work on my system with kdbus and bus-proxyd. I
> appended a log. I hope this helps. Otherwise every thing
Hi,
This is just a heads up.
Avahi-daemon doesn't work on my system with kdbus and bus-proxyd. I
appended a log. I hope this helps. Otherwise every thing works quite well
for me with current systemd,kdbus git.
feb 10 10:11:12 dbuch-laptop avahi-daemon[2561]: avahi-daemon 0.6.31
exiting.
feb 10 1
Okay, Tom fixed this with 057255fbbf2ecb1c46e025b04087fa9340d9880d.
2015-02-03 21:50 GMT+01:00 Daniel Buch :
> Hi,
>
> This commit 51ddf61540976fc7b09ce5 solved systemd-resolved, but broke
> systemd-timesyncd. Atleast on my system.
>
> dbuch@dbuch-laptop ~ % lscpu | grep -i &
Hi,
This commit 51ddf61540976fc7b09ce5 solved systemd-resolved, but broke
systemd-timesyncd. Atleast on my system.
dbuch@dbuch-laptop ~ % lscpu | grep -i "byte"
Byte Order:Little Endian
dbuch@dbuch-laptop ~ % SYSTEMD_LOGLEVEL=debug sudo
/usr/lib/systemd/systemd-timesyncd
Failed to en
Nevermind, ignore this. This is of course only where gcc complaints.
Den 04/11/2014 20.53 skrev "Daniel Buch" :
> This is recently added by david. And i like replace return -errno treewide
> if desired?
>
> I suppose its safe and correct to assume every return -e
This is recently added by david. And i like replace return -errno treewide if
desired?
I suppose its safe and correct to assume every return -errno can be replaced?
---
src/sysusers/sysusers.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/src/sys
I think you might want to cast it to avoid compiler warning. Like:
(void) base_filesystem_create()
Den 04/11/2014 17.36 skrev :
> From: Harald Hoyer
>
> Not all switch roots are like base_filesystem_create() wants them
> to look like. They might even boot, if they are RO and don't have the FS
> l
My general understanding is equal to dale. But with some consideration it
led me to agree with the warning approach. Its no big deal setting EDITOR.
Den 14/10/2014 01.06 skrev "Ronny Chevalier" :
> 2014-10-13 16:13 GMT+02:00 Simon McVittie >:
> > On 13/10/14 14:38, Dale R. Worley wrote:
> >> My g
Nice, I was in the process of implementing this. Looks good to me. But I
think it would be better to use "vi" instead of "vim" if no &editor is set.
Vim is not installed on every system as default but vi is most likely.
Den 11/10/2014 18.37 skrev "Ronny Chevalier" :
> It helps editing units by eit
'systemctl list-unit-files'.
They used to timeout after 2 minutes so this looks promising.
2014-10-09 18:23 GMT+02:00 Lennart Poettering :
> On Fri, 03.10.14 22:00, Daniel Buch (boogiewasth...@gmail.com) wrote:
>
> > Hi,
> >
> > With current git and since 430e21c
No runtime kdbus but --enable-kdbus configuration at build time
Den 08/10/2014 17.11 skrev "Lennart Poettering" :
> On Fri, 03.10.14 22:00, Daniel Buch (boogiewasth...@gmail.com) wrote:
>
> > Hi,
> >
> > With current git and since 430e21c2f7e77d600257ead56419f5
18:26 GMT+02:00 David Herrmann :
> Hi
>
> On Fri, Oct 3, 2014 at 10:00 PM, Daniel Buch
> wrote:
> > Hi,
> >
> > With current git and since 430e21c2f7e77d600257ead56419f51 i keep on
> getting
> > timeout on these units
> >
>
> I also occasionally ge
]: systemd-hostnamed.service failed.
2014-10-04 7:12 GMT+02:00 Andrei Borzenkov :
> В Fri, 3 Oct 2014 22:00:50 +0200
> Daniel Buch пишет:
>
> > Hi,
> >
> > With current git and since 430e21c2f7e77d600257ead56419f51 i keep on
> > getting timeout on these units
> &g
Hi,
With current git and since 430e21c2f7e77d600257ead56419f51 i keep on
getting timeout on these units
dbuch@dbuch-laptop ~/dev/systemd (git)-[master] % systemctl --failed
UNIT LOAD ACTIVE SUBDESCRIPTION
● systemd-hostnamed.service loaded failed failed Hostname Servi
I just hit this assert on my arch system with gcc 4.9,
dbuch-laptop systemd-resolved[457]: Assertion 's->protocol ==
DNS_PROTOCOL_LLMNR' failed at src/resolve/resolved-dns-scope.c:369
2014-08-14 19:58 GMT+02:00 Lennart Poettering :
> On Sat, 19.07.14 10:37, Thomas H.P. Andersen (pho...@gmail.co
Lets mimic colored operational state dump as if link name is appiled
---
src/network/networkctl.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/network/networkctl.c b/src/network/networkctl.c
index 731ad27..9c4c1b7 100644
--- a/src/network/networkctl.c
+++ b
Cool, its fixed.
2014-08-13 21:08 GMT+02:00 Lennart Poettering :
> On Wed, 13.08.14 21:01, Daniel Buch (boogiewasth...@gmail.com) wrote:
>
> > Indeed, i run gnome and gnomes NetworkManager.
> >
> > I just tested the binary approach with LOG_LEVEL=debug (log attached
&
: 1407956263.730
constant : 1
offset : -0.355 sec
freq offset : +0 (0 ppm)
interval/delta/delay/jitter/drift 32s/-0.355s/0.040s/0.000s/+0ppm
2014-08-13 20:47 GMT+02:00 Lennart Poettering :
> On Wed, 13.08.14 20:35, Daniel Buch (boogiewasth...@gmail.com) wrote:
>
> >
With current git i noticed systemd-timesyncd failed and complain like this,
log attached below.
aug 13 20:12:08 dbuch-laptop systemd[1]: Starting Network Time
Synchronization...
aug 13 20:12:08 dbuch-laptop systemd[1]: systemd-timesyncd.service: main
process exited, code=exited, status=1/FAILURE
a
We need to check if argv[1] is set before compare
---
src/analyze/analyze.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/analyze/analyze.c b/src/analyze/analyze.c
index 66e2aab..83da7f5 100644
--- a/src/analyze/analyze.c
+++ b/src/analyze/analyze.c
@@ -1349,7 +1349,7 @@
Its false positive but lets make gcc happy
---
src/journal/coredump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/journal/coredump.c b/src/journal/coredump.c
index 182c2b1..a361a51 100644
--- a/src/journal/coredump.c
+++ b/src/journal/coredump.c
@@ -700,7 +700,7 @@ log:
Im not sure if we want the help approach or just fail?
I can change this and resed if you want.
Assertion 'strv_uniq(ans)' failed at src/verify/verify.c:53, function
generate_path(). Aborting.
[1]4795 abort (core dumped) systemd-verify
---
src/verify/verify.c | 9 -
1 file changed,
You are right! Sorry for the confusion
2014-06-26 14:04 GMT+02:00 Zbigniew Jędrzejewski-Szmek :
> On Thu, Jun 26, 2014 at 01:49:56PM +0200, Daniel Buch wrote:
> > Well we assign fd to be -1 above signalfd() and afterwards never read it.
> > That's what my compi
40604 (prerelease) (GCC)
2014-06-26 13:12 GMT+02:00 Zbigniew Jędrzejewski-Szmek :
> On Thu, Jun 26, 2014 at 12:50:40PM +0200, Daniel Buch wrote:
> > Not sure this is an appropiate fix, feel free to leave it out
> >
> > ---
> > src/shared/ask-password-api.c | 2 +-
> &
Not sure this is an appropiate fix, feel free to leave it out
---
src/shared/ask-password-api.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/shared/ask-password-api.c b/src/shared/ask-password-api.c
index 5997a03..39eab0d 100644
--- a/src/shared/ask-password-api.c
+++ b
Lets allow LC_ALL=C without corrupted output
---
src/bus-proxyd/bus-policy.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/bus-proxyd/bus-policy.c b/src/bus-proxyd/bus-policy.c
index 053495c..2df4bf7 100644
--- a/src/bus-proxyd/bus-policy.c
+++ b/src/bus-proxyd/bu
Have you compiled with: -lsystemd?
2014-05-14 11:48 GMT+02:00 Hurry Zeng :
> Hi All,
>
> i tried to compile some source code on archlinux (v 2014.05.01), but i got
> an error: (header missing ?)
> fatal error:* systemd/sd-event.h*: No such file or directory
> #include
> ^
> comp
No problem :)
2014-04-09 11:46 GMT+02:00 Daniel Mack :
> On 04/09/2014 11:43 AM, Daniel Buch wrote:
> > ---
> > connection.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/connection.c b/connection.c
> > index 2d69f17
---
connection.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/connection.c b/connection.c
index 2d69f17..5e7d553 100644
--- a/connection.c
+++ b/connection.c
@@ -1024,7 +1024,7 @@ int kdbus_cmd_msg_recv(struct kdbus_conn *conn,
/* just drop the message */
i
It seems to be a clang-analyzer problem since it don't behave like
clang-compiler regarding -std={c99,gnu99}
---
autogen.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/autogen.sh b/autogen.sh
index 9b4781c..449a2e6 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -72,7 +72,7 @@
/test-resolve.c
+++ b/src/libsystemd/sd-resolve/test-resolve.c
@@ -4,6 +4,7 @@
This file is part of systemd.
Copyright 2005-2008 Lennart Poettering
+ Copyright 2014 Daniel Buch
systemd is free software; you can redistribute it and/or modify it
under the terms of the GNU Lesser General
/test-resolve.c
+++ b/src/libsystemd/sd-resolve/test-resolve.c
@@ -4,6 +4,7 @@
This file is part of systemd.
Copyright 2005-2008 Lennart Poettering
+ Copyright 2014 Daniel Buch
systemd is free software; you can redistribute it and/or modify it
under the terms of the GNU Lesser General
---
src/core/socket.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/src/core/socket.c b/src/core/socket.c
index 35531ed..8ecc9f9 100644
--- a/src/core/socket.c
+++ b/src/core/socket.c
@@ -597,13 +597,7 @@ static void socket_dump(Unit *u, FILE *f, const char
*prefix) {
---
TODO| 1 -
test/TEST-01-BASIC/test.sh | 2 ++
test/TEST-02-CRYPTSETUP/test.sh | 2 ++
test/TEST-03-JOBS/test-jobs.sh | 1 +
test/TEST-03-JOBS/test.sh | 2 ++
test/rules-test.sh | 2 ++
6 files changed, 9 insertions(+), 1 deletion(-)
diff --
Hi,
Hope this is not completly ridiculous?
I havnt tested this since im not entirely sure how to do it.
So tips and comments regarding that are very welcome, im tempt to research
further and maybe eventually provide a test for socket-proxy.
Best regards.
---
Makefile.am |
---
NEWS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 6a6635b..5da5891 100644
--- a/NEWS
+++ b/NEWS
@@ -212,7 +212,7 @@ CHANGES WITH 209:
time, and those which should be run only at boot (for
example, a line that creates /run/nologin).
Ooops, sorry about double post -.-
2014/1/18 Daniel Buch
> ---
> src/libsystemd/sd-resolve.c | 36 ++--
> 1 file changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/src/libsystemd/sd-resolve.c b/src/libsystemd/sd-resolve.c
> inde
---
TODO| 1 -
src/libsystemd/sd-resolve.c | 4 ++--
src/systemd/sd-resolve.h| 9 +++--
3 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/TODO b/TODO
index 91a7bda..a842158 100644
--- a/TODO
+++ b/TODO
@@ -38,7 +38,6 @@ Features:
- maybe simplify fun
---
TODO | 1 -
src/libsystemd/resolve-util.h | 2 --
src/libsystemd/sd-resolve.c | 11 ---
src/libsystemd/test-resolve.c | 2 +-
4 files changed, 1 insertion(+), 15 deletions(-)
diff --git a/TODO b/TODO
index a567669..91a7bda 100644
--- a/TODO
+++ b/TODO
@@
---
src/libsystemd/sd-resolve.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/src/libsystemd/sd-resolve.c b/src/libsystemd/sd-resolve.c
index b6bf8d4..464967b 100644
--- a/src/libsystemd/sd-resolve.c
+++ b/src/libsystemd/sd-resolve.c
@@
---
src/libsystemd/sd-resolve.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/libsystemd/sd-resolve.c b/src/libsystemd/sd-resolve.c
index 6958aa9..7cc8dc4 100644
--- a/src/libsystemd/sd-resolve.c
+++ b/src/libsystemd/sd-resolve.c
@@ -423,7 +423,7 @@ sd_resolve* sd_r
---
TODO| 1 -
src/libsystemd/sd-resolve.c | 4 ++--
src/systemd/sd-resolve.h| 9 +++--
3 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/TODO b/TODO
index 91a7bda..a842158 100644
--- a/TODO
+++ b/TODO
@@ -38,7 +38,6 @@ Features:
- maybe simplify fun
---
TODO | 1 -
src/libsystemd/resolve-util.h | 2 --
src/libsystemd/sd-resolve.c | 11 ---
src/libsystemd/test-resolve.c | 2 +-
4 files changed, 1 insertion(+), 15 deletions(-)
diff --git a/TODO b/TODO
index a567669..91a7bda 100644
--- a/TODO
+++ b/TODO
@@
---
src/libsystemd/sd-resolve.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/libsystemd/sd-resolve.c b/src/libsystemd/sd-resolve.c
index 6958aa9..7cc8dc4 100644
--- a/src/libsystemd/sd-resolve.c
+++ b/src/libsystemd/sd-resolve.c
@@ -423,7 +423,7 @@ sd_resolve* sd_r
lets get this right once, and if not for all, atleast for now :)
So comments and input about nameing is very welcome.
Cheers
---
src/libsystemd/sd-resolve.c | 210 ++--
1 file changed, 105 insertions(+), 105 deletions(-)
diff --git a/src/libsystemd/sd-re
We dont want _t prefixes, right?
---
src/libsystemd/resolve-util.h | 2 +-
src/libsystemd/sd-resolve.c | 72 +--
src/libsystemd/test-resolve.c | 4 +--
src/systemd/sd-resolve.h | 42 -
4 files changed, 60 insertions(+), 60 d
hat for a few releases (we'll use it
> internally first to make sure it is the way we want it).
>
> Or are there any benefits to these annotations even when the symbols
> are not exported?
>
> -t
>
> On Tue, Jan 14, 2014 at 3:04 PM, Daniel Buch
&g
---
src/libsystemd/sd-resolv.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/src/libsystemd/sd-resolv.c b/src/libsystemd/sd-resolv.c
index b8288ba..cd79a6c 100644
--- a/src/libsystemd/sd-resolv.c
+++ b/src/libsystemd/sd-resolv.c
@@ -41
---
src/libsystemd/sd-resolv.c | 282 +--
src/libsystemd/test-resolv.c | 26 ++--
src/systemd/sd-resolv.h | 48
3 files changed, 178 insertions(+), 178 deletions(-)
diff --git a/src/libsystemd/sd-resolv.c b/src/libsystemd/sd-resolv.c
index
---
src/libsystemd/resolv-util.h | 12 +++---
src/libsystemd/sd-resolv.c | 100 +--
src/libsystemd/test-resolv.c | 38
src/systemd/sd-resolv.h | 80 +-
4 files changed, 115 insertions(+), 115 deletio
Ohh.. that sounds reasonable, i can do the git mv and renameig (And squash
to a single commit) when the decision is set :)
2014/1/13 Tom Gundersen
> On Mon, Jan 13, 2014 at 8:56 AM, Daniel Buch
> wrote:
> > Okay, guess thats right? Second opinion, lennart? Kay?
>
> Yeah, w
---
src/libsystemd-bus/sd-dns.c | 34 --
src/libsystemd-bus/test-dns.c | 21 ++---
2 files changed, 30 insertions(+), 25 deletions(-)
diff --git a/src/libsystemd-bus/sd-dns.c b/src/libsystemd-bus/sd-dns.c
index 8126cb3..0f90d02 100644
--- a/src/li
---
src/libsystemd-bus/dns-util.h | 12 ++---
src/libsystemd-bus/sd-dns.c | 100 +-
src/libsystemd-bus/test-dns.c | 26 +--
src/systemd/sd-dns.h | 46 +--
4 files changed, 92 insertions(+), 92 deletions(-)
diff --git a/
Hi,
bisect tells me this commit, 8b255ecd99dfee, causes gdm to crash when
--enable-kdbus is configured and the kdbus module isn't loaded.
Gdm starts but crashes and restarts as you enter your (correct)password.
Is this correct? Or am i missing something?
_
Hi again,
Im hopeing we can continue in-tree since its easier from here, and im unable to
get the time i want at the moment.
But i will ofcourse continue to help where i can when time permits.
I think the file nameing and locations are right?
Anyway heres what i got so far
---
Makefile.am
Yes im still working on it (Should have been finished days ago. 24 hours a
day is again not enough -.-). So far i went for the threaded version, and
cleaned up stuff according to this mail thread.
And i updated it to match systemd with c99 null initialisation of structs
etc. That might be wrong si
Cool, thanks you for the very decent reply.. I will work on this the next
few days, you can then expect some new RFC's :)
2013/12/11 Lennart Poettering
> On Wed, 11.12.13 02:18, Lennart Poettering (lenn...@poettering.net) wrote:
>
> > > C99 or C89? Do we want it to be public or private?
> >
> >
Hi,
So i layed the foundation of this libary to fit systemd
But what is actually desired?
C99 or C89? Do we want it to be public or private? Is modernization desired?
Daniel Buch (1):
Initial libsystemd-asyncns commit
Makefile.am | 23 +
src/libsystemd-asyncns
Also for log_error() except where a specific error is specified
e.g. errno ? strerror(errno) : "Some user specified message"
---
TODO | 2 --
src/core/automount.c | 2 +-
src/core/main.c| 2 +-
src/core/manager.c | 2 +-
src/core
> On Thu, Oct 31, 2013 at 10:03:07AM +0100, Daniel Buch wrote:
> > Hi there,
> >
> > By these 3 patches test_strv.c should be complete
> Applied as one patch.
>
> > Sorry for the tap mess i pushed, wont happen again ;)
Hi there,
By these 3 patches test_strv.c should be complete
Sorry for the tap mess i pushed, wont happen again ;)
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
---
src/test/test-strv.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/src/test/test-strv.c b/src/test/test-strv.c
index 9b51d82..e468859 100644
--- a/src/test/test-strv.c
+++ b/src/test/test-strv.c
@@ -199,6 +199,22 @@ static void test_strv_split_nulstr(void) {
a
---
src/test/test-strv.c | 16
1 file changed, 16 insertions(+)
diff --git a/src/test/test-strv.c b/src/test/test-strv.c
index f32d02e..e96200e 100644
--- a/src/test/test-strv.c
+++ b/src/test/test-strv.c
@@ -156,6 +156,21 @@ static void test_strv_quote_unquote(const char* const
---
src/test/test-strv.c | 16
1 file changed, 16 insertions(+)
diff --git a/src/test/test-strv.c b/src/test/test-strv.c
index e96200e..9b51d82 100644
--- a/src/test/test-strv.c
+++ b/src/test/test-strv.c
@@ -171,6 +171,21 @@ static void test_strv_split(void) {
}
}
+s
---
src/test/test-strv.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/src/test/test-strv.c b/src/test/test-strv.c
index c3d536d..de5cef0 100644
--- a/src/test/test-strv.c
+++ b/src/test/test-strv.c
@@ -282,6 +282,34 @@ static void test_strv_append(void) {
---
src/shared/install.c | 1 -
src/shared/path-lookup.h | 2 ++
src/systemctl/systemctl.c | 4 +---
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/shared/install.c b/src/shared/install.c
index 3bced1a..987b36d 100644
--- a/src/shared/install.c
+++ b/src/shared/install.c
I run with SigLevel = Required DatabaseOptional. And i guess that's
recommended. Have you tried pacman-key --init before you --populate
archlinux?
2013/8/17 Zbigniew Jędrzejewski-Szmek
> Hi,
>
> I was trying to get the arch installation example in systemd-spawn
> to work on Fedora. My intent is
http://cgit.freedesktop.org/systemd/systemd/tree/TODO#n115
I wonder if this isnt covered with GREEDY_REALLOC()?
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
-hashmap.c b/src/test/test-hashmap.c
new file mode 100644
index 000..2aead79
--- /dev/null
+++ b/src/test/test-hashmap.c
@@ -0,0 +1,508 @@
+/***
+ This file is part of systemd
+
+ Copyright 2013 Daniel Buch
+
+ systemd is free software; you can redistribute it and/or modify it
+ under the terms of
Thanks for review, kay!
I adabted the code. So trivial_cmp() is tested with INT_TO_PTR('a') - i
guess its ok to use 'a' since its evaulated to int?
The casts.. Dont know :p they are removed :)
2013/4/26 Kay Sievers
> On Fri, Apr 26, 2013 at 8:49 PM, Daniel Buch
>
/test/test-prioq.c
diff --git a/src/test/test-hashmap.c b/src/test/test-hashmap.c
new file mode 100644
index 000..7c55c87
--- /dev/null
+++ b/src/test/test-hashmap.c
@@ -0,0 +1,508 @@
+/***
+ This file is part of systemd
+
+ Copyright 2013 Daniel Buch
+
+ systemd is free software; you can
I felt the inconsistentsy was kinda awfull.
I can change all to void* (instead of, void *) if you like but else leave
this patch to the trash?
2013/4/26 Kay Sievers
> On Fri, Apr 26, 2013 at 7:49 PM, Zbigniew Jędrzejewski-Szmek
> wrote:
> > On Fri, Apr 26, 2013 at 06:40:08PM +
---
src/shared/hashmap.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/shared/hashmap.h b/src/shared/hashmap.h
index 26bd030..f52517f 100644
--- a/src/shared/hashmap.h
+++ b/src/shared/hashmap.h
@@ -57,11 +57,11 @@ int hashmap_ensure_allocated(Hashmap **h,
/test-hashmap.c
@@ -0,0 +1,506 @@
+/***
+ This file is part of systemd
+
+ Copyright 2013 Daniel Buch
+
+ systemd is free software; you can redistribute it and/or modify it
+ under the terms of the GNU Lesser General Public License as published by
+ the Free Software Foundation; either version 2.1 o
This is first part of hashmap test unit - last part is in development. So
review is much appreciated
Thanks in advance.
---
Makefile.am | 10 +++
src/test/test-hashmap.c | 203
2 files changed, 213 insertions(+)
create mode 100644 s
New OOM check patch:
I do assert_se() before variable is used to do correct check.
---
src/test/test-strv.c | 16
1 file changed, 16 insertions(+)
diff --git a/src/test/test-strv.c b/src/test/test-strv.c
index d2eb225..504415a 100644
--- a/src/test/test-strv.c
+++ b/src/test/te
---
src/test/test-strv.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/test/test-strv.c b/src/test/test-strv.c
index e33568c..1718f56 100644
--- a/src/test/test-strv.c
+++ b/src/test/test-strv.c
@@ -27,7 +27,7 @@
#include "strv.h"
static void test_specifier_pr
---
src/test/test-strv.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/src/test/test-strv.c b/src/test/test-strv.c
index ea1f088..e33568c 100644
--- a/src/test/test-strv.c
+++ b/src/test/test-strv.c
@@ -85,18 +85,23 @@ static void test_strv_join(void) {
};
---
src/test/test-strv.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/test/test-strv.c b/src/test/test-strv.c
index a8801b5..ea1f088 100644
--- a/src/test/test-strv.c
+++ b/src/test/test-strv.c
@@ -100,6 +100,18 @@ static void test_strv_join(void) {
assert_se(str
test-strv.c: Indent fix
---
src/test/test-strv.c | 96 ++--
1 file changed, 48 insertions(+), 48 deletions(-)
diff --git a/src/test/test-strv.c b/src/test/test-strv.c
index 535685f..a8801b5 100644
--- a/src/test/test-strv.c
+++ b/src/test/test-strv.
---
src/test/test-strv.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/test/test-strv.c b/src/test/test-strv.c
index fabc26e..535685f 100644
--- a/src/test/test-strv.c
+++ b/src/test/test-strv.c
@@ -190,6 +190,19 @@ static void test_strv_merge(void) {
assert(str
---
src/test/test-strv.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/test/test-strv.c b/src/test/test-strv.c
index 3ed5a09..fabc26e 100644
--- a/src/test/test-strv.c
+++ b/src/test/test-strv.c
@@ -158,6 +158,20 @@ static void test_strv_sort(void) {
assert(stre
---
src/test/test-strv.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/src/test/test-strv.c b/src/test/test-strv.c
index 07aac3a..3ed5a09 100644
--- a/src/test/test-strv.c
+++ b/src/test/test-strv.c
@@ -158,6 +158,24 @@ static void test_strv_sort(void) {
assert(
And now with patch files.
2013/2/11 Daniel Buch
> I made tests for:
>
> strv_merge
> strv_merge_concat
> strv_append
>
0003-test-strv.c-added-strv_append-test.patch
Description: Binary data
0002-test-strv.c-added-strv_merge_concat-test.patch
Description: Binary data
I made tests for:
strv_merge
strv_merge_concat
strv_append
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
I did some improvements on strv-test.c and added additional test, more is
on its way.
Patch files is attached.
What do you think?
0001-test-strv.c-Split-tests-into-seperate-functions.patch
Description: Binary data
0002-test-strv.c-test-strv_join-added.patch
Description: Binary data
__
93 matches
Mail list logo