[systemd-devel] [PATCH] Added test for unit file state returned by unit_file_get_state and unit_file_get_list.

2014-10-03 Thread Ken Sedgwick
--- .gitignore | 1 + Makefile.am| 44 ++- src/test/test-enabled.c| 143 + .../etc/systemd/system/masked.service | 1 + .../etc/systemd/system/maske

Re: [systemd-devel] [PATCH] Added test for unit file state returned by unit_file_get_state and unit_file_get_list.

2014-10-05 Thread Ken Sedgwick
Will do. Ken On Sun, Oct 5, 2014 at 2:27 PM, Zbigniew Jędrzejewski-Szmek < zbys...@in.waw.pl> wrote: > On Fri, Oct 03, 2014 at 04:03:14PM -0700, Ken Sedgwick wrote: > > +const char *subdir = "/test-enabled-root"; > > +char root_dir[UNIT_NAME_MAX + 2 + 1]

[systemd-devel] [PATCH 0/3 v2] Added test for unit file state returned by unit_file_get_state and unit_file_get_list.

2014-10-07 Thread Ken Sedgwick
Ken Sedgwick (3): Added test for unit file state returned by unit_file_get_state and unit_file_get_list. Made test-enabled units more basic, removing superfluous fields. Cleaned up test path assignment code. ___ systemd-devel mailing list systemd

[systemd-devel] [PATCH 1/3] Added test for unit file state returned by unit_file_get_state and unit_file_get_list.

2014-10-07 Thread Ken Sedgwick
--- .gitignore | 1 + Makefile.am| 44 ++- src/test/test-enabled.c| 143 + .../etc/systemd/system/masked.service | 1 + .../etc/systemd/system/maske

[systemd-devel] [PATCH 2/3] Made test-enabled units more basic, removing superfluous fields.

2014-10-07 Thread Ken Sedgwick
--- test/test-enabled-root/etc/systemd/system/some.target | 6 +- test/test-enabled-root/run/systemd/system/other.target | 3 +-- test/test-enabled-root/usr/lib/systemd/system/another.service | 7 ++- test/test-enabled-root/usr/lib/systemd/system/disabled.serv

[systemd-devel] [PATCH 3/3] Cleaned up test path assignment code.

2014-10-07 Thread Ken Sedgwick
--- src/test/test-enabled.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/test/test-enabled.c b/src/test/test-enabled.c index 607f68c..104348e 100644 --- a/src/test/test-enabled.c +++ b/src/test/test-enabled.c @@ -75,9 +75,6 @@ */ -const char *subdir = "/test-ena

[systemd-devel] [PATCH, REVIEW] Added unit enabled-context cache to improve performance w/ many units.

2014-10-07 Thread Ken Sedgwick
review. Many thanks in advance, Ken -- Ken Sedgwick Bonsai Software, Inc. http://www.bonsai.com/ken/ (510) 269-7334 k...@bonsai.com Public Key: http://www.bonsai.com/ken/ken.asc GPG Fingerprint: 851E 3B07 E586 0843 9434 5CC7 4033 3B9B 3F3F 9640 diff --git a/.gitignore b/.gitignore index f119b57

[systemd-devel] [PATCH v2] Added test for unit file state returned by unit_file_get_state and unit_file_get_list. Made test-enabled units more basic, removing superfluous fields. Cleaned up test path

2014-10-07 Thread Ken Sedgwick
--- .gitignore | 1 + Makefile.am| 44 ++- src/test/test-enabled.c| 141 + .../etc/systemd/system/masked.service | 1 + .../etc/systemd/system/maske

[systemd-devel] [PATCH v2] Added test for unit file state returned by unit_file_get_state and unit_file_get_list

2014-10-07 Thread Ken Sedgwick
Combined initial submission and subsequent fixes into a single patch. Ken Sedgwick (1): Added test for unit file state returned by unit_file_get_state and unit_file_get_list. Made test-enabled units more basic, removing superfluous fields. Cleaned up test path assignment code

[systemd-devel] [PATCH, REVIEW] Added unit enabled-context cache to improve performance w/ many units.

2014-10-07 Thread Ken Sedgwick
Resubmitting using git format-patch, git imap-send ... no code changes. --- .gitignore | 1 + Makefile.am| 44 +++- src/core/dbus-manager.c| 4 +- src/core/manager.c

Re: [systemd-devel] [PATCH v2] Added test for unit file state returned by unit_file_get_state and unit_file_get_list. Made test-enabled units more basic, removing superfluous fields. Cleaned up test p

2014-10-11 Thread Ken Sedgwick
M, David Timothy Strauss < da...@davidstrauss.net> wrote: > It looks like newlines at the end of the new files are inconsistent > ("No newline at end of file"). > > Other than that +1. It's great to add tests, have them pass on master, > optimize master (the next

[systemd-devel] [PATCH v3] tests: added tests for unit_file_get_{state, list}

2014-10-14 Thread Ken Sedgwick
This test constructs different unit file states and checks the output of unit_file_get_state and unit_file_get_list for each. This test characterizes the current output of the master branch in preparation for a patch which improves the performance of unit state detection in the face of thousands o

[systemd-devel] [PATCH] test-manyunits: test unit_file_get_list perforamnce with many units

2014-10-17 Thread Ken Sedgwick
This test temporarily creates several thousand unit files and checks the performance of unit_file_get_list. This test is currently added to manual_tests only since it does not pass. This test does pass if the enabled unit cache patch is applied. --- .gitignore| 1 + Makefile.am

[systemd-devel] [PATCH, REVIEW, v2] find_symlinks: adds a cache of enabled unit symbolic link state

2014-10-17 Thread Ken Sedgwick
The current find_symlinks_fd code traverses the config directories duplicatively. This is a performance problem if 1000s of units are being controlled. This patch adds a hashmap cache of symbolic link state which is filled in one traversal and then consulted as needed to prevent re-traversal. The

[systemd-devel] [PATCH, v3 1/3] tests: added tests for unit_file_get_{state, list}

2014-10-21 Thread Ken Sedgwick
This test constructs different unit file states and checks the output of unit_file_get_state and unit_file_get_list for each. This test characterizes the current output of the master branch in preparation for a patch which improves the performance of unit state detection in the face of thousands o

[systemd-devel] [PATCH, v3 3/3] find_symlinks: adds a cache of enabled unit symbolic link state

2014-10-21 Thread Ken Sedgwick
The current find_symlinks_fd code traverses the config directories duplicatively. This is a performance problem if 1000s of units are being controlled. This patch adds a hashmap cache of symbolic link state which is filled in one traversal and then consulted as needed to prevent re-traversal. The

[systemd-devel] [PATCH, v3 2/3] tests: unit_file_get_list performance with many units

2014-10-21 Thread Ken Sedgwick
This test temporarily creates several thousand unit files and checks the performance of unit_file_get_list. This test is currently added to manual_tests only since it does not pass. This test does pass if the subsequent enabled unit cache patch is applied. --- .gitignore| 1 +

[systemd-devel] [PATCH] daemon-reload timestamped: coalesce redundant daemon-reloads

2014-12-02 Thread Ken Sedgwick
Systems with many units (~10K) take many seconds to perform a daemon-reload. The process of load-balancing these systems requires multiple daemon-reloads, many issued concurrently. Currently many of these redundant daemon-reloads timeout and fail. This patch adds a new systemd method ReloadTimes