If there are no further objections I will push the patch as is.
Michal
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Currently after exiting rescue shell we isolate default target. User
might want to isolate to some other target than default one. However
issuing systemctl isolate command to desired target would bring system
to default target as a consequence of running ExecStopPost action.
Having common ancestor
We already ignore IP fragments, because we expect that Fragment
offset (FO) field is not set. However first fragment in a fragmented IP
flow will have all zeroes in FO field. We should ignore such packet as
well, thus we need to look at MF flag in the IP header. Checking MF flag
will filter out all
On Tue, Jun 24, 2014 at 03:54:54PM +0200, Tom Gundersen wrote:
> On Tue, Jun 24, 2014 at 12:58 PM, Michal Sekletar wrote:
> > On Thu, Jun 19, 2014 at 12:02:39PM -0500, Dan Williams wrote:
> >> On Thu, 2014-06-19 at 18:59 +0200, Michal Sekletar wrote:
> >> > Ch
On Wed, Jul 02, 2014 at 03:05:36AM +0200, Zbigniew Jędrzejewski-Szmek wrote:
> On Tue, Jul 01, 2014 at 04:36:47PM +0200, Lennart Poettering wrote:
> > On Tue, 01.07.14 16:47, microcai (micro...@fedoraproject.org) wrote:
> >
> > > > Maybe another option is to improve localectl on the client side to
On Thu, Jun 19, 2014 at 12:02:39PM -0500, Dan Williams wrote:
> On Thu, 2014-06-19 at 18:59 +0200, Michal Sekletar wrote:
> > Check that received DHCP packets actually include our MAC address in
> > chaddr field. BPF interpreter has 32 bit wide registers but MAC address
> >
On Mon, Jun 23, 2014 at 02:46:42PM +0200, Lennart Poettering wrote:
> On Mon, 23.06.14 13:34, Michal Sekletar (msekl...@redhat.com) wrote:
>
> What's the rationale?
This came up while discussing the issue when some script saved list of actions
it took and same script could be
---
src/systemctl/systemctl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c
index 727be58..2dac67c 100644
--- a/src/systemctl/systemctl.c
+++ b/src/systemctl/systemctl.c
@@ -6644,7 +6644,7 @@ found:
} else {
On Wed, Jun 18, 2014 at 09:51:02PM +0200, Friedrich Kröner wrote:
> Hello,
>
> when trying systemd-networkd with >=214 and the following config:
>
> [Match]
> Name=eth*
>
> [Network]
> DHCP=yes
>
> Address=2001:db8::1234:5678/64
> DNS=8.8.8.8
> DNS=2001:db8:1::ab9:C0A8:102
>
>
> I get lots of
On Thu, Jun 19, 2014 at 12:02:39PM -0500, Dan Williams wrote:
> On Thu, 2014-06-19 at 18:59 +0200, Michal Sekletar wrote:
> > Check that received DHCP packets actually include our MAC address in
> > chaddr field. BPF interpreter has 32 bit wide registers but MAC address
> >
Check that received DHCP packets actually include our MAC address in
chaddr field. BPF interpreter has 32 bit wide registers but MAC address
is 48 bits long so we have to do check in two steps.
---
src/libsystemd-network/dhcp-internal.h| 3 ++-
src/libsystemd-network/dhcp-network.c | 15 +
---
src/libsystemd-network/dhcp-network.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/libsystemd-network/dhcp-network.c
b/src/libsystemd-network/dhcp-network.c
index e5fd6a8..f500bff 100644
--- a/src/libsystemd-network/dhcp-network.c
+++ b/src/libsystemd-network/dhcp-network.c
@@
On Mon, Jun 02, 2014 at 06:03:27PM +0200, Michal Sekletar wrote:
> This should make logic in locale_setup() work as intended, hence don't
> parse /etc/locale.conf if admin passed to us explicit locale settings on
> kernel cmdline.
> ---
> src/shared/fileio.c | 28 +
On Fri, May 30, 2014 at 06:20:16PM +0200, Michal Sekletar wrote:
ping?
> ---
> src/locale/localed.c | 13 +++--
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/src/locale/localed.c b/src/locale/localed.c
> index e3061c8..358f6c2 100644
> --- a
On Tue, Jun 03, 2014 at 11:05:53AM +0200, Kay Sievers wrote:
> On Tue, Jun 3, 2014 at 10:58 AM, Michal Sekletar wrote:
>
> > Currently systemd-localed does conversions from X11 keymap to VConsole
> > keymap
> > and vice-versa. There was a request coming from Anaconda in
Hello,
Currently systemd-localed does conversions from X11 keymap to VConsole keymap
and vice-versa. There was a request coming from Anaconda installer team at Red
Hat which was about splitting this functionality to separate library.
I am curious if other people would be interested in such librar
This should make logic in locale_setup() work as intended, hence don't
parse /etc/locale.conf if admin passed to us explicit locale settings on
kernel cmdline.
---
src/shared/fileio.c | 28 ++--
1 file changed, 18 insertions(+), 10 deletions(-)
diff --git a/src/shared/file
systemd spawns services with locale settings taken from kernel
cmdline. If it doesn't find anything there, then it proceeds with
parsing settings from /etc/locale.conf. localed should do the same and
look at kernel cmdline first.
---
src/locale/localed.c | 80 ++---
---
src/locale/localed.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/src/locale/localed.c b/src/locale/localed.c
index e3061c8..358f6c2 100644
--- a/src/locale/localed.c
+++ b/src/locale/localed.c
@@ -712,15 +712,16 @@ static int find_legacy_keymap(Context *c,
On Fri, May 30, 2014 at 12:45:21PM +0200, Piotr Wilczek wrote:
> This patch adds posibility for journal to get process data from
> socket data (if available) instead of from procfs.
>
> Additionally a new procinfo structure is added to store all process
> data in single place. This data include cr
On Wed, May 28, 2014 at 10:30:56PM +0200, Lubomir Rintel wrote:
> ---
> man/systemd-journald.service.xml | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git a/man/systemd-journald.service.xml
> b/man/systemd-journald.service.xml
> index f0ce7aa..715 100644
> --- a/man/systemd
On Wed, May 14, 2014 at 07:51:01AM +0200, Michal Sekletar wrote:
> On Tue, May 13, 2014 at 11:54:49PM -0400, Garry T. Williams wrote:
> > On 5-12-14 15:11:46 Michal Sekletar wrote:
> > > On Sat, May 10, 2014 at 05:12:21PM -0400, Garry T. Williams wrote:
> > > > This
ctive by
> default.
>
> This means {systemd-networkd,NetworkManager}-wait-online.service, can be
> enabled by default
> as part of network-online.target, and only delay boot when some service
> actively pulls it in.
>
> See: <https://bugzilla.gnome.org/show_bug.cgi?id
On Tue, May 13, 2014 at 11:54:49PM -0400, Garry T. Williams wrote:
> On 5-12-14 15:11:46 Michal Sekletar wrote:
> > On Sat, May 10, 2014 at 05:12:21PM -0400, Garry T. Williams wrote:
> > > This recently stated showing up in the journal on Fedora F20 here:
> > >
&g
On Sat, May 10, 2014 at 05:12:21PM -0400, Garry T. Williams wrote:
> This recently stated showing up in the journal on Fedora F20 here:
>
> May 10 17:01:01 vfr systemd[1]: Starting Session 20 of user root.
> May 10 17:01:01 vfr systemd[1]: Started Session 20 of user root.
> May 10 17:0
On Tue, May 06, 2014 at 12:36:44PM -0700, Michael Marineau wrote:
> commit 20a83d7bf was not equivalent to the original bug fix proposed by
> Michal Sekletar . The committed version only added
> the job to the run queue if the job had a timeout, which most jobs do
> not have. Just re-
On Tue, May 06, 2014 at 12:36:44PM -0700, Michael Marineau wrote:
> commit 20a83d7bf was not equivalent to the original bug fix proposed by
> Michal Sekletar . The committed version only added
> the job to the run queue if the job had a timeout, which most jobs do
> not have. Just re-
When we have job installed and added to run queue for service which is still in
dead state and systemd initiates reload then after reload we never add
deserialized job to the run queue again. This is caused by check in
service_coldplug() where we check if deserialized state is something else
than d
On Mon, Feb 24, 2014 at 04:32:46PM +0100, Lennart Poettering wrote:
> On Mon, 24.02.14 15:59, Michal Sekletar (msekl...@redhat.com) wrote:
>
> > hostnamed parses its state information at the startup time and doesn't
> > update
> > it. This might lead to the sit
Not that we are going to move things around but it is nicer to have paths
configurable rather than hardcoded in the source.
---
Added trailing slash. Thanks!
Makefile.am | 2 ++
src/backlight/backlight.c | 6 +++---
units/systemd-backli...@.service.in | 2 +-
3
On Mon, Feb 24, 2014 at 04:05:36PM +0100, Lennart Poettering wrote:
> On Mon, 24.02.14 15:59, Michal Sekletar (msekl...@redhat.com) wrote:
>
> > ---
> > src/hostname/hostnamed.c | 26 +-
> > 1 file changed, 13 insertions(+), 13 deletions(-)
&
We are not parsing timezone data.
---
src/hostname/hostnamed.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/hostname/hostnamed.c b/src/hostname/hostnamed.c
index 045f24d..064d9d2 100644
--- a/src/hostname/hostnamed.c
+++ b/src/hostname/hostnamed.c
@@ -719,7 +719,7 @@ int
We don't change static hostname in case it is the same as the one we currently
know about. This is not ideal, because it might have been changed in the
meantime
and we just don't know about the change. So allow user the set whatever he
desires and don't check, before doing so, against our cached i
hostnamed parses its state information at the startup time and doesn't update
it. This might lead to the situation when we are presenting administrator with
inaccurate information. We should watch for changes in the system and update our
state information accordingly.
---
src/hostname/hostnamed.c
---
src/hostname/hostnamed.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/src/hostname/hostnamed.c b/src/hostname/hostnamed.c
index 064d9d2..d8938a4 100644
--- a/src/hostname/hostnamed.c
+++ b/src/hostname/hostnamed.c
@@ -409,8 +409,8 @@ static i
Not that we are going to move things around but it is nicer to have paths
configurable rather than hardcoded in the source.
---
Makefile.am | 2 ++
src/backlight/backlight.c | 6 +++---
units/systemd-backli...@.service.in | 2 +-
3 files changed, 6 insertions(+),
On Tue, Nov 19, 2013 at 08:54:41AM -0500, Daniel J Walsh wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 11/18/2013 05:45 PM, Michal Sekletar wrote:
> > On Mon, Nov 18, 2013 at 04:19:20PM -0500, Daniel J Walsh wrote: On
> > 11/16/2013 08:10 AM, Lennart Poe
On Mon, Nov 18, 2013 at 04:19:20PM -0500, Daniel J Walsh wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 11/16/2013 08:10 AM, Lennart Poettering wrote:
> > On Thu, 14.11.13 15:43, Daniel J Walsh (dwa...@redhat.com) wrote:
> >
> >>
> >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA
On Sun, Nov 10, 2013 at 11:13:57PM +0100, Lennart Poettering wrote:
> On Fri, 08.11.13 14:36, Michal Sekletar (msekl...@redhat.com) wrote:
>
> >
> > On Thu, Nov 07, 2013 at 10:39:19PM +0100, Lennart Poettering wrote:
> > > On Wed, 06.11.13 11:18, Michal Sekletar
On Thu, Nov 07, 2013 at 10:39:19PM +0100, Lennart Poettering wrote:
> On Wed, 06.11.13 11:18, Michal Sekletar (msekl...@redhat.com) wrote:
>
> > Type x in tmpfiles configuration accepts shell style globs instead of normal
> > paths. If user uses normal path he might expect tha
On Thu, Nov 07, 2013 at 10:39:19PM +0100, Lennart Poettering wrote:
> On Wed, 06.11.13 11:18, Michal Sekletar (msekl...@redhat.com) wrote:
>
> > Type x in tmpfiles configuration accepts shell style globs instead of normal
> > paths. If user uses normal path he might expect tha
Type x in tmpfiles configuration accepts shell style globs instead of normal
paths. If user uses normal path he might expect that the path will be left
untouched. However this is not the case for directories and content of the
directory will be cleaned according to the Age parameter, we should rath
---
src/systemctl/systemctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c
index 9f5e273..0c1588c 100644
--- a/src/systemctl/systemctl.c
+++ b/src/systemctl/systemctl.c
@@ -1362,7 +1362,7 @@ static int list_jobs(DBusConne
In case when update of current values is not necessary we still might end up
calling ioctl(), because need_update variable is not explicitly initialized.
---
src/udev/net/ethtool-util.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/udev/net/ethtool-util.c b/src/udev/n
On Wed, Sep 11, 2013 at 08:04:38PM +0200, Lennart Poettering wrote:
> On Fri, 09.08.13 16:00, Michal Sekletar (msekl...@redhat.com) wrote:
>
> Heya,
Hi Lennart,
>
> Hmm, so what I don't really like about this patch is that the stop might
> have caused the triggering un
On Thu, Sep 12, 2013 at 06:51:49PM +0200, Lennart Poettering wrote:
> On Fri, 19.07.13 09:17, Lukáš Nykrýn (lnyk...@redhat.com) wrote:
>
> > Hi,
> > when service has StopWhenUnneeded=yes and it is requested by forking
> > service, which fails during initialization, the first unit is not
> > stoppe
Hi everyone,
I am wondering if there is something else wrong or it is merge ready?
Please let me know.
Michal
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
wait_filter() callback shouldn't process JobRemove signals for arbitrary
jobs. It should only deal with signals for jobs which are included in
set of jobs we wait for.
---
src/systemctl/systemctl.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/src/systemctl/sy
>From a62d3668fb2513b1ece827520d44d5b7cd560407 Mon Sep 17 00:00:00 2001
From: Michal Sekletar
Date: Thu, 8 Aug 2013 13:26:56 +0200
Subject: [PATCH 1/3] systemctl: check for triggering units before calling
StopUnit
Rearranging the code in a way that we always check for triggers before
we is
On Thu, Aug 08, 2013 at 06:11:42PM +0200, Zbigniew Jędrzejewski-Szmek wrote:
> On Thu, Aug 08, 2013 at 03:19:09PM +0200, Michal Sekletar wrote:
> > Calling enable on template units doesn't make sense since it is possible
> > to enable instances directly and users are not
On Thu, Aug 08, 2013 at 03:35:24PM +0200, Tom Gundersen wrote:
> Hi Michal,
Hello Tom,
>
> On Thu, Aug 8, 2013 at 3:19 PM, Michal Sekletar wrote:
> > Calling enable on template units doesn't make sense since it is possible
> > to enable instances directly and users a
On Thu, Aug 08, 2013 at 03:57:20PM +0200, Václav Pavlín wrote:
> Michal Sekletar píše v Čt 08. 08. 2013 v 15:19 +0200:
> > Rearranging the code in a way that we always check for triggers
> > before we issue StopUnit D-Bus call will make behavior consistent,
> > thus trigge
---
TODO | 5 -
1 file changed, 5 deletions(-)
diff --git a/TODO b/TODO
index ead699c..884acd6 100644
--- a/TODO
+++ b/TODO
@@ -2,11 +2,6 @@ Bugfixes:
* the running hwdb seems not to pick up updated database files without
an explicit: udevadm control --reload
-* enabling an instance uni
Rearranging the code in a way that we always check for triggers
before we issue StopUnit D-Bus call will make behavior consistent,
thus triggers are always checked.
https://bugzilla.redhat.com/show_bug.cgi?id=908690
---
src/systemctl/systemctl.c | 20 ++--
1 file changed, 10 inser
Calling enable on template units doesn't make sense since it is possible
to enable instances directly and users are not forced to use Alias=
trickery anymore.
---
src/shared/install.c | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/src/shared/install.c b/s
When dependency unit is configured with StopWhenUnneeded=yes and
activation of main unit fails, e.g. start timeout occurs, then
dependencies are never stopped. This happens because start job for
the main unit is still around.
---
src/core/unit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(
Hi Zbyszek,
- Original Message -
> Maybe just stick it in mount_setup()?
Thank you for this suggestion!
>
> It seems to be without much difference, but I'd go for /run, since
> this way there'll be less chance that somebody deletes it by mistake.
I first tried /tmp and I had issue that
All Execs within the service, will get mounted the same
/tmp and /var/tmp directories, if service is configured with
PrivateTmp=yes. Temporary directories are cleaned up by service
itself in addition to systemd-tmpfiles. Directory which is mounted
as inaccessible is created at runtime in /run/syste
---
src/systemd/sd-shutdown.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/systemd/sd-shutdown.h b/src/systemd/sd-shutdown.h
index cee4350..b8f6a48 100644
--- a/src/systemd/sd-shutdown.h
+++ b/src/systemd/sd-shutdown.h
@@ -37,7 +37,7 @@ typedef enum sd_shutdown_mode
---
src/systemctl/systemctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c
index 4a55c56..b5902e6 100644
--- a/src/systemctl/systemctl.c
+++ b/src/systemctl/systemctl.c
@@ -2053,7 +2053,7 @@ static int set_cgroup_attr(DBu
All Execs within the service, will get mounted the same
/tmp and /var/tmp directories, if service is configured with
PrivateTmp=yes. Temporary directories are cleaned up by service
itself in addition to systemd-tmpfiles. Directory which is mounted
as inaccessible is shared and created at install ti
Thank you for the review! It is very appreciated.
Michal
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Hi Zbyszek,
> Hi,
>
> that's not necessary, it's initialized right below the assert
> statements.
I know it is initialized right after asserts, however we tend to
initialize vars witch are marked for auto-cleanup with NULL. So
I thought it would be good to do it here too, since it doesn't hurt
---
src/systemctl/systemctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c
index 4a55c56..db12255 100644
--- a/src/systemctl/systemctl.c
+++ b/src/systemctl/systemctl.c
@@ -1454,7 +1454,7 @@ static int start_unit_one(
All Execs within the service, will get mounted the same /tmp and /var/tmp
directories, if service is configured with PrivateTmp=yes. Temporary
directories are cleaned up by service itself, rather than relying on
systemd-tmpfiles. Directory which is mounted as inaccessible is shared,
created at inst
Hi everyone,
I haven't tested the patch, so suggestions and testing are very appreciated.
Regards,
Michal
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
We should not try to get information about mount unit from fragment
if the unit was created because of /proc/self/mountinfo event.
---
src/core/mount.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/core/mount.c b/src/core/mount.c
index 419cf27..df9 100644
--- a/s
Hi Zbigniew,
you are right. I overlooked the fact that negation has higher precedence than
equal operator. Thank you! Would you be so kind and commit the patch?
Michal.
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.f
Hi Carlos,
I shouldn't use word "Agreed", because it seems that it caused some confusion.
On Mar 2, 2013, at 3:55 PM, Carlos Silva wrote:
> On Sat, Mar 2, 2013 at 1:46 PM, Michal Sekletar wrote:
> >> -if (!i->type == IGNORE_DIRECTORY_PAT
On Mar 1, 2013, at 10:35 PM, Zbigniew Jędrzejewski-Szmek
wrote:
Hi Zbigniew,
> On Fri, Mar 01, 2013 at 06:29:59PM +0100, Lukas Nykryn wrote:
>> ---
>> src/tmpfiles/tmpfiles.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles/tmpf
On Mar 1, 2013, at 3:16 PM, Lennart Poettering wrote:
> On Wed, 20.02.13 14:50, Michal Sekletar (msekl...@redhat.com) wrote:
>
>> All Execs within the service, will get mounted the same /tmp and /var/tmp
>> directories, if service is configured with PrivateTmp=yes. Temporary
All Execs within the service, will get mounted the same /tmp and /var/tmp
directories, if service is configured with PrivateTmp=yes. Temporary
directories are cleaned up by service itself, rather than relying on
systemd-tmpfiles. Same logic applies also to inaccessible directories.
---
man/systemd
All Execs within the service, will get mounted the same /tmp and /var/tmp
directories, if service is configured with PrivateTmp=yes. Temporary
directories are cleaned up by service itself, rather than relying on
systemd-tmpfiles. Same logic applies also to inaccessible directories.
---
man/systemd
Hello Tom,
thank you very much for the review, it is very appreciated. I've sent
out the patch to get a feedback on a general approach, since there are
no objections to it, I will hack up the rest, inaccessible dirs, man
page etc...
Cheers,
Michal
_
Hello Michal,
thank you for the review. I've added explicit free to previously
strduped strings rather than setting flag to true earlier and trying to
remove non-existing dirs on failure. I hope that fix the issue you
pointed out.
Regards,
Michal Sek
All Execs within the service, will get mounted the same /tmp and /var/tmp
directories, if service is configured with PrivateTmp=yes. Temporary
directories are cleaned up by service itself, rather than relying on
systemd-tmpfiles.
---
src/core/execute.c | 30 +--
src/core/execute.h |
All Execs within the service, will get mounted the same /tmp and /var/tmp
directories, if service is configured with PrivateTmp=yes. Temporary
directories are cleaned up by service itself, rather than relying on
systemd-tmpfiles.
---
src/core/execute.c | 30 +--
src/core/execute.h |
are actually conclusion of discussion in one of the threads
here on mailing list. Further opinions and discussion on this topic
would be very appreciated.
Regards,
Michal Sekletar
___
systemd-devel mailing list
systemd-devel@lists.freedes
---
src/login/logind-session.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/login/logind-session.c b/src/login/logind-session.c
index b64a5d3..b981e14 100644
--- a/src/login/logind-session.c
+++ b/src/login/logind-session.c
@@ -772,7 +772,6 @@ static int get_process_ct
---
src/core/job.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/core/job.c b/src/core/job.c
index 5ff95f5..31ab118 100644
--- a/src/core/job.c
+++ b/src/core/job.c
@@ -821,7 +821,7 @@ int job_finish_and_invalidate(Job *j, JobResult result,
bool recursive) {
---
src/shared/socket-util.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/shared/socket-util.c b/src/shared/socket-util.c
index 49ea758..42ea545 100644
--- a/src/shared/socket-util.c
+++ b/src/shared/socket-util.c
@@ -369,6 +369,8 @@ int socket_address_print(const SocketAddress *a, ch
In cases where path_strv_canonicalize() returns NULL, strv_free() is
called afterwards and it will call free() on pointers which were freed
already in path_strv_canonicalize()
---
src/shared/path-util.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/shared/path-util.c b/src/shared/path-ut
---
src/journal/coredumpctl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/journal/coredumpctl.c b/src/journal/coredumpctl.c
index aa946ae..800e43f 100644
--- a/src/journal/coredumpctl.c
+++ b/src/journal/coredumpctl.c
@@ -220,9 +220,10 @@ static int retrieve(sd_journa
l might contain zero strings, however there is still memory
allocated for NULL terminator, use _cleanup_strv_free_ instead to
prevent tiny leak in such case.
---
src/locale/localectl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/locale/localectl.c b/src/locale/local
---
src/locale/localectl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/locale/localectl.c b/src/locale/localectl.c
index c05eba0..84feb25 100644
--- a/src/locale/localectl.c
+++ b/src/locale/localectl.c
@@ -354,7 +354,8 @@ static int list_locales(DBusConnection *bus,
---
src/journal/coredumpctl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/journal/coredumpctl.c b/src/journal/coredumpctl.c
index 5c442ff..aa946ae 100644
--- a/src/journal/coredumpctl.c
+++ b/src/journal/coredumpctl.c
@@ -57,7 +57,7 @@ static Set *new_matches(void)
On Thu, 2012-10-25 at 17:12 +0200, Michal Schmidt wrote:
> On 10/25/2012 04:16 PM, Michal Sekletar wrote:
> > ---
> > src/journal/coredumpctl.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/src/journal/coredumpctl.c b/src/journal/coredumpctl.c
l might contain zero strings, however there is still memory
allocated for NULL terminator, use _cleanup_strv_free_ instead to
prevent tiny leak in such case.
---
src/locale/localectl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/locale/localectl.c b/src/locale/localec
https://bugzilla.redhat.com/show_bug.cgi?id=869779
---
src/sysctl/sysctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/sysctl/sysctl.c b/src/sysctl/sysctl.c
index a68d67f..035e0ec 100644
--- a/src/sysctl/sysctl.c
+++ b/src/sysctl/sysctl.c
@@ -178,7 +178,7 @@ static int
---
src/journal/coredumpctl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/journal/coredumpctl.c b/src/journal/coredumpctl.c
index d15a31e..1a4d78f 100644
--- a/src/journal/coredumpctl.c
+++ b/src/journal/coredumpctl.c
@@ -222,6 +222,7 @@ static int retrieve(sd_journal *j, const char *n
---
src/shared/util.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/shared/util.c b/src/shared/util.c
index 2f0aba8..8da2314 100644
--- a/src/shared/util.c
+++ b/src/shared/util.c
@@ -148,6 +148,9 @@ usec_t timespec_load(const struct timespec *ts) {
ts->tv_nsec == (lon
---
src/locale/localectl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/locale/localectl.c b/src/locale/localectl.c
index c05eba0..16700fe 100644
--- a/src/locale/localectl.c
+++ b/src/locale/localectl.c
@@ -354,6 +354,7 @@ static int list_locales(DBusConnection *bus, char **args,
unsi
---
src/journal/coredumpctl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/journal/coredumpctl.c b/src/journal/coredumpctl.c
index 5c442ff..d15a31e 100644
--- a/src/journal/coredumpctl.c
+++ b/src/journal/coredumpctl.c
@@ -58,6 +58,7 @@ static Set *new_matches(void) {
if (!tm
From: Michal Sekletar
When stopping multiple units at once do not print warning about
triggering units when they are stopped by the same command.
---
src/systemctl/systemctl.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/systemctl/systemctl.c b/src
Hello,
it should be fixed and behavior should be the same as Michal has
described, however patch is not based on current origin/master HEAD
since I am unable to pull today. If it does not apply cleanly please let
me know. Thank you.
Regards,
Michal
_
Makes possible to specify separate timeout for start and stop of
the service.
---
man/systemd.service.xml | 25 -
src/core/dbus-service.c | 4 +++-
src/core/load-fragment-gperf.gperf.m4 | 4 +++-
src/core/load-fragment.c | 12 +
This should address TODO item "new dependency type to "group" services
in a target". Semantic of new dependency is as follows. Once configured
it creates dependency which will cause that all dependent units get
stopped if unit they all depend on is stopped or restarted. Usual use
case would be con
is specified last in unit file is applied and
always overrides the previous settings.
We are interested in opinion of systemd community in regard to this
matter. Thank you.
Best Regards,
--
Michal Sekletar and Lukas Nykryn
___
systemd-devel mailing list
On Tue, 2012-07-10 at 00:54 +0200, Lennart Poettering wrote:
> Can you elaborate on this? Would generators work for you?
>
> http://www.freedesktop.org/wiki/Software/systemd/Generators
>
> (Sorry for not responding earlier!)
>
> Lennart
>
Hi Lennart,
I'd like to work on this, because I think
https://bugzilla.redhat.com/show_bug.cgi?id=752774
---
man/systemctl.xml | 33 +++-
src/shared/install.c | 78 +---
src/shared/unit-name.c | 12
src/shared/unit-name.h |1 +
4 files changed, 100 insertions(+), 24
101 - 200 of 208 matches
Mail list logo
