Re: [systemd-devel] Configurability for systemd logging API

2015-07-30 Thread SF Markus Elfring
>> I find that the change acceptance is unclear for fine-tuning of this software >> also around message log programming interfaces. >> Which design approaches do you find acceptable for further considerations? > > Sorry, I really can't follow. How do you generally think about any further fine-tun

Re: [systemd-devel] Configurability for systemd logging API

2015-07-29 Thread SF Markus Elfring
>> Such messages correspond to specific data structures. >> * The log origin and log level are repeated there while the recorded >> information might occasionally not be detailed enough. >> I find that such details can be better handled by the software build >> system. … > I appreciate you wan

[systemd-devel] Configurability for systemd logging API

2015-07-29 Thread SF Markus Elfring
Hello, Programs from the systemd software library output also some log messages as it is usual for such server applications. Such messages correspond to specific data structures. * The log origin and log level are repeated there while the recorded information might occasionally not be detailed

Re: [systemd-devel] Clarification around a segmentation fault from an udevd worker

2015-07-29 Thread SF Markus Elfring
> This is *very* strange. The 'format' parameter should not contain that > "%s:%s:%d" prefix at all, as this cannot work of course because the > argument list doesn't match. I guess that I wonder also about one of my own programming mistakes here. > Which version of systemd are you based on? la

Re: [systemd-devel] Clarification around a segmentation fault from an udevd worker

2015-07-29 Thread SF Markus Elfring
> This should usually generate a coredump. I have regenerated the current software on my test system. last commit: 6ad6d61f9ddd58983b075e4fbece30bae46fac37 Sonne:/home/elfring/Projekte/Bau/systemd # systemctl stop systemd-udevd.service systemd-udevd-kernel.socket systemd-udevd-control.socket &&

Re: [systemd-devel] Completion of error handling

2015-07-28 Thread SF Markus Elfring
> I have no understanding of Coccinelle. I do not understand what you > are saying. The application of a few scripts in the semantic patch language can occasionally help to improve some software, can't it? Now I'll try again to present more detailed source code analysis results according to specif

[systemd-devel] Creation of additional links for selected devices

2015-07-26 Thread SF Markus Elfring
Hello, I would like to clarify the combination of commands like "udevadm control -p" and "udevadm trigger" a bit more. How do device properties differ from attributes in this use case? I imagine that additional properties can be set before a corresponding addition of matching devices would be tr

Re: [systemd-devel] Clarification around a segmentation fault from an udevd worker

2015-07-26 Thread SF Markus Elfring
>> Jul 26 15:03:38 Sonne systemd-udevd[5347]: auid=1000 uid=0 >> gid=0 ses=1 pid=5347 comm="systemd-udevd" >> exe="/home/elfring/Projekte/Bau/systemd/systemd-udevd" sig >> Jul 26 15:03:38 Sonne kernel: systemd-udevd[5347]: segfault at 438 ip >> 76fefc78 sp 7fffc6b0 error 4 in >

Re: [systemd-devel] Clarification around a segmentation fault from an udevd worker

2015-07-26 Thread SF Markus Elfring
> It should print the backtrace with the location where the error happened. Unfortunately, no. Sonne:/home/elfring/Projekte/Bau/systemd # systemctl stop systemd-udevd.service systemd-udevd-kernel.socket systemd-udevd-control.socket && gdb systemd-udevd … worker [5347] terminated by signal 11 (S

Re: [systemd-devel] Completion of error handling

2015-07-26 Thread SF Markus Elfring
> No, nothing needs more discussion or attention in the context of systemd. I disagree here. - I would appreciate if return value ignorance can be still reduced at more source code places. Do you distinguish any update candidates which belong to a subsystem in this software? > None of the above

[systemd-devel] Clarification around a segmentation fault from an udevd worker

2015-07-25 Thread SF Markus Elfring
Hello, I would like to clarify the setting of device file permissions for my needs. So I extended the debug output at some source code places to see also better which lines are executed during my tests. I built these extensions for calls of the function "log_debug" on the current source files (la

Re: [systemd-devel] Completion of error handling

2015-07-24 Thread SF Markus Elfring
> We accept contributions only in git-format-patch frmatted patches, > best via github PRs. The higher level patch formats I'm trying to make you aware of will also result in file changes which can be integrated by this content management interface depending on your general acceptance for correspo

Re: [systemd-devel] Completion of error handling

2015-07-24 Thread SF Markus Elfring
> I have no understanding of Coccinelle. This software provides the tool "spatch" which lets you specify transformations for C source code in a similar way you are used to already by the reuse of unified context diffs. http://coccinelle.lip6.fr/ I assume that you have eventually noticed specific

Re: [systemd-devel] Completion of error handling

2015-07-24 Thread SF Markus Elfring
> We are regularly checking the systemd sources with coverity and the > llvm/clang analyzer. I hope that I may look also into a corresponding web interface. https://scan.coverity.com/projects/350 I found a few update candidates by a web search. https://github.com/systemd/systemd/issues/644 An a

[systemd-devel] Completion of error handling

2015-07-23 Thread SF Markus Elfring
Hello, I would like to continue the clarification of open issues around a topic like "Completion of error handling". https://github.com/systemd/systemd/issues/644 I hope that the amount of unchecked return values can be reduced further in affected source files by the reuse of dedicated software d