Re: [systemd-devel] [PATCH] sysusers: remove additional finger information from gecos

2015-02-07 Thread Sami Kerola
On 7 February 2015 at 23:50, Mantas Mikulėnas wrote: > On Sun, Feb 8, 2015 at 1:38 AM, Sami Kerola wrote: >> >> This change removes garbage from authentication messages if chfn(1) has >> been used. For example; >> >> $ timedatectl set-timezone Europe/London &g

[systemd-devel] [PATCH] sysusers: remove additional finger information from gecos

2015-02-07 Thread Sami Kerola
This change removes garbage from authentication messages if chfn(1) has been used. For example; $ timedatectl set-timezone Europe/London [...] Authenticating as: Sami Kerola,office,officephone,homephone, (kerolasa) --- src/sysusers/sysusers.c | 4 1 file changed, 4 insertions(+) diff

Re: [systemd-devel] [PATCH 2/2] journal, readahead: remove file handle leaks

2013-01-27 Thread Sami Kerola
On Sun, Jan 27, 2013 at 10:17 PM, David Strauss wrote: > Does the leak show up under Valgrind with fd checking enabled? I did not check. > On Sun, Jan 27, 2013 at 1:58 PM, Kay Sievers wrote: >> On Sun, Jan 27, 2013 at 10:51 PM, Sami Kerola wrote: >>> Found with the cocci

[systemd-devel] [PATCH 2/2] journal, readahead: remove file handle leaks

2013-01-27 Thread Sami Kerola
Found with the coccicheck-0.2.4 open file check. --- src/journal/catalog.c| 8 +++- src/readahead/readahead-common.c | 10 +++--- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/src/journal/catalog.c b/src/journal/catalog.c index 3735ad9..f89b309 100644 --- a/s

[systemd-devel] [PATCH 1/2] allover: remove unnecessary if() statements

2013-01-27 Thread Sami Kerola
The coccicheck-0.2.4 detected unnecessary NULL checks. Almost all of them were in format type *example; example = request_reservation(); if (!example) return; here_be_dragons; if (d) free(example); where the later if is impossible to be false. --- src/core/dbus.c

[systemd-devel] [PATCH] licence: remove references to old FSF address

2012-12-16 Thread Sami Kerola
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=57206 --- LICENSE.LGPL2.1| 82 -- src/gudev/gudev.h | 11 +++-- src/gudev/gudevclient.c| 12 +++-- src/gudev/gudevclient.h| 11 +++-- src/g

[systemd-devel] [PATCH] sd-daemon: fix cppcheck warnings

2012-10-15 Thread Sami Kerola
cs.net/lists/util-linux-ng/msg07031.html Signed-off-by: Sami Kerola --- src/libsystemd-daemon/sd-daemon.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libsystemd-daemon/sd-daemon.c b/src/libsystemd-daemon/sd-daemon.c index 863ac75..03cde39 100644 --- a/src