Re: [systemd-devel] feature request: dlopen

2015-02-22 Thread Shawn Landden
sufficient > that you will give this absolute top priority above everything else > that cannot be immediately put on hold. > > i am subscribed to this list on "nomail", and will follow it on gmane. > as you are experienced software developers i would not presume to > interfere with how to go about dynamically-loading of libsystemd0, > however if you would appreciate the benefit of my experience (which > comes in part from one of the software libre world's more experienced > unix portability experts, andrew tridgell), i will be more than happy > to help as i can. > > l. > ___ > systemd-devel mailing list > systemd-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/systemd-devel > -- --- Shawn Landden ChurchOfGit.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] A use case for staged startup

2015-02-21 Thread Shawn Landden
t need systemctl like the previous post suggests, if you get the dependencies right. You might also look at overlayfs, which got merged in Linux 3.18. I think overlayfs will make this possible, and of course share your results! > Thanks, > Jeff > > [1] > http://lists.freedesktop.org/arch

[systemd-devel] [v1] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-02-20 Thread Shawn Landden
if (!l) +return; + +for (k = l; *k; k++) +free(*k); + free(l); } diff --git a/src/systemctl/bootspec.c b/src/systemctl/bootspec.c new file mode 100644 index 000..0a43c7b --- /dev/null +++ b/src/systemctl/bootspec.c @@ -0,0 +1,204 @@ +/*-*- Mode:

[systemd-devel] [PATCH 8/8] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-02-20 Thread Shawn Landden
**k; + +if (!l) +return; + +for (k = l; *k; k++) +free(*k); + free(l); } diff --git a/src/systemctl/bootspec.c b/src/systemctl/bootspec.c new file mode 100644 index 000..8673957 --- /dev/null +++ b/src/systemctl/bootspec.c @@ -0,0 +1

[systemd-devel] [PATCH 7/8] add rpmvercmp()

2015-02-20 Thread Shawn Landden
--- Makefile.am| 2 + src/shared/rpmvercmp.c | 122 + src/shared/rpmvercmp.h | 14 ++ 3 files changed, 138 insertions(+) create mode 100644 src/shared/rpmvercmp.c create mode 100644 src/shared/rpmvercmp.h diff --git a/Makefile.a

[systemd-devel] [PATCH 4/8] update TODO

2015-02-20 Thread Shawn Landden
--- TODO | 2 ++ 1 file changed, 2 insertions(+) diff --git a/TODO b/TODO index 52a32d3..bf66ba1 100644 --- a/TODO +++ b/TODO @@ -32,6 +32,8 @@ External: * When lz4 gets an API for lz4 command output, make use of it to compress coredumps in a way compatible with /usr/bin/lz4. +* Fix emacs f

[systemd-devel] [PATCH 1/8] man: these binaries are internal APIs

2015-02-20 Thread Shawn Landden
--- man/systemd-halt.service.xml | 1 - man/systemd-shutdownd.service.xml | 1 - man/systemd-suspend.service.xml | 1 - 3 files changed, 3 deletions(-) diff --git a/man/systemd-halt.service.xml b/man/systemd-halt.service.xml index c94e2a1..7e7f8f2 100644 --- a/man/systemd-halt.service.xml

[systemd-devel] [PATCH 2/8] man/systemd.timer.xml: improve documentation of WakeSystem=

2015-02-20 Thread Shawn Landden
--- man/systemd.timer.xml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/man/systemd.timer.xml b/man/systemd.timer.xml index 20890f2..4207be0 100644 --- a/man/systemd.timer.xml +++ b/man/systemd.timer.xml @@ -230,8 +230,9 @@ be suspended and if the system support

[systemd-devel] [PATCH 3/8] power: refactor the three power management binaries to src/power

2015-02-20 Thread Shawn Landden
--- Makefile.am | 6 +- src/core/shutdown.c | 420 - src/power/Makefile| 28 +++ src/power/shutdown.c | 420 + src/power/shutdownd.c | 461 +++

[systemd-devel] [PATCH 6/8] add rbtree implamentation

2015-02-20 Thread Shawn Landden
from https://github.com/fbuihuu/libtree (LGPLv2.1+) --- Makefile.am | 2 + src/shared/rbtree.c | 482 src/shared/rbtree.h | 79 + 3 files changed, 563 insertions(+) create mode 100644 src/shared/rbtree.c create mode 100644 s

[systemd-devel] [PATCH 5/8] power: these binaries are internal APIs

2015-02-20 Thread Shawn Landden
They are not executed by a user (they all check how they were executed) so we can use assert() in main() just like we would anywhere else. --- src/power/shutdown.c | 20 ++-- src/power/shutdownd.c | 22 -- src/power/sleep.c | 14 +++--- 3 files chan

[systemd-devel] [PATCH] fix build against v3.20-rc1

2015-02-18 Thread Shawn Landden
--- fs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs.c b/fs.c index 22ca62b..f751392 100644 --- a/fs.c +++ b/fs.c @@ -208,7 +208,6 @@ static struct inode *fs_inode_get(struct super_block *sb, inode->i_private = kdbus_node_ref(node); inode->i_mapping->a_ops = &empty_aops

Re: [systemd-devel] [PATCH] shutdown: avoid calling `kexec` binary unnessecarily

2015-02-17 Thread Shawn Landden
t; On Mon, Feb 16, 2015 at 07:53:47PM -0800, Shawn Landden wrote: > > On Mon, Feb 16, 2015 at 5:08 AM, Lennart Poettering < > lenn...@poettering.net> > > wrote: > > > > > On Fri, 13.02.15 14:18, Shawn Landden (sh...@churchofgit.com) wrote: > > > > &

Re: [systemd-devel] [PATCH] shutdown: avoid calling `kexec` binary unnessecarily

2015-02-17 Thread Shawn Landden
On Tue, Feb 17, 2015 at 4:34 PM, Shawn Landden wrote: > On Tue, Feb 17, 2015 at 7:00 AM, Zbigniew Jędrzejewski-Szmek < > zbys...@in.waw.pl> wrote: > >> On Mon, Feb 16, 2015 at 07:53:47PM -0800, Shawn Landden wrote: >> > On Mon, Feb 16, 2015 at 5:08 AM

Re: [systemd-devel] [PATCH] shutdown: avoid calling `kexec` binary unnessecarily

2015-02-17 Thread Shawn Landden
On Tue, Feb 17, 2015 at 7:00 AM, Zbigniew Jędrzejewski-Szmek < zbys...@in.waw.pl> wrote: > On Mon, Feb 16, 2015 at 07:53:47PM -0800, Shawn Landden wrote: > > On Mon, Feb 16, 2015 at 5:08 AM, Lennart Poettering < > lenn...@poettering.net> > > wrote: > > > &g

Re: [systemd-devel] [PATCH] shutdown: avoid calling `kexec` binary unnessecarily

2015-02-16 Thread Shawn Landden
On Mon, Feb 16, 2015 at 5:08 AM, Lennart Poettering wrote: > On Fri, 13.02.15 14:18, Shawn Landden (sh...@churchofgit.com) wrote: > > > Still use helper when Xen Dom0, to avoid duplicating some hairy > > code. > > Hmm, what precisely does the helper do on xen? > > &

Re: [systemd-devel] [PATCH] configure: turn off -Wlogical-not-parentheses

2015-02-16 Thread Shawn Landden
On Mon, Feb 16, 2015 at 2:03 PM, Zbigniew Jędrzejewski-Szmek < zbys...@in.waw.pl> wrote: > On Mon, Feb 16, 2015 at 02:02:17PM -0800, Shawn Landden wrote: > > Introduced in gcc-5 > > > > These errors are really annoying. I can get behind clarification of > nested

[systemd-devel] [PATCH] configure: turn off -Wlogical-not-parentheses

2015-02-16 Thread Shawn Landden
Introduced in gcc-5 These errors are really annoying. I can get behind clarification of nested ifs, but this is overkill. --- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index 97a29d6..e646db7 100644 --- a/configure.ac +++ b/configure.ac @@ -187,6

[systemd-devel] [PATCH] timedated: when performing "SetTime" compensate for program lag

2015-02-16 Thread Shawn Landden
I can't test this as kdbus doesn't build against Linux 3.19 --- TODO | 2 -- src/timedate/timedated.c | 14 ++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/TODO b/TODO index 93dfa60..88055d3 100644 --- a/TODO +++ b/TODO @@ -190,8 +190,6 @@ Featur

[systemd-devel] [PATCH] timedated: when performing "SetTime" compensate for program lag

2015-02-16 Thread Shawn Landden
The start time could be moved back a little bit by using kdbus timestamps, but I'm guessing that that amount of time is insignificant. --- TODO | 2 -- src/timedate/timedated.c | 7 +++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/TODO b/TODO index 93dfa60

[systemd-devel] [PATCH] timedated: when performing "SetTime" compensate for program lag

2015-02-13 Thread Shawn Landden
--- TODO | 2 -- src/timedate/timedated.c | 14 ++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/TODO b/TODO index 68b0af6..7b93404 100644 --- a/TODO +++ b/TODO @@ -190,8 +190,6 @@ Features: * we should try harder to collapse start jobs for swaps

[systemd-devel] [PATCH] shutdown: avoid calling `kexec` binary unnessecarily

2015-02-13 Thread Shawn Landden
Still use helper when Xen Dom0, to avoid duplicating some hairy code. So we don't have any logic to load kexec kernels? --- TODO| 3 --- src/core/shutdown.c | 33 - 2 files changed, 20 insertions(+), 16 deletions(-) diff --git a/TODO b/TODO index 8

Re: [systemd-devel] [PATCH] timedated: support split usr v3

2015-01-19 Thread Shawn Landden
On Sun, Jan 18, 2015 at 12:52 PM, Kay Sievers wrote: > On Sun, Jan 18, 2015 at 7:53 PM, Shawn Landden > wrote: > > From: Shawn Paul Landden > > > > The current Debian solution to this is really ugly, and I would rather > > have them use the correct patch even if

[systemd-devel] [PATCH] timedated: support split usr v3

2015-01-18 Thread Shawn Landden
From: Shawn Paul Landden The current Debian solution to this is really ugly, and I would rather have them use the correct patch even if split usr is dumb. Read: http://rusty.ozlabs.org/?p=236 ("Why Everyone Must Oppose The Merging of /usr and /") (I managed to skip the

[systemd-devel] [PATCH 1/2] libudev: fix strict aliasing violation

2014-12-23 Thread Shawn Paul Landden
--- src/libudev/libudev-monitor.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/libudev/libudev-monitor.c b/src/libudev/libudev-monitor.c index e8d6b4a..484fefe 100644 --- a/src/libudev/libudev-monitor.c +++ b/src/libudev/libudev-monitor.c @@ -5

[systemd-devel] [PATCH 2/2] udev: fix another strict aliasing issue

2014-12-23 Thread Shawn Paul Landden
--- src/udev/ata_id/ata_id.c | 62 +++- 1 file changed, 30 insertions(+), 32 deletions(-) diff --git a/src/udev/ata_id/ata_id.c b/src/udev/ata_id/ata_id.c index 89628c9..fc13819 100644 --- a/src/udev/ata_id/ata_id.c +++ b/src/udev/ata_id/ata_id.c @@ -40

[systemd-devel] [PATCH] util: fix strict aliasing violations in use of struct inotify_event v5

2014-12-23 Thread Shawn Paul Landden
There is alot of cleanup that will have to happen to turn on -fstrict-aliasing, but I think our code should be "correct" to the rule. --- src/core/mount.c | 4 ++-- src/core/path.c | 4 ++-- src/journal/sd-journal.c | 4 ++-- src/shared/util.c| 5 ++--- src/shared/util

[systemd-devel] [PATCH] util: fix strict aliasing violations in use of struct inotify_event v3

2014-12-22 Thread Shawn Paul Landden
There is alot of cleanup that will have to happen to turn on -fstrict-aliasing, but I think our code should be "correct" to the rule. v2: move union def to header file v3: fix syntax --- src/journal/sd-journal.c | 6 +++--- src/shared/util.c| 7 +++ src/shared/util.h| 6 ++

[systemd-devel] [PATCH] gitignore: add another test

2014-12-22 Thread Shawn Paul Landden
--- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 1b5d60f..00a46a5 100644 --- a/.gitignore +++ b/.gitignore @@ -206,6 +206,7 @@ /test-libudev /test-libudev-sym* /test-list +/test-lldp /test-unaligned /test-locale-util /test-local-addresses -- 2

[systemd-devel] [PATCH] util: fix strict aliasing violations in use of struct inotify_event v2

2014-12-22 Thread Shawn Paul Landden
There is alot of cleanup that will have to happen to turn on -fstrict-aliasing, but I think our code should be "correct" to the rule. v2: move union def to header file --- src/journal/sd-journal.c | 6 +++--- src/shared/util.c| 6 +++--- src/shared/util.h| 5 + src/udev/udevd.

[systemd-devel] [PATCH] util: fix strict aliasing violations in use of struct inotify_event

2014-12-22 Thread Shawn Paul Landden
There is alot of cleanup that will have to happen to turn on -fstrict-aliasing, but I think our code should be "correct" to the rule. --- src/journal/sd-journal.c | 9 ++--- src/shared/util.c| 9 ++--- src/udev/udevd.c | 9 ++--- 3 files changed, 18 insertions(+), 9 del

[systemd-devel] [PATCH] timedated: support split usr v2

2014-12-21 Thread Shawn Paul Landden
The current Debian solution to this is really ugly, and I would rather have them use the correct patch even if split usr is dumb. Read: http://rusty.ozlabs.org/?p=236 ("Why Everyone Must Oppose The Merging of /usr and /") (I managed to skip the pulseaudio implamentation mess because I had a fanc

[systemd-devel] [PATCH] timedated: support split usr

2014-12-21 Thread Shawn Paul Landden
The current Debian solution to this is really ugly, and I would rather have them use the correct patch even if split usr is dumb. Read: http://rusty.ozlabs.org/?p=236 ("Why Everyone Must Oppose The Merging of /usr and /") (I managed to skip the pulseaudio implamentation mess because I had a fanc

Re: [systemd-devel] [PATCH 2/2] syscallfilter: port to libseccomp

2014-02-04 Thread Shawn Landden
of course > probably document it... > > Lennart > > -- > Lennart Poettering, Red Hat > ___ > systemd-devel mailing list > systemd-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/systemd-devel -- Shawn Landden +1 360 389 3001 (SMS preferred) ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] Use normal English elide in place of ellipsize

2014-02-04 Thread Shawn Landden
as implemented. > > If the logic was made smarter to not necessarily truncate at the end > (e.g. to remove vowels or similar), then "abbreviate" would be better > (although I cannot see this happening any time soon in a language > agnostic way!). > > My £0.02 > >

[systemd-devel] [PATCH] make: test-ellipsize is a manual test

2014-02-02 Thread Shawn Landden
--- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 8bef21b..dd4e2dc 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1124,6 +1124,7 @@ manual_tests += \ test-cgroup \ test-install \ test-watchdog \ + test-

[systemd-devel] [PATCH] manager: use CMSG macros

2014-02-02 Thread Shawn Landden
--- src/core/manager.c | 29 + 1 file changed, 21 insertions(+), 8 deletions(-) diff --git a/src/core/manager.c b/src/core/manager.c index 634b141..74fb52d 100644 --- a/src/core/manager.c +++ b/src/core/manager.c @@ -1275,9 +1275,10 @@ static int manager_dispatch_notif

[systemd-devel] [PATCH] DEFAULT_PATH_SPLIT_USR macro

2013-12-20 Thread Shawn Landden
--- src/nspawn/nspawn.c| 2 +- src/shared/path-util.h | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/nspawn/nspawn.c b/src/nspawn/nspawn.c index a85579b..241b4b5 100644 --- a/src/nspawn/nspawn.c +++ b/src/nspawn/nspawn.c @@ -1243,7 +1243,7 @@ int main(int argc, ch

Re: [systemd-devel] systemd-nspawn and kernel command line

2013-12-20 Thread Shawn Landden
On Fri, Dec 20, 2013 at 2:09 PM, Shawn Landden wrote: > On Mon, Dec 9, 2013 at 9:23 AM, Colin Guthrie wrote: >> 'Twas brillig, and Lennart Poettering at 08/12/13 23:48 did gyre and gimble: >>> On Sat, 07.12.13 18:33, Colin Guthrie (gm...@colin.guthr.ie) wrote: >>>

Re: [systemd-devel] systemd-nspawn and kernel command line

2013-12-20 Thread Shawn Landden
On Mon, Dec 9, 2013 at 9:23 AM, Colin Guthrie wrote: > 'Twas brillig, and Lennart Poettering at 08/12/13 23:48 did gyre and gimble: >> On Sat, 07.12.13 18:33, Colin Guthrie (gm...@colin.guthr.ie) wrote: >> >>> Hi, >>> >>> When playing with systemd-nspawn, is there a way to override the kernel >>>

Re: [systemd-devel] [PATCH 00/11] *** SUBJECT HERE ***

2013-12-20 Thread Shawn Landden
On Fri, Dec 20, 2013 at 11:50 AM, Colin Walters wrote: > On Thu, 2013-12-19 at 14:20 +0100, Florian Weimer wrote: > >> readdir_r is rather broken on Linux because there are some directories >> it cannot read. > > Citation? Are you talking about > http://womble.decadent.org.uk/readdir_r-advisory.h

Re: [systemd-devel] [PATCH] core: support Distribute=n to distribute to n workers

2013-12-19 Thread Shawn Landden
ping? On Fri, Dec 13, 2013 at 8:23 PM, Shawn Landden wrote: > If Distribute=n, turns SO_REUSEPORT on, and spawns > n workers to handling incoming requests. > > SO_REUSEPORT sockets on the same port must all be created > by the same uid, therefore using the option allows > other

Re: [systemd-devel] [PATCH] __thread --> thread_local for C11 compat

2013-12-17 Thread Shawn Landden
On Tue, Dec 17, 2013 at 12:46 PM, Lennart Poettering wrote: > On Sun, 15.12.13 16:19, Shawn Landden (sh...@churchofgit.com) wrote: > >> to actually use this we would have to add this patch: >> >> diff --git a/configure.ac b/configure.ac >> index f85e86e..5ead12

[systemd-devel] [PATCH] journal: fix against (theoretical) undefined behavior

2013-12-16 Thread Shawn Landden
While all the libc implementations I know return NULL when memchr's size parameter is 0, without accessing any memory, passing NULL to memchr is still invalid: C11 7.24.1p2: Where an argument declared as "size_t n" specifies the length of the array for a function, n can have the value zero on a ca

Re: [systemd-devel] [PATCH] journal: fix assert against (theoretical) undefined behavior

2013-12-16 Thread Shawn Landden
On Mon, Dec 16, 2013 at 12:19 PM, Thomas H.P. Andersen wrote: > On Mon, Dec 16, 2013 at 8:15 PM, Shawn Landden wrote: >> On Mon, Dec 16, 2013 at 11:06 AM, Thomas H.P. Andersen >> wrote: >>> On Mon, Dec 16, 2013 at 7:50 PM, Shawn Landden >>> wrote: >

Re: [systemd-devel] [PATCH] journal: fix assert against (theoretical) undefined behavior

2013-12-16 Thread Shawn Landden
On Mon, Dec 16, 2013 at 11:06 AM, Thomas H.P. Andersen wrote: > On Mon, Dec 16, 2013 at 7:50 PM, Shawn Landden wrote: >> On Mon, Dec 16, 2013 at 10:36 AM, Lennart Poettering >> wrote: >>> On Mon, 16.12.13 09:20, Shawn Landden (sh...@churchofgit.com) wrote: >

Re: [systemd-devel] [PATCH] journal: fix assert against (theoretical) undefined behavior

2013-12-16 Thread Shawn Landden
On Mon, Dec 16, 2013 at 10:36 AM, Lennart Poettering wrote: > On Mon, 16.12.13 09:20, Shawn Landden (sh...@churchofgit.com) wrote: > >> While all the libc implementations I know return NULL when memchr's size >> parameter is 0: >> >> C11 7.24.1p2: Wher

[systemd-devel] [PATCH] journal: fix assert against (theoretical) undefined behavior

2013-12-16 Thread Shawn Landden
While all the libc implementations I know return NULL when memchr's size parameter is 0: C11 7.24.1p2: Where an argument declared as "size_t n" specifies the length of the array for a function, n can have the value zero on a call to that function. Unless explicitly stated otherwise in the descript

[systemd-devel] [PATCH] _noreturn_ --> noreturn for C11 compat

2013-12-16 Thread Shawn Landden
also define noreturn w/o --- src/core/main.c | 2 +- src/journal/test-journal-interleaving.c | 2 +- src/shared/log.c| 4 ++-- src/shared/log.h| 4 ++-- src/shared/macro.h | 10 +- src/shared/

[systemd-devel] [PATCH 1/2] util: no need for in_initrd() cache to be thread-local

2013-12-15 Thread Shawn Landden
the process only has one working directory, and a race is harmless --- src/shared/util.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/shared/util.c b/src/shared/util.c index b5ffaa1..7c73074 100644 --- a/src/shared/util.c +++ b/src/shared/util.c @@ -2737,9 +2737,

[systemd-devel] [PATCH] __thread --> thread_local for C11 compat

2013-12-15 Thread Shawn Landden
Also make thread_local available w/o including . (as the latter hasn't been implemented, but this part is trivial) --- src/libsystemd-bus/sd-bus.c | 4 ++-- src/libsystemd-bus/sd-event.c | 2 +- src/libsystemd-id128/sd-id128.c | 8 src/login/logind-inhibit.c | 2 +- src/sha

Re: [systemd-devel] [PATCH] __thread --> thread_local for C11 compat

2013-12-15 Thread Shawn Landden
On Sun, Dec 15, 2013 at 3:16 PM, Lennart Poettering wrote: > On Sun, 15.12.13 14:56, Shawn Landden (sh...@churchofgit.com) wrote: > >> On Sun, Dec 15, 2013 at 1:56 PM, Lennart Poettering >> wrote: >> > On Sun, 15.12.13 13:19, Shawn Landden (sh...@churchofgit.com)

Re: [systemd-devel] [PATCH] __thread --> thread_local for C11 compat

2013-12-15 Thread Shawn Landden
On Sun, Dec 15, 2013 at 1:56 PM, Lennart Poettering wrote: > On Sun, 15.12.13 13:19, Shawn Landden (sh...@churchofgit.com) wrote: > >> also make thread_local available w/o including > > Hmm, that looks a bit too early, no? Does gcc even support this? glibc gcc-4.9 supports

[systemd-devel] [PATCH] __thread --> thread_local for C11 compat

2013-12-15 Thread Shawn Landden
also make thread_local available w/o including --- src/libsystemd-bus/sd-bus.c | 4 ++-- src/libsystemd-bus/sd-event.c | 2 +- src/libsystemd-id128/sd-id128.c | 8 src/login/logind-inhibit.c | 2 +- src/shared/capability.c | 4 ++-- src/shared/cgroup-util.c

[systemd-devel] [PATCH] __thread --> thread_local for C11 compat

2013-12-15 Thread Shawn Landden
also make thread_local available w/o including --- src/libsystemd-bus/sd-bus.c | 4 ++-- src/libsystemd-bus/sd-event.c | 2 +- src/libsystemd-id128/sd-id128.c | 8 src/login/logind-inhibit.c | 2 +- src/shared/capability.c | 4 ++-- src/shared/cgroup-util.c| 2

Re: [systemd-devel] [PATCH] udev: fix printf specifiers

2013-12-14 Thread Shawn Landden
On Sat, Dec 14, 2013 at 8:11 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Sat, Dec 14, 2013 at 06:48:34PM -0800, Shawn Landden wrote: >> This keeps the same behavior, which is wierd. >> --- >> src/udev/udev-builtin-path_id.c | 4 ++-- >> 1 file changed, 2 insertions(+)

[systemd-devel] [PATCH] udev: fix printf specifiers

2013-12-14 Thread Shawn Landden
This keeps the same behavior, which is wierd. --- src/udev/udev-builtin-path_id.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/udev/udev-builtin-path_id.c b/src/udev/udev-builtin-path_id.c index 7476330..7543a11 100644 --- a/src/udev/udev-builtin-path_id.c +++ b/src/

Re: [systemd-devel] systemd + logind possible deadlock

2013-12-14 Thread Shawn Landden
meme status http://gnomememes.tumblr.com/post/48703520110#notes On Sat, Dec 14, 2013 at 8:56 AM, Zbigniew Jędrzejewski-Szmek wrote: > On Sat, Dec 14, 2013 at 11:55:47AM +0200, Oleksii Shevchuk wrote: >> > strace -p 1 >> >> stat("/sys", {st_mode=S_IFDIR|0555, st_size=0, ...}) = 0 >> open("/sys/cl

[systemd-devel] Fwd: [Pkg-systemd-maintainers] Bug#732157: Want SIGSTOP-style daemon/service readiness notification

2013-12-14 Thread Shawn Landden
forwarding to systemd-devel for discussion -- Forwarded message -- From: Ian Jackson Date: Sat, Dec 14, 2013 at 1:05 PM Subject: [Pkg-systemd-maintainers] Bug#732157: Want SIGSTOP-style daemon/service readiness notification To: sub...@bugs.debian.org Package: systemd Version: 2

[systemd-devel] [PATCH] build: use -ftrapv for development

2013-12-14 Thread Shawn Landden
We want to find these bugs if they exist. --- autogen.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/autogen.sh b/autogen.sh index d0a2f3f..9ffd724 100755 --- a/autogen.sh +++ b/autogen.sh @@ -54,10 +54,10 @@ args="$args \ fi if [ "x$1" = "xc" ]; then -./c

Re: [systemd-devel] [PATCH] sd-event: we do not support EPOLLONESHOT correctly

2013-12-13 Thread Shawn Landden
On Fri, Dec 13, 2013 at 8:39 PM, Shawn Landden wrote: > On Fri, Dec 13, 2013 at 8:04 PM, Shawn Landden wrote: >> On Fri, Dec 13, 2013 at 7:17 PM, Lennart Poettering >> wrote: >>> On Fri, 13.12.13 13:08, Shawn Landden (sh...@churchofgit.com) wrote: >>> >

Re: [systemd-devel] [PATCH] sd-event: we do not support EPOLLONESHOT correctly

2013-12-13 Thread Shawn Landden
On Fri, Dec 13, 2013 at 8:04 PM, Shawn Landden wrote: > On Fri, Dec 13, 2013 at 7:17 PM, Lennart Poettering > wrote: >> On Fri, 13.12.13 13:08, Shawn Landden (sh...@churchofgit.com) wrote: >> >>> If this event is not the highest priority, then it will not be &g

[systemd-devel] [PATCH] core: support Distribute=n to distribute to n workers

2013-12-13 Thread Shawn Landden
If Distribute=n, turns SO_REUSEPORT on, and spawns n workers to handling incoming requests. SO_REUSEPORT sockets on the same port must all be created by the same uid, therefore using the option allows other root programs (or programs of the same user if running in --user mode) to "hijack" this por

Re: [systemd-devel] [PATCH] sd-event: we do not support EPOLLONESHOT correctly

2013-12-13 Thread Shawn Landden
On Fri, Dec 13, 2013 at 7:17 PM, Lennart Poettering wrote: > On Fri, 13.12.13 13:08, Shawn Landden (sh...@churchofgit.com) wrote: > >> If this event is not the highest priority, then it will not be >> dispatched when the epoll triggers, and since we will not get any more >

Re: [systemd-devel] [PATCH 1/2] nspawn: --populate to run static binaries on empty target directory

2013-12-13 Thread Shawn Landden
On Tue, Dec 10, 2013 at 2:18 PM, Lennart Poettering wrote: > On Mon, 02.12.13 09:41, Shawn Landden (sh...@churchofgit.com) wrote: > >> >> On Mon, Dec 2, 2013 at 8:27 AM, Lennart Poettering >> wrote: >> > On Sat, 30.11.13 10:20, Shawn Landden (sh...@churchofgit.

[systemd-devel] [PATCH] sd-event: we do not support EPOLLONESHOT correctly

2013-12-13 Thread Shawn Landden
If this event is not the highest priority, then it will not be dispatched when the epoll triggers, and since we will not get any more wakeups (due to the way EPOLLONESHOT works) will never be dispatched. Since we only handle one event per epoll_wait() wakeup, and we dequeue a ONE_SHOT event when w

[systemd-devel] [PATCH] core: support Distribute=n to distribute to n workers

2013-12-13 Thread Shawn Landden
If Distribute=n, turns SO_REUSEPORT on, and spawns n workers to handling incoming requests. SO_REUSEPORT sockets on the same port must all be created by the same uid, therefore using the option allows other root programs (or programs of the same user if running in --user mode) to "hijack" this por

Re: [systemd-devel] [PATCH] core: support Distribute=n to distribute to n workers

2013-12-13 Thread Shawn Landden
Forgot to send my notes on the last review On Fri, Dec 13, 2013 at 7:12 AM, Lennart Poettering wrote: > On Thu, 12.12.13 23:46, Shawn Landden (sh...@churchofgit.com) wrote: > >> -Socket.ReusePort,config_parse_bool, 0, >>

[systemd-devel] [PATCH] core: support Distribute=n to distribute to n workers

2013-12-12 Thread Shawn Landden
If Distribute=n, turns SO_REUSEPORT on, and spawns n workers to handling incoming requests. SO_REUSEPORT sockets on the same port must all be created by the same uid, therefore using the option allows other root programs (or programs of the same user if running in --user mode) to "hijack" this por

Re: [systemd-devel] [PATCH] timedatectl: work with old timedated

2013-12-12 Thread Shawn Landden
On Thu, Dec 12, 2013 at 11:02 AM, Lennart Poettering wrote: > On Thu, 12.12.13 10:00, Shawn Landden (sh...@churchofgit.com) wrote: > > > Applied. Dropped the fflush(stderr) bits though as we that's not > necessary for stderr, and not even for stdout if an \n was printed &

[systemd-devel] [PATCH] timedatectl: work with old timedated

2013-12-12 Thread Shawn Landden
Which does have TimeUSec. Should we specifically check for this method instead of assuming time=0 means it doesn't exist? Before: shawn@debian-T61:~/git/systemd$ ./timedatectl Local time: Wed 1969-12-31 16:00:00 PST Universal time: Thu 1970-01-01 00:00:00 UTC RTC time

Re: [systemd-devel] [HACK/RFC/PATCH] systemd-su: "su" on steroids

2013-12-11 Thread Shawn Landden
On Tue, Dec 10, 2013 at 3:18 PM, Lennart Poettering wrote: > On Mon, 02.12.13 21:47, David Herrmann (dh.herrm...@gmail.com) wrote: > >> >> 4h later, I present "systemd-su": >> >> If you want to give it a try, run: >> systemd-su -u david /bin/sh >> >> It requires the systemd-suexec helper interna

Re: [systemd-devel] [PATCH] test-fileio: replace mktemp with mkstemp to avoid warnings

2013-12-11 Thread Shawn Landden
Thank you for this! On Wed, Dec 11, 2013 at 5:55 PM, Thomas H.P. Andersen wrote: > On Thu, Dec 12, 2013 at 1:41 AM, Zbigniew Jędrzejewski-Szmek > wrote: >> On Thu, Dec 12, 2013 at 12:32:43AM +0100, Thomas H.P. Andersen wrote: >>> From: Thomas Hindoe Paaboel Andersen >>> >>> This is a fairly use

[systemd-devel] [PATCH] timedatectl: work with old timedated

2013-12-11 Thread Shawn Landden
Which does have TimeUSec. Should we specifically check for this method instead of assuming time=0 means it doesn't exist? Before: shawn@debian-T61:~/git/systemd$ ./timedatectl Local time: Wed 1969-12-31 16:00:00 PST Universal time: Thu 1970-01-01 00:00:00 UTC RTC time

[systemd-devel] [PATCH] core: support Distribute=n to distribute to n workers

2013-12-10 Thread Shawn Landden
Because it takes a while for the service to start up, and until then we spin in a fast epoll loop, this tends to start up all the instances all at once. There are a number of ways we can slow this instanciation down: 1) Call accept() and pass an additional fd to the service 2) Use EPOLLET: requir

[systemd-devel] [PATCH] core/manager: remove infinite loop

2013-12-10 Thread Shawn Landden
--- src/core/manager.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/core/manager.c b/src/core/manager.c index f06df54..c25343f 100644 --- a/src/core/manager.c +++ b/src/core/manager.c @@ -2211,10 +2211,8 @@ int manager_deserialize(Manager *m, FILE *f, FDSet *fds) {

[systemd-devel] [PATCH 1/2] core: support Distribute=n to distribute to n workers

2013-12-09 Thread Shawn Landden
Until there are some use cases for Distribute= w/o SO_REUSEPORT make it imply that. Otherwise we need a new config_parse_distribute in load-fragment.c and gain the same issues of config_parse_syscall, where NoNewPrivs can be still set to false, but only if set _after_ SystemCallFilter (only allowed

[systemd-devel] [PATCH 2/2] epoll and signalfd has been moved into sd event loop

2013-12-09 Thread Shawn Landden
--- src/core/manager.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/core/manager.c b/src/core/manager.c index f06df54..56c10cf 100644 --- a/src/core/manager.c +++ b/src/core/manager.c @@ -22,9 +22,7 @@ #include #include #include -#include #include -#include #include #inclu

[systemd-devel] [PATCH] update README to not suggest that systemd works without procfs

2013-12-09 Thread Shawn Landden
--- README | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/README b/README index cc43953..7cd1f1d 100644 --- a/README +++ b/README @@ -45,6 +45,7 @@ REQUIREMENTS: CONFIG_EPOLL CONFIG_NET CONFIG_SYSFS + CONFIG_PROC_FS Lin

[systemd-devel] [PATCH] update README to not suggest that systemd works without procfs

2013-12-09 Thread Shawn Landden
--- README | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/README b/README index cc43953..f2a86c5 100644 --- a/README +++ b/README @@ -45,6 +45,7 @@ REQUIREMENTS: CONFIG_EPOLL CONFIG_NET CONFIG_SYSFS + CONFIG_PROC_FS Lin

Re: [systemd-devel] [PATCH 4/4] core: lazy distribute for Distribute pools

2013-12-08 Thread Shawn Landden
On Sun, Dec 8, 2013 at 7:50 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Mon, Nov 18, 2013 at 12:36:52AM +0100, Zbigniew Jędrzejewski-Szmek wrote: >> On Sun, Nov 17, 2013 at 02:57:56PM -0800, Shawn Landden wrote: >> > On Sun, Nov 17, 2013 at 2:28 PM, Zbigniew Jędrzejewski

Re: [systemd-devel] [PATCH] test: rework run_qemu

2013-12-07 Thread Shawn Landden
On Sat, Dec 7, 2013 at 3:01 PM, Ronny Chevalier wrote: > It tries to find a suitable QEMU binary and will use KVM if present. > We can now configure QEMU from outside with 4 variables : > - $QEMU_BIN : path to QEMU's binary > - $KERNEL_APPEND : arguments appended to kernel cmdline > - $KERNE

Re: [systemd-devel] systemd-nspawn and kernel command line

2013-12-07 Thread Shawn Landden
On Sat, Dec 7, 2013 at 11:03 AM, Colin Guthrie wrote: > 'Twas brillig, and Shawn Landden at 07/12/13 18:57 did gyre and gimble: >> On Sat, Dec 7, 2013 at 10:33 AM, Colin Guthrie wrote: >>> Hi, >>> >>> When playing with systemd-nspawn, is there a way to

Re: [systemd-devel] systemd-nspawn and kernel command line

2013-12-07 Thread Shawn Landden
On Sat, Dec 7, 2013 at 10:33 AM, Colin Guthrie wrote: > Hi, > > When playing with systemd-nspawn, is there a way to override the kernel > command line seen inside the container. I mean it's probably not correct > that the host systems /proc/cmdline leaks into the container. No it is not, /proc/cmd

[systemd-devel] [PATCH] nspawn: fix buggy mount_binds, now works for bind-mounted files

2013-12-05 Thread Shawn Landden
--- src/nspawn/nspawn.c | 42 ++ 1 file changed, 26 insertions(+), 16 deletions(-) diff --git a/src/nspawn/nspawn.c b/src/nspawn/nspawn.c index dd7337b..c1212c0 100644 --- a/src/nspawn/nspawn.c +++ b/src/nspawn/nspawn.c @@ -416,6 +416,7 @@ static int mount_

Re: [systemd-devel] [PATCH 1/2] nspawn: --populate to run static binaries on empty target directory

2013-12-03 Thread Shawn Landden
On Mon, Dec 2, 2013 at 9:41 AM, Shawn Landden wrote: > On Mon, Dec 2, 2013 at 8:27 AM, Lennart Poettering > wrote: >> On Sat, 30.11.13 10:20, Shawn Landden (sh...@churchofgit.com) wrote: >> >>> nspawn has been called "chroot on steroids". >>> &g

Re: [systemd-devel] [PATCH 1/2] nspawn: --populate to run static binaries on empty target directory

2013-12-02 Thread Shawn Landden
On Mon, Dec 2, 2013 at 8:27 AM, Lennart Poettering wrote: > On Sat, 30.11.13 10:20, Shawn Landden (sh...@churchofgit.com) wrote: > >> nspawn has been called "chroot on steroids". >> >> Continue that tradition by supporting target directories that >> ar

Re: [systemd-devel] [RFC 05/12] gfx: add sd-gfx library with unifont section

2013-12-02 Thread Shawn Landden
On Wed, Nov 27, 2013 at 10:48 AM, David Herrmann wrote: > If we want to interact with a user in the initrd, during > emergency-situations, in single-user mode, or in any other rather limited > situation, we currently rely on the kernel to do input and graphics access > for us. More precisely, we r

Re: [systemd-devel] [PATCH 2/4] shared: mark strv_length() _pure_

2013-12-01 Thread Shawn Landden
On Sun, Dec 1, 2013 at 3:59 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Sun, Dec 01, 2013 at 02:50:15PM -0800, Shawn Landden wrote: >> --- >> src/shared/strv.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/shared/strv.c b/s

[systemd-devel] [PATCH] nspawn: shorten conditional path

2013-12-01 Thread Shawn Landden
--- src/nspawn/nspawn.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/src/nspawn/nspawn.c b/src/nspawn/nspawn.c index dd7337b..f400a65 100644 --- a/src/nspawn/nspawn.c +++ b/src/nspawn/nspawn.c @@ -481,10 +481,8 @@ static int setup_timezone(const char *de

[systemd-devel] [PATCH] nspawn: --populate with dynamic libs and one-file scripts

2013-12-01 Thread Shawn Landden
the whitelist of dynamic linker paths comes from clang --- man/systemd-nspawn.xml | 8 +-- src/nspawn/elf.c | 161 + src/nspawn/elf.h | 14 +++- src/nspawn/nspawn.c| 191 ++--- src/shared/util.c

[systemd-devel] [PATCH 4/4] nspawn: --populate with dynamic libs and one-file scripts

2013-12-01 Thread Shawn Landden
the whitelist of dynamic linker paths comes from clang --- man/systemd-nspawn.xml | 8 +-- src/nspawn/elf.c | 162 + src/nspawn/elf.h | 14 +++- src/nspawn/nspawn.c| 191 ++--- src/shared/util.c

[systemd-devel] [PATCH 3/4] nspawn: --populate to run static binaries on empty target directory

2013-12-01 Thread Shawn Landden
-u --user= diff --git a/src/nspawn/elf.c b/src/nspawn/elf.c new file mode 100644 index 000..f91b374 --- /dev/null +++ b/src/nspawn/elf.c @@ -0,0 +1,131 @@ +/*-*- Mode: C; c-basic-offset: 8; indent-tabs-mode: nil -*-*/ + +/*** + This file is part of systemd. + + Copyright

[systemd-devel] [PATCH 2/4] shared: mark strv_length() _pure_

2013-12-01 Thread Shawn Landden
--- src/shared/strv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/strv.c b/src/shared/strv.c index 607c221..cc6adfa 100644 --- a/src/shared/strv.c +++ b/src/shared/strv.c @@ -84,7 +84,7 @@ char **strv_copy(char * const *l) { return r; } -unsigned strv

[systemd-devel] [PATCH 1/4] nspawn: shorten conditional path

2013-12-01 Thread Shawn Landden
--- src/nspawn/nspawn.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/src/nspawn/nspawn.c b/src/nspawn/nspawn.c index dd7337b..0151cf3 100644 --- a/src/nspawn/nspawn.c +++ b/src/nspawn/nspawn.c @@ -481,10 +481,8 @@ static int setup_timezone(const char *de

Re: [systemd-devel] systemd session mode

2013-12-01 Thread Shawn Landden
On Sun, Dec 1, 2013 at 11:25 AM, Hristo Venev wrote: > I've implemented session mode for systemd. I am currently using it and it > works > pretty okay. I just had to generate D-Bus user services for D-Bus activation > to > work. > > A new variable, XDG_SESSION_DIR, has been added. It defaults to

Re: [systemd-devel] [RFC] logind: introduce session "positions"

2013-12-01 Thread Shawn Landden
On Sun, Dec 1, 2013 at 3:43 AM, David Herrmann wrote: > logind has no concept of session ordering. Sessions have a unique name, > some attributes about the capabilities and that's already it. There is > currently no stable+total order on sessions. If we use the logind API to > switch between sessi

Re: [systemd-devel] [RFC 05/12] gfx: add sd-gfx library with unifont section

2013-11-30 Thread Shawn Landden
On Sat, Nov 30, 2013 at 9:28 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Wed, Nov 27, 2013 at 07:48:40PM +0100, David Herrmann wrote: >> As a first step, we add the required header+build-chain and add the >> font-handling. To avoid heavy font-pipelines in systemd, we only provide >> a statically-s

[systemd-devel] [PATCH] fix regression of read_full_file() in fileio.c

2013-11-30 Thread Shawn Landden
my e93c33d4aa broke this stupidly --- src/shared/fileio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/shared/fileio.c b/src/shared/fileio.c index ac1b409..ede8819 100644 --- a/src/shared/fileio.c +++ b/src/shared/fileio.c @@ -240,6 +240,7 @@ int read_full_file(const char *fn, char **co

Re: [systemd-devel] build broken on clang

2013-11-30 Thread Shawn Landden
On Sat, Nov 30, 2013 at 5:46 PM, Greg KH wrote: > On Sun, Dec 01, 2013 at 12:38:44AM +0100, Thomas H.P. Andersen wrote: >> Hi, >> >> Since 777d7a6123cbb192a8ff9e4ac5c05b1da84b4217 the build is broken on clang: >> >> src/libsystemd-bus/bus-control.c:686:41: error: fields must have a >> constant siz

<    1   2   3   4   >