Re: [systemd-devel] TTY ownership and systemd user session

2014-01-09 Thread Yin Kangkai
On 2014-01-10, 06:27 +0100, Lennart Poettering wrote: > On Thu, 09.01.14 09:56, Yin Kangkai (kangkai@linux.intel.com) wrote: > > > Hi, > > > > I am bringing up systemd user session in Tizen, I am using v208. > > > > We run into a small issue that i

[systemd-devel] TTY ownership and systemd user session

2014-01-08 Thread Yin Kangkai
Hi, I am bringing up systemd user session in Tizen, I am using v208. We run into a small issue that if a user session service file claims TTY, systemd user session will fail to chown_terminal() for it: "Failed at step STDIN spawning /usr/bin/xorg-launch-helper: Permission denied" My testing se

Re: [systemd-devel] [PATCH 4/4] gdbus: Add basic kdbus tests

2013-12-20 Thread Yin Kangkai
On 2013-11-21, 12:33 +0100, Karol Lewandowski wrote: > +TESTS > += > + > +* Build test binaries: > + > + cd gio/tests > + make > + > +* Set variable to use custom library and to use kdbus as session bus: > + > + export LD_LIBRARY_PATH=absolute_path_to_glib_libs_with_kdbus_patch > + export D

Re: [systemd-devel] [PATCH] libsystemd-bus: make sure buf transfered into kenrel is 8 aligned

2013-12-16 Thread Yin Kangkai
On 2013-12-16, 17:49 +0100, Kay Sievers wrote: > On Mon, Dec 16, 2013 at 4:09 PM, Kay Sievers wrote: > Just added __attribute__ ((__aligned__(8))) to kdbus.h for structures > used in ioctls. Yes, your patch is much more cleaner, thanks Kay. Regards, Kangkai __

Re: [systemd-devel] [PATCH] libsystemd-bus: make sure buf transfered into kenrel is 8 aligned

2013-12-16 Thread Yin Kangkai
On 2013-12-16, 16:01 +0100, Lennart Poettering wrote: > On Mon, 16.12.13 15:50, Lennart Poettering (lenn...@poettering.net) wrote: > > > > diff --git a/src/libsystemd-bus/bus-control.c > > > b/src/libsystemd-bus/bus-control.c > > > index 0072c37..6b2790d 100644 > > > --- a/src/libsystemd-bus/bus-

[systemd-devel] [PATCH] libsystemd-bus: make sure buf transfered into kenrel is 8 aligned

2013-12-16 Thread Yin Kangkai
From: Yin Kangkai Otherwise, for example hello arg passed to KDBUS_CMD_HELLO might not be 8 bytes aligned and kernel returns -EFAULT. 319 int bus_kernel_take_fd(sd_bus *b) { 320 struct kdbus_cmd_hello hello; (gdb) p &hello $8 = (struct kdbus_cmd_hello *) 0xb354 ---

Re: [systemd-devel] [PATCH] libsystemd-bus: trivial macro KDBUS_PART_HEADER_SIZE replace

2013-12-10 Thread Yin Kangkai
On 2013-12-10, 20:56 +0100, Lennart Poettering wrote: > On Wed, 04.12.13 15:28, Yin Kangkai (kangkai@intel.com) wrote: > > > It's a little bit cleaner(?) to replace offsetof(struct kdbus_item, data) > > with > > KDBUS_PART_HEADER_SIZE. > > Hmm, is this

Re: [systemd-devel] [PATCH 1/7] libsystemd-bus: bring definitions in sync with kdbus

2013-12-04 Thread Yin Kangkai
On 2013-12-04, 08:49 +0100, Daniel Mack wrote: > > Actually, I have a stupid question, do we have any particular reason > > to use "part/PART"? giving the fact that we already have term "item" > > everywhere in the code... > > > > struct kdbus_item, items, kdbus_msg.items... > > > > My opinion, o

[systemd-devel] [PATCH] libsystemd-bus: trivial macro KDBUS_PART_HEADER_SIZE replace

2013-12-03 Thread Yin Kangkai
It's a little bit cleaner(?) to replace offsetof(struct kdbus_item, data) with KDBUS_PART_HEADER_SIZE. --- src/libsystemd-bus/bus-control.c | 16 src/libsystemd-bus/bus-kernel.c | 41 src/libsystemd-bus/bus-kernel.h | 2 +- 3 files chang

Re: [systemd-devel] [PATCH 1/7] libsystemd-bus: bring definitions in sync with kdbus

2013-12-03 Thread Yin Kangkai
On 2013-11-15, 19:32 +0100, Daniel Mack wrote: > In particular, KDBUS_ITEM_NEXT is now called KDBUS_PART_NEXT, and > KDBUS_ITEM_FOREACH was renamed to KDBUS_PART_FOREACH and takes one more > argument to make it more flexible. [...] > --- > src/libsystemd-bus/bus-control.c | 2 +- > src/libsyste

[systemd-devel] [PATCH] conf-parser: fix memory realloc error

2013-11-25 Thread Yin Kangkai
Otherwise there is some memory corruption and undefined behavior, e.g., in my case systemd-udev was always aborted at the _cleanup_freep_ around that code blocks. Signed-off-by: Yin Kangkai --- src/shared/conf-parser.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src

Re: [systemd-devel] [PATCH] build fix: add RT_LIBS to link against for test-bus-marshal

2013-11-20 Thread Yin Kangkai
On 2013-11-21, 13:14 +1000, David Timothy Strauss wrote: > I often get this when I have a dirty build. Have you tried a fully clean > build? Retried with a make distclean, and you're right, do not met this issue again. So please ignore this patch. Regards, Kangkai __

[systemd-devel] [PATCH] build fix: add RT_LIBS to link against for test-bus-marshal

2013-11-20 Thread Yin Kangkai
ibrt.so.1: could not read symbols: Invalid operation collect2: error: ld returned 1 exit status make[2]: *** [test-bus-marshal] Error 1 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2 Signed-off-by: Yin Kangkai --- Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 delet

[systemd-devel] [PATCH] journal: add HAVE_XZ check to avoid build failure

2012-08-24 Thread Yin Kangkai
Without this, build fail if we --disable-xz or does not have xz installed in system. Signed-off-by: Yin Kangkai --- src/journal/journal-verify.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/journal/journal-verify.c b/src/journal/journal-verify.c index 2401293