Re: [systemd-devel] [PATCH] [RFC] Move handling of sysv initscripts to a generator

2014-06-06 Thread Lennart Poettering
On Wed, 28.05.14 11:58, Thomas H.P. Andersen (pho...@gmail.com) wrote: On Wed, May 28, 2014 at 3:38 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Wed, May 28, 2014 at 01:12:23AM +0200, Thomas H.P. Andersen wrote: From: Thomas Hindoe Paaboel Andersen pho...@gmail.com Reuses

Re: [systemd-devel] [PATCH] [RFC] Move handling of sysv initscripts to a generator

2014-05-31 Thread Andrey Borzenkov
В Thu, 29 May 2014 16:11:25 +0200 Thomas H.P. Andersen pho...@gmail.com пишет: What about the SysVStartPriority= option set in native .service's? Is there any non-trivial use case for it? The only usage I have seen was in rc.local emulation and right now none of services installed here defines

Re: [systemd-devel] [PATCH] [RFC] Move handling of sysv initscripts to a generator

2014-05-29 Thread Thomas H.P. Andersen
On Wed, May 28, 2014 at 3:38 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Wed, May 28, 2014 at 01:12:23AM +0200, Thomas H.P. Andersen wrote: From: Thomas Hindoe Paaboel Andersen pho...@gmail.com Reuses logic from service.c and the rc-local generator. Note that this drops

Re: [systemd-devel] [PATCH] [RFC] Move handling of sysv initscripts to a generator

2014-05-29 Thread Andrey Borzenkov
В Thu, 29 May 2014 16:11:25 +0200 Thomas H.P. Andersen pho...@gmail.com пишет: On Wed, May 28, 2014 at 3:38 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Wed, May 28, 2014 at 01:12:23AM +0200, Thomas H.P. Andersen wrote: From: Thomas Hindoe Paaboel Andersen pho...@gmail.com

Re: [systemd-devel] [PATCH] [RFC] Move handling of sysv initscripts to a generator

2014-05-29 Thread Thomas H.P. Andersen
On Thu, May 29, 2014 at 4:30 PM, Andrey Borzenkov arvidj...@gmail.com wrote: В Thu, 29 May 2014 16:11:25 +0200 Thomas H.P. Andersen pho...@gmail.com пишет: On Wed, May 28, 2014 at 3:38 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Wed, May 28, 2014 at 01:12:23AM +0200, Thomas

Re: [systemd-devel] [PATCH] [RFC] Move handling of sysv initscripts to a generator

2014-05-28 Thread Thomas H.P. Andersen
On Wed, May 28, 2014 at 3:38 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Wed, May 28, 2014 at 01:12:23AM +0200, Thomas H.P. Andersen wrote: From: Thomas Hindoe Paaboel Andersen pho...@gmail.com Reuses logic from service.c and the rc-local generator. Note that this drops

Re: [systemd-devel] [PATCH] [RFC] Move handling of sysv initscripts to a generator

2014-05-28 Thread Thomas H.P. Andersen
On Wed, May 28, 2014 at 1:59 PM, Michael Biebl mbi...@gmail.com wrote: 2014-05-28 11:58 GMT+02:00 Thomas H.P. Andersen pho...@gmail.com: On Wed, May 28, 2014 at 3:38 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Wed, May 28, 2014 at 01:12:23AM +0200, Thomas H.P. Andersen wrote:

Re: [systemd-devel] [PATCH] [RFC] Move handling of sysv initscripts to a generator

2014-05-28 Thread Thomas H.P. Andersen
On Wed, May 28, 2014 at 2:14 AM, Peeters Simon peeters.si...@gmail.com wrote: 2014-05-28 1:12 GMT+02:00 Thomas H.P. Andersen pho...@gmail.com: From: Thomas Hindoe Paaboel Andersen pho...@gmail.com Reuses logic from service.c and the rc-local generator. Note that this drops reading of

[systemd-devel] [PATCH] [RFC] Move handling of sysv initscripts to a generator

2014-05-27 Thread Thomas H.P. Andersen
From: Thomas Hindoe Paaboel Andersen pho...@gmail.com Reuses logic from service.c and the rc-local generator. Note that this drops reading of chkconfig entirely. It also drops reading runlevels from the LSB headers. The runlevels were only used to check for runlevels outside of the normal 1-5

Re: [systemd-devel] [PATCH] [RFC] Move handling of sysv initscripts to a generator

2014-05-27 Thread Peeters Simon
2014-05-28 1:12 GMT+02:00 Thomas H.P. Andersen pho...@gmail.com: From: Thomas Hindoe Paaboel Andersen pho...@gmail.com Reuses logic from service.c and the rc-local generator. Note that this drops reading of chkconfig entirely. It also drops reading runlevels from the LSB headers. The

Re: [systemd-devel] [PATCH] [RFC] Move handling of sysv initscripts to a generator

2014-05-27 Thread Cristian Rodríguez
El 27/05/14 20:14, Peeters Simon escribió: this feels wrong, the native unit should override the sysv one. Is there any reason why you want to change this? Couldn't you just use arg_dest = argv[3]; instead? This behaviour is probably my only objection to the idea in question, the generated

Re: [systemd-devel] [PATCH] [RFC] Move handling of sysv initscripts to a generator

2014-05-27 Thread Zbigniew Jędrzejewski-Szmek
On Wed, May 28, 2014 at 01:12:23AM +0200, Thomas H.P. Andersen wrote: From: Thomas Hindoe Paaboel Andersen pho...@gmail.com Reuses logic from service.c and the rc-local generator. Note that this drops reading of chkconfig entirely. How likely is this to cause regressions in existing