Re: [systemd-devel] [PATCH] Partially revert ma-setup: simplify

2015-06-08 Thread Lennart Poettering
On Mon, 08.06.15 12:29, Lennart Poettering (lenn...@poettering.net) wrote: On Wed, 03.06.15 11:23, Mimi Zohar (zo...@linux.vnet.ibm.com) wrote: On Wed, 2015-06-03 at 06:50 +0200, Lennart Poettering wrote: On Tue, 02.06.15 11:55, Mimi Zohar (zo...@linux.vnet.ibm.com) wrote: We

Re: [systemd-devel] [PATCH] Partially revert ma-setup: simplify

2015-06-08 Thread Lennart Poettering
On Wed, 03.06.15 11:23, Mimi Zohar (zo...@linux.vnet.ibm.com) wrote: On Wed, 2015-06-03 at 06:50 +0200, Lennart Poettering wrote: On Tue, 02.06.15 11:55, Mimi Zohar (zo...@linux.vnet.ibm.com) wrote: We could add another parameter to copy_bytes(), but in this case it's cleaner to

Re: [systemd-devel] [PATCH] Partially revert ma-setup: simplify

2015-06-08 Thread Lennart Poettering
On Thu, 04.06.15 13:24, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Wed, Jun 03, 2015 at 11:23:51AM -0400, Mimi Zohar wrote: On Wed, 2015-06-03 at 06:50 +0200, Lennart Poettering wrote: On Tue, 02.06.15 11:55, Mimi Zohar (zo...@linux.vnet.ibm.com) wrote: We could add

Re: [systemd-devel] [PATCH] Partially revert ma-setup: simplify

2015-06-08 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jun 08, 2015 at 12:29:51PM +0200, Lennart Poettering wrote: On Thu, 04.06.15 13:24, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Wed, Jun 03, 2015 at 11:23:51AM -0400, Mimi Zohar wrote: On Wed, 2015-06-03 at 06:50 +0200, Lennart Poettering wrote: On Tue, 02.06.15

Re: [systemd-devel] [PATCH] Partially revert ma-setup: simplify

2015-06-04 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jun 03, 2015 at 11:23:51AM -0400, Mimi Zohar wrote: On Wed, 2015-06-03 at 06:50 +0200, Lennart Poettering wrote: On Tue, 02.06.15 11:55, Mimi Zohar (zo...@linux.vnet.ibm.com) wrote: We could add another parameter to copy_bytes(), but in this case it's cleaner to call fstat()

Re: [systemd-devel] [PATCH] Partially revert ma-setup: simplify

2015-06-03 Thread Mimi Zohar
On Wed, 2015-06-03 at 06:50 +0200, Lennart Poettering wrote: On Tue, 02.06.15 11:55, Mimi Zohar (zo...@linux.vnet.ibm.com) wrote: We could add another parameter to copy_bytes(), but in this case it's cleaner to call fstat() and loop_write(). Right. copy_bytes has no concept of

Re: [systemd-devel] [PATCH] Partially revert ma-setup: simplify

2015-06-02 Thread Lennart Poettering
On Tue, 02.06.15 15:28, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Tue, Jun 02, 2015 at 04:17:04PM +0200, Lennart Poettering wrote: On Mon, 01.06.15 12:36, Mimi Zohar (zo...@linux.vnet.ibm.com) wrote: On Mon, 2015-06-01 at 11:57 -0400, Mimi Zohar wrote: On Mon,

Re: [systemd-devel] [PATCH] Partially revert ma-setup: simplify

2015-06-02 Thread Lennart Poettering
On Tue, 02.06.15 11:55, Mimi Zohar (zo...@linux.vnet.ibm.com) wrote: We could add another parameter to copy_bytes(), but in this case it's cleaner to call fstat() and loop_write(). Right. copy_bytes has no concept of rules/records. So either another parameter is added to copy_bytes to

Re: [systemd-devel] [PATCH] Partially revert ma-setup: simplify

2015-06-02 Thread Mimi Zohar
On Tue, 2015-06-02 at 15:28 +, Zbigniew Jędrzejewski-Szmek wrote: On Tue, Jun 02, 2015 at 04:17:04PM +0200, Lennart Poettering wrote: On Mon, 01.06.15 12:36, Mimi Zohar (zo...@linux.vnet.ibm.com) wrote: On Mon, 2015-06-01 at 11:57 -0400, Mimi Zohar wrote: On Mon, 2015-06-01 at

Re: [systemd-devel] [PATCH] Partially revert ma-setup: simplify

2015-06-01 Thread Mimi Zohar
On Mon, 2015-06-01 at 10:36 -0400, Zbigniew Jędrzejewski-Szmek wrote: --- OK, that's strange. Because the error message comes from copy_bytes() failing, and in copy_bytes() EINVAL could only originate in loop_write(), unless I'm missing something. Can you check the following patch, which

Re: [systemd-devel] [PATCH] Partially revert ma-setup: simplify

2015-06-01 Thread Mimi Zohar
On Mon, 2015-06-01 at 11:57 -0400, Mimi Zohar wrote: On Mon, 2015-06-01 at 10:36 -0400, Zbigniew Jędrzejewski-Szmek wrote: --- OK, that's strange. Because the error message comes from copy_bytes() failing, and in copy_bytes() EINVAL could only originate in loop_write(), unless I'm

Re: [systemd-devel] [PATCH] Partially revert ma-setup: simplify

2015-06-01 Thread systemd github import bot
Patchset imported to github. Pull request: https://github.com/systemd-devs/systemd/compare/master...systemd-mailing-devs:1433169401-2220-1-git-send-email-zbyszek%40in.waw.pl -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel mailing

[systemd-devel] [PATCH] Partially revert ma-setup: simplify

2015-06-01 Thread Zbigniew Jędrzejewski-Szmek
--- OK, that's strange. Because the error message comes from copy_bytes() failing, and in copy_bytes() EINVAL could only originate in loop_write(), unless I'm missing something. Can you check the following patch, which essentially reverts to the old copy method? Zbyszek src/core/ima-setup.c |

Re: [systemd-devel] [PATCH] Partially revert ma-setup: simplify

2015-06-01 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jun 01, 2015 at 12:36:25PM -0400, Mimi Zohar wrote: On Mon, 2015-06-01 at 11:57 -0400, Mimi Zohar wrote: On Mon, 2015-06-01 at 10:36 -0400, Zbigniew Jędrzejewski-Szmek wrote: --- OK, that's strange. Because the error message comes from copy_bytes() failing, and in