Re: [systemd-devel] [PATCH] ask-password-api.c: fix assigned but not read warning

2014-06-26 Thread Daniel Buch
You are right! Sorry for the confusion 2014-06-26 14:04 GMT+02:00 Zbigniew Jędrzejewski-Szmek : > On Thu, Jun 26, 2014 at 01:49:56PM +0200, Daniel Buch wrote: > > Well we assign fd to be -1 above signalfd() and afterwards never read it. > > That's what my compiler complained about. > > > > Think

Re: [systemd-devel] [PATCH] ask-password-api.c: fix assigned but not read warning

2014-06-26 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jun 26, 2014 at 01:49:56PM +0200, Daniel Buch wrote: > Well we assign fd to be -1 above signalfd() and afterwards never read it. > That's what my compiler complained about. > > Thinking further i guess its the assignment thats redundant since cleanup > attribute calls safe_close() that bas

Re: [systemd-devel] [PATCH] ask-password-api.c: fix assigned but not read warning

2014-06-26 Thread Daniel Buch
Well we assign fd to be -1 above signalfd() and afterwards never read it. That's what my compiler complained about. Thinking further i guess its the assignment thats redundant since cleanup attribute calls safe_close() that basiclly assigns fd to be -1. I got, gcc version 4.9.0 20140604 (prerele

Re: [systemd-devel] [PATCH] ask-password-api.c: fix assigned but not read warning

2014-06-26 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jun 26, 2014 at 12:50:40PM +0200, Daniel Buch wrote: > Not sure this is an appropiate fix, feel free to leave it out > > --- > src/shared/ask-password-api.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/shared/ask-password-api.c b/src/shared/ask-password-ap

[systemd-devel] [PATCH] ask-password-api.c: fix assigned but not read warning

2014-06-26 Thread Daniel Buch
Not sure this is an appropiate fix, feel free to leave it out --- src/shared/ask-password-api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/ask-password-api.c b/src/shared/ask-password-api.c index 5997a03..39eab0d 100644 --- a/src/shared/ask-password-api.c +++ b