[systemd-devel] [PATCH] dbus-manager: don't allow enabling if unit is masked

2014-10-06 Thread Jan Synacek
https://bugzilla.redhat.com/show_bug.cgi?id=1149069 --- src/core/dbus-manager.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/core/dbus-manager.c b/src/core/dbus-manager.c index 533ce43..c2d52b2 100644 --- a/src/core/dbus-manager.c +++ b/src/core/dbus-manager.c @

Re: [systemd-devel] [PATCH] dbus-manager: don't allow enabling if unit is masked

2014-10-06 Thread Lennart Poettering
On Mon, 06.10.14 13:21, Jan Synacek (jsyna...@redhat.com) wrote: Hmm with this change in place we'd have different behaviour for the cases where systemctl executes the operation client-side, and when it goes via the bus. We really should keep those differences in behaviour to a minimum. I figure

Re: [systemd-devel] [PATCH] dbus-manager: don't allow enabling if unit is masked

2014-10-06 Thread Jan Synacek
Lennart Poettering writes: > On Mon, 06.10.14 13:21, Jan Synacek (jsyna...@redhat.com) wrote: > > Hmm with this change in place we'd have different behaviour for the > cases where systemctl executes the operation client-side, and when it > goes via the bus. We really should keep those differences

Re: [systemd-devel] [PATCH] dbus-manager: don't allow enabling if unit is masked

2014-10-07 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Oct 07, 2014 at 08:23:32AM +0200, Jan Synacek wrote: > While I'm at it, what about disable? Should it behave in the same way, > i.e. return error when the unit is masked? My guess is that yes, but I'm > not sure. I don't see a reason why disabling should be disallowed. I think we even allow

Re: [systemd-devel] [PATCH] dbus-manager: don't allow enabling if unit is masked

2014-10-08 Thread Lennart Poettering
On Tue, 07.10.14 08:23, Jan Synacek (jsyna...@redhat.com) wrote: > Lennart Poettering writes: > > On Mon, 06.10.14 13:21, Jan Synacek (jsyna...@redhat.com) wrote: > > > > Hmm with this change in place we'd have different behaviour for the > > cases where systemctl executes the operation client-si