Re: [systemd-devel] [PATCH] fix scan-build issues

2013-12-10 Thread Thomas H.P. Andersen
On Tue, Dec 10, 2013 at 1:48 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Tue, Dec 10, 2013 at 01:44:02PM +0100, Thomas H.P. Andersen wrote: >> >> Makefile.am: >> >> Moved some -D's from CFLAGS to CPPFLAGS. I also simplified them a >> >> bit and got rid of a left over DBUS_CFLAGS. >> > I think that

Re: [systemd-devel] [PATCH] fix scan-build issues

2013-12-10 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 10, 2013 at 01:44:02PM +0100, Thomas H.P. Andersen wrote: > >> Makefile.am: > >> Moved some -D's from CFLAGS to CPPFLAGS. I also simplified them a > >> bit and got rid of a left over DBUS_CFLAGS. > > I think that this breaks compilation if the directory has > > spaces in the name. Not a

Re: [systemd-devel] [PATCH] fix scan-build issues

2013-12-10 Thread Thomas H.P. Andersen
On Tue, Dec 10, 2013 at 5:37 AM, Zbigniew Jędrzejewski-Szmek wrote: > On Mon, Dec 09, 2013 at 09:01:08PM +0100, Thomas H.P. Andersen wrote: >> From: Thomas Hindoe Paaboel Andersen >> >> The static analyzer scan-build had a few issues with analysing >> parts of systemd. >> >> gpt-auto-generator.c:

Re: [systemd-devel] [PATCH] fix scan-build issues

2013-12-09 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Dec 09, 2013 at 09:01:08PM +0100, Thomas H.P. Andersen wrote: > From: Thomas Hindoe Paaboel Andersen > > The static analyzer scan-build had a few issues with analysing > parts of systemd. > > gpt-auto-generator.c: > scan-build could not find blkid.h. Whether it should be blkid.h or > blk

[systemd-devel] [PATCH] fix scan-build issues

2013-12-09 Thread Thomas H.P. Andersen
From: Thomas Hindoe Paaboel Andersen The static analyzer scan-build had a few issues with analysing parts of systemd. gpt-auto-generator.c: scan-build could not find blkid.h. Whether it should be blkid.h or blkid/blkid.h seems to depend on the version used. We already use blkid/blkid.h in udev-b