Re: [systemd-devel] [PATCH] fstab-generator: Do not try to fsck non-devices

2013-12-21 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Dec 21, 2013 at 05:49:19PM +0100, Tom Gundersen wrote: > On Sat, Dec 21, 2013 at 5:42 PM, Kay Sievers wrote: > > On Sat, Dec 21, 2013 at 5:33 PM, Dave Reisner wrote: > >> On Sat, Dec 21, 2013 at 12:49:07PM +0100, Tom Gundersen wrote: > >>> On Sat, Dec 21, 2013 at 11:22 AM, Thomas Bächler

Re: [systemd-devel] [PATCH] fstab-generator: Do not try to fsck non-devices

2013-12-21 Thread Thomas Bächler
Am 21.12.2013 12:49, schrieb Tom Gundersen: >> -r = add_fsck(f, what, where, type, passno); >> -if (r < 0) >> -return r; >> +if(is_device_path(what)) { >> +r = add_fsck(f, what, where, type, passno); >> +if (r < 0) >> +

Re: [systemd-devel] [PATCH] fstab-generator: Do not try to fsck non-devices

2013-12-21 Thread Tom Gundersen
On Sat, Dec 21, 2013 at 5:42 PM, Kay Sievers wrote: > On Sat, Dec 21, 2013 at 5:33 PM, Dave Reisner wrote: >> On Sat, Dec 21, 2013 at 12:49:07PM +0100, Tom Gundersen wrote: >>> On Sat, Dec 21, 2013 at 11:22 AM, Thomas Bächler >>> wrote: >>> > This fixes a regression introduced in 64e70e4 where

Re: [systemd-devel] [PATCH] fstab-generator: Do not try to fsck non-devices

2013-12-21 Thread Kay Sievers
On Sat, Dec 21, 2013 at 5:33 PM, Dave Reisner wrote: > On Sat, Dec 21, 2013 at 12:49:07PM +0100, Tom Gundersen wrote: >> On Sat, Dec 21, 2013 at 11:22 AM, Thomas Bächler >> wrote: >> > This fixes a regression introduced in 64e70e4 where the mount fails >> > when fstab is misconfigured with fs_pa

Re: [systemd-devel] [PATCH] fstab-generator: Do not try to fsck non-devices

2013-12-21 Thread Dave Reisner
On Sat, Dec 21, 2013 at 12:49:07PM +0100, Tom Gundersen wrote: > On Sat, Dec 21, 2013 at 11:22 AM, Thomas Bächler wrote: > > This fixes a regression introduced in 64e70e4 where the mount fails > > when fstab is misconfigured with fs_passno > 0 on a virtual file > > system like tmpfs. > > --- > >

Re: [systemd-devel] [PATCH] fstab-generator: Do not try to fsck non-devices

2013-12-21 Thread Tom Gundersen
On Sat, Dec 21, 2013 at 11:22 AM, Thomas Bächler wrote: > This fixes a regression introduced in 64e70e4 where the mount fails > when fstab is misconfigured with fs_passno > 0 on a virtual file > system like tmpfs. > --- > src/fstab-generator/fstab-generator.c | 8 +--- > 1 file changed, 5 ins

[systemd-devel] [PATCH] fstab-generator: Do not try to fsck non-devices

2013-12-21 Thread Thomas Bächler
This fixes a regression introduced in 64e70e4 where the mount fails when fstab is misconfigured with fs_passno > 0 on a virtual file system like tmpfs. --- src/fstab-generator/fstab-generator.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/fstab-generator/fstab-ge