Re: [systemd-devel] [PATCH] install: Assume *.wants symlinks have the same name as their target for scalability.

2013-12-12 Thread David Timothy Strauss
On Wed, Dec 11, 2013 at 8:36 PM, Andrey Borzenkov wrote: > This completely changes semantic of what it does. In this case no > symlink is needed in the first place - just > "touch .../unit.wants/other.unit" would be enough, as long as we assume > units can only be located in standard config paths.

Re: [systemd-devel] [PATCH] install: Assume *.wants symlinks have the same name as their target for scalability.

2013-12-12 Thread David Timothy Strauss
On Thu, Dec 12, 2013 at 6:23 AM, Lennart Poettering wrote: > This isn't right. Units might be symlinked under different names, we > need to support that. For example, all template instances carry a > different name for the symlink then for the source. Good point, though we could still support tha

Re: [systemd-devel] [PATCH] install: Assume *.wants symlinks have the same name as their target for scalability.

2013-12-12 Thread Lennart Poettering
On Wed, 11.12.13 15:54, da...@davidstrauss.net (da...@davidstrauss.net) wrote: > From: David Strauss > > --- > src/shared/install.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/shared/install.c b/src/shared/install.c > index 17e8a75..14c0f4b 100644 > --- a/src/shared/insta

Re: [systemd-devel] [PATCH] install: Assume *.wants symlinks have the same name as their target for scalability.

2013-12-11 Thread Andrey Borzenkov
В Wed, 11 Dec 2013 15:54:39 -0800 da...@davidstrauss.net пишет: > From: David Strauss > > --- > src/shared/install.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/shared/install.c b/src/shared/install.c > index 17e8a75..14c0f4b 100644 > --- a/src/shared/install.c > +++ b/sr

Re: [systemd-devel] [PATCH] install: Assume *.wants symlinks have the same name as their target for scalability.

2013-12-11 Thread David Timothy Strauss
After watching the results for an hour or so, this massively improves the performance of is-enabled and several other systems on our heavily loaded boxes. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mail

[systemd-devel] [PATCH] install: Assume *.wants symlinks have the same name as their target for scalability.

2013-12-11 Thread david
From: David Strauss --- src/shared/install.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/shared/install.c b/src/shared/install.c index 17e8a75..14c0f4b 100644 --- a/src/shared/install.c +++ b/src/shared/install.c @@ -423,6 +423,11 @@ static int find_symlinks_fd(