Re: [systemd-devel] [PATCH] journal: Fix sd_journal_enumerate_unique skipping values

2014-10-09 Thread Zbigniew Jędrzejewski-Szmek
>>Von: "Zbigniew Jędrzejewski-Szmek" > >>>An: "Jan Janssen" > >>>Cc: systemd-devel@lists.freedesktop.org > >>>Betreff: Re: [systemd-devel] [PATCH] journal: Fix > >>>sd_journal_enumerate_unique skipping values > >>&g

Re: [systemd-devel] [PATCH] journal: Fix sd_journal_enumerate_unique skipping values

2014-10-08 Thread Jan Janssen
: Re: [systemd-devel] [PATCH] journal: Fix sd_journal_enumerate_unique skipping values On Mon, Oct 06, 2014 at 06:57:38PM +0200, Zbigniew Jędrzejewski-Szmek wrote: On Mon, Oct 06, 2014 at 06:36:34PM +0200, Jan Janssen wrote: *bump* Sorry, I'll look into this. Doesn't work. Both wi

Re: [systemd-devel] [PATCH] journal: Fix sd_journal_enumerate_unique skipping values

2014-10-08 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 08, 2014 at 08:24:49AM +0200, Jan Janssen wrote: > > > > Gesendet: Mittwoch, 08. Oktober 2014 um 01:40 Uhr > > Von: "Zbigniew Jędrzejewski-Szmek" > > An: "Jan Janssen" > > Cc: systemd-devel@lists.freedesktop.org >

Re: [systemd-devel] [PATCH] journal: Fix sd_journal_enumerate_unique skipping values

2014-10-07 Thread Jan Janssen
> Gesendet: Mittwoch, 08. Oktober 2014 um 01:40 Uhr > Von: "Zbigniew Jędrzejewski-Szmek" > An: "Jan Janssen" > Cc: systemd-devel@lists.freedesktop.org > Betreff: Re: [systemd-devel] [PATCH] journal: Fix sd_journal_enumerate_unique > skipping values > &

Re: [systemd-devel] [PATCH] journal: Fix sd_journal_enumerate_unique skipping values

2014-10-07 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Oct 06, 2014 at 06:57:38PM +0200, Zbigniew Jędrzejewski-Szmek wrote: > On Mon, Oct 06, 2014 at 06:36:34PM +0200, Jan Janssen wrote: > > *bump* > Sorry, I'll look into this. Doesn't work. Both without or with your other patch sd_journal_enumerate_unique I get bogus results on my test case.

Re: [systemd-devel] [PATCH] journal: Fix sd_journal_enumerate_unique skipping values

2014-10-06 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Oct 06, 2014 at 06:36:34PM +0200, Jan Janssen wrote: > *bump* Sorry, I'll look into this. Zbyszek > On 2014-09-06 10:36, Jan Janssen wrote: > >sd_journal_enumerate_unique will lock its mmap window to prevent it > >from being released by calling mmap_cache_get with keep_always=true. > >Thi

Re: [systemd-devel] [PATCH] journal: Fix sd_journal_enumerate_unique skipping values

2014-10-06 Thread Jan Janssen
*bump* On 2014-09-06 10:36, Jan Janssen wrote: sd_journal_enumerate_unique will lock its mmap window to prevent it from being released by calling mmap_cache_get with keep_always=true. This call may return windows that are wider, but compatible with the parameters provided to it. This can result

[systemd-devel] [PATCH] journal: Fix sd_journal_enumerate_unique skipping values

2014-09-06 Thread Jan Janssen
sd_journal_enumerate_unique will lock its mmap window to prevent it from being released by calling mmap_cache_get with keep_always=true. This call may return windows that are wider, but compatible with the parameters provided to it. This can result in a mismatch where the window to be released can