Re: [systemd-devel] [PATCH] journald: fix syslog facility for messages coming from kmsg

2014-07-28 Thread Michal Sekletar
On Sun, Jul 27, 2014 at 07:57:47PM +0200, Zbigniew Jędrzejewski-Szmek wrote: > On Sun, Jul 27, 2014 at 01:11:07PM +0200, Michal Sekletar wrote: > > On Sat, Jul 26, 2014 at 09:11:47PM +0200, Zbigniew Jędrzejewski-Szmek wrote: > > > Hm, what was wrong with the facility before? > > > > I think that w

Re: [systemd-devel] [PATCH] journald: fix syslog facility for messages coming from kmsg

2014-07-27 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Jul 27, 2014 at 01:11:07PM +0200, Michal Sekletar wrote: > On Sat, Jul 26, 2014 at 09:11:47PM +0200, Zbigniew Jędrzejewski-Szmek wrote: > > Hm, what was wrong with the facility before? > > I think that we should always add SYSLOG_FACILITY field. Now, if (priority & > LOG_FACMASK) == LOG_KE

Re: [systemd-devel] [PATCH] journald: fix syslog facility for messages coming from kmsg

2014-07-27 Thread Michal Sekletar
On Sat, Jul 26, 2014 at 09:11:47PM +0200, Zbigniew Jędrzejewski-Szmek wrote: > Hm, what was wrong with the facility before? I think that we should always add SYSLOG_FACILITY field. Now, if (priority & LOG_FACMASK) == LOG_KERN we don't do that. We set SYSLOG_IDENTIFIER to "kernel" tough. But missin

Re: [systemd-devel] [PATCH] journald: fix syslog facility for messages coming from kmsg

2014-07-26 Thread Zbigniew Jędrzejewski-Szmek
Hm, what was wrong with the facility before? Zbyszek On Fri, Jul 25, 2014 at 03:04:44PM +0200, Michal Sekletar wrote: > --- > src/journal/journald-kmsg.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/journal/journald-kmsg.c b/src/journal/journald-kmsg.c > in

[systemd-devel] [PATCH] journald: fix syslog facility for messages coming from kmsg

2014-07-25 Thread Michal Sekletar
--- src/journal/journald-kmsg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/journal/journald-kmsg.c b/src/journal/journald-kmsg.c index 12992e7..8d24344 100644 --- a/src/journal/journald-kmsg.c +++ b/src/journal/journald-kmsg.c @@ -274,6 +274,9 @@ static void dev_