Re: [systemd-devel] [PATCH] libsystemd-bus: Clean up code

2013-12-10 Thread Lennart Poettering
On Tue, 10.12.13 18:33, Lennart Poettering (lenn...@poettering.net) wrote: > On Tue, 10.12.13 05:24, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > On Mon, Dec 09, 2013 at 09:22:43PM +0100, Thomas H.P. Andersen wrote: > > > If I understood correctly then the assert_return was meant

Re: [systemd-devel] [PATCH] libsystemd-bus: Clean up code

2013-12-10 Thread Lennart Poettering
On Tue, 10.12.13 05:24, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > On Mon, Dec 09, 2013 at 09:22:43PM +0100, Thomas H.P. Andersen wrote: > > If I understood correctly then the assert_return was meant to be used > > only on the public library functions. I can't seem to find the > > re

Re: [systemd-devel] [PATCH] libsystemd-bus: Clean up code

2013-12-10 Thread Lukasz Skalski
On 12/10/2013 05:24 AM, Zbigniew Jędrzejewski-Szmek wrote: On Mon, Dec 09, 2013 at 09:22:43PM +0100, Thomas H.P. Andersen wrote: If I understood correctly then the assert_return was meant to be used only on the public library functions. I can't seem to find the reference to it so maybe I am wron

Re: [systemd-devel] [PATCH] libsystemd-bus: Clean up code

2013-12-09 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Dec 09, 2013 at 09:22:43PM +0100, Thomas H.P. Andersen wrote: > If I understood correctly then the assert_return was meant to be used > only on the public library functions. I can't seem to find the > reference to it so maybe I am wrong though. There's no strong reason to limit usage to pub

Re: [systemd-devel] [PATCH] libsystemd-bus: Clean up code

2013-12-09 Thread Thomas H.P. Andersen
If I understood correctly then the assert_return was meant to be used only on the public library functions. I can't seem to find the reference to it so maybe I am wrong though. On Mon, Dec 9, 2013 at 2:09 PM, Lukasz Skalski wrote: > --- > src/libsystemd-bus/bus-dump.c | 2 +- > src/libsyst

[systemd-devel] [PATCH] libsystemd-bus: Clean up code

2013-12-09 Thread Lukasz Skalski
--- src/libsystemd-bus/bus-dump.c | 2 +- src/libsystemd-bus/bus-error.c | 3 +-- src/libsystemd-bus/bus-kernel.c| 12 +++- src/libsystemd-bus/bus-message.c | 12 +++- src/libsystemd-bus/bus-signature.c | 13 - 5 files changed, 12 insertions(+), 30 dele