On 2013-12-16, 17:49 +0100, Kay Sievers wrote:
> On Mon, Dec 16, 2013 at 4:09 PM, Kay Sievers wrote:
> Just added __attribute__ ((__aligned__(8))) to kdbus.h for structures
> used in ioctls.
Yes, your patch is much more cleaner, thanks Kay.
Regards,
Kangkai
__
On 2013-12-16, 16:01 +0100, Lennart Poettering wrote:
> On Mon, 16.12.13 15:50, Lennart Poettering (lenn...@poettering.net) wrote:
>
> > > diff --git a/src/libsystemd-bus/bus-control.c
> > > b/src/libsystemd-bus/bus-control.c
> > > index 0072c37..6b2790d 100644
> > > --- a/src/libsystemd-bus/bus-
On Mon, Dec 16, 2013 at 4:09 PM, Kay Sievers wrote:
> On Mon, Dec 16, 2013 at 4:01 PM, Lennart Poettering
> wrote:
>> On Mon, 16.12.13 15:50, Lennart Poettering (lenn...@poettering.net) wrote:
>>
>>> > diff --git a/src/libsystemd-bus/bus-control.c
>>> > b/src/libsystemd-bus/bus-control.c
>>> > i
On Mon, Dec 16, 2013 at 4:01 PM, Lennart Poettering
wrote:
> On Mon, 16.12.13 15:50, Lennart Poettering (lenn...@poettering.net) wrote:
>
>> > diff --git a/src/libsystemd-bus/bus-control.c
>> > b/src/libsystemd-bus/bus-control.c
>> > index 0072c37..6b2790d 100644
>> > --- a/src/libsystemd-bus/bus
On Mon, 16.12.13 15:50, Lennart Poettering (lenn...@poettering.net) wrote:
> > diff --git a/src/libsystemd-bus/bus-control.c
> > b/src/libsystemd-bus/bus-control.c
> > index 0072c37..6b2790d 100644
> > --- a/src/libsystemd-bus/bus-control.c
> > +++ b/src/libsystemd-bus/bus-control.c
> > @@ -207,7
On Mon, 16.12.13 16:21, Yin Kangkai (kangkai@linux.intel.com) wrote:
> From: Yin Kangkai
>
> Otherwise, for example hello arg passed to KDBUS_CMD_HELLO might not be 8
> bytes
> aligned and kernel returns -EFAULT.
>
> 319 int bus_kernel_take_fd(sd_bus *b) {
> 320 struct kdbu
From: Yin Kangkai
Otherwise, for example hello arg passed to KDBUS_CMD_HELLO might not be 8 bytes
aligned and kernel returns -EFAULT.
319 int bus_kernel_take_fd(sd_bus *b) {
320 struct kdbus_cmd_hello hello;
(gdb) p &hello
$8 = (struct kdbus_cmd_hello *) 0xb354
---
src/libs
